GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-24 16:56:36 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Fix cutting off of Review Interval bins

Browse source
This commit is contained in:
Henrik Giesel 2021-01-08 12:11:53 +01:00
parent e89996bc27
commit b76639c2e3
1 changed files with 25 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
ts/graphs/intervals.ts
View file

@ -67,32 +67,50 @@ export function prepareIntervalData(
return [null, []]; return [null, []];
} }
const [_xMinOrig, origXMax] = extent(allIntervals); const xMin = 0;
let xMax = origXMax; let [, xMax] = extent(allIntervals);
let niceNecessary = false;
// cap max to selected range // cap max to selected range
switch (range) { switch (range) {
case IntervalRange.Month: case IntervalRange.Month:
xMax = Math.min(xMax!, 31); xMax = Math.min(xMax!, 30);
break; break;
case IntervalRange.Percentile50: case IntervalRange.Percentile50:
xMax = quantile(allIntervals, 0.5); xMax = quantile(allIntervals, 0.5);
niceNecessary = true;
break; break;
case IntervalRange.Percentile95: case IntervalRange.Percentile95:
xMax = quantile(allIntervals, 0.95); xMax = quantile(allIntervals, 0.95);
niceNecessary = true;
break; break;
case IntervalRange.All: case IntervalRange.All:
niceNecessary = true;
break; break;
} }
const xMin = 1;
xMax = xMax! + 1; xMax = xMax! + 1;
// do not show the zero interval
const increment = (x: number) => x + 1;
const adjustTicks = (x: number, idx: number, ticks: number[]) =>
idx === ticks.length - 1 ? [x - (ticks[0] - 1), x + 1] : x - (ticks[0] - 1);
// cap bars to available range // cap bars to available range
const desiredBars = Math.min(70, xMax! - xMin!); const desiredBars = Math.min(70, xMax! - xMin!);
const scale = scaleLinear().domain([xMin!, xMax!]);
const prescale = scaleLinear().domain([xMin!, xMax!]);
const scale = scaleLinear().domain(
(niceNecessary ? prescale.nice() : prescale).domain().map(increment)
);
const bins = histogram() const bins = histogram()
.domain(scale.domain() as any) .domain(scale.domain() as [number, number])
.thresholds(scale.ticks(desiredBars))(allIntervals); .thresholds((scale.ticks(desiredBars) as any).flatMap(adjustTicks))(
allIntervals
);
// empty graph? // empty graph?
const totalInPeriod = sum(bins, (bin) => bin.length); const totalInPeriod = sum(bins, (bin) => bin.length);