GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-11-12 15:47:12 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

More accurate sorting by R (#3747)

Browse source 
* Match calc of relative overdueness in SM2 and FSRS

* Fix calculation of FSRS relative overdueness

* Improve readability by avoiding double negative

* Move comment line
This commit is contained in:
user1823 2025-01-25 15:45:49 +05:30 committed by GitHub
parent 9b2987b4a8
commit b80384c715
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
rslib/src/storage/card/mod.rs
View file

@ -775,7 +775,8 @@ impl fmt::Display for ReviewOrderSubclause {
ReviewOrderSubclause::DifficultyDescending => "extract_fsrs_variable(data, 'd') desc", ReviewOrderSubclause::DifficultyDescending => "extract_fsrs_variable(data, 'd') desc",
ReviewOrderSubclause::RetrievabilitySm2 { today, order } => { ReviewOrderSubclause::RetrievabilitySm2 { today, order } => {
temp_string = format!( temp_string = format!(
"ivl / cast({today}-due+0.001 as real) {order}", // - (elapsed days+0.001)/(scheduled interval)
"-(1 + cast({today}-due+0.001 as real)/ivl) {order}",
today = today today = today
); );
&temp_string &temp_string

4
rslib/src/storage/sqlite.rs
View file

@ -388,7 +388,9 @@ fn add_extract_fsrs_relative_retrievability(db: &Connection) -> rusqlite::Result
.max(0.0001); .max(0.0001);
Ok(Some( Ok(Some(
-(1. / current_retrievability - 1.) / (1. / desired_retrievability - 1.), // power should be the reciprocal of the value of DECAY in FSRS-rs, which is
// currently -0.5
-(current_retrievability.powi(-2) - 1.) / (desired_retrievability.powi(-2) - 1.),
)) ))
}, },
) )