From b97fabb6770bcedca04a9034ce91d4708d7d7889 Mon Sep 17 00:00:00 2001
From: Matthias Metelka <62722460+kleinerpirat@users.noreply.github.com>
Date: Mon, 10 Oct 2022 05:29:09 +0200
Subject: [PATCH] Make Qt stylesheets fully responsive to RTL (#2114)

* Make Qt stylesheets fully responsive to RTL

* Fix typing
---
 qt/aqt/stylesheets.py | 20 ++++++++++----------
 qt/aqt/theme.py       | 11 +++++++++++
 2 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/qt/aqt/stylesheets.py b/qt/aqt/stylesheets.py
index 4e53ee34a..75acbbca2 100644
--- a/qt/aqt/stylesheets.py
+++ b/qt/aqt/stylesheets.py
@@ -117,7 +117,7 @@ QMainWindow::separator:vertical {{
 def combobox_styles(tm: ThemeManager) -> str:
     return f"""
 QComboBox {{
-    padding: 1px 4px 2px 6px;
+    padding: {"1px 6px 2px 4px" if tm.rtl() else "1px 4px 2px 6px"};
 }}
 QComboBox:editable:on,
 QComboBox:editable:focus,
@@ -149,8 +149,8 @@ QComboBox::drop-down {{
     width: 16px;
     subcontrol-position: top right;
     border: 1px solid {tm.var(colors.BUTTON_BORDER)};
-    border-top-right-radius: {tm.var(props.BORDER_RADIUS)};
-    border-bottom-right-radius: {tm.var(props.BORDER_RADIUS)};
+    border-top-{tm.right()}-radius: {tm.var(props.BORDER_RADIUS)};
+    border-bottom-{tm.right()}-radius: {tm.var(props.BORDER_RADIUS)};
 }}
 QComboBox::down-arrow {{
     image: url({tm.themed_icon("mdi:chevron-down")});
@@ -199,15 +199,15 @@ QTabBar::tab {{
   border: 1px solid {tm.var(colors.BORDER)};
 }}
 QTabBar::tab:first {{
-  border-top-left-radius: {tm.var(props.BORDER_RADIUS)};
-  border-bottom-left-radius: {tm.var(props.BORDER_RADIUS)};
+  border-top-{tm.left()}-radius: {tm.var(props.BORDER_RADIUS)};
+  border-bottom-{tm.left()}-radius: {tm.var(props.BORDER_RADIUS)};
 }}
 QTabBar::tab:!first {{
-  margin-left: -1px;
+  margin-{tm.left()}: -1px;
 }}
 QTabBar::tab:last {{
-  border-top-right-radius: {tm.var(props.BORDER_RADIUS)};
-  border-bottom-right-radius: {tm.var(props.BORDER_RADIUS)};
+  border-top-{tm.right()}-radius: {tm.var(props.BORDER_RADIUS)};
+  border-bottom-{tm.right()}-radius: {tm.var(props.BORDER_RADIUS)};
 }}
 QTabBar::tab:selected {{
     color: white;
@@ -328,12 +328,12 @@ QSpinBox::down-button:hover {{
 QSpinBox::up-button {{
     margin-bottom: -1px;
     subcontrol-position: top right;
-    border-top-right-radius: {tm.var(props.BORDER_RADIUS)};
+    border-top-{tm.right()}-radius: {tm.var(props.BORDER_RADIUS)};
 }}
 QSpinBox::down-button {{
     margin-top: -1px;
     subcontrol-position: bottom right;
-    border-bottom-right-radius: {tm.var(props.BORDER_RADIUS)};
+    border-bottom-{tm.right()}-radius: {tm.var(props.BORDER_RADIUS)};
 }}
 QSpinBox::up-arrow {{
     image: url({tm.themed_icon("mdi:chevron-up")});
diff --git a/qt/aqt/theme.py b/qt/aqt/theme.py
index 2a0bdd237..d1e03572b 100644
--- a/qt/aqt/theme.py
+++ b/qt/aqt/theme.py
@@ -11,7 +11,9 @@ import subprocess
 from dataclasses import dataclass
 from typing import Callable, List, Tuple
 
+import anki.lang
 import aqt
+from anki.lang import is_rtl
 from anki.utils import is_lin, is_mac, is_win
 from aqt import QApplication, colors, gui_hooks
 from aqt.qt import (
@@ -57,6 +59,15 @@ class ThemeManager:
     default_palette: QPalette | None = None
     _default_style: str | None = None
 
+    def rtl(self) -> bool:
+        return is_rtl(anki.lang.current_lang)
+
+    def left(self) -> str:
+        return "right" if self.rtl() else "left"
+
+    def right(self) -> str:
+        return "left" if self.rtl() else "right"
+
     # Qt applies a gradient to the buttons in dark mode
     # from about #505050 to #606060.
     DARK_MODE_BUTTON_BG_MIDPOINT = "#555555"