GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-18 22:12:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

warn add-ons importing json from anki.utils; use stdout not stderr

Browse source
This commit is contained in:
Damien Elmes 2021-01-31 21:05:46 +10:00
parent 7fda601aef
commit bb92dde2d7
2 changed files with 14 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pylib/anki/collection.py
View file

@ -8,6 +8,7 @@ import enum
import os
import pprint
import re
import sys
import time
import traceback
import weakref
@ -107,7 +108,7 @@ class Collection:
@property
def backend(self) -> RustBackend:
traceback.print_stack()
traceback.print_stack(file=sys.stdout)
print()
print(
"Accessing the backend directly will break in the future. Please use the public methods on Collection instead."

16
pylib/anki/utils.py
View file

@ -3,8 +3,7 @@
from __future__ import annotations
# some add-ons expect json to be in the utils module
import json # pylint: disable=unused-import
import json as _json
import os
import platform
import random
@ -33,8 +32,17 @@ try:
from_json_bytes = orjson.loads
except:
print("orjson is missing; DB operations will be slower")
to_json_bytes = lambda obj: json.dumps(obj).encode("utf8") # type: ignore
from_json_bytes = json.loads
to_json_bytes = lambda obj: _json.dumps(obj).encode("utf8") # type: ignore
from_json_bytes = _json.loads
def __getattr__(name: str) -> Any:
if name == "json":
traceback.print_stack(file=sys.stdout)
print("add-on should import json directly, not from anki.utils")
return _json
raise AttributeError(f"module {__name__} has no attribute {name}")
# Time handling
##############################################################################