Merge pull request #359 from Arthur-Milchior/noDefaultInDeckList2

list of decks contains default iff deck chooser contains default
This commit is contained in:
Damien Elmes 2019-12-06 15:01:15 +10:00 committed by GitHub
commit bceb4feb5b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 6 deletions

View file

@ -206,16 +206,19 @@ class DeckManager:
self.select(int(list(self.decks.keys())[0])) self.select(int(list(self.decks.keys())[0]))
self.save() self.save()
def allNames(self, dyn=True): def allNames(self, dyn=True, forceDefault=True):
"An unsorted list of all deck names." "An unsorted list of all deck names."
if dyn: if dyn:
return [x['name'] for x in list(self.decks.values())] return [x['name'] for x in self.all(forceDefault=forceDefault)]
else: else:
return [x['name'] for x in list(self.decks.values()) if not x['dyn']] return [x['name'] for x in self.all(forceDefault=forceDefault) if not x['dyn']]
def all(self): def all(self, forceDefault=True):
"A list of all decks." "A list of all decks."
return list(self.decks.values()) decks = list(self.decks.values())
if not forceDefault and not self.col.db.scalar("select 1 from cards where did = 1 limit 1") and len(decks)>1:
decks = [deck for deck in decks if deck['id'] != 1]
return decks
def allIds(self): def allIds(self):
return list(self.decks.keys()) return list(self.decks.keys())

View file

@ -38,7 +38,7 @@ class StudyDeck(QDialog):
if title: if title:
self.setWindowTitle(title) self.setWindowTitle(title)
if not names: if not names:
names = sorted(self.mw.col.decks.allNames(dyn=dyn)) names = sorted(self.mw.col.decks.allNames(dyn=dyn, forceDefault=False))
self.nameFunc = None self.nameFunc = None
self.origNames = names self.origNames = names
else: else: