From c05475a49e54ed7a56bc635e5e5528334d4ba6ac Mon Sep 17 00:00:00 2001 From: Damien Elmes Date: Mon, 13 Sep 2021 12:01:34 +1000 Subject: [PATCH] Merge pull request #1364 from evandroforks/fix_unclosed_python_file Fix ResourceWarning: unclosed file <_io.BufferedWriter name=5> --- qt/aqt/sound.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/qt/aqt/sound.py b/qt/aqt/sound.py index 590776226..3001d2c68 100644 --- a/qt/aqt/sound.py +++ b/qt/aqt/sound.py @@ -313,6 +313,8 @@ class SimpleProcessPlayer(Player): # pylint: disable=abstract-method if self._terminate_flag: self._process.terminate() self._process.wait(1) + if self._process.stdin: + self._process.stdin.close() self._process = None return @@ -321,6 +323,8 @@ class SimpleProcessPlayer(Player): # pylint: disable=abstract-method self._process.wait(0.1) if self._process.returncode != 0: print(f"player got return code: {self._process.returncode}") + if self._process.stdin: + self._process.stdin.close() self._process = None return except subprocess.TimeoutExpired: