diff --git a/ts/deck-options/AdvancedOptions.svelte b/ts/deck-options/AdvancedOptions.svelte index 72c109fc3..b5f6aed69 100644 --- a/ts/deck-options/AdvancedOptions.svelte +++ b/ts/deck-options/AdvancedOptions.svelte @@ -12,16 +12,12 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html import HelpModal from "../components/HelpModal.svelte"; import Item from "../components/Item.svelte"; import SettingTitle from "../components/SettingTitle.svelte"; - import SwitchRow from "../components/SwitchRow.svelte"; import TitledContainer from "../components/TitledContainer.svelte"; import { type HelpItem, HelpItemScheduler } from "../components/types"; import CardStateCustomizer from "./CardStateCustomizer.svelte"; - import FsrsOptions from "./FsrsOptions.svelte"; - import GlobalLabel from "./GlobalLabel.svelte"; import type { DeckOptionsState } from "./lib"; import SpinBoxFloatRow from "./SpinBoxFloatRow.svelte"; import SpinBoxRow from "./SpinBoxRow.svelte"; - import Warning from "./Warning.svelte"; export let state: DeckOptionsState; export let api: Record; @@ -32,51 +28,16 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html const fsrs = state.fsrs; const settings = { - fsrs: { - title: "FSRS", - help: tr.deckConfigFsrsTooltip(), - url: HelpPage.DeckOptions.fsrs, - }, maximumInterval: { title: tr.schedulingMaximumInterval(), help: tr.deckConfigMaximumIntervalTooltip(), url: HelpPage.DeckOptions.maximumInterval, }, - desiredRetention: { - title: tr.deckConfigDesiredRetention(), - help: tr.deckConfigDesiredRetentionTooltip(), - sched: HelpItemScheduler.FSRS, - }, sm2Retention: { title: tr.deckConfigSm2Retention(), help: tr.deckConfigSm2RetentionTooltip(), sched: HelpItemScheduler.FSRS, }, - modelWeights: { - title: tr.deckConfigWeights(), - help: tr.deckConfigWeightsTooltip(), - sched: HelpItemScheduler.FSRS, - }, - rescheduleCardsOnChange: { - title: tr.deckConfigRescheduleCardsOnChange(), - help: tr.deckConfigRescheduleCardsOnChangeTooltip(), - sched: HelpItemScheduler.FSRS, - }, - ignoreRevlogsBeforeMs: { - title: tr.deckConfigIgnoreBefore(), - help: tr.deckConfigIgnoreBeforeTooltip(), - sched: HelpItemScheduler.FSRS, - }, - computeOptimalWeights: { - title: tr.deckConfigComputeOptimalWeights(), - help: tr.deckConfigComputeOptimalWeightsTooltip(), - sched: HelpItemScheduler.FSRS, - }, - computeOptimalRetention: { - title: tr.deckConfigComputeOptimalRetention(), - help: tr.deckConfigComputeOptimalRetentionTooltip(), - sched: HelpItemScheduler.FSRS, - }, startingEase: { title: tr.schedulingStartingEase(), help: tr.deckConfigStartingEaseTooltip(), @@ -122,8 +83,6 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html modal.show(); carousel.to(index); } - - $: fsrsClientWarning = $fsrs ? tr.deckConfigFsrsOnAllClients() : ""; @@ -139,19 +98,6 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html }} /> - - - - openHelpModal(Object.keys(settings).indexOf("fsrs"))} - > - - - - - - - {:else} - - openHelpModal(Object.keys(settings).indexOf(key))} - /> + + + openHelpModal(Object.keys(settings).indexOf("sm2Retention"))} + > + {tr.deckConfigSm2Retention()} + + {/if} diff --git a/ts/deck-options/DeckOptionsPage.svelte b/ts/deck-options/DeckOptionsPage.svelte index b240e35d0..9d2ee3e6a 100644 --- a/ts/deck-options/DeckOptionsPage.svelte +++ b/ts/deck-options/DeckOptionsPage.svelte @@ -16,6 +16,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html import ConfigSelector from "./ConfigSelector.svelte"; import DailyLimits from "./DailyLimits.svelte"; import DisplayOrder from "./DisplayOrder.svelte"; + import FsrsOptionsOuter from "./FsrsOptionsOuter.svelte"; import HtmlAddon from "./HtmlAddon.svelte"; import LapseOptions from "./LapseOptions.svelte"; import type { DeckOptionsState } from "./lib"; @@ -107,6 +108,10 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html {/if} + + + + diff --git a/ts/deck-options/FsrsOptions.svelte b/ts/deck-options/FsrsOptions.svelte index f54ec8ce7..d1b9e69e8 100644 --- a/ts/deck-options/FsrsOptions.svelte +++ b/ts/deck-options/FsrsOptions.svelte @@ -268,17 +268,6 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html - - openHelpModal("sm2Retention")}> - {tr.deckConfigSm2Retention()} - - -
-
-
- - openHelpModal("rescheduleCardsOnChange")}> - - - - - {#if $fsrsReschedule} - - {/if} -
- -
- {tr.deckConfigComputeOptimalWeights()} + + openHelpModal("ignoreBefore")}> + {tr.deckConfigIgnoreBefore()} + +
+
+ + openHelpModal("rescheduleCardsOnChange")}> + + + + + {#if $fsrsReschedule} + + {/if} +
+
{tr.deckConfigComputeOptimalRetention()} (experimental) diff --git a/ts/deck-options/FsrsOptionsOuter.svelte b/ts/deck-options/FsrsOptionsOuter.svelte new file mode 100644 index 000000000..467a550a4 --- /dev/null +++ b/ts/deck-options/FsrsOptionsOuter.svelte @@ -0,0 +1,110 @@ + + + + + { + modal = e.detail.modal; + carousel = e.detail.carousel; + }} + /> + + + + + openHelpModal(Object.keys(settings).indexOf("fsrs"))} + > + + + + + + + + {#if $fsrs} + + openHelpModal(Object.keys(settings).indexOf(key))} + /> + {/if} + +