From 20085c9bc419bf0d74f5ba6af5599b5c21d72151 Mon Sep 17 00:00:00 2001
From: hikaru-y <hkrysg@gmail.com>
Date: Fri, 20 Aug 2021 04:31:11 +0900
Subject: [PATCH] Quote font family names, except for generic families

Fixes https://forums.ankiweb.net/t/font-script-is-not-changing-in-the-anki-windows/12465
---
 ts/editor/editing-area.ts | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/ts/editor/editing-area.ts b/ts/editor/editing-area.ts
index 831824b73..8ecad2ef3 100644
--- a/ts/editor/editing-area.ts
+++ b/ts/editor/editing-area.ts
@@ -105,10 +105,18 @@ export class EditingArea extends HTMLDivElement {
         firstRule.style.color = color;
     }
 
+    quoteFontFamily(fontFamily: string): string {
+        // generic families (e.g. sans-serif) must not be quoted
+        if (!/^[a-z|-]+$/.test(fontFamily)) {
+            fontFamily = `"${fontFamily}"`;
+        }
+        return fontFamily;
+    }
+
     setBaseStyling(fontFamily: string, fontSize: string, direction: string): void {
         const styleSheet = this.baseStyle.sheet as CSSStyleSheet;
         const firstRule = styleSheet.cssRules[0] as CSSStyleRule;
-        firstRule.style.fontFamily = fontFamily;
+        firstRule.style.fontFamily = this.quoteFontFamily(fontFamily);
         firstRule.style.fontSize = fontSize;
         firstRule.style.direction = direction;
     }