GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-11-11 15:17:12 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

convert floats to single-precision before comparing in isModified (#3686)

Browse source
This commit is contained in:
llama 2025-01-07 22:13:43 +08:00 committed by GitHub
parent f057ee465d
commit d01d83e2c6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
ts/routes/deck-options/lib.ts
View file

@ -12,7 +12,7 @@ import { DeckConfig, DeckConfig_Config, DeckConfigsForUpdate_CurrentDeck_Limits
import { updateDeckConfigs } from "@generated/backend"; import { updateDeckConfigs } from "@generated/backend";
import { localeCompare } from "@tslib/i18n"; import { localeCompare } from "@tslib/i18n";
import { promiseWithResolver } from "@tslib/promise"; import { promiseWithResolver } from "@tslib/promise";
import { cloneDeep, isEqual } from "lodash-es"; import { cloneDeep, isEqual, isEqualWith } from "lodash-es";
import { tick } from "svelte"; import { tick } from "svelte";
import type { Readable, Writable } from "svelte/store"; import type { Readable, Writable } from "svelte/store";
import { get, readable, writable } from "svelte/store"; import { get, readable, writable } from "svelte/store";
@ -337,7 +337,16 @@ export class DeckOptionsState {
async isModified(): Promise<boolean> { async isModified(): Promise<boolean> {
const original = await this.originalConfigsPromise; const original = await this.originalConfigsPromise;
const current = this.getAllConfigs(); const current = this.getAllConfigs();
return !isEqual(original, current); return !isEqualWith(original, current, (lhs, rhs) => {
if (typeof lhs === "number" && typeof rhs === "number") {
// rslib hands us 32-bit floats (f32), while ts uses 64-bit floats
// SpinBox and ParamsInput both round their values as f64 on blur
// while the original config's corresponding value remains an f32
// so we convert both to f32 before checking for equality
return Math.fround(lhs) === Math.fround(rhs);
}
// undefined means fallback to isEqual
});
} }
resolveOriginalConfigs(): void { resolveOriginalConfigs(): void {