diff --git a/qt/aqt/editor.py b/qt/aqt/editor.py index 3ee676cbe..d1b9dde2d 100644 --- a/qt/aqt/editor.py +++ b/qt/aqt/editor.py @@ -803,39 +803,39 @@ to a cloze type first, via Edit>Change Note Type.""" local = False # fetch it into a temporary folder self.mw.progress.start(immediate=not local, parent=self.parentWindow) - r = None - ct = None + response = None + content_type = None error_msg: Optional[str] = None try: if local: req = urllib.request.Request( url, None, {"User-Agent": "Mozilla/5.0 (compatible; Anki)"} ) - with urllib.request.urlopen(req) as response: - filecontents = response.read() + with urllib.request.urlopen(req) as resp: + filecontents = resp.read() else: - reqs = HttpClient() - reqs.timeout = 30 - r = reqs.get(url) - if r.status_code != 200: - error_msg = _("Unexpected response code: %s") % r.status_code + client = HttpClient() + client.timeout = 30 + response = client.get(url) + if response.status_code != 200: + error_msg = _("Unexpected response code: %s") % response.status_code return - filecontents = r.content - ct = r.headers.get("content-type") + filecontents = response.content + content_type = response.headers.get("content-type") except (urllib.error.URLError, requests.exceptions.RequestException) as e: error_msg = _("An error occurred while opening %s") % e return finally: - if r: - r.close() + if response: + response.close() self.mw.progress.finish() if error_msg: showWarning(error_msg) # strip off any query string url = re.sub(r"\?.*?$", "", url) fname = os.path.basename(urllib.parse.unquote(url)) - if ct: - fname = self.mw.col.media.add_extension_based_on_mime(fname, ct) + if content_type: + fname = self.mw.col.media.add_extension_based_on_mime(fname, content_type) return self.mw.col.media.write_data(fname, filecontents)