From 22539933bf433c36d41f0e3c69599525b1e0856e Mon Sep 17 00:00:00 2001
From: Luc Mcgrady <lucmcgrady@gmail.com>
Date: Tue, 30 Sep 2025 22:43:02 +0100
Subject: [PATCH 01/11] Feat/Disable parameter editing until right clicked 3
 times

---
 ftl/core/deck-config.ftl                  |  1 +
 ts/routes/deck-options/ParamsInput.svelte | 11 +++++++++++
 2 files changed, 12 insertions(+)

diff --git a/ftl/core/deck-config.ftl b/ftl/core/deck-config.ftl
index 1e193dc04..3c8e0d0c1 100644
--- a/ftl/core/deck-config.ftl
+++ b/ftl/core/deck-config.ftl
@@ -383,6 +383,7 @@ deck-config-which-deck = Which deck would you like to display options for?
 
 deck-config-updating-cards = Updating cards: { $current_cards_count }/{ $total_cards_count }...
 deck-config-invalid-parameters = The provided FSRS parameters are invalid. Leave them blank to use the default parameters.
+deck-config-manual-parameter-edit-warning = The parameters should only be generated with the optimize button. Manually editing them is heavily advised against.
 deck-config-not-enough-history = Insufficient review history to perform this operation.
 deck-config-must-have-400-reviews =
     { $count ->
diff --git a/ts/routes/deck-options/ParamsInput.svelte b/ts/routes/deck-options/ParamsInput.svelte
index d046c5e84..9917cbf64 100644
--- a/ts/routes/deck-options/ParamsInput.svelte
+++ b/ts/routes/deck-options/ParamsInput.svelte
@@ -46,6 +46,15 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
             input.value = stringValue;
         }
     }
+
+    const UNLOCK_EDIT_COUNT = 3;
+    let rightClickCount = 0;
+    function onRightClick() {
+        rightClickCount += 1;
+        if (rightClickCount == UNLOCK_EDIT_COUNT) {
+            alert(tr.deckConfigManualParameterEditWarning());
+        }
+    }
 </script>
 
 <svelte:window onresize={updateHeight} />
@@ -56,6 +65,8 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     on:blur={update}
     class="w-100"
     placeholder={render(defaults)}
+    disabled={rightClickCount < UNLOCK_EDIT_COUNT}
+    on:contextmenu={onRightClick}
 ></textarea>
 
 <style>

From f2114b9a5f8723e0b819b30a20046d37048cb7ee Mon Sep 17 00:00:00 2001
From: Luc Mcgrady <lucmcgrady@gmail.com>
Date: Tue, 30 Sep 2025 22:47:29 +0100
Subject: [PATCH 02/11] wording

---
 ftl/core/deck-config.ftl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ftl/core/deck-config.ftl b/ftl/core/deck-config.ftl
index 3c8e0d0c1..955cd262b 100644
--- a/ftl/core/deck-config.ftl
+++ b/ftl/core/deck-config.ftl
@@ -383,7 +383,7 @@ deck-config-which-deck = Which deck would you like to display options for?
 
 deck-config-updating-cards = Updating cards: { $current_cards_count }/{ $total_cards_count }...
 deck-config-invalid-parameters = The provided FSRS parameters are invalid. Leave them blank to use the default parameters.
-deck-config-manual-parameter-edit-warning = The parameters should only be generated with the optimize button. Manually editing them is heavily advised against.
+deck-config-manual-parameter-edit-warning = The parameters should only be modified using the optimize button. Manually editing them is heavily advised against.
 deck-config-not-enough-history = Insufficient review history to perform this operation.
 deck-config-must-have-400-reviews =
     { $count ->

From 103db391fce53ae1e9f4144f1a2062ab49407a9d Mon Sep 17 00:00:00 2001
From: Luc Mcgrady <lucmcgrady@gmail.com>
Date: Thu, 2 Oct 2025 14:03:34 +0100
Subject: [PATCH 03/11] use left click

---
 ts/routes/deck-options/ParamsInput.svelte | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/ts/routes/deck-options/ParamsInput.svelte b/ts/routes/deck-options/ParamsInput.svelte
index 9917cbf64..47cad05ff 100644
--- a/ts/routes/deck-options/ParamsInput.svelte
+++ b/ts/routes/deck-options/ParamsInput.svelte
@@ -48,10 +48,10 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     }
 
     const UNLOCK_EDIT_COUNT = 3;
-    let rightClickCount = 0;
-    function onRightClick() {
-        rightClickCount += 1;
-        if (rightClickCount == UNLOCK_EDIT_COUNT) {
+    let clickCount = 0;
+    function onClick() {
+        clickCount += 1;
+        if (clickCount == UNLOCK_EDIT_COUNT) {
             alert(tr.deckConfigManualParameterEditWarning());
         }
     }
@@ -65,8 +65,8 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     on:blur={update}
     class="w-100"
     placeholder={render(defaults)}
-    disabled={rightClickCount < UNLOCK_EDIT_COUNT}
-    on:contextmenu={onRightClick}
+    readonly={clickCount < UNLOCK_EDIT_COUNT}
+    on:click={onClick}
 ></textarea>
 
 <style>
@@ -74,4 +74,8 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
         resize: none;
         overflow-y: auto;
     }
+
+    textarea:read-only {
+        opacity: 0.75;
+    }
 </style>

From 82de2078f520468b63a3defec8fda36840ae283b Mon Sep 17 00:00:00 2001
From: Luc Mcgrady <lucmcgrady@gmail.com>
Date: Fri, 3 Oct 2025 23:18:40 +0100
Subject: [PATCH 04/11] Change placeholder to text

---
 ftl/core/deck-config.ftl                     | 3 +++
 ts/routes/deck-options/FsrsOptions.svelte    | 6 +-----
 ts/routes/deck-options/ParamsInput.svelte    | 3 +--
 ts/routes/deck-options/ParamsInputRow.svelte | 3 +--
 4 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/ftl/core/deck-config.ftl b/ftl/core/deck-config.ftl
index bc6514de0..dfbc8ee56 100644
--- a/ftl/core/deck-config.ftl
+++ b/ftl/core/deck-config.ftl
@@ -383,6 +383,9 @@ deck-config-which-deck = Which deck would you like to display options for?
 
 deck-config-updating-cards = Updating cards: { $current_cards_count }/{ $total_cards_count }...
 deck-config-invalid-parameters = The provided FSRS parameters are invalid. Leave them blank to use the default values.
+deck-config-placeholder-parameters = 
+    Default parameters
+    (Press "{deck-config-optimize-button}" periodicaly to allow fsrs to better adjust to your memory)
 deck-config-manual-parameter-edit-warning = The parameters should only be modified using the optimize button. Manually editing them is heavily advised against.
 deck-config-not-enough-history = Insufficient review history to perform this operation.
 deck-config-must-have-400-reviews =
diff --git a/ts/routes/deck-options/FsrsOptions.svelte b/ts/routes/deck-options/FsrsOptions.svelte
index 48124771f..080917491 100644
--- a/ts/routes/deck-options/FsrsOptions.svelte
+++ b/ts/routes/deck-options/FsrsOptions.svelte
@@ -387,11 +387,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 <Warning warning={desiredRetentionWarning} className={retentionWarningClass} />
 
 <div class="ms-1 me-1">
-    <ParamsInputRow
-        bind:value={$config.fsrsParams6}
-        defaultValue={[]}
-        defaults={defaults.fsrsParams6}
-    >
+    <ParamsInputRow bind:value={$config.fsrsParams6} defaultValue={[]}>
         <SettingTitle on:click={() => openHelpModal("modelParams")}>
             {tr.deckConfigWeights()}
         </SettingTitle>
diff --git a/ts/routes/deck-options/ParamsInput.svelte b/ts/routes/deck-options/ParamsInput.svelte
index 47cad05ff..a19274e78 100644
--- a/ts/routes/deck-options/ParamsInput.svelte
+++ b/ts/routes/deck-options/ParamsInput.svelte
@@ -7,7 +7,6 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     import * as tr from "@generated/ftl";
 
     export let value: number[];
-    export let defaults: number[];
 
     let stringValue: string;
     let taRef: HTMLTextAreaElement;
@@ -64,7 +63,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     value={stringValue}
     on:blur={update}
     class="w-100"
-    placeholder={render(defaults)}
+    placeholder={tr.deckConfigPlaceholderParameters()}
     readonly={clickCount < UNLOCK_EDIT_COUNT}
     on:click={onClick}
 ></textarea>
diff --git a/ts/routes/deck-options/ParamsInputRow.svelte b/ts/routes/deck-options/ParamsInputRow.svelte
index 864bc4fbc..07081ac49 100644
--- a/ts/routes/deck-options/ParamsInputRow.svelte
+++ b/ts/routes/deck-options/ParamsInputRow.svelte
@@ -10,11 +10,10 @@
 
     export let value: number[];
     export let defaultValue: number[];
-    export let defaults: number[];
 </script>
 
 <slot />
 <ConfigInput>
-    <ParamsInput bind:value {defaults} />
+    <ParamsInput bind:value />
     <RevertButton slot="revert" bind:value {defaultValue} />
 </ConfigInput>

From f7b857887d37c9086568b5dafe1ad390ec3272a2 Mon Sep 17 00:00:00 2001
From: Luc Mcgrady <lucmcgrady@gmail.com>
Date: Fri, 3 Oct 2025 23:23:08 +0100
Subject: [PATCH 05/11] use diabled agaain

---
 ts/routes/deck-options/ParamsInput.svelte | 25 +++++++++++++----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/ts/routes/deck-options/ParamsInput.svelte b/ts/routes/deck-options/ParamsInput.svelte
index a19274e78..3ba109343 100644
--- a/ts/routes/deck-options/ParamsInput.svelte
+++ b/ts/routes/deck-options/ParamsInput.svelte
@@ -58,15 +58,18 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
 <svelte:window onresize={updateHeight} />
 
-<textarea
-    bind:this={taRef}
-    value={stringValue}
-    on:blur={update}
-    class="w-100"
-    placeholder={tr.deckConfigPlaceholderParameters()}
-    readonly={clickCount < UNLOCK_EDIT_COUNT}
-    on:click={onClick}
-></textarea>
+<!-- svelte-ignore a11y_click_events_have_key_events -->
+<!-- svelte-ignore a11y_no_static_element_interactions -->
+<div on:click={onClick}>
+    <textarea
+        bind:this={taRef}
+        value={stringValue}
+        on:blur={update}
+        class="w-100"
+        placeholder={tr.deckConfigPlaceholderParameters()}
+        disabled={clickCount < UNLOCK_EDIT_COUNT}
+    ></textarea>
+</div>
 
 <style>
     textarea {
@@ -74,7 +77,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
         overflow-y: auto;
     }
 
-    textarea:read-only {
-        opacity: 0.75;
+    textarea:disabled {
+        pointer-events: none;
     }
 </style>

From d8fcc44fe537c8c59b4dcf938de2eb93082245b5 Mon Sep 17 00:00:00 2001
From: Luc Mcgrady <lucmcgrady@gmail.com>
Date: Fri, 3 Oct 2025 23:32:28 +0100
Subject: [PATCH 06/11] Add warning box

---
 ts/routes/deck-options/ParamsInput.svelte | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/ts/routes/deck-options/ParamsInput.svelte b/ts/routes/deck-options/ParamsInput.svelte
index 3ba109343..fe0567c40 100644
--- a/ts/routes/deck-options/ParamsInput.svelte
+++ b/ts/routes/deck-options/ParamsInput.svelte
@@ -5,6 +5,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 <script lang="ts">
     import { tick } from "svelte";
     import * as tr from "@generated/ftl";
+    import Warning from "./Warning.svelte";
 
     export let value: number[];
 
@@ -50,10 +51,12 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     let clickCount = 0;
     function onClick() {
         clickCount += 1;
-        if (clickCount == UNLOCK_EDIT_COUNT) {
-            alert(tr.deckConfigManualParameterEditWarning());
-        }
     }
+
+    $: unlockEditWarning =
+        clickCount >= UNLOCK_EDIT_COUNT
+            ? tr.deckConfigManualParameterEditWarning()
+            : "";
 </script>
 
 <svelte:window onresize={updateHeight} />
@@ -71,6 +74,8 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     ></textarea>
 </div>
 
+<Warning warning={unlockEditWarning} className="alert-danger"></Warning>
+
 <style>
     textarea {
         resize: none;

From fcd2c6726282383db89b85f2226cf833dd84c788 Mon Sep 17 00:00:00 2001
From: Luc Mcgrady <lucmcgrady@gmail.com>
Date: Fri, 3 Oct 2025 23:39:51 +0100
Subject: [PATCH 07/11] FSRS

---
 ftl/core/deck-config.ftl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ftl/core/deck-config.ftl b/ftl/core/deck-config.ftl
index dfbc8ee56..fa8514dc0 100644
--- a/ftl/core/deck-config.ftl
+++ b/ftl/core/deck-config.ftl
@@ -385,7 +385,7 @@ deck-config-updating-cards = Updating cards: { $current_cards_count }/{ $total_c
 deck-config-invalid-parameters = The provided FSRS parameters are invalid. Leave them blank to use the default values.
 deck-config-placeholder-parameters = 
     Default parameters
-    (Press "{deck-config-optimize-button}" periodicaly to allow fsrs to better adjust to your memory)
+    (Press "{deck-config-optimize-button}" periodicaly to allow FSRS to better adjust to your memory)
 deck-config-manual-parameter-edit-warning = The parameters should only be modified using the optimize button. Manually editing them is heavily advised against.
 deck-config-not-enough-history = Insufficient review history to perform this operation.
 deck-config-must-have-400-reviews =

From b6ce0c6ae05ff4117109d8196feda932ddec5bb7 Mon Sep 17 00:00:00 2001
From: Luc Mcgrady <lucmcgrady@gmail.com>
Date: Fri, 3 Oct 2025 23:53:38 +0100
Subject: [PATCH 08/11] Added: Timeout ms

---
 ts/routes/deck-options/ParamsInput.svelte | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/ts/routes/deck-options/ParamsInput.svelte b/ts/routes/deck-options/ParamsInput.svelte
index fe0567c40..ada8bcd9c 100644
--- a/ts/routes/deck-options/ParamsInput.svelte
+++ b/ts/routes/deck-options/ParamsInput.svelte
@@ -48,9 +48,19 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
     }
 
     const UNLOCK_EDIT_COUNT = 3;
+    const UNLOCK_CLICK_TIMEOUT_MS = 500;
     let clickCount = 0;
+
+    let clickTimeout: ReturnType<typeof setTimeout>;
+
     function onClick() {
         clickCount += 1;
+        clearTimeout(clickTimeout);
+        if (clickCount < UNLOCK_EDIT_COUNT) {
+            clickTimeout = setTimeout(() => {
+                clickCount = 0;
+            }, UNLOCK_CLICK_TIMEOUT_MS);
+        }
     }
 
     $: unlockEditWarning =

From c84441611dbcb098550b9e3549a748978dee7a08 Mon Sep 17 00:00:00 2001
From: Luc Mcgrady <lucmcgrady@gmail.com>
Date: Wed, 8 Oct 2025 16:07:16 +0100
Subject: [PATCH 09/11] a11y

---
 ts/routes/deck-options/ParamsInput.svelte | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/ts/routes/deck-options/ParamsInput.svelte b/ts/routes/deck-options/ParamsInput.svelte
index ada8bcd9c..b323dfdfa 100644
--- a/ts/routes/deck-options/ParamsInput.svelte
+++ b/ts/routes/deck-options/ParamsInput.svelte
@@ -60,29 +60,33 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
             clickTimeout = setTimeout(() => {
                 clickCount = 0;
             }, UNLOCK_CLICK_TIMEOUT_MS);
+        } else {
+            taRef.focus();
         }
     }
 
-    $: unlockEditWarning =
-        clickCount >= UNLOCK_EDIT_COUNT
-            ? tr.deckConfigManualParameterEditWarning()
-            : "";
+    $: unlocked = clickCount >= UNLOCK_EDIT_COUNT;
+    $: unlockEditWarning = unlocked ? tr.deckConfigManualParameterEditWarning() : "";
 </script>
 
 <svelte:window onresize={updateHeight} />
 
-<!-- svelte-ignore a11y_click_events_have_key_events -->
-<!-- svelte-ignore a11y_no_static_element_interactions -->
-<div on:click={onClick}>
+<span
+    on:click={onClick}
+    on:keypress={onClick}
+    role="button"
+    aria-label={"FSRS Parameters"}
+    tabindex={unlocked ? -1 : 0}
+>
     <textarea
         bind:this={taRef}
         value={stringValue}
         on:blur={update}
         class="w-100"
         placeholder={tr.deckConfigPlaceholderParameters()}
-        disabled={clickCount < UNLOCK_EDIT_COUNT}
+        disabled={!unlocked}
     ></textarea>
-</div>
+</span>
 
 <Warning warning={unlockEditWarning} className="alert-danger"></Warning>
 

From 495da3c2df2a8dd7b3d4e8374926dce6ae2760bd Mon Sep 17 00:00:00 2001
From: Luc Mcgrady <lucmcgrady@gmail.com>
Date: Mon, 27 Oct 2025 12:29:34 +0000
Subject: [PATCH 10/11] Fix: typo

---
 ftl/core/deck-config.ftl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ftl/core/deck-config.ftl b/ftl/core/deck-config.ftl
index fa8514dc0..433a73eb2 100644
--- a/ftl/core/deck-config.ftl
+++ b/ftl/core/deck-config.ftl
@@ -385,7 +385,7 @@ deck-config-updating-cards = Updating cards: { $current_cards_count }/{ $total_c
 deck-config-invalid-parameters = The provided FSRS parameters are invalid. Leave them blank to use the default values.
 deck-config-placeholder-parameters = 
     Default parameters
-    (Press "{deck-config-optimize-button}" periodicaly to allow FSRS to better adjust to your memory)
+    (Press "{deck-config-optimize-button}" periodically to allow FSRS to better adjust to your memory)
 deck-config-manual-parameter-edit-warning = The parameters should only be modified using the optimize button. Manually editing them is heavily advised against.
 deck-config-not-enough-history = Insufficient review history to perform this operation.
 deck-config-must-have-400-reviews =

From 44a10811a3d1d2412c124c1e7738b24a4d15d839 Mon Sep 17 00:00:00 2001
From: Luc Mcgrady <lucmcgrady@gmail.com>
Date: Mon, 27 Oct 2025 12:45:26 +0000
Subject: [PATCH 11/11] Fix: Text selection issue

---
 ts/routes/deck-options/ParamsInput.svelte | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ts/routes/deck-options/ParamsInput.svelte b/ts/routes/deck-options/ParamsInput.svelte
index b323dfdfa..d2f5c49ac 100644
--- a/ts/routes/deck-options/ParamsInput.svelte
+++ b/ts/routes/deck-options/ParamsInput.svelte
@@ -71,7 +71,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
 
 <svelte:window onresize={updateHeight} />
 
-<span
+<div
     on:click={onClick}
     on:keypress={onClick}
     role="button"
@@ -86,7 +86,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
         placeholder={tr.deckConfigPlaceholderParameters()}
         disabled={!unlocked}
     ></textarea>
-</span>
+</div>
 
 <Warning warning={unlockEditWarning} className="alert-danger"></Warning>