GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-18 14:02:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Fix/SQL retrievability underflow (#3980)

Browse source 
* Fix/Saturating sub called before u32 conversion

* more
This commit is contained in:
Luc Mcgrady 2025-05-05 09:49:12 +01:00 committed by GitHub
parent dcc6000f70
commit e06852a0ed
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
rslib/src/storage/sqlite.rs
View file

@ -315,7 +315,7 @@ fn add_extract_fsrs_retrievability(db: &Connection) -> rusqlite::Result<()> {
let Ok(next_day_at) = ctx.get_raw(4).as_i64() else {
return Ok(None);
};
(next_day_at).saturating_sub(due) as u32 / 86_400
(next_day_at as u32).saturating_sub(due as u32) / 86_400
} else {
let Ok(ivl) = ctx.get_raw(2).as_i64() else {
return Ok(None);
@ -324,7 +324,7 @@ fn add_extract_fsrs_retrievability(db: &Connection) -> rusqlite::Result<()> {
return Ok(None);
};
let review_day = due.saturating_sub(ivl);
days_elapsed.saturating_sub(review_day) as u32
(days_elapsed as u32).saturating_sub(review_day as u32)
};
let decay = card_data.decay.unwrap_or(FSRS5_DEFAULT_DECAY);
Ok(card_data.memory_state().map(|state| {
@ -359,14 +359,14 @@ fn add_extract_fsrs_relative_retrievability(db: &Connection) -> rusqlite::Result
};
let days_elapsed = if due > 365_000 {
// (re)learning
next_day_at.saturating_sub(due) as u32 / 86_400
(next_day_at as u32).saturating_sub(due as u32) / 86_400
} else {
let Ok(days_elapsed) = ctx.get_raw(2).as_i64() else {
return Ok(None);
};
let review_day = due.saturating_sub(interval);
days_elapsed.saturating_sub(review_day) as u32
(days_elapsed as u32).saturating_sub(review_day as u32)
};
if let Ok(card_data) = ctx.get_raw(0).as_str() {
if !card_data.is_empty() {