GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-13 14:03:55 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Adjusted loss values

Browse source
This commit is contained in:
Luc Mcgrady 2025-06-05 23:03:39 +01:00
parent 89bafdb47e
commit e642eb535e
No known key found for this signature in database
GPG key ID: 4F3D7A0B17CC3D9C
4 changed files with 35 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
proto/anki/scheduler.proto
View file

@ -360,7 +360,7 @@ message ComputeFsrsParamsRequest {
message ComputeFsrsParamsResponse {
repeated float params = 1;
uint32 fsrs_items = 2;
optional float log_loss = 3;
optional bool health_check_passed = 3;
}
message ComputeFsrsParamsFromItemsRequest {

34
rslib/src/scheduler/fsrs/params.rs
View file

@ -51,6 +51,18 @@ pub(crate) fn ignore_revlogs_before_ms_from_config(config: &DeckConfig) -> Resul
ignore_revlogs_before_date_to_ms(&config.inner.ignore_revlogs_before_date)
}
/// r: retention
fn log_loss_adjustment(r: f32) -> f32 {
0.621 * (4. * r * (1. - r)).powf(0.739)
}
/// r: retention
///
/// c: review count
fn rmse_adjustment(r: f32, c: u32) -> f32 {
0.0417 / (r.powf(1.63) - 1.41) + 0.125 / ((c as f32 / 1000.).powf(0.655) + 1.22) + 0.102
}
impl Collection {
/// Note this does not return an error if there are less than 400 items -
/// the caller should instead check the fsrs_items count in the return
@ -77,7 +89,7 @@ impl Collection {
return Ok(ComputeFsrsParamsResponse {
params: current_params.to_vec(),
fsrs_items,
log_loss: None,
health_check_passed: None,
});
}
// adapt the progress handler to our built-in progress handling
@ -149,11 +161,25 @@ impl Collection {
}
}
let log_loss = if health_check {
let health_check_passed = if health_check {
let fsrs = FSRS::new(None)?;
fsrs.evaluate_with_time_series_splits(input, |_| true)
.ok()
.map(|eval| eval.log_loss)
.map(|eval| {
let r = items.iter().fold(0, |p, item| {
p + (item
.reviews
.last()
.map(|reviews| reviews.rating)
.unwrap_or(0)
> 1) as u32
}) as f32
/ fsrs_items as f32;
let adjusted_log_loss = eval.log_loss / log_loss_adjustment(r);
let adjusted_rmse = eval.rmse_bins / rmse_adjustment(r, fsrs_items);
adjusted_log_loss < 1.10 && adjusted_rmse < 1.58
})
} else {
None
};
@ -161,7 +187,7 @@ impl Collection {
Ok(ComputeFsrsParamsResponse {
params,
fsrs_items,
log_loss,
health_check_passed,
})
}

2
rslib/src/scheduler/service/mod.rs
View file

@ -376,7 +376,7 @@ impl crate::services::BackendSchedulerService for Backend {
Ok(ComputeFsrsParamsResponse {
params,
fsrs_items,
log_loss: None,
health_check_passed: None,
})
}

10
ts/routes/deck-options/FsrsOptions.svelte
View file

@ -41,7 +41,6 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
const defaults = state.defaults;
const fsrsReschedule = state.fsrsReschedule;
const daysSinceLastOptimization = state.daysSinceLastOptimization;
const logLossBadThreshold = 0.5;
$: lastOptimizationWarning =
$daysSinceLastOptimization > 30 ? tr.deckConfigTimeToOptimize() : "";
@ -191,13 +190,10 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
)) ||
resp.params.length === 0;
const highLogLoss =
resp.logLoss && resp.logLoss > logLossBadThreshold;
const health_check_passed =
resp.healthCheckPassed && !resp.healthCheckPassed;
if (resp.logLoss) {
console.log(`FSRS-test-train-split-log-loss = ${resp.logLoss}`);
}
if (highLogLoss) {
if (health_check_passed) {
setTimeout(() => alert(tr.deckConfigFsrsBadFitWarning()));
} else if (already_optimal) {
const msg = resp.fsrsItems