GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-18 22:12:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Fix mpv being left around on abrupt termination (#4042)

Browse source 
Closes #4015
This commit is contained in:
Damien Elmes 2025-06-01 13:16:28 +07:00 committed by GitHub
parent 96ff27d1fb
commit f81a9bfdfb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 17 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
qt/aqt/mpv.py
View file

@ -69,6 +69,7 @@ if is_win:
# pylint: disable=import-error # pylint: disable=import-error
import pywintypes import pywintypes
import win32file # pytype: disable=import-error import win32file # pytype: disable=import-error
import win32job
import win32pipe import win32pipe
import winerror import winerror
@ -131,6 +132,22 @@ class MPVBase:
def _start_process(self): def _start_process(self):
"""Start the mpv process.""" """Start the mpv process."""
self._proc = subprocess.Popen(self.argv, env=self.popenEnv) self._proc = subprocess.Popen(self.argv, env=self.popenEnv)
if is_win:
# Ensure mpv gets terminated if Anki closes abruptly.
self._job = win32job.CreateJobObject(None, "")
extended_info = win32job.QueryInformationJobObject(
self._job, win32job.JobObjectExtendedLimitInformation
)
extended_info["BasicLimitInformation"][
"LimitFlags"
] = win32job.JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE
win32job.SetInformationJobObject(
self._job,
win32job.JobObjectExtendedLimitInformation,
extended_info,
)
handle = self._proc._handle # pylint: disable=no-member
win32job.AssignProcessToJobObject(self._job, handle)
def _stop_process(self): def _stop_process(self):
"""Stop the mpv process.""" """Stop the mpv process."""