From fb2e2bd37adbcfab2d4e2e6f7103c6835c80a7f3 Mon Sep 17 00:00:00 2001 From: Damien Elmes Date: Sat, 9 Aug 2025 16:46:25 +1000 Subject: [PATCH] Revert "Fix/Retention help button bounds (#4253)" (#4258) This reverts commit 5462d99255c41ed47b7953ca6487594ba7cabd5d. --- ts/lib/components/TitledContainer.svelte | 28 ++++++++++++++---------- ts/routes/graphs/Graph.svelte | 4 ++-- ts/routes/graphs/TrueRetention.svelte | 4 ++-- 3 files changed, 20 insertions(+), 16 deletions(-) diff --git a/ts/lib/components/TitledContainer.svelte b/ts/lib/components/TitledContainer.svelte index 98983940a..70e4a078c 100644 --- a/ts/lib/components/TitledContainer.svelte +++ b/ts/lib/components/TitledContainer.svelte @@ -12,7 +12,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html export { className as class }; export let title: string; - export let onHelpClick: ((_e: MouseEvent | KeyboardEvent) => void) | null = null; + export let onTitleClick: ((_e: MouseEvent | KeyboardEvent) => void) | null = null;
-

- {title} -

- {#if onHelpClick} -
- -
+

+ {title} +

+ + {:else} +

+ {title} +

{/if} +
+ +
diff --git a/ts/routes/graphs/Graph.svelte b/ts/routes/graphs/Graph.svelte index 1dafed4bb..2c509639e 100644 --- a/ts/routes/graphs/Graph.svelte +++ b/ts/routes/graphs/Graph.svelte @@ -8,7 +8,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html // When title is null (default), the graph is inlined, not having TitledContainer wrapper. export let title: string | null = null; export let subtitle: string | null = null; - export let onHelpClick: ((_e: MouseEvent | KeyboardEvent) => void) | null = null; + export let onTitleClick: ((_e: MouseEvent | KeyboardEvent) => void) | null = null; {#if title == null} @@ -19,7 +19,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html {:else} - +
{#if subtitle} diff --git a/ts/routes/graphs/TrueRetention.svelte b/ts/routes/graphs/TrueRetention.svelte index 9af2b4d85..6b89ab9b8 100644 --- a/ts/routes/graphs/TrueRetention.svelte +++ b/ts/routes/graphs/TrueRetention.svelte @@ -57,12 +57,12 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html const title = tr.statisticsTrueRetentionTitle(); const subtitle = tr.statisticsTrueRetentionSubtitle(); - const onHelpClick = () => { + const onTitleClick = () => { openHelpModal(Object.keys(retentionHelp).indexOf("trueRetention")); }; - +