GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-18 14:02:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Enable strict_optional for aqt/debug_console, emptycards, flags (#3565)

Browse source 
* Enable strict_optional for debug_console

* Fix mypy errors

* Enable strict_optional for emptycards

* Fix mypy errors

* Enable strict_optional for flags

* Fix mypy errors
This commit is contained in:
Ben Nguyen 2024-11-09 02:43:51 -08:00 committed by GitHub
parent 748aa0f07a
commit fdaad7150e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 14 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
.mypy.ini
View file

@ -80,6 +80,12 @@ strict_optional = True
strict_optional = True strict_optional = True
[mypy-aqt.switch] [mypy-aqt.switch]
strict_optional = True strict_optional = True
[mypy-aqt.debug_console]
strict_optional = True
[mypy-aqt.emptycards]
strict_optional = True
[mypy-aqt.flags]
strict_optional = True
[mypy-anki.scheduler.base] [mypy-anki.scheduler.base]
strict_optional = True strict_optional = True
[mypy-anki._backend.rsbridge] [mypy-anki._backend.rsbridge]

4
qt/aqt/debug_console.py
View file

@ -196,6 +196,7 @@ class DebugConsole(QDialog):
def _on_context_menu(self, text_edit: QPlainTextEdit) -> None: def _on_context_menu(self, text_edit: QPlainTextEdit) -> None:
menu = text_edit.createStandardContextMenu() menu = text_edit.createStandardContextMenu()
assert menu is not None
menu.addSeparator() menu.addSeparator()
for action in self._actions(): for action in self._actions():
entry = menu.addAction(action.name) entry = menu.addAction(action.name)
@ -227,7 +228,7 @@ class DebugConsole(QDialog):
sys.stderr = self._oldStderr sys.stderr = self._oldStderr
sys.stdout = self._oldStdout sys.stdout = self._oldStdout
def _card_repr(self, card: anki.cards.Card) -> None: def _card_repr(self, card: anki.cards.Card | None) -> None:
import copy import copy
import pprint import pprint
@ -316,6 +317,7 @@ class DebugConsole(QDialog):
) )
self._log.appendPlainText(to_append) self._log.appendPlainText(to_append)
slider = self._log.verticalScrollBar() slider = self._log.verticalScrollBar()
assert slider is not None
slider.setValue(slider.maximum()) slider.setValue(slider.maximum())
self._log.ensureCursorVisible() self._log.ensureCursorVisible()

3
qt/aqt/emptycards.py
View file

@ -63,7 +63,7 @@ class EmptyCardsDialog(QDialog):
def on_finished(code: Any) -> None: def on_finished(code: Any) -> None:
self.form.webview.cleanup() self.form.webview.cleanup()
self.form.webview = None self.form.webview = None # type: ignore
saveGeom(self, "emptycards") saveGeom(self, "emptycards")
qconnect(self.finished, on_finished) qconnect(self.finished, on_finished)
@ -71,6 +71,7 @@ class EmptyCardsDialog(QDialog):
self._delete_button = self.form.buttonBox.addButton( self._delete_button = self.form.buttonBox.addButton(
tr.empty_cards_delete_button(), QDialogButtonBox.ButtonRole.ActionRole tr.empty_cards_delete_button(), QDialogButtonBox.ButtonRole.ActionRole
) )
assert self._delete_button is not None
self._delete_button.setAutoDefault(False) self._delete_button.setAutoDefault(False)
qconnect(self._delete_button.clicked, self._on_delete) qconnect(self._delete_button.clicked, self._on_delete)

6
qt/aqt/flags.py
View file

@ -34,11 +34,11 @@ class Flag:
class FlagManager: class FlagManager:
def __init__(self, mw: aqt.main.AnkiQt) -> None: def __init__(self, mw: aqt.main.AnkiQt) -> None:
self.mw = mw self.mw = mw
self._flags: list[Flag] | None = None self._flags: list[Flag] = []
def all(self) -> list[Flag]: def all(self) -> list[Flag]:
"""Return a list of all flags.""" """Return a list of all flags."""
if self._flags is None: if not self._flags:
self._load_flags() self._load_flags()
return self._flags return self._flags
@ -57,7 +57,7 @@ class FlagManager:
def require_refresh(self) -> None: def require_refresh(self) -> None:
"Discard cached labels." "Discard cached labels."
self._flags = None self._flags = []
def _load_flags(self) -> None: def _load_flags(self) -> None:
labels = cast(dict[str, str], self.mw.col.get_config("flagLabels", {})) labels = cast(dict[str, str], self.mw.col.get_config("flagLabels", {}))