GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-17 07:49:06 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions
5491 commits 11 branches 166 tags 122 MiB
Commit graph

593 commits

Author SHA1 Message Date
Damien Elmes
717ea6db3d sched_timing_today() needs a default rollover hour 
When unset it was reverting to the V1 code.

https://forums.ankiweb.net/t/daily-counts-are-reset-on-sync/3441/16
 2020-09-18 19:13:47 +10:00
Damien Elmes
779a8930e7 check original due in card stats 
https://forums.ankiweb.net/t/how-come-some-of-my-cards-are-showing-retrospective-due-dates/3434/6
 2020-09-17 14:36:18 +10:00
Aleksa Sarai
96da137314 rs: remove most &mut references in BackendService 
The previous implementation had some slightly questionable memory safety
properties (older versions of PyO3 didn't uphold the Rust aliasing rules
and would thus create multiple &mut references to #[pyclass] objects).
This explains why Backend has internal Mutex<T>s even though all of its
methods took &mut self.

The solution is to simply make all methods take &self, which luckily
doesn't pose too make issues -- most of the code inside Backend already
has sufficient locking. The only two things which needed to be
explicitly handled where:

1. "self.runtime" which was fairly easy to handle. All usages of
   the Runtime only require an immutable reference to create a new
   Handle, so we could switch to OnceCell which provides
   lazy-initialisation semantics without needing a more heavy-handed
   Mutex<tokio::runtime::Handle>.

2. "self.sync_abort" was simply wrapped in a Mutex<>, though some of the
   odd semantics of sync_abort (not being able to handle multiple
   processes synchronising at the same time) become pretty obvious with
   this change (for now we just log a warning in that case). In
   addition, switch to an RAII-style guard to make sure we don't forget
   to clear the abort_handle.

As a result, we now no longer break Rust's aliasing rules and we can
build with newer versions of PyO3 which have runtime checks for these
things (and build on stable Rust).

Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
 2020-09-05 19:37:59 +10:00
Damien Elmes
cce0ee2b03 handle quoted html chars in media check 
https://forums.ankiweb.net/t/unable-to-play-longer-audio-on-cards/1313/30
 2020-09-04 09:36:38 +10:00
Damien Elmes
f32d773e25 set_deck() 2020-09-03 17:42:46 +10:00
Damien Elmes
f7d4bf8489 support did:[deck id] search 2020-09-03 16:43:22 +10:00
Damien Elmes
32759a55e4 log 0 day interval as 1 day 
Allows distinguishing it from resetting to new, and is treated as
a one day delay when answering anyway.
 2020-09-03 16:00:06 +10:00
Damien Elmes
7c169daa95 move card sorting and resetting to backend 2020-09-03 15:54:15 +10:00
Damien Elmes
72142d51c4 set local offset when saving preferences 2020-09-03 12:43:18 +10:00
Damien Elmes
366c5c4774 log manual reschedule, but ignore the log entry in the stats 2020-09-02 17:56:23 +10:00
Damien Elmes
31b7d7d645 move reschedCards() to backend 2020-09-02 17:56:23 +10:00
Damien Elmes
396081d329 move filtered deck empty/fill to backend 
emptying of individual card ids still to be done
 2020-09-02 17:56:23 +10:00
Damien Elmes
7f42500e53 rename some card+note fields in backend 2020-09-01 10:24:38 +10:00
Damien Elmes
9f51347e1e move bury/suspend into backend 2020-09-01 10:24:38 +10:00
Damien Elmes
988b3c00c1 move unbury/unsuspend routines into backend 2020-09-01 10:24:38 +10:00
Damien Elmes
4894025cfc add separate sched/user bury searches, and fix bury enums 2020-09-01 10:24:38 +10:00
Damien Elmes
2a6206be91 handle null return from sum() in other columns 2020-09-01 10:24:38 +10:00
Damien Elmes
999b659c3a reimplement congrats screen in Rust+Typescript 2020-09-01 10:24:38 +10:00
Damien Elmes
55ae49e251 fix nonbreaking spaces breaking media 
https://forums.ankiweb.net/t/unable-to-play-longer-audio-on-cards/1313
 2020-08-30 11:23:12 +10:00
Soren Bjornstad
0614642052 fix unanchored regex in bulk tag add routine 
Previously, it was not possible to add a substring of an existing tag.
For example, with the tag "foobar", you could not add the tag "foo",
"bar" or "oob".

Because the match was unanchored, the regex checking whether the tag
already existed determined that the tag was present when it was not.
 2020-08-28 16:21:23 -05:00
Damien Elmes
7cfeb6cbb3 check if we need to unbury at the start of the sync process 
https://forums.ankiweb.net/t/bug-buried-cards-in-filtered-decks-not-being-unburied-next-day/2541/24
 2020-08-28 21:09:07 +10:00
Damien Elmes
b9f6bde2dc catch leading/trailing boolean operators 
https://forums.ankiweb.net/t/is-it-only-me-anki-giving-corrupt-collection-error/2424/20
 2020-08-27 09:59:29 +10:00
Damien Elmes
41a47fcf01 fix some clippy lints 2020-08-26 19:02:56 +10:00
Damien Elmes
fb4105013f add escape hatch for very slow connections 2020-08-26 18:44:20 +10:00
Damien Elmes
8c7c2eeda3 specify I/O timeout 
We need to be a bit conservative here due to buffer bloat - in the
upload case on a slow link, it can appear that no I/O is happening
when a buffer is draining.
 2020-08-26 18:30:51 +10:00
Damien Elmes
3b8c7f22d2 don't crash when upgrading collection with ntid of 0 2020-08-23 14:14:44 +10:00
Damien Elmes
8c558e4e5d normalize field before checking duplicates 
https://forums.ankiweb.net/t/unicode-normalisation/2531
 2020-08-23 12:09:55 +10:00
Damien Elmes
e281d8947d ensure we don't crash on a zero field notetype 2020-08-23 12:09:36 +10:00
Damien Elmes
db92548987 fix empty cards not ignoring <br> 
https://forums.ankiweb.net/t/bug-report-empty-cards-are-not-recognized/2555
 2020-08-23 11:44:49 +10:00
Damien Elmes
3a2031272b catch timeout error 2020-08-21 19:03:23 +10:00
Damien Elmes
26e69d5070 ensure tag replacements fully match 
https://anki.tenderapp.com/discussions/private/5180-anki-desktop-bug-removing-a-tag-removes-all-substrings
 2020-08-19 15:35:20 +10:00
Damien Elmes
cb68958b59 strip nuls from tags as well 
https://forums.ankiweb.net/t/unable-to-sync-between-macbook-and-my-iphone/2405
 2020-08-19 15:34:21 +10:00
Damien Elmes
724005386c catch attempt to update missing note 
https://forums.ankiweb.net/t/bug-report-editor-updating-non-existing-card/2117/4?u=dae
 2020-08-17 19:44:27 +10:00
Damien Elmes
2e7ecfb1d2 allow setting sort field before add 2020-08-17 19:44:09 +10:00
Damien Elmes
cb821a9e3c fix globs not working in bulk tag add/remove 2020-08-17 18:14:00 +10:00
Damien Elmes
692164df7c journal mode was not being set on media db 2020-08-17 12:30:14 +10:00
Damien Elmes
54bb782809 handle <%foo%> inside {{#conditional}} 
https://forums.ankiweb.net/t/the-latest-version-of-ios-cannot-display-the-template-normally/2142
 2020-08-12 19:28:26 +10:00
Damien Elmes
d0d2ba15e2 generate extra templates when recovering notetype 2020-08-10 13:42:37 +10:00
Damien Elmes
a4c8825aeb show ordinal if card template missing 2020-08-10 13:41:22 +10:00
Damien Elmes
ffd1638400 fix assertion failure when recovering notetype 
Notes need to have their notetype ID updated to reflect the
newly created notetype.

https://forums.ankiweb.net/t/anki-crashes-on-sync-study-export/1978
 2020-08-08 12:26:00 +10:00
Damien Elmes
bdf6e2b87d handle negative review times in sync 2020-08-07 15:02:03 +10:00
Damien Elmes
60730af9f4 fix negative review times in DB check 2020-08-07 14:37:44 +10:00
Damien Elmes
c03d3f6c7f add some extra help to the json decode error 2020-08-07 13:13:11 +10:00
Damien Elmes
176ab312da handle some instances of floats when an integer is expected during sync 2020-08-03 17:47:15 +10:00
Damien Elmes
99140fb189 fix conditional negation being lost on field rename 
https://forums.ankiweb.net/t/anki-force-changes-all-to/1694
 2020-08-02 10:09:24 +10:00
Damien Elmes
bd37a7e17e fix moves into/out of a filtered deck not syncing 
the mtime comparison should have only been done if the object in the
local collection was also pending
 2020-07-31 15:39:30 +10:00
Damien Elmes
47d3666ad0 fix hour graph not handling timezones west of UTC 
https://forums.ankiweb.net/t/statistics-bugs-after-update-2-1-5-to-2-1-29/1620
 2020-07-31 13:33:41 +10:00
Damien Elmes
a93145c4c7 handle preview repeat in deck list 2020-07-30 09:11:13 +10:00
Damien Elmes
3da7884e19 reject double comma in id list 
https://forums.ankiweb.net/t/anki-2-1-29-and-below-2-small-bugs/1496
 2020-07-29 13:05:34 +10:00
Damien Elmes
f4bd143050 handle multiple clozes in cloze-only filter 
https://forums.ankiweb.net/t/built-in-tts-not-reading-multiple-clozes/1516
 2020-07-29 12:54:29 +10:00
Damien Elmes
55891fc8f7 clearer message when template error is preventing save 2020-07-29 12:53:03 +10:00
Damien Elmes
3099edf8ee show card stats in reverse order like older Anki versions 2020-07-28 09:49:27 +10:00
Damien Elmes
8f470ce23d fix note/card ids being flipped in card stats 2020-07-28 09:49:11 +10:00
Damien Elmes
9ec58c10ec strip unwanted control characters when writing fields 
closes #661
 2020-07-24 09:18:05 +10:00
Damien Elmes
61f0c3eec0 add cloze-only filter 
https://anki.tenderapp.com/discussions/ankidesktop/42383-two-feature-suggestions
 2020-07-21 12:59:28 +10:00
Damien Elmes
ce2c553840 i18n some sync errors 2020-07-16 13:55:59 +10:00
Damien Elmes
e471497bd2 add platform version back into sync metadata 2020-07-16 10:12:41 +10:00
Damien Elmes
bbc75cdf5d update rslib/rspy deps 2020-07-12 11:38:25 +10:00
Damien Elmes
d35bc85ead is:review should include relearning cards 
https://forums.ankiweb.net/t/anki-2-1-28-beta/629/36

This issue appears to have existed since the V2 scheduler was
introduced - the old Python search code was ignoring Relearn as well.
 2020-07-09 11:07:50 +10:00
Damien Elmes
3a75161778 fix deck tree with a day delta, and support arbitrary timestamps 2020-07-06 19:16:03 +10:00
Damien Elmes
71dbbd9fa8 set schema on collection creation 2020-07-03 11:55:27 +10:00
Damien Elmes
9bb45673a8 show clearer error when media db locked 
should not happen frequently during a sync, but may happen during
the initial change checking stage

https://forums.ankiweb.net/t/error-when-adding-audio-file/495/2
 2020-07-01 11:19:06 +10:00
Damien Elmes
f43aa54ed9 fix media db conflict aborting immediately instead of after 5s 
https://forums.ankiweb.net/t/error-when-adding-audio-file/495/2
 2020-07-01 11:17:33 +10:00
Damien Elmes
8cfafdbc32 supported edited:n 
https://forums.ankiweb.net/t/feature-request-advanced-broswer-search-by-edited/268
 2020-07-01 10:17:57 +10:00
Damien Elmes
06d9f64dea lint fixes 2020-06-29 15:53:56 +10:00
Damien Elmes
693fcfce7d i18n card counts 2020-06-29 15:48:01 +10:00
Damien Elmes
349eca843b get i18n working in typescript 2020-06-29 15:48:01 +10:00
Damien Elmes
618fc65282 handle revlog entries with negative review times 2020-06-29 15:48:01 +10:00
Damien Elmes
4be8e7923a fix partially quoted text not handling escaped quotes 
https://forums.ankiweb.net/t/how-to-search-for-cards-containing-quotes/500/10
 2020-06-29 15:48:01 +10:00
Damien Elmes
0293f2220c qt's js code now shares ts/node_modules; more graph work 2020-06-29 15:48:01 +10:00
Damien Elmes
4d88b6521d cards added graph 2020-06-29 15:48:01 +10:00
Damien Elmes
1e9901e9bd experiment with exposing raw card/revlog data to frontend 2020-06-29 15:48:00 +10:00
Damien Elmes
fd258d15c5 some initial work on updating the graphs 2020-06-29 15:48:00 +10:00
Damien Elmes
61efce295e fix v2 scheduler cutoff being used if previously activated 2020-06-23 12:46:40 +09:00
Damien Elmes
710e5ecce2 formatting fix 2020-06-22 11:58:31 +10:00
Damien Elmes
cec1fdece5 move revlog out of sync code, and add enums 
and remove type=4, which does not appear to be used
 2020-06-16 16:31:36 +10:00
Damien Elmes
f5694a7e4a migrate card stats to backend 
Currently this renders the HTML directly like the previous Python
implementation - doing it in JS would probably make more sense in the
future.
 2020-06-15 17:22:16 +10:00
Damien Elmes
965fd848d1 on upgrade, mark decks modified that are renamed 2020-06-14 14:48:58 +10:00
Damien Elmes
07874f8328 handle db errors the same way as other backend requests 2020-06-12 20:39:02 +10:00
Damien Elmes
dc8297644b pass db json back as bytes 2020-06-12 20:20:29 +10:00
Damien Elmes
1773c6eec9 don't exclude the default deck from the normal name list 
https://forums.ankiweb.net/t/issue-backend-get-deck-names-doesnt-return-default-deck/52
 2020-06-11 14:36:00 +10:00
Damien Elmes
4092da9dbe use vendored hyper for panic fix 2020-06-11 13:30:35 +10:00
Damien Elmes
d5cd9af53b fix review cards with high intervals not being reset properly 
would lead to a "fixed .. with invalid card property" message that
didn't go away
 2020-06-09 20:11:26 +10:00
Damien Elmes
a11d803030 switch default leech action to tag only 2020-06-09 12:03:47 +10:00
Damien Elmes
6d7be475e6 catch invalid regex in search 
https://github.com/ankitects/anki/pull/652
 2020-06-09 11:46:07 +10:00
Damien Elmes
c6e5dc0ef6 check full upload return text 2020-06-09 08:50:16 +10:00
Damien Elmes
75471224fa add progress to db check 2020-06-08 21:07:36 +10:00
Damien Elmes
e74e5c604b add daily count updating to backend 2020-06-05 19:49:53 +10:00
Damien Elmes
55f8b87548 support generating a due tree for a different date 2020-06-05 09:38:31 +10:00
Damien Elmes
c5e65d02e1 add note/card removal to backend 2020-06-04 18:21:04 +10:00
Damien Elmes
cb7d78dde5 "Template" special field should have been called "Card" 2020-06-02 16:47:30 +10:00
Damien Elmes
c8b585b3e4 automatically abort the media sync on full sync 2020-06-02 16:22:53 +10:00
Damien Elmes
7dc8df748b ensure sync indicator updates after download 2020-06-02 15:10:41 +10:00
Damien Elmes
7536a3b899 fix full download on Windows 2020-06-02 15:06:23 +10:00
Damien Elmes
ca704187c6 skip note update if unchanged 2020-06-02 13:32:36 +10:00
Damien Elmes
d7a2e78c0b change sync label to indicate sync state 
- blue for normal sync, red for full sync required
- refactor status fetching code so we don't hold a collection lock
during the network request, which slows things down
- fix sync spinner restarting when returning to deck list
 2020-06-02 13:23:01 +10:00
Damien Elmes
42c34b60c0 use a shared async runtime instead of recreating each time 2020-06-02 09:35:27 +10:00
Damien Elmes
a3e5068952 add some syncing tests - please see alpha2 notes before syncing 2020-06-01 19:44:25 +10:00
Damien Elmes
c6712cbf2c fix \n in buildhash 2020-06-01 19:38:45 +10:00
Damien Elmes
80210ab6bd handle missing counts in sanity check 2020-06-01 19:38:41 +10:00