Commit graph

1081 commits

Author SHA1 Message Date
Damien Elmes
aaaf8e12a5 skip the webview reload when undoing reviews 2019-01-29 09:35:46 +10:00
Damien Elmes
9911258802 remove another newline case from empty fields
thanks to dlon: https://github.com/dae/anki/pull/273
2019-01-29 08:29:01 +10:00
Damien Elmes
6950a05260 Merge pull request #273 from zjosua/reinstate-mungehtml
Reinstate mungeHTML in editor.py
2019-01-29 08:26:47 +10:00
Damien Elmes
234c053d8d Merge pull request #275 from glutanimate/editor-addbutton-qrc-support
Add support for button icons stored in Qt resource system
2019-01-29 08:26:07 +10:00
Glutanimate
e94e316bee Add support for button icons stored in Qt resource system 2019-01-26 20:42:56 +01:00
David Lönnhager
d5806060b4 Fix crash caused by cutting and copying 2019-01-26 04:29:05 +01:00
zjosua
119a06dc28 Reinstate mungeHTML in editor.py
The removal of this function in #270 causes <br> to remain in seemingly
empty editor fields, which in turn wrongly prompts the "Close and lose
current input?" dialog.
2019-01-25 23:12:48 +01:00
Damien Elmes
19757a57f5 Merge pull request #270 from dlon/br-improve
Remove <br> from empty fields.
2019-01-21 14:26:12 +10:00
David Lönnhager
e81447de0e Remove <br> from empty fields. 2019-01-19 19:36:55 +01:00
Damien Elmes
4a2e6719eb Revert "default to GL mode auto on qt 5.12"
This reverts commit 52e6afc409.

unfortunately there still appear to be widespread issues on qt 5.12
2019-01-06 09:59:25 +10:00
Damien Elmes
a8e3672d7e fix field content showing in top button area 2018-12-22 13:27:12 +10:00
Damien Elmes
4e659d61eb detect and refuse to run on nouveau 2018-12-18 19:29:34 +10:00
Damien Elmes
328c73d0bc ignore broken reset hooks in database check
ideally the original code should be correctly cleaning up the hooks,
but if it does not, then we don't want to repeatedly present the user
with confusing errors when they try to check their database is ok.
2018-12-15 13:14:33 +10:00
Damien Elmes
90adf539d8 remove unused ref 2018-12-15 12:45:38 +10:00
Damien Elmes
e7b6b9befa make sure change note type clears up hooks
if an error occurred after QDialog.accept() had been called,
the hook was left lying around and caused errors when reset later
fired

File "aqt\main.py", line 1028, in onCheckDB
  File "aqt\main.py", line 516, in reset
  File "anki\hooks.py", line 28, in runHook
  File "aqt\modelchooser.py", line 47, in onReset
  File "aqt\modelchooser.py", line 82, in updateModels
<class 'RuntimeError'>: wrapped C/C++ object of type QPushButton has been deleted
2018-12-15 12:45:17 +10:00
Damien Elmes
451934741c fix the other json.dumps call
previous change was in the wrong place
1ae2a08900
2018-12-15 09:15:43 +10:00
Damien Elmes
270e0b4271 apply stylesheet app wide, and add border to win10 menu
the night mode add-on may need updating with this change, but with
a global stylesheet it may be easier to style widgets in the future

menu bar issue:

https://anki.tenderapp.com/discussions/beta-testing/1313-anki-216-beta-1#comment_46664932
2018-12-14 20:35:12 +10:00
Damien Elmes
670a1a773d add file to track pinned modules 2018-12-14 20:32:53 +10:00
Damien Elmes
1ae2a08900 don't escape unicode characters in add-on json
https://anki.tenderapp.com/discussions/ankidesktop/31423-configuration-module-of-addons-is-not-allowing-pt-br-accent
2018-12-13 21:34:55 +10:00
Damien Elmes
f0d2a5c321 include git hash in version info 2018-12-13 20:59:06 +10:00
Damien Elmes
52e6afc409 default to GL mode auto on qt 5.12 2018-12-10 15:17:21 +10:00
Damien Elmes
785acd681c restore tooltips for fields/cards 2018-12-07 08:33:47 +10:00
Damien Elmes
cbee39da6d Merge pull request #265 from Arthur-Milchior/reopenEdit
The note in curentEdit is not changed until the window is closed.
2018-12-03 16:41:56 +10:00
Damien Elmes
a7cb4e0cdc fix editor buttons overlapping field content
https://anki.tenderapp.com/discussions/ankidesktop/31235-editor-second-row-for-buttons-feature-request
2018-12-03 09:54:51 +10:00
Damien Elmes
0d75802e20 fix import screen appearing before progress dialog closes 2018-12-01 13:37:26 +10:00
Arthur-Milchior
7d4067e3ff The note in curentEdit is not changed until the window is closed.
https://anki.tenderapp.com/discussions/ankidesktop/31105-reopening-an-edit-window
I added a «reopen» method, which I believe may be useful in other
cases too. I check whether the method exists before calling it, so
there should be no compatibility problem.
2018-11-28 10:24:59 +01:00
Damien Elmes
5c5042cf5a ensure card list updated when editing html
using an extra hook is ugly, but there's a risk re-purposing
the editTimer hook will break an add-on that assumes the note
has already been loaded

https://anki.tenderapp.com/discussions/ankidesktop/30972-bug-editing-html-in-browser-not-saved-unless-tabbingclicking-to-other-field
2018-11-27 18:00:57 +10:00
Damien Elmes
0605bd06fe case-insensitive field sort in find dupes 2018-11-27 16:44:23 +10:00
Damien Elmes
0560b6c4b2 limit find&replace fields to selected notes 2018-11-27 16:42:00 +10:00
Damien Elmes
ee6da6de61 fix encoding error when setting up profile
https://anki.tenderapp.com/discussions/ankidesktop/30926-error-when-choosing-ukrainian-as-the-interface-language
2018-11-27 12:55:24 +10:00
David Lönnhager
3a8fc88536 Use escape to close the deck chooser without switching to the selected deck 2018-11-26 18:06:29 +01:00
Damien Elmes
975edd0d56 catch wrong objects in add-on conf
based on patch from Arthur: https://github.com/dae/anki/pull/261/files
2018-11-18 15:22:31 +10:00
Damien Elmes
8f01c5ea90 fix font hack 2018-11-15 14:04:08 +10:00
Damien Elmes
8d2066a56e Merge pull request #260 from zandimna/patch-1
Change the order of elements on the window title
2018-11-13 11:10:51 +10:00
zandimna
8fa4b53107 Change the order of elements on the window title
The application name typically comes at the end of the title. As such, many tools grabs the final string as the application name. What Anki does currently causes the profile name to be grabbed, producing unexpected results.
2018-11-12 20:23:47 +08:00
Damien Elmes
66a38ca9c8 catch maxpath error in mediasrv
https://anki.tenderapp.com/discussions/ankidesktop/30729-valueerror-in-ospathisdir-call-in-mediasrvpy-for-elements-with-long-strings-as-src
2018-11-12 19:35:23 +10:00
Damien Elmes
0814d02c5f paste links as anchors if shift held down 2018-11-12 16:39:24 +10:00
Damien Elmes
ee88b22985 add hack for font name consistency issue
https://anki.tenderapp.com/discussions/ankidesktop/30785-bug-font-not-applying-to-japanese-characters
2018-11-12 16:30:11 +10:00
Damien Elmes
45a42a1c76 normalize search text
https://anki.tenderapp.com/discussions/ankidesktop/30614-diacritics-changed-on-card-save-anki-21
2018-11-12 12:43:54 +10:00
Damien Elmes
555e94f558 skip scroll if the number of cards has not changed
The scrolling behaviour is useful when cards are deleted, but
annoying in other cases such as when changing flags.
2018-11-12 12:26:23 +10:00
Damien Elmes
984de2e57e prevent hiding of shortcuts in browser context menu 2018-11-12 12:13:58 +10:00
Damien Elmes
b97f63b5b8 checkmark on flags in browser 2018-11-12 12:10:50 +10:00
Damien Elmes
f28df3c2fe prevent qt from hiding shortcuts in reviewer context 2018-11-12 12:02:51 +10:00
Damien Elmes
fe00fd1e0f show checkmark on current flag in reviewer context menu 2018-11-12 12:01:54 +10:00
Damien Elmes
0ebfeacad2 toggle flags in reviewer 2018-11-12 11:58:36 +10:00
Damien Elmes
4965f6bfb7 toggle flags instead of using separate clear action in browser 2018-11-12 11:55:37 +10:00
Damien Elmes
96ae855afd use a semi transparent, neutral selection in browser
As the base colour of rows is now visible, actions like flagging
now provide immediate feedback about what they've changed.
2018-11-12 11:02:01 +10:00
Damien Elmes
fd37eceaeb change purple flag to orange 2018-11-01 14:58:41 +10:00
Damien Elmes
c5a17a29fb Revert "workaround bottom toolbar issue on macOS/qt5.12"
This reverts commit 40b06d463a.

underlying issue should be fixed in qt5.12beta3
2018-10-29 21:08:16 +10:00
Damien Elmes
63a48ecdc4 display warning when profile corrupted 2018-10-29 21:06:33 +10:00