GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-17 15:59:03 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions
7243 commits 12 branches 166 tags 134 MiB
Commit graph

940 commits

Author SHA1 Message Date
Damien Elmes
9a697fd843 Merge branch 'more-backend-search' into main 2021-01-31 14:21:51 +10:00
Damien Elmes
5710e4bbd0 move drag/drop deck logic to backend 2021-01-31 13:46:31 +10:00
RumovZ
0374e8f4fe Revert addition of pb.NoteIDs 2021-01-30 12:59:18 +01:00
RumovZ
8033cc6784 Remove redundant docstring 2021-01-30 10:37:46 +01:00
Damien Elmes
2f1bbd44d2 simplify nid/nids searches, and ditch helper function 
- IdList could be re-used for a cids: search in the future if required.
- Embedding the message means it's easy to access from Python as
an attribute of SearchTerm.
 2021-01-30 11:37:00 +10:00
Damien Elmes
f6f537e89f simplify Dupe message and ditch helper function 
Calling code doesn't need to know about the existence of such helpers;
it can just rely on code completion to discover the required arguments.
 2021-01-30 11:10:26 +10:00
Damien Elmes
cf1e2a2c0d export SearchTerm from collection.py, and avoid exporting embedded items 2021-01-30 11:01:11 +10:00
Damien Elmes
b34d128560 rename FilterToSearchIn in backend to match frontend 2021-01-30 10:54:21 +10:00
RumovZ
c7365abc9e Refactor search_string() and FilterToSearchIn 
See #955.
 2021-01-29 18:27:33 +01:00
Damien Elmes
34c53aafb4 add getter/setter for boolean config values 2021-01-29 21:03:19 +10:00
RumovZ
9cf02efd20 Use proper docstrings 2021-01-29 09:40:21 +01:00
RumovZ
12c97442c9 Rename filters added_in etc. to added_in_days 2021-01-29 09:38:13 +01:00
Damien Elmes
137679a1a1 remove unused set_all_config; expose .all_config(). 2021-01-29 16:30:42 +10:00
RumovZ
df1d059128 Use backend filter for findDupes and handle excep. 2021-01-28 19:49:16 +01:00
RumovZ
d3d34bd9b3 Add backend filter for field name 2021-01-28 19:48:01 +01:00
RumovZ
cd9a3734c3 Use backend nid filter in browser 2021-01-28 16:21:56 +01:00
RumovZ
5af4b9f2a4 Add helper functions for search strings in col 2021-01-28 11:13:57 +01:00
Maksim Abramchuk
abd2f1a712 Remove unused variable 2021-01-26 21:37:16 +00:00
Damien Elmes
08f6ec649c fix finished screen not showing when learning cards due later 2021-01-25 21:12:57 +10:00
Damien Elmes
a6a4c0032d Merge pull request #934 from hgiesel/graphprefs 
Add GraphsPreferences API to graphs for setting persistent preferences
 2021-01-23 21:24:41 +10:00
Damien Elmes
387be76c00 minor wording tweak: GraphsPreferences -> GraphPreferences 2021-01-23 20:47:45 +10:00
Damien Elmes
fd6465c460 refresh new/rev counts when fillNew/fillRev() fails 
This was the behaviour before, but got lost when ._reset_counts() was
added. Also added the check back to schedv2:fillRev(), which also
appears to have gotten lost in the move to ._reset_counts()

Just a stop-gap fix until this code can get a proper rewrite.
 2021-01-23 14:02:05 +10:00
Damien Elmes
6329824e25 remove "invalid current deck" 
This should resolve itself when a user clicks on a deck.
 2021-01-23 13:04:58 +10:00
Henrik Giesel
25eee0e704 Change the function name in genbackend.py 2021-01-22 20:05:28 +01:00
Henrik Giesel
1516f5c37e Add GraphsPreferences endpoint to backend 2021-01-22 13:13:48 +01:00
abdo
4dfaf06308 Use new backend filters in rename_tag() 2021-01-16 18:49:48 +03:00
abdo
112aa44c90 Merge branch 'master' of https://github.com/ankitects/anki into tagtree 2021-01-15 01:12:01 +03:00
abdo
53736b7b9d Pass escaped name to bulk_update in rename_tag 2021-01-14 18:38:46 +03:00
abdo
4911945b9b Refactor code for clearing unused tags and saving collapse state 2021-01-14 07:04:14 +03:00
RumovZ
895b3a0b6f Use backend to set dupe filter 2021-01-14 10:42:37 +10:00
Damien Elmes
6cc58451b1 add local sync server frontend 2021-01-13 11:42:00 +10:00
abdo
c423e8d7bb Merge branch 'master' of https://github.com/ankitects/anki into tagtree 2021-01-12 23:31:58 +03:00
Damien Elmes
48892e588b tidy up UTC offset handling/timing calculations 
- use the TimestampSecs newtype instead of raw i64s
- use FixedOffset instead of a minutes_west offset
- check localOffset each time the timing is calculated, and set it
if it's stale - even for v1.
- check for and fix missing rollover when calculating timing
- stop explicitly passing localOffset in the sync/start call
 2021-01-12 21:32:56 +10:00
Damien Elmes
5e34168f7f remove temporary sync/dbcheck logging 2021-01-12 18:47:08 +10:00
Damien Elmes
0accefcd94 drop basicCheck() 
It can considerably slow down syncing on large collections
 2021-01-12 18:47:08 +10:00
Damien Elmes
4b98ce0145 Merge pull request #917 from hgiesel/querynozero3 
Coerce added/edited:0 to 1, Constrain rated:n to 1-365
 2021-01-11 16:24:12 +10:00
Henrik Giesel
3d2fcb6215 Adjust pyblib test_find 2021-01-10 16:25:52 +01:00
RumovZ
3d93d440c9 Also add FilterToSearch to want_release_gil() 2021-01-10 11:31:00 +01:00
RumovZ
02837ebbef Use explicit wrapper functions to get filters 2021-01-09 16:48:47 +01:00
abdo
a17d309ed3 Move tag collapse method to the backend 2021-01-09 17:10:16 +03:00
abdo
a18227acc4 Do not check for missing tag parents at registration time 2021-01-09 17:10:16 +03:00
abdo
a30a2638ce Hierarchical tags 2021-01-09 17:10:13 +03:00
RumovZ
370c689c83 Prettify frontend filter code 2021-01-09 12:34:46 +01:00
RumovZ
0cb75f5601 Use backend filters instead of literal searches 2021-01-09 10:51:15 +01:00
RumovZ
ad361e7a77 Provide ConcatSeparator through rsbackend.py 2021-01-07 17:48:30 +01:00
RumovZ
e563e4a19e Add writer functions to want_release_gil() 2021-01-07 13:09:00 +01:00
Damien Elmes
2b5ef0b9a8 fix qt/ pylints 2021-01-07 16:21:50 +10:00
Damien Elmes
f333c3332a Make orjson optional again 
While 32 bit platform support is probably not going to come back,
this allows Anki to run on other architectures orjson doesn't support.
 2021-01-07 09:44:40 +10:00
Damien Elmes
ceca13516b no need to log card resets when exporting 2021-01-05 11:11:37 +10:00
Damien Elmes
3123e6df7f do tag rename and tag clearing in background; move logic to tags.py 
Because the logic is in rename_tag() now, it means we create a
checkpoint even if the tag is orphaned. This is because currently
checkpointing is a GUI responsibility. In the future we need to introduce
multi-level undo, and should move responsibility for managing it
to the backend.
 2021-01-04 14:14:39 +10:00
Damien Elmes
2e4434df4f add linux_arm64 platform 2020-12-29 18:40:39 +10:00
Damien Elmes
0d3b80abd7 Merge pull request #866 from guillem-palau-salva/master 
Update consts.py
 2020-12-29 10:15:42 +10:00
Damien Elmes
ff0382ce11 Merge pull request #872 from RumovZ/fix-deck-check 
Fix deck check and thus blue sync arrow bug
 2020-12-29 10:11:59 +10:00
RumovZ
b4fa13aa0e Fix deck check and thus blue snyc arrow bug 
Cast col.decks.selected() to int so the return type fits the annotation.
Thus, fix the comparison in col.decks.select() which was leading to
a superfluous db modification and in turn to a false indication of a
necessary sync right after another one in certain cases.
 2020-12-29 00:29:36 +01:00
Guillem Palau-Salvà
2b5a6be3fa Update consts.py 
I notices that type 4 is added in the revlog when rescheduling. Reviews are logged as 0 time and type 4.
 2020-12-27 01:02:32 +01:00
Damien Elmes
d222686755 update to stable pyo3 0.13 release 2020-12-23 10:08:38 +10:00
Damien Elmes
25160daa90 tag the wheels as manual so test ... doesn't build them 2020-12-21 19:28:47 +10:00
Damien Elmes
250a45d32e possible fix for sync button colour blue after sync 
If the client's clock is behind AnkiWeb's, even by a few seconds,
we can end up with a situation where last_begin_at is updated after
the sync to a value less than the mtime we received from AnkiWeb,
causing the collection to be saved, which bumps the modtime.

Work around this by recording mtime at begin() time, and seeing if it
has changed in either direction.

Thanks to Rumo, who did the hard work looking into it:
https://forums.ankiweb.net/t/why-is-my-sync-button-blue/2078/21
 2020-12-21 19:27:26 +10:00
Damien Elmes
407b7f7410 tweak naming and move method into col.decks 2020-12-20 10:26:16 +10:00
k12ish
5da867c88a Added type hints, renamed kwarg 2020-12-19 18:12:58 +00:00
k12ish
9dc01bace1 Added method 2020-12-19 17:59:07 +00:00
Damien Elmes
faf992643a exhaustiveness checks on literals are now possible with the move to py38 2020-12-18 16:50:55 +10:00
Damien Elmes
9f3659a1d3 use QtMultimedia for recording instead of PyAudio 
The unmute-on-first-duration-change approach is to try to prevent
clicks/pops that can happen at the start of recordings. If it doesn't
solve the problem, we may need to drop down to the lower-level
QAudioInput().

Closes https://github.com/ankitects/help-wanted/issues/23

May fix https://forums.ankiweb.net/t/anki-crashes-periodically-after-clicking-record-audio-button/5824,
which I suspect was caused by processEvents()
 2020-12-16 19:33:25 +10:00
Damien Elmes
42f583f8a1 fix some warnings on startup 2020-12-16 15:38:24 +10:00
Damien Elmes
32a71c5418 remove conditional rsbackend_gen import 
It causes PyCharm to think methods are missing on col.backend, and
should not be needed with the move to Bazel.
 2020-12-16 13:30:54 +10:00
Damien Elmes
c28885d191 add type stub for _rsbridge to make PyCharm happy 2020-12-16 13:13:42 +10:00
Damien Elmes
5c93898e32 symlink generated .py/.pyi into tree to fix Python code completion 2020-12-16 11:36:42 +10:00
Damien Elmes
75a97d75ee add ability to specify an individual Python test 2020-12-16 10:40:29 +10:00
Damien Elmes
f7b87bb716 minor doc updates 2020-12-11 22:37:12 +10:00
Damien Elmes
7a95d7e189 remove unwanted leading '/' in wheel records 2020-12-10 23:02:18 +10:00
Damien Elmes
51635ff7e4 simplify wheel building 2020-12-10 20:27:21 +10:00
Damien Elmes
cf8cfcf97f drop unused i686 references 
https://forums.ankiweb.net/t/changing-ankis-build-system-to-bazel/4737/9
 2020-12-09 15:45:01 +10:00
Damien Elmes
1315d8b3c1 update Rust deps incl. Pyo3 
This includes the refcount bug fix from pyo3 0.12.4
 2020-12-01 16:48:45 +10:00
Damien Elmes
00d7a99562 expose Gaelic in language selection 2020-11-30 14:44:29 +10:00
Damien Elmes
2f9ddadf2c switch to workspace for Rust code 2020-11-24 18:41:03 +10:00
Damien Elmes
6a1cf40dcd Merge branch 'master' into init-lang 2020-11-22 16:10:49 +10:00
Damien Elmes
68311500b3 update remaining python format strings to Fluent 2020-11-22 14:57:53 +10:00
abdo
d06a9137b6 Set up default language before loading profile 
We can make more strings translatable this way.
 2020-11-21 05:29:23 +03:00
Damien Elmes
4043bd90bb Merge pull request #823 from RumovZ/rework-search-parser 
Rework search parser
 2020-11-20 16:22:12 +10:00
abdo
702c5712e4 Fix description of exporters 
Description broke yet again with the full migration to Fluent
 2020-11-19 23:52:46 +03:00
RumovZ
4e7a31250f Add Python test for tag whitespace 
Assert tag matches do not occur across different tags.
 2020-11-19 09:28:19 +01:00
RumovZ
f05e70a03e Merge branch 'master' into rework-search-parser 
Conflicts:
    rslib/src/search/sqlwriter.rs
 2020-11-18 09:04:04 +01:00
Damien Elmes
e271c63537 remove print statement from unit tests 2020-11-18 13:56:44 +10:00
Damien Elmes
ebd1236ab0 strip out unused gettext refs 2020-11-18 13:22:51 +10:00
Damien Elmes
7e655614b2 fix remaining _() references; remove unused imports 2020-11-18 12:43:46 +10:00
Damien Elmes
bd0919b7f1 update pylib ngettext references 2020-11-18 09:12:25 +10:00
Damien Elmes
346ec6880e drop i18n references in old stats 2020-11-18 09:12:03 +10:00
Damien Elmes
2feddb3d70 update temporary val="%s" references to standard ftl 2020-11-17 22:00:44 +10:00
Damien Elmes
1781e83252 merge pylib references 2020-11-17 19:23:06 +10:00
Damien Elmes
83cbe0d412 map gettext strings to keys/modules for ftl conversion 2020-11-17 14:11:09 +10:00
RumovZ
66241f642a Update frontend test to new escape handling 2020-11-15 09:39:10 +01:00
Damien Elmes
ad5cbf195f use full path in backend_pb2 import 2020-11-13 14:21:21 +10:00
Damien Elmes
a4af59fc4d format_fix -> format; rename svelte-check for consistency 2020-11-12 20:19:32 +10:00
Damien Elmes
c1e154e3ad update Python deps 2020-11-12 20:03:41 +10:00
Damien Elmes
dc9026e9d7 orjson was missing from dep list; drop 32 bit compat 2020-11-12 20:03:41 +10:00
Damien Elmes
db24dcf9a7 add coding specifier to anki/__init__.py 
older gettext versions will complain otherwise (was breaking Windows CI)
 2020-11-11 21:51:11 +10:00
Damien Elmes
593e9d4e7b Merge pull request #817 from cecini/formatcheck 
Update mypy and black format check to python version 3.8
 2020-11-11 21:36:32 +10:00
Damien Elmes
c62e6e61c2 update i18n scripts 
- export updated .po files for consumption
- add a script to pull and push translations
 2020-11-11 21:08:06 +10:00
cecini
28abd41925 Update mypy and black format check to python version 3.8 2020-11-11 09:24:28 +00:00
Damien Elmes
f8d402ee70 fix error exporting v2 collection when translations don't match 
https://forums.ankiweb.net/t/utf8-error-in-importing-deck/4430/13
 2020-11-11 15:42:08 +10:00
Damien Elmes
ec74cf6730 handle packaged pylib buildinfo.txt; drop aqt buildinfo 2020-11-11 10:33:49 +10:00
Damien Elmes
8147c9996a Merge pull request #793 from nwwt/object-audio-tags-support 
Audio & object tag support
 2020-11-11 10:33:31 +10:00
Andreas Reis
81d6d21ae3 cleanup / renames 
・ soundRegexps →  sound_regexps

・ htmlRegexps →  html_media_regexps

・ HTML_TAGS →  HTML_MEDIA_TAGS

・ escapeImages →  escape_media_filenames + alias

・ strip_html_preserving_image_filenames →  strip_html_preserving_media_filenames
 2020-11-10 14:53:04 +01:00
ianki
28ad68d490 Add hooks for filtering media. 2020-11-09 02:12:23 -08:00
Damien Elmes
338836ebb9 cleanups 2020-11-05 11:21:13 +10:00
Damien Elmes
ad809943bf fix backend_pb2 race 2020-11-05 11:02:40 +10:00
Damien Elmes
507a17b9e0 unused import 2020-11-04 21:04:42 +10:00
Damien Elmes
e4ba941cf1 move aqt_data into source folder; implement wheel building 2020-11-04 12:14:03 +10:00
Damien Elmes
f0e3d29979 switch to the stable Python ABI 
Should allow the library to be imported in both Python 3.8+3.9.
 2020-11-03 20:29:07 +10:00
Alan Du
3d68b22962 Update to PyO3 0.12 
+ cargo raze by Damien
 2020-11-02 18:38:34 +10:00
Damien Elmes
db0e0e78f8 update cargo deps; add script to copy them from rslib/ 2020-11-02 18:17:26 +10:00
Damien Elmes
7c27c4b9a0 move backend.proto into rslib/ 2020-11-02 16:28:31 +10:00
Damien Elmes
a7f403f0b0 rspy -> pylib/rsbridge 2020-11-02 15:21:12 +10:00
Damien Elmes
f9171eb3d3 remove old makefiles 2020-11-01 14:41:01 +10:00
Damien Elmes
ce3b08ac58 initial Bazel conversion 
Running and testing should be working on the three platforms, but
there's still a fair bit that needs to be done:

- Wheel building + testing in a venv still needs to be implemented.
- Python requirements still need to be compiled with piptool and pinned;
need to compile on all platforms then merge
- Cargo deps in cargo/ and rslib/ need to be cleaned up, and ideally
unified into one place
- Currently using rustls to work around openssl compilation issues
on Linux, but this will break corporate proxies with custom SSL
authorities; need to conditionally use openssl or use
https://github.com/seanmonstar/reqwest/pull/1058
- Makefiles and docs still need cleaning up
- It may make sense to reparent ts/* to the top level, as we don't
nest the other modules under a specific language.
- rspy and pylib must always be updated in lock-step, so merging
rspy into pylib as a private module would simplify things.
- Merging desktop-ftl and mobile-ftl into the core ftl would make
managing and updating translations easier.
- Obsolete scripts need removing.
- And probably more.
 2020-11-01 14:26:58 +10:00
Andreas Reis
c77ac81e9d Add audio & object tags to media check 
Makes the media check recognize files in <audio> and <object> tags as used.

They've been observed/supported by the WebView (checked: Anki, AnkiDroid) since just about forever already and are extremely useful if one knows a thing about web dev.
 2020-10-25 13:09:57 +01:00
Arthur Milchior
7287b295f4 NF: uses consts and update comment according to code 2020-10-15 08:22:23 +02:00
Damien Elmes
597b81ebeb Merge pull request #782 from johan456789/patch-1 
fix outdated help site
 2020-10-12 12:15:46 +10:00
Damien Elmes
909367efc1 fixes for latest mypy 2020-10-10 19:02:59 +10:00
johan456789
7130a21e8d fix outdated help site 2020-10-07 19:38:49 +08:00
Damien Elmes
2ed1507162 bump version 2020-10-02 10:22:21 +10:00
Arthur Milchior
fa13c0cc20 NF: uses consts in col 2020-09-27 09:01:47 +02:00
Damien Elmes
1a619073d7 bump version 2020-09-24 10:52:24 +10:00
Arthur Milchior
b322e6d5f2 NF: remove _changedGuids 
Nothing is ever added to the map.
That was a bug detected by lint in ankidroid
 2020-09-21 06:02:10 +02:00
Damien Elmes
28b5c6c107 small learning steps were being stored as a float 
https://forums.ankiweb.net/t/bug-with-fractional-learning-intervals/3524/5
 2020-09-20 10:29:39 +10:00
Damien Elmes
bc60d233e5 rebuild_filtered_deck() and new_filtered() 2020-09-03 18:02:47 +10:00
Damien Elmes
6f7f5686e8 empty_filtered_deck() 2020-09-03 17:43:07 +10:00
Damien Elmes
f32d773e25 set_deck() 2020-09-03 17:42:46 +10:00
Damien Elmes
7c169daa95 move card sorting and resetting to backend 2020-09-03 15:54:15 +10:00
Damien Elmes
366c5c4774 log manual reschedule, but ignore the log entry in the stats 2020-09-02 17:56:23 +10:00
Damien Elmes
31b7d7d645 move reschedCards() to backend 2020-09-02 17:56:23 +10:00
Damien Elmes
396081d329 move filtered deck empty/fill to backend 
emptying of individual card ids still to be done
 2020-09-02 17:56:23 +10:00
Damien Elmes
0f6840596b fix night mode on old graphs 2020-09-02 17:56:12 +10:00
Damien Elmes
7f42500e53 rename some card+note fields in backend 2020-09-01 10:24:38 +10:00
Damien Elmes
9f51347e1e move bury/suspend into backend 2020-09-01 10:24:38 +10:00
Damien Elmes
a8f84c1264 formatting fixes for latest black 2020-09-01 10:24:38 +10:00
Damien Elmes
988b3c00c1 move unbury/unsuspend routines into backend 2020-09-01 10:24:38 +10:00
Damien Elmes
999b659c3a reimplement congrats screen in Rust+Typescript 2020-09-01 10:24:38 +10:00
Damien Elmes
8ad734afc5 add missing pylint/isort deps 2020-08-31 14:07:04 +10:00
Damien Elmes
8729edffbb update to latest black 2020-08-31 13:29:28 +10:00
Damien Elmes
aeca369c9b update to latest isort, pylint and pytest 2020-08-31 12:05:36 +10:00
Damien Elmes
204db71586 fix new pylint raise-missing-from lint 2020-08-31 12:04:14 +10:00
Damien Elmes
f3c6d565b0 bump version 2020-08-31 11:07:54 +10:00
Damien Elmes
7cfeb6cbb3 check if we need to unbury at the start of the sync process 
https://forums.ankiweb.net/t/bug-buried-cards-in-filtered-decks-not-being-unburied-next-day/2541/24
 2020-08-28 21:09:07 +10:00
Damien Elmes
864864f650 fix next learn message overestimating delay 
https://forums.ankiweb.net/t/bug-with-short-intervals-in-anki-2-1-scheduler/2678
 2020-08-27 09:35:31 +10:00
Damien Elmes
31f011b3a5 fix description in export screen (thanks to ANH) 
https://forums.ankiweb.net/t/anki-2-1-31-exporting-display-bug/2669/3
 2020-08-26 08:33:35 +10:00
Damien Elmes
2f6d816cdc bump version 2020-08-26 08:05:45 +10:00
Damien Elmes
58c8609332 bump version 2020-08-24 11:28:22 +10:00
Damien Elmes
9ae45ecea2 revlog entry should not be deleted when undoing preview card 
The plan is to add a revlog entry when previewing in the future; this
is just a temporary fix.
 2020-08-19 16:44:06 +10:00
Arthur Milchior
110f4c664f Any removed 2020-08-12 01:37:21 +02:00
Arthur Milchior
a74601a0f0 NF: childMapNode 2020-08-12 00:42:42 +02:00
Damien Elmes
4629dd38fb bump version 2020-08-09 13:44:59 +10:00
Damien Elmes
fa9aa82830 previous fs encoding test didn't catch things like latin-1 
https://forums.ankiweb.net/t/unicodeencodeerror-when-syncing/1746
 2020-08-03 11:29:07 +10:00
Damien Elmes
02c7a0e339 enable strict equality checks in mypy 
Without it, the following code reports no problems:

def foo() -> int:
    return 5
print(foo == 5)
 2020-08-03 10:26:40 +10:00
Damien Elmes
1902e839e3 fix missing translations in export screen 
https://forums.ankiweb.net/t/untranslated-strings/1623
 2020-07-31 13:33:41 +10:00
Damien Elmes
cecdebc70b pin pytest due to pylint issue 2020-07-29 14:52:45 +10:00
Matt Krump
d4511e3287 Turn on check_untyped_defs for aqt.exporting 2020-07-28 18:42:22 -06:00
Damien Elmes
d3653ab6d5 bump version 2020-07-28 12:59:56 +10:00
Damien Elmes
39272c436e force old graphs to use ltr 
otherwise the axis labels are way off

https://forums.ankiweb.net/t/anki-2-1-29-beta/1220/8
 2020-07-22 14:30:56 +10:00
Damien Elmes
7e78d12b99 bump version 2020-07-21 15:54:14 +10:00
Damien Elmes
876f474b7d apply rtl dir to webviews 
https://forums.ankiweb.net/t/gui-problems-with-right-to-left-languages/1205
 2020-07-21 11:52:25 +10:00
Damien Elmes
15bc3c4033 Merge pull request #698 from Arthur-Milchior/remove_clear_overdue 
remove _clearOverdue
 2020-07-21 10:27:04 +10:00
Arthur Milchior
e40c3b4254 remove unused variable 2020-07-20 10:17:23 +02:00
Arthur Milchior
d686aeccad duplicate assignment removed 2020-07-20 06:47:47 +02:00
Arthur Milchior
d983feaefe typo 2020-07-20 06:28:36 +02:00
Arthur Milchior
b4c32db460 remove useless variable cram 2020-07-20 06:24:42 +02:00
Arthur Milchior
4885404afb remove _clearOverdue 
This member is never read
 2020-07-20 05:45:18 +02:00
Damien Elmes
3ca4a882a1 Merge pull request #692 from Arthur-Milchior/remove_useles_variables 
Remove useless variables
 2020-07-20 11:35:40 +10:00
Damien Elmes
f1202efe5f Merge pull request #697 from Arthur-Milchior/typos 
Comment typo
 2020-07-20 11:34:02 +10:00
Damien Elmes
bc28a40e50 Merge pull request #696 from Arthur-Milchior/note_to_add_note 
For some reason, add_note were assigned to a unused variable
 2020-07-20 11:32:55 +10:00
Damien Elmes
6073644ed4 Merge pull request #695 from Arthur-Milchior/note->field 
replace "note" by "field"
 2020-07-20 11:32:30 +10:00
Arthur Milchior
8253ee59bc Comment typo 2020-07-19 11:24:58 +02:00
Arthur Milchior
57aac57e93 For some reason, add_note were assigned to a unused variable 
I remove it for clarity
 2020-07-19 10:58:40 +02:00
Arthur Milchior
83fac5db14 replace "note" by "field" 
My bad. In one case `f` did represent "field" and not "fact"
 2020-07-19 08:24:43 +02:00
Arthur Milchior
d09cf43bab Uses constant in tests 2020-07-19 05:34:22 +02:00
Arthur Milchior
d9fe9297ba d2->col2 2020-07-17 17:55:57 +02:00
Arthur Milchior
2c5001a0e8 tmp->col in tests 2020-07-17 17:37:17 +02:00
Arthur Milchior
b553d32db2 f4->note4 2020-07-17 17:34:39 +02:00
Arthur Milchior
7e8c748c09 f3->note3 2020-07-17 17:33:58 +02:00
Arthur Milchior
5a7bda27c8 f->n in id 2020-07-17 17:30:29 +02:00
Arthur Milchior
a81d7544f6 NF: deck2->col2 2020-07-17 17:27:40 +02:00
Arthur Milchior
71afb2b4d3 Remove useless variables 2020-07-17 08:38:48 +02:00
Arthur Milchior
83c778ea53 gn->deckn in test 
Obtained by
```
sed -i "s/\bg1\b/deck1/g" pylib/tests/*py qt/tests/*py
sed -i "s/\bg2\b/deck2/g" pylib/tests/*py qt/tests/*py
```
 2020-07-17 06:58:32 +02:00
Arthur Milchior
14421e107c d->col in tests 
obtained by
```
sed -i "s/\bd\b/col/g" pylib/tests/*py qt/tests/*py
```
 2020-07-17 06:58:32 +02:00
Arthur Milchior
c918d794c2 deck->col in tests 
Obtained by
```
sed -i "s/\bdeck\b/col/g" pylib/tests/*py qt/tests/*py
```
 2020-07-17 06:50:46 +02:00
Arthur Milchior
9d313ea6b3 f2->note2 in test 
Obtained by
```
sed -i "s/\bf2\b/note2/g" pylib/tests/*py qt/tests/*py
```
 2020-07-17 06:47:44 +02:00
Arthur Milchior
d4b2982fc2 f->note in test 
Obtained by sed -i "s/\bf\b/note/g" pylib/tests/*py qt/tests/*py
 2020-07-17 06:47:44 +02:00
Arthur Milchior
1f51a93fff note->n 
Next commit will transform f into note, and this lead to a variable clash here
 2020-07-17 06:08:33 +02:00
Damien Elmes
3a75161778 fix deck tree with a day delta, and support arbitrary timestamps 2020-07-06 19:16:03 +10:00
Damien Elmes
4e7ae0969f formatting 2020-07-01 14:01:24 +10:00
Damien Elmes
e9eb7c0e9b hack around future unburied date 
We want to avoid unburied != self.today, because the unburied time
is synchronized as part of the collection at the moment, and we don't
want a client with an older unburied time that was modified more
recently to cause cards to be unburied twice - so we only unbury
if today is more than 7 days earlier than the last unbury time.

Unsure what caused these users to end up in that state in the first
place:
https://anki.tenderapp.com/discussions/ankidesktop/41335-cards-remain-buried-forever-unless-manually-unburied
 2020-07-01 13:12:45 +10:00
Damien Elmes
1e9901e9bd experiment with exposing raw card/revlog data to frontend 2020-06-29 15:48:00 +10:00
Damien Elmes
df8be64da3 protobuf package should be in PascalCase 2020-06-29 15:48:00 +10:00
Damien Elmes
597830942d fix media not working after full sync 2020-06-24 09:52:02 +10:00
Damien Elmes
5da6b010c9 drop yellow colour in "filtered" for now 
It's difficult to read against a light background
 2020-06-16 16:39:07 +10:00
Damien Elmes
f5694a7e4a migrate card stats to backend 
Currently this renders the HTML directly like the previous Python
implementation - doing it in JS would probably make more sense in the
future.
 2020-06-15 17:22:16 +10:00
Damien Elmes
a6bc2b88cc fix lint issues with latest mypy_protobuf 2020-06-14 15:38:43 +10:00
Damien Elmes
07874f8328 handle db errors the same way as other backend requests 2020-06-12 20:39:02 +10:00
Damien Elmes
9e867189bd update unit test for leech change 2020-06-09 14:12:34 +10:00
Damien Elmes
cafe5cbbc1 strip out \r on export 
(private post)
https://anki.tenderapp.com/discussions/ankidesktop/42315-bug-report-exporting-selected-cards-in-browser-issue
 2020-06-09 12:56:16 +10:00
Damien Elmes
682358b594 fix error when importing v2 apkg 
https://anki.tenderapp.com/discussions/ankidesktop/42070-anki-closes-without-warning-when-importing-conflicting-shared-deck
 2020-06-09 12:06:52 +10:00
Damien Elmes
73eef285f0 fix audio being included in FrontSide 2020-06-09 08:16:03 +10:00
Damien Elmes
75471224fa add progress to db check 2020-06-08 21:07:36 +10:00
Damien Elmes
9cf159cea4 Merge pull request #658 from BlueGreenMagick/media-type 
add type hint for media dir
 2020-06-08 11:31:01 +10:00
Damien Elmes
d970dda3c9 fix legacy deckDueTree() 2020-06-08 11:12:24 +10:00
BlueGreenMagick
5e22627462 add type hint for media dir 2020-06-07 10:35:48 +09:00
Damien Elmes
e74e5c604b add daily count updating to backend 2020-06-05 19:49:53 +10:00
Damien Elmes
55f8b87548 support generating a due tree for a different date 2020-06-05 09:38:31 +10:00
Damien Elmes
c5e65d02e1 add note/card removal to backend 2020-06-04 18:21:04 +10:00
Damien Elmes
80987a34ab add .count() to hooks, and list->sequence in note deletion 2020-06-04 18:20:03 +10:00
Damien Elmes
0334ce075c fix duplicate/empty check 2020-06-02 17:34:34 +10:00
Damien Elmes
d7a2e78c0b change sync label to indicate sync state 
- blue for normal sync, red for full sync required
- refactor status fetching code so we don't hold a collection lock
during the network request, which slows things down
- fix sync spinner restarting when returning to deck list
 2020-06-02 13:23:01 +10:00
Damien Elmes
e534ae9aab "fix" v1 scheduler breaking after burySiblings change 2020-06-01 19:44:25 +10:00
Damien Elmes
ad3082d1c8 handle aborting normal sync 
- Use a separate abort handle, as the media sync is running
in the background and we need to be able to target them separately.
The current progress handling is going to need a rethink if we introduce
any other background tasks in the future.
- Roll back the transaction when interrupting.
 2020-06-01 13:57:10 +10:00
Damien Elmes
da1e0527ca report normal sync progress 
Also:
- provide a way for the progress handler to skip the throttling so that
we can ensure progress is updated at the end of a stage
- show 'checking' at the end of full sync
 2020-06-01 13:57:10 +10:00
Damien Elmes
854c524ecf fix mtime being bumped in .reset() 2020-06-01 13:57:10 +10:00
Damien Elmes
0e9bd3fa1b fix de-auth when no media DB set up 2020-06-01 13:57:10 +10:00
Damien Elmes
0787381a99 login/full up/full down plugged in 2020-06-01 13:57:10 +10:00
Damien Elmes
aaed0464e5 rework progress handling 
- client now polls status instead of backend pushing it
- supports multiple threads
- update throttling happens in one place
 2020-06-01 13:57:10 +10:00
Damien Elmes
9a4d9fdec0 tidy up sibling burying 
closes #649
 2020-06-01 13:48:15 +10:00
Damien Elmes
f8e577367b handle images served from directory + svg content type 
https://anki.tenderapp.com/discussions/ankidesktop/41974-win-linux-when-pasting-some-html-i-get-error-in-_run_command-ankirsbackendioerror-ioerror
 2020-06-01 13:40:17 +10:00
Damien Elmes
1a88b16f07 Merge pull request #643 from evandroforks/add_repr_functions 
Added __repr__ functions to common objects
 2020-06-01 13:29:21 +10:00
evandrocoan
1d18d5dd70 Say which card failed with an exception 2020-05-31 19:41:18 -03:00
evandrocoan
3d2dcc8cec Added super().__repr__() to new __repr__() calls 2020-05-31 19:39:19 -03:00
evandrocoan
45cb996cc9 Added __repr__ functions to common objects 2020-05-31 19:39:19 -03:00
Damien Elmes
9e5dad86a8 fix typechecking breaking with latest mypy_protobuf 
the change that caused it:
https://github.com/dropbox/mypy-protobuf/issues/118

This is more awkward to handle now, as the types are only available
at type-checking time. Python's static typing is such a mess :-(
 2020-05-27 09:14:02 +10:00
Damien Elmes
3d6c478f8a avoid printing the original exception bytes 
Prevents the "while processing this exception, another exception
occurred" message
 2020-05-25 14:28:37 +10:00
Damien Elmes
004733f4b3 move generated methods into separate, gitignored file 2020-05-24 20:41:53 +10:00
Damien Elmes
91e3256e6a move dupe check to backend 2020-05-24 19:48:56 +10:00
Damien Elmes
e9fea26d1c use keyword args for calls with more than one argument 2020-05-24 09:12:47 +10:00
Damien Elmes
bbcc566e6d migrate the remaining methods 2020-05-24 08:36:50 +10:00
Damien Elmes
93f18c14d4 migrate more scheduling/media/etc 
almost there
 2020-05-23 21:34:19 +10:00
Damien Elmes
8b93a0c19d migrate notetypes, update GIL list 2020-05-23 20:43:55 +10:00
Damien Elmes
35489d5fa7 add some more newtypes to the RPC defs 2020-05-23 16:58:01 +10:00
Damien Elmes
8df2ab65fb migrate cards and notes 2020-05-23 16:19:48 +10:00
Damien Elmes
32a071cf79 migrate decks and dconf methods 2020-05-23 15:09:16 +10:00
Damien Elmes
927ed25b02 more methods 2020-05-23 14:01:36 +10:00
Damien Elmes
d57ded706f migrate more methods to service 2020-05-22 22:09:33 +10:00
Damien Elmes
36024ed086 start reworking protobuf handling 
Will allow us to cut down on boilerplate by automatically generating
code from RPC service definitions
 2020-05-22 20:56:15 +10:00
Damien Elmes
7676748e6c fix deletion of decks; allow deleting cards from default 
https://anki.tenderapp.com/discussions/beta-testing/1967-2126-189-g7384df8f-crash-at-note-types-fields-save#comment_48353232
 2020-05-22 11:24:56 +10:00
Damien Elmes
d31f2d8c23 move deck/notetype update hooks to gui 
We need to migrate away from firing hooks in libanki, since libanki
methods may be running on a background thread, and hook consumers
typically expect the code to run in the main thread. We could document
it, but it would frequently be forgotten about, and could lead to
crashes.

https://anki.tenderapp.com/discussions/ankidesktop/41748-qobject-cannot-create-children-for-a-parent-that-is-in-a-different-thread-when-hitting-the-save-button-on-clayoutpy-window
 2020-05-22 10:47:14 +10:00
Damien Elmes
d3557f380d can't use _card.note_type() in clayout 2020-05-22 09:58:58 +10:00
Damien Elmes
ede0bb5420 add back most of .fields() to avoid breaking add-ons 2020-05-21 12:08:51 +10:00
Damien Elmes
2b46d4c73c use longer delay in test_timing() 
was intermittently failing in slow Windows CI
 2020-05-21 09:33:49 +10:00
evandrocoan
04dc65ef78 Fixed HttpClient session not being closed 2020-05-20 19:20:41 -03:00
Damien Elmes
99462e39b8 fix deck age being used instead of collection 
https://anki.tenderapp.com/discussions/ankidesktop/41637-bug-in-statistics
 2020-05-20 19:46:01 +10:00
Damien Elmes
b3e8c63d65 update missed storage._Collection references 2020-05-20 19:45:46 +10:00
Damien Elmes
068cc43095 storage->collection 2020-05-20 17:58:28 +10:00
Damien Elmes
4f5fc9a63d move storage logic into collection.py; fix export bug 
https://anki.tenderapp.com/discussions/ankidesktop/41495-using-file-export-closes-the-collection-on-mwcoldb-if-the-browser-window-is-open
 2020-05-20 17:43:34 +10:00
Damien Elmes
3f8a3afb78 fix extending limits in custom study 
https://anki.tenderapp.com/discussions/beta-testing/1967-2126-189-g7384df8f-crash-at-note-types-fields-save
 2020-05-20 14:13:40 +10:00