GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-13 22:13:58 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions
10915 commits 10 branches 166 tags 121 MiB
Commit graph

1956 commits

Author SHA1 Message Date
Jarrett Ye
6648b20b06 clamp interval before fuzz_bounds (#3024) 
* clamp interval before fuzz_bounds

* update unit test of with_review_fuzz
 2024-02-25 12:18:01 +07:00
Viktor Ricci
43999e4518 Fix regex skipping over all src except the last (#3021) 
Adapting HTML_MEDIA_TAGS to allow for `>` inside '' and "" led to
multiple images inside a field sometimes being disregarded and
marked as "unused". This seems to have been caused by a missing
lazy (?) quantifier for the regex part skipping over non-`>`.
 2024-02-24 15:27:38 +07:00
Abdo
3cde97275d Check required review count for FSRS after filtering (#3019) 
* Check for required review count for FSRS after filtering

* Remove unreachable check

* Update minimum review count in optimal retention calculation

* Fix review check in optimal retention routine too
 2024-02-24 14:53:38 +07:00
Luc Mcgrady
291342ea2c FSRS - Ignore revlogs before date while optimizing (#2922) 
* Added: Date input button

* Added: ignoreDate to config

* Added: Backend

* Optimize function passes value

* Fix: Spelling

* Moved: filter logic from revlog_for_srs to update_memory_state

* fmt

* Copyright header

* ./check

* Fix: Test

* Renamed: Ignore_date -> Ignore_before_date

* Neaten parameters

* evaluate weights

* ./check

* Optimize all presets

* Added: Label localizations

* Removed globe label

* Added: Tooltip

* Changed error type

* fmt

* Moved filter to own function

* missing function call replacement

* Fix: Typo

* Apply suggestions from code review

Co-authored-by: Damien Elmes <dae@users.noreply.github.com>

* timestamp * 1000 -> timestamp_millis

* ignoreBefore -> ignore_before

* clarified ignore_before variables

* i64 -> TimestampMillis

* Un-traitified remove_revlogs_before

* Added: ms == 0 guard

* Added: Ignore_before affects scheduling

* Moved filter to fsrs_items_for_training

* removed filter from revlog_for_srs

* Tuple -> UpdateMemoryStateEntry

* Removed unused function

* Removed superfluous _ms from variables

* cid -> id

* Different ignore method

* Added: Unit test

* cid -> id

* Test: Exact ms edge case

* ./check

* Fix: re-learns could be before ignore date in cards without learning steps

* getignoreRevlogsBeforeMs -> getIgnoreRevlogsBeforeMs

* Removed pub(crate)

* Clarified unit test

* last_learn_entry -> first_of_last_learn_entries

* @user1823's method

* IOS fix

* ./check

* Fix: width defined twice
 2024-02-22 11:01:10 +07:00
Damien Elmes
5a152ff56e FSRS items, not revlogs 
https://forums.ankiweb.net/t/discrepancy-between-revlog-count-in-optimize-and-evaluate/41224/5
 2024-02-19 17:51:07 +07:00
Abdo
970ca973ba Fix deck names differing in case being duplicated in CSV import (#3008) 2024-02-14 20:25:54 +10:00
Jarrett Ye
9b7ff46fb2 Fix/ignore revlogs before Forget entry (#3002) 
* Fix/ignore revlogs before Forget entry

* Update weights.rs
 2024-02-12 16:09:39 +10:00
Abdo
739e0196e9 Keep previous FSRS parameters if they get worse when optimizing (#2996) 
* Update to fsrs-rs 0.3.0

* Keep previous FSRS parameters if they get worse when optimizing
 2024-02-11 16:26:04 +10:00
Abdo
6d62ca1cf5 Fix preset: search ignoring cards in filtered decks (#2997) 2024-02-11 16:11:05 +10:00
Abdo
bffac38cf9 Fix maybe_coalesce_note_undo_entry() (#2992) 
* Fix maybe_coalesce_note_undo_entry()

* Use .count()

* Only check .first()

* Explicitly match on [note change, collection modification] (dae)
 2024-02-11 16:04:10 +10:00
Abdo
d11a655e9b Maintain original IO cloze order in editing mode (#2987) 
* Maintain original IO cloze order in editing mode

* Fix ordinal propery name
 2024-02-07 13:42:47 +10:00
Abdo
c828c8d1e6 Do not reset original_due when card stays in filtered deck (#2988) 2024-02-07 13:27:54 +10:00
Jarrett Ye
f76763b10e update FSRS to v0.2.0 (#2977) 
* update FSRS to v0.2.0

* update comments

* ./ninja fix:minilints

* 1000 -> 400 in translation (dae)
 2024-01-30 16:27:12 +10:00
RumovZ
b8aa550353 Increase parent limits in custom study when 'limits start from top' is enabled (#2971) 
Closes #2965.
 2024-01-29 13:15:44 +10:00
RumovZ
4274fbf04c Fix notetype conflict resolution (#2967) 
* Fix undoing notetype conflict resolution

* Fix field/template mapping after notetype conflict resolution
 2024-01-29 13:00:57 +10:00
Abdo
09b5ed719e Add by creation date review sort order (#2957) 
* Add by creation date review sort order

* Order by template after nid in ReverseAdded of filtered decks too
 2024-01-21 20:29:19 +10:00
Abdo
c183b758bd Default to 'Bury Card' action consistently (#2950) 2024-01-19 15:49:16 +10:00
Damien Elmes
fd5100ae88 Fix error after notetype merge + downgrade 2024-01-12 15:16:27 +10:00
Damien Elmes
b2345e9fe4 Include details on what's missing when a NotFound error is triggered 
Makes debugging issues like #2939 easier
 2024-01-11 14:20:10 +10:00
Damien Elmes
5b6a81cbf2 Fix importing of Mnemosyne due dates (#2936) 2024-01-11 14:11:17 +10:00
RumovZ
4920c13526 Fix note id mix-up when resolving notetype conflicts (#2940) 
Closes #2939.
 2024-01-11 13:50:03 +10:00
Damien Elmes
6709e022fc Use card.reps - 1 when calculating fuzz (#2933) 
https://github.com/open-spaced-repetition/fsrs4anki-helper/issues/343#issuecomment-1879584562

https://forums.ankiweb.net/t/reschedule-is-inconsistent-with-normal-schedule-in-fuzz/39363
 2024-01-09 12:26:46 +10:00
Damien Elmes
ee05094e57 Check review count up front 
https://forums.ankiweb.net/t/inconsistent-number-of-reviews-when-clicking-optimize/39275/7
 2024-01-08 14:05:09 +10:00
Damien Elmes
f1009d8d44 Update to Rust 1.75 2024-01-05 14:28:23 +10:00
Abdo
c18ad5ed85 Ignore some extra chars in no-combining search (#2929) 
* Ignore some extra chars in no-combining search

* Construct new string

* Update rslib/src/text.rs (dae)
 2024-01-05 14:22:52 +10:00
Viktor Ricci
d0359ab5eb Allow > inside HTML attributes (#2918) 
* Allow > inside HTML attributes

* Don't add unnecessary (?:...) to HTML_MEDIA_TAGS
 2024-01-01 14:09:30 +10:00
Damien Elmes
bb71e9b18c Work around test failure on Windows 2023-12-28 18:43:28 +10:00
Damien Elmes
f94a129f5e Pull in FSRS fix for pretrain 2023-12-28 18:15:44 +10:00
RumovZ
54b21bdeaa Cloze notetype merges (#2912) 
* Abort when trying to match notetypes of different kinds

* Skip merging templates if target is cloze
 2023-12-28 18:01:23 +10:00
RumovZ
9bebe2d72d Fix new cards from parent decks being gathered (#2907) 
Fixes #2906.
 2023-12-24 20:04:28 +10:00
Jarrett Ye
9af073cd0e Update to FSRS-4.5 (#2901) 2023-12-22 16:17:40 +10:00
Damien Elmes
08a7b3ccab Update FSRS 
We're on the commit prior to
https://github.com/open-spaced-repetition/fsrs-rs/pull/141, as that is
going to require work that will need to wait until after 23.12
 2023-12-22 14:02:39 +10:00
Damien Elmes
2a173fdca9 Force memory state recompute when cards moved into different deck 2023-12-22 14:02:39 +10:00
RumovZ
1ad343c22a Log existing notes during CSV import (#2898) 2023-12-22 14:01:35 +10:00
Damien Elmes
e5fa4791a7 Use seconds instead of minutes for preview delay 
Since this is not compatible with older clients, preview_delay has been
brought back so the configured value will still sync.
 2023-12-21 11:02:29 +10:00
Damien Elmes
3b3d9444b8 Calculate elapsed days for intraday learning cards 
https://forums.ankiweb.net/t/anki-23-12-beta/37771/109
 2023-12-13 10:18:29 +10:00
Damien Elmes
701e0b7e60 Fix error generating parameters when a parameter is 0 2023-12-12 12:33:32 +10:00
Damien Elmes
9c3cf6af57 Ensure cloze numbers sort in order 
https://forums.ankiweb.net/t/anki-23-12-beta/37771/103
 2023-12-12 09:51:42 +10:00
Damien Elmes
935f50cfff Don't use SM2 memory state when cards are manually introduced 
https://github.com/open-spaced-repetition/fsrs4anki/issues/540#issuecomment-1848833376
 2023-12-12 09:40:31 +10:00
Damien Elmes
f4acaa17cd Update FSRS for new default weights 2023-12-08 13:54:31 +10:00
Damien Elmes
629ff330a2 Allow user to configure hard/good buttons when rescheduling off 
Closes #2858
 2023-12-08 11:04:34 +10:00
Damien Elmes
cdacb9a489 Hide position when card not new 
https://forums.ankiweb.net/t/position-info-is-shown-even-when-the-card-is-not-new/38087
 2023-12-08 10:06:14 +10:00
Damien Elmes
a1c2009c0e Treat cards with no reps like new cards 
https://github.com/open-spaced-repetition/fsrs4anki/issues/540#issuecomment-1837780217
 2023-12-07 14:56:39 +10:00
Damien Elmes
75681810b0 Update to latest fsrs-rs 
The extra entries in Cargo.lock and licenses.json are mostly spurious,
and caused by https://github.com/tracel-ai/burn/pull/1025#issuecomment-1842006690
 2023-12-07 14:13:58 +10:00
Gustaf-C
908f77ca53 Include elapsed_secs in learning card state (#2862) 
* Include elapsed_time in learning card state

* Suggested updates, elapsed_time -> elapsed_secs

* Remove outdated comment
 2023-12-06 16:40:22 +10:00
Jarrett Ye
f968cad2a6 Fix/keep two decimals for stability (#2873) 
* Fix/keep two decimals

* update test
 2023-12-06 10:08:52 +10:00
Abdo
95af26a056 Do not add a fallback field reference if front side contains conditionals (#2859) 
* Do not add a fallback field ref if front contains conditionals

* Ensure field reference when there are only conditionals
 2023-12-06 10:06:28 +10:00
Jarrett Ye
c54ae4bee1 skip revlog with time = 0 when calc recall cost (#2870) 
* skip revlog with time = 0 when calc recall cost

* Update retention.rs
 2023-12-05 13:08:34 +10:00
Damien Elmes
7d8ca4f86d Catch NaNs in FSRS weights 
Users pasting in weights from the old scheduler were leaving the outer
square brackets in, causing the first and last numbers to be parsed as
NaN.
 2023-12-04 16:19:22 +10:00
Shawn M Moore
996216c736 Remember endpoint we authenticated against in returned SyncAuth (#2864) 
* Include endpoint we authed against in response

* Add self to contributors
 2023-12-04 15:05:29 +10:00