Damien Elmes
605ad1c9ee
remove unnecessary setMod() calls
2021-03-10 11:47:53 +10:00
Damien Elmes
57d7e3e2ab
commit immediately when there's no active checkpoint
...
Reviews and operations on the backend that support undoing can now be
committed immediately, so they will not be lost in the event of a crash.
This required tweaks to a few places:
- don't set collection mtime on save() unless changes were made in
Python, as otherwise we end up accidentally clearing the backend undo
queue
- autosave() is now run on every reset()
- garbage collection now runs in a timer, instead of relying on
autosave() to be run periodically
2021-03-10 11:47:53 +10:00
Damien Elmes
40aff4447a
undo support for note adding
2021-03-10 11:47:53 +10:00
Damien Elmes
105ce94dd4
undo unbury/unsuspend
2021-03-10 11:47:53 +10:00
Damien Elmes
41779c1aad
implement bury/suspend undo
2021-03-10 11:47:53 +10:00
Damien Elmes
b466f0ce90
rework undo
...
- use dataclasses for the review/checkpoint undo cases, instead of the
nasty ad-hoc list structure
- expose backend review undo to Python, and hook it into GUI
- redo is not currently exposed on the GUI, and the backend can only
cope with reviews done by the new scheduler at the moment
- the initial undo prototype code was bumping mtime/usn on undo, but
that was not ideal, as it was breaking the queue handling which expected
the mtime to match. The original rationale for bumping mtime/usn was
to avoid problems with syncing, but various operations like removing
a revlog can't be synced anyway - so we just need to ensure we clear the
undo queue prior to syncing
2021-03-10 11:47:53 +10:00
Damien Elmes
b9c4b2bdbe
Merge pull request #1046 from hgiesel/sticky
...
Sticky icons in the editor window
2021-03-10 11:43:51 +10:00
Damien Elmes
1e7405296f
Merge pull request #1050 from BlueGreenMagick/choose-addon-to-update
...
Choose addon to update
2021-03-10 11:41:50 +10:00
RumovZ
9a844591fe
Ensure mouse is at current index before searching
...
Thus, no search will be triggered when clicking an expansion indicator
as this doesn't update the current element. However, if the indicator
belongs to the current item, a search will be triggered anyway.
2021-03-09 20:36:15 +01:00
RumovZ
a9ea7e39ae
Disable expand on double click in search mode
2021-03-09 20:18:12 +01:00
bluegreenmagick
4cde93ed74
don't show routine update when not update_enabled
2021-03-09 22:27:28 +09:00
bluegreenmagick
29076ec9ec
add context menu to open ankiweb page
2021-03-09 22:19:03 +09:00
bluegreenmagick
c11feda0eb
add bool_to_check and checked method
2021-03-09 22:19:03 +09:00
bluegreenmagick
01d8dc20f1
fix check issues in ChooseAddonsToUpdateList
2021-03-09 22:19:03 +09:00
bluegreenmagick
e73e0bec34
save chooseaddonupdate check state
2021-03-09 22:19:03 +09:00
Henrik Giesel
e03bfd2923
Refactor bridgeCommand and silence false "uncaught msg" log
2021-03-09 13:43:11 +01:00
Henrik Giesel
cd26901f3d
Make sure topleft buttons are rounded too, prefer Bootstrap's rounded class
2021-03-09 13:43:11 +01:00
Henrik Giesel
6fbd82f2f8
Change signature of editor onBridgeCmd to Any instead of None
2021-03-09 13:43:11 +01:00
Henrik Giesel
da0317cb85
Replace pin icon with lock icon
...
Credit goes out to @kleinerpirat
2021-03-09 13:43:11 +01:00
Henrik Giesel
ebf423bc9c
Remove Change Tracker again
2021-03-09 13:43:11 +01:00
Henrik Giesel
8593ab3c4c
Connect icons to sticky fields values
2021-03-09 13:37:56 +01:00
Henrik Giesel
d13bd1096d
Remove explicit popperjs again, because it's included in bootstrap.bundle
2021-03-09 13:37:56 +01:00
Henrik Giesel
31cba30873
Include the bootstrap icons in the editor view
2021-03-09 13:37:56 +01:00
Henrik Giesel
a66b0fbd84
Fix positioning of buttons
2021-03-09 13:37:56 +01:00
Henrik Giesel
f2cc85a3bc
Include bootstrap in editor
2021-03-09 13:37:56 +01:00
Henrik Giesel
aeda64a890
Add bootstrap, bootstrap-icons, and popperjs
2021-03-09 13:37:56 +01:00
RumovZ
3f772ce0fe
Add shortcuts for sidebar tools
2021-03-09 11:19:44 +01:00
RumovZ
28402c7015
Improve toolbar styling for macOS
2021-03-09 08:50:01 +01:00
RumovZ
08c09bcb0f
Remove edit mode
2021-03-08 11:55:15 +01:00
RumovZ
8d9072193c
Enable drag for all sidebar items ...
...
... and set valid drop targets dynamically based on the current
selection.
2021-03-08 11:35:39 +01:00
RumovZ
f07890c178
Ask before removing tags from collection
2021-03-07 11:40:11 +01:00
RumovZ
6c4d6457fb
Simplify multi deletion confirmation strings
2021-03-07 11:05:43 +01:00
RumovZ
f72daacae4
Only show edit actions with conform selection
2021-03-07 11:05:28 +01:00
RumovZ
23777eed67
Fix repainting in case of tree building exception
2021-03-07 09:47:17 +01:00
RumovZ
cce1b1f702
Remove context action dict
...
Now that almost all actions can be triggered from outside the context
menu and are available for more than one item type, it's easier to check
for available actions dynamically.
2021-03-05 12:22:49 +01:00
RumovZ
39dad049cd
Fix children check in context tree actions
2021-03-05 10:27:44 +01:00
Benjamin K
5d880f6e31
Clean up imports
2021-03-04 19:55:35 +01:00
Benjamin K
a066cee326
The old delimiter is now kept, when cancel button is clicked
2021-03-04 19:39:43 +01:00
RumovZ
513e7bdfb4
Enable deleting via delete key
2021-03-04 18:31:35 +01:00
RumovZ
1f500c1fb8
Enable Enter/Return search in all modes ...
...
... but don't trigger search if the key closes the editor.
Also get rid of the on_click of the saved searches root which has
already been removed on main.
2021-03-04 17:40:12 +01:00
RumovZ
4ab9e6caef
Ask for confirmation when overwriting saved search
2021-03-04 17:22:03 +01:00
RumovZ
6930ea24a9
Adjust sidebar tool icons to smaller size
2021-03-04 17:20:10 +01:00
RumovZ
5c6eea0d80
Make renamed item current (don't just select)
2021-03-03 23:00:37 +01:00
RumovZ
7d3d6edb26
Remove renaming dialogues from sidebar ...
...
... in favour of in-line editing. This is simpler and more ergonomic for
the user (and the programmer) but doesn't allow for editing parents
through text input (in the case of tags and decks).
2021-03-03 21:57:39 +01:00
RumovZ
bcc8a5ac3a
Enable renaming templates from the sidebar
2021-03-03 18:09:53 +01:00
RumovZ
aa4576dd42
Enable renaming notetypes
2021-03-03 15:18:50 +01:00
RumovZ
65a2796a0e
Enable group expanding/collapsing
...
Also, only show expand/collapse actions if they will have an effect.
2021-03-03 11:44:42 +01:00
RumovZ
61e61376a2
Make SidebarItem._is_extended a property
2021-03-03 11:43:31 +01:00
RumovZ
e2940de4a4
Escape backslashes in re.sub()'s repl
2021-03-03 09:20:02 +01:00
RumovZ
c0d77896da
Add DECK_CURRENT as a SidebarItemType
...
Thus, disable renaming, deleting etc. for the current deck item.
As a consequence, editable is no longer needed as a field of SidebarItem
as it can be derived from its type.
2021-03-03 09:15:36 +01:00
bluegreenmagick
69006b5872
add dialog to choose addons to update
2021-03-03 10:34:43 +09:00
RumovZ
adaea7227e
Select and scroll to renamed/added sidebar item
2021-03-02 23:13:34 +01:00
RumovZ
25d57574c9
Enable removal of multiple tags from the sidebar
2021-03-02 11:05:16 +01:00
RumovZ
e29bd4479b
Make clickable dyndeck labels fixed in size
2021-03-01 11:26:52 +01:00
RumovZ
f4aeb0c097
Enable deleting multiple saved searches
2021-03-01 09:41:41 +01:00
RumovZ
e199bf0b47
Fix repainting when renaming tag via dialogue
2021-03-01 08:45:33 +01:00
RumovZ
30e7d705b6
Enable extended selection in edit mode
2021-03-01 08:45:03 +01:00
Damien Elmes
e218604708
monospace font in html editor
...
https://forums.ankiweb.net/t/change-default-font-of-html-edit-mode-to-a-monospaced-font/7833
2021-03-01 10:16:12 +10:00
Damien Elmes
32af54cd4d
catch attempts to nest under a filtered deck; don't show traceback
2021-03-01 09:58:12 +10:00
Damien Elmes
5564fd9e13
Merge pull request #1040 from RumovZ/deck-name-err
...
Catch deck rename errors and localise warnings
2021-03-01 09:40:55 +10:00
RumovZ
e83f0fef0f
Fix Qt types
2021-02-28 22:36:31 +01:00
RumovZ
dc1711b630
Always return False from rename_node
...
setData expects a result but due to the asynchrony of the editor it
might not be known, yet.
2021-02-28 22:36:21 +01:00
RumovZ
1b8cebb8c5
Enable in-place editing of sidebar tags
2021-02-28 21:50:21 +01:00
RumovZ
d0b916a2ff
Enable in-place editing of saved searches
2021-02-28 21:13:26 +01:00
RumovZ
0b83828508
Enable in-place editing of sidebar deck items
2021-02-28 21:03:19 +01:00
RumovZ
88c69665f3
Add support for multi deck deletion in python
2021-02-26 19:52:34 +01:00
RumovZ
2c25645975
Place sidebar tools right of search bar
2021-02-26 13:04:30 +01:00
RumovZ
92cbf168f6
Catch DeckIsFilteredError directly on frontend
2021-02-26 11:32:40 +01:00
Damien Elmes
b8acf11f3e
remove left-click on saved searches
...
Multiple users have thought it was a bug rather than an intentional
feature, and it breaks double-clicking:
https://forums.ankiweb.net/t/anki-2-1-41-beta/7305/51
2021-02-26 18:48:32 +10:00
Damien Elmes
d666b7e5b0
fix browser appearance defaults
...
https://forums.ankiweb.net/t/small-bug-in-the-browser-appearance-window/7806
2021-02-26 18:46:09 +10:00
Damien Elmes
bfd452c120
Merge pull request #1039 from RumovZ/dyndeck-hint
...
Clickable hint in dyndeck dialogue for unmovable cards
2021-02-26 18:02:51 +10:00
RumovZ
f5981e94bf
Add group search context action
2021-02-25 21:24:11 +01:00
RumovZ
172133299b
Handle search on event level
...
Instead of assigning each sidebar item a lambda, add a field for search
representation and handle searching in event handler.
2021-02-25 19:57:12 +01:00
RumovZ
47e1e62967
Make search first (default) mode
2021-02-25 19:28:29 +01:00
RumovZ
4a1e995934
Add edit mode in sidebar
2021-02-25 13:12:51 +01:00
RumovZ
0889972bb0
Save last sidebar tool
2021-02-25 12:20:54 +01:00
RumovZ
fd784adc31
Add select and search modes to sidebar
2021-02-25 11:06:59 +01:00
RumovZ
17afcb094f
Add toolbar to sidebar
2021-02-25 11:05:04 +01:00
RumovZ
9d3da3b844
Add icons for sidebar tools
2021-02-25 11:02:17 +01:00
bluegreenmagick
c7d8700054
StudyDeck without add button
2021-02-25 07:34:01 +09:00
RumovZ
1dca43f409
Fix #1024 – catch deck rename errors
2021-02-24 13:59:38 +01:00
RumovZ
8e43b29816
Localise RenameDeckError
2021-02-24 13:57:44 +01:00
RumovZ
e95c2fa6ce
Fix type hints in dyndeckconf
2021-02-24 11:24:27 +01:00
RumovZ
234ca4d496
Refactor dyndeckconf/on_hint_button
2021-02-24 11:14:33 +01:00
RumovZ
d6b1c0cf3a
Give dyndeck hint unique styling
2021-02-23 23:34:05 +01:00
RumovZ
ae88f7e593
Add clickable hint to dyndeckconf
2021-02-23 23:14:11 +01:00
RumovZ
5a37b8e2af
Add direct col reference to dyndeckconf
2021-02-23 22:31:04 +01:00
Henrik Giesel
8aa8174d4b
Fix scrollbar issue in anki-editable component in two ways
...
- using :host-context(.nightMode) allows for applying the nightmode
scroll bar inside the component
- apply max-width: 100% to all element within editable, not just images
2021-02-23 15:52:20 +01:00
Damien Elmes
f41ec183c2
Merge pull request #1034 from abdnh/clayout-cloze-shortcuts
...
Shortcuts to preview clozes in card layout screen
2021-02-22 10:07:16 +10:00
abdo
39f3b6ce93
Shortcuts to preview clozes in card layout screen
...
Assign Alt+{number} to select cloze cards.
2021-02-21 14:46:53 +03:00
Damien Elmes
13f5ee1ddc
tweak update message
...
- Since we need to show this to new users until AnkiDroid is updated,
use a wording that doesn't seem so out of place to new users.
- Avoid mentioning syncing, since the user may not sync, and the
modSchema() call will allow the user to confirm anyway.
- Let the user know they can change their mind about AnkiDroid by
visiting the preferences.
2021-02-21 19:47:26 +10:00
Damien Elmes
5ae66af5d2
rework v2 scheduler upgrade; drop downgrade
...
- Rework V2 upgrade so that it no longer resets cards in learning,
or empties filtered decks.
- V1 users will receive a message at the top of the deck list
encouraging them to upgrade, and they can upgrade directly from that
screen.
- The setting in the preferences screen has been removed, so users
will need to use an older Anki version if they wish to switch back to
V1.
- Prevent V2 exports with scheduling from being importable into a V1
collection - the code was previously allowing this when it shouldn't
have been.
- New collections still default to v1 at the moment.
Also add helper to get map of decks and deck configs, as there were
a few places in the codebase where that was required.
2021-02-21 15:50:41 +10:00
bluegreenmagick
d6eac551b1
change _on_click_current to _on_click_index
...
fix bug where clicking on a blank space below sidebar item
would still trigger currentIndex item's click event
2021-02-20 22:58:02 +09:00
Damien Elmes
2941503bea
tweak getFile() arguments in editor to be more readable
2021-02-19 10:18:40 +10:00
Damien Elmes
654f4d65f7
disable card shifting in reposition by default
...
https://forums.ankiweb.net/t/uncheck-shift-position-of-existing-cards-by-default/7550
2021-02-19 10:09:01 +10:00
Damien Elmes
ab1e59a04d
use add-on id if name is blank
...
https://forums.ankiweb.net/t/support-for-rtl-layout-in-ankiweb-add-on-page/7522
2021-02-16 11:12:05 +10:00
Henrik Giesel
adb002f05f
Remove unused imports
2021-02-12 02:16:05 +01:00
Henrik Giesel
87febe489e
Allow for passing in custom note type and template
2021-02-12 02:12:03 +01:00
Henrik Giesel
270cef63f4
Allow for passing in custom note types for rendering ephemeral cards
2021-02-12 01:53:03 +01:00
Damien Elmes
6e9dfefb24
Revert "Use new note.ephemeral_card method in clayout"
...
This partially reverts commit 2483ef4517 .
2021-02-12 10:05:46 +10:00