GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-16 07:19:01 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions
9218 commits 11 branches 166 tags 122 MiB
Commit graph

9218 commits

This branch
This branch
All branches
Author SHA1 Message Date
RumovZ
0d68e1d59c Add tooltips for some browser columns 2021-09-30 13:15:09 +02:00
Damien Elmes
c7f4d30e7f fix uncaught error when int over 64 bits passed into db_command() 2021-09-30 16:46:33 +10:00
blue-putty
2d64c89c51 Typo correction 
test changed to tense
 2021-09-29 20:59:57 -04:00
Damien Elmes
7ce0b944bd update svelte-check 
Invoking from scripts/svelte-check is currently broken due to sass
imports - it appears to have been broken some time back.
 2021-09-29 12:27:27 +10:00
Damien Elmes
899d0556e8 handle changed aria-expanded typing 2021-09-29 12:20:27 +10:00
Damien Elmes
6db52323dd make 'for' argument optional in TooltipLabel 
The latest svelte-check has revealed we were not passing 'for' in
when we should have been. This is a quick hack to get the tests passing
again, but a better approach that actually makes this accessible again
would be good in the future.
 2021-09-29 12:20:03 +10:00
Damien Elmes
9b994ac537 silence execCommand deprecation warnings for now 2021-09-29 11:36:37 +10:00
RumovZ
2fca3de03e Remove redundant call to len_columns() 2021-09-28 12:11:20 +02:00
RumovZ
7c376e0172 Tweak comment 
Co-authored-by: Damien Elmes <dae@users.noreply.github.com>
 2021-09-28 11:48:35 +02:00
RumovZ
6be0de0310 Speed up to_row_of_unselected_note() 
Skip rows between selected rows and return fetched note ids.
 2021-09-28 11:47:13 +02:00
RumovZ
17ece47beb Cache selectionModel().selectedRows() 2021-09-28 11:45:22 +02:00
RumovZ
014220959a Calculate len_selection depending on modifiers 
If no modifiers are pressed, a single row has probably been clicked and
`selectedRows()` is fast, while a lot of rows might have been deselcted.
 2021-09-28 10:22:20 +02:00
RumovZ
4245a6bbc3 Prefer selectionModel().reset() over .clear() 
The latter triggers `selectionChanged()` unreliably, probably due to the
aggregation of chronologically close events, causing problems in
tracking `_len_selection`. `reset()` never emits signals.
 2021-09-28 10:19:33 +02:00
abdo
4d3f2c0232 Strip isolation chars from filenames in Check Media screen 2021-09-27 22:15:37 +03:00
Damien Elmes
b1e7a25623 Revert "Revert "Merge pull request #1364 from evandroforks/fix_unclosed_python_file"" 
This reverts commit a2ac197fd7.

Looks like it wasn't the cause of the previously reported problem:

https://forums.ankiweb.net/t/2-1-48-tts-problem/13587/2
 2021-09-27 18:43:16 +10:00
Damien Elmes
04a620ff1a Merge pull request #1382 from RumovZ/tags-from-sidebar 
Tags from sidebar
 2021-09-27 18:41:32 +10:00
Damien Elmes
c3c51af7a9 Merge pull request #1388 from lolilolicon/patch-1 
Quote $PREFIX properly for paths with spaces
 2021-09-27 18:39:25 +10:00
Damien Elmes
da1f890115 Merge pull request #1391 from sobjornstad/change_note_type_hook 
Add hook for selecting a new note type in the add window
 2021-09-27 18:38:40 +10:00
RumovZ
94eafcf831 Calculate number of selected rows manually 
`len(self._view.selectionModel().selectedRows())` is slow for large
selections, because Qt queries flags() for every selected cell, so we
calculate the number of selected rows ourselves.
 2021-09-27 10:15:53 +02:00
RumovZ
8daecb94e5 Switch to new row before deleting notes 
The table now properly deselects deleted rows, but that takes effort and
it's more convenient to have a selected row after deleting.
 2021-09-25 17:28:38 +02:00
RumovZ
c0616fe820 Handle deleted or restored rows 
- Cache the result of 'table.len_selection()'
- Update this cache manually when a row was deleted or restored
- Emit 'dataChanged()' after such a change to fix flags not updating
correctly to the shortcut in 'model.flags()'
- Remove/retsore focus if the current element was deleted/restored
 2021-09-25 17:16:53 +02:00
RumovZ
053bbe8f01 Only check flags of cached rows 
Speeds up the selection process (esp. Ctrl+A) by avoiding to fetch rows.

Co-authored-by: BlueGreenMagick <BlueGreenMagick@users.noreply.github.com>
 2021-09-25 15:32:22 +02:00
RumovZ
0a95d69735 Add callbacks to row fetching routine 
Called when a row is detected that has been deleted or restored.
 2021-09-25 15:27:19 +02:00
RumovZ
a77c65006f Check 'index.isValid()' in 'table.model' 2021-09-25 15:21:06 +02:00
Soren Bjornstad
834118ce8a Add hook after selecting a new note type in the add window 2021-09-24 21:54:33 -05:00
Damien Elmes
5d0736ab96 update svelte2tsx 
We can now use the typings from the Svelte library instead of the
svelte2tsx shims
 2021-09-25 11:07:31 +10:00
lolilolicon
739d3d3cb5 Update CONTRIBUTORS 2021-09-24 13:46:01 +00:00
lolilolicon
1120e6d644 Quote $PREFIX properly for paths with spaces 2021-09-23 01:24:52 +00:00
lolilolicon
ad9497aaf7 Quote $PREFIX properly for paths with spaces 2021-09-23 01:20:53 +00:00
Damien Elmes
8f7e7498da update to TypeScript 4.4.x 2021-09-23 09:53:37 +10:00
Damien Elmes
81104f47f4 fixes for TypeScript 4.4.x 
closes #1386
 2021-09-23 09:52:21 +10:00
RumovZ
b42379bf96 Apply suggestions from code review 
Capitalise "selected"

Co-authored-by: Damien Elmes <dae@users.noreply.github.com>
 2021-09-22 16:59:05 +02:00
Damien Elmes
df26c61164 update ts deps 
typescript and bootstrap have been pinned for now:

https://github.com/ankitects/anki/issues/1386
https://github.com/ankitects/anki/issues/1385

hint failures for svelte-check have also been temporarily turned
off, due to it now complaining about document.execCommand():

Hint: The signature '(commandId: string, showUI?: boolean, value?: string): boolean' of 'document.execCommand' is deprecated. (ts)
    const wrapWithForecolor = (color: string) => () => {
        document.execCommand("forecolor", false, color);
    };

Will follow up in #1377
 2021-09-22 23:21:39 +10:00
Damien Elmes
2bd8704554 add SECURITY.md 2021-09-22 22:55:19 +10:00
Damien Elmes
6f8fddffd6 Merge pull request #1384 from hikaru-y/fix-previewer-memory-leak 
Fix memory leak in previewer
 2021-09-22 21:45:14 +10:00
hikaru-y
6e196e43fd Fix memory leak in previewer 
Related thread:
https://forums.ankiweb.net/t/high-memory-usage-over-time-on-2-1-44/13544/
 2021-09-22 17:21:08 +09:00
RumovZ
dcb7d44ce4 Enable adding/removing tags from the sidebar ... 
... to selected notes.
 2021-09-21 11:48:43 +02:00
Damien Elmes
016443cc88 Merge pull request #1376 from hgiesel/mathjaxcleanupv2 
Mathjax Cleanup
 2021-09-21 18:39:27 +10:00
Damien Elmes
54ec174453 Merge pull request #1375 from RumovZ/disable-actions 
Disable unusable browser actions on row change
 2021-09-21 18:38:30 +10:00
Damien Elmes
2b1ba8f039 bump version 2021-09-21 16:30:15 +10:00
Damien Elmes
888f02a0f6 Merge pull request #1379 from BlueGreenMagick/dont-fill-empty-on-add-cards 
set CardLayout fill_empty=False for add cards editor
 2021-09-21 15:08:54 +10:00
Damien Elmes
2695cb64ff add hidden option to disable tooltips in browse screen 
https://forums.ankiweb.net/t/browser-text-pop-up-when-hovering-over-card-poll/13254
 2021-09-21 15:03:37 +10:00
Damien Elmes
916ff49efe temporary fix for error on deleting (#1374) 2021-09-20 22:02:44 +10:00
Damien Elmes
8dde10e83a add startup message about forcing Wayland 2021-09-20 21:42:16 +10:00
Damien Elmes
c0abcdf647 Revert "Merge pull request #1364 from evandroforks/fix_unclosed_python_file" 
This reverts commit c05475a49e.

Revert "possible fix for reported audio issues"

This reverts commit e53192a079.

Reverting in case https://forums.ankiweb.net/t/2-1-48-release-candidate/13268/10
is related to this change. If the issue persists, we'll know this was
not the cause.
 2021-09-20 21:39:15 +10:00
bluegreenmagick
1a9e0ec1a0 set CardLayout fill_empty=False for add cards editor 
Card layout view functions as a previewer in add cards dialog
so displaying accurately is more important than having placeholders.
Especially for card layouts using conditional-not fields {{^Field}}
card layout is rendered badly.
 2021-09-20 18:34:49 +09:00
RumovZ
64fd90d633 Simplify sidebar context menu separators 
Qt can collapse consecutive menu separators, so no need to check if a
subroutine has actually added any actions to the menu.
 2021-09-19 18:33:36 +02:00
Henrik Giesel
66608b06b0 Allow for explicit any 2021-09-17 21:30:32 +02:00
Henrik Giesel
16b6d95593 Make HandleSelection perfectly size when first activating 2021-09-17 21:23:04 +02:00
Henrik Giesel
1e2fa82446 Fix missizing of HandleSelection when first moving from empty to Mathjax 2021-09-17 20:54:37 +02:00