Commit graph

394 commits

Author SHA1 Message Date
Henrik Giesel
4dd565065f Move caretToEnd logic out of focus handling 2021-03-08 20:40:23 +01:00
Henrik Giesel
eff90085ea Improve focus handling
* Ported from #1046:

* disabling buttons will clear button highlight
* enabling button will set button highlight
* move caret to end executed before enabling buttons (so button highlight will be for actual position of caret)
* move caret to end will also be executed if previousActiveElement is null, which will only be the case before the first onBlur was executed:
  * so that caret will be moved to end on opening editor
2021-03-08 14:20:06 +01:00
abdo
5af6a63e20 Fix editor RTL check 2021-03-07 18:12:42 +03:00
Henrik Giesel
41c3c3ecf3 Do not execute caretToEnd when Alt-tabbing back to application 2021-03-06 17:57:04 +01:00
Henrik Giesel
e87d951a74 Fix focus handling when coming from top left buttons 2021-03-01 12:28:45 +01:00
Damien Elmes
7c03d184de Merge pull request #1038 from hgiesel/imgmaxwidth
Fix scrollbar issue in anki-editable component in two ways
2021-02-24 10:16:12 +10:00
Damien Elmes
735253dd43 Merge pull request #1037 from hgiesel/browserbug2
Remove logic for pulling editor field into view
2021-02-24 09:53:11 +10:00
Henrik Giesel
e2bda7273e Fix scrollbar issue in anki-editable component in two ways
- using :host-context(.nightMode) allows for applying the nightmode
  scroll bar inside the component
- apply max-width: 100% to all element within editable, not just images
2021-02-23 15:52:20 +01:00
Henrik Giesel
561dbbb718 Satisfy formatter 2021-02-23 13:34:41 +01:00
Henrik Giesel
eed8fb06c6 Remove logic for pulling editor field in view 2021-02-23 12:55:04 +01:00
Henrik Giesel
49e408e64d Satisfy formatter 2021-02-22 14:44:31 +01:00
Henrik Giesel
5c332e20ab Load graphs.js from head
* Also move script into body, to be a valid HTML document
2021-02-22 14:17:56 +01:00
Henrik Giesel
042d9095ea Move tooltip creation into function 2021-02-22 14:10:35 +01:00
Henrik Giesel
7c31e7f09d Increase the padding in the editable to 6px 2021-02-16 18:40:58 +01:00
Henrik Giesel
70e09bf70a Add max-width: 100% to editable.scss 2021-02-16 18:28:40 +01:00
Damien Elmes
e7a0f22ebf ignore manually scheduled cards in hour graph 2021-02-10 09:36:51 +10:00
Damien Elmes
83e2538f8e tweak sidebar appearance
- draw a border between sidebar and main area
- tweak padding

Testing is a pain, because you need to check day mode on the
three platforms, and night mode as well. If you can do it better, PRs
are welcome :-)
2021-02-09 16:23:44 +10:00
Damien Elmes
51ea2a14e8 add missing license headers 2021-02-09 13:38:04 +10:00
Henrik Giesel
c521ac1e94 Rework focusing code to fix two issues:
1. Clicking away from the editor window, and back on it should not focus old field
2. Clicking on a field, which is not fully visible, should scroll it into view
2021-02-09 01:09:16 +01:00
Henrik Giesel
f72bcc679d Use mouseup intead of click for updateButtonState 2021-02-08 22:18:06 +01:00
Henrik Giesel
572aae1ae8 Refactor wrap code 2021-02-08 22:13:49 +01:00
Henrik Giesel
94ca6c0ffe Give toolbar items a bottom margin to separate the rows when they wrap 2021-02-08 21:26:37 +01:00
Henrik Giesel
22e098f5c9 Put wrapping code into its own file 2021-02-08 21:02:46 +01:00
Henrik Giesel
c721e2fa2f updateButtonState on clicking editor field 2021-02-08 20:49:33 +01:00
Henrik Giesel
de3b120031 Export saveNow 2021-02-08 20:28:02 +01:00
Henrik Giesel
3c9f3e7baa Split up index.ts into several more files
This is to provide minimal closures for the mutable file-local variables:
- changeTimer
- previousActiveElement
- currentNoteId

This makes it clear, that they should not be used, but rather the
functions which wrap them in an API
2021-02-08 19:48:42 +01:00
Henrik Giesel
3287f61b75 Avoid making currentField a global 2021-02-08 17:00:27 +01:00
Henrik Giesel
d509bf6d3c Export current field for editor 2021-02-08 15:44:56 +01:00
Damien Elmes
2edd992020 render deck description with markdown; strip images
To support images on that screen, we'll first need to adjust the base url
for each platform, or rewrite the local image URLs, as otherwise they
are resolved to _anki/pages/...
2021-02-06 15:02:40 +10:00
Damien Elmes
33e532166a Revert "sanitize deck description HTML with html-sanitize"
This reverts commit cd37a9ae83.
2021-02-06 13:25:40 +10:00
Damien Elmes
cd37a9ae83 sanitize deck description HTML with html-sanitize
Committing for reference; will roll back afterwards.

This adds approximately 150k to the bundled .js file in release mode.
html-sanitizer might be useful to replace our custom paste filtering
code in the future, but for now I'm not sure it's worth the extra
page load time over doing the filtering in Rust.
2021-02-06 13:25:34 +10:00
Damien Elmes
12d5bc217d show deck description on congrats screen 2021-02-06 13:20:06 +10:00
Damien Elmes
30c108fc91 Merge pull request #1006 from hgiesel/deadeditor
Remove some dead editor code
2021-02-06 09:02:35 +10:00
Damien Elmes
63ea689636 Restore "Merge pull request #1007 from hgiesel/sveltesass2""
This reverts commit 86b470071f and
points to a new rules_svelte commit.

It looks like we were getting away with not listing the dep on the
rules_svelte end - the failing build turned out to be because we need
to pass sass in to our local svelte_check invocation.
2021-02-06 08:39:36 +10:00
Damien Elmes
86b470071f Revert "Merge pull request #1007 from hgiesel/sveltesass2"
Roll back to investigate issues.

This reverts commit 58a58d94be, reversing
changes made to 31d06e8f39.
2021-02-06 08:20:10 +10:00
Henrik Giesel
9449dabf9a Use lang="scss" in CardCounts 2021-02-05 14:52:25 +01:00
Henrik Giesel
c554d4ac28 Remove usage of window.event in onPaste 2021-02-05 13:42:49 +01:00
Henrik Giesel
e9f8ba14f9 Remove dead code kept for compatibility 2021-02-05 13:41:35 +01:00
Damien Elmes
6c3d107d30 Merge pull request #1004 from hgiesel/graphsfix
Update setFirstWeekday with new .on() type signature
2021-02-05 20:05:17 +10:00
Damien Elmes
b6e873b17b move remaining Filter button items into sidebar
- Closes #976
- Added helper to apply arbitrary colour to an icon.
- Fix #979 - low res icons in night mode.
- The icons and colours are not perfect - please feel free to send
through a PR if you can improve them.
- Convert colors dictionary into module consts, so we can
use code completion.
- Added "Edited Today" and "Due Tomorrow"
- Rename camelCase attribute to snake_case and tweak the wording
of some enum constants. We've already broken compatibility with the
major sidebar add-ons, so we may as well make these changes while we
can.
- Removed Filter button. Currently there is no exposed way to toggle
the Sidebar off - wonder if we still need it?
2021-02-05 18:58:22 +10:00
Henrik Giesel
77c18c856d Update setFirstWeekday with new .on() type signature 2021-02-04 14:25:51 +01:00
Damien Elmes
67accf7829 avoid wrapping card count text on small screens 2021-02-03 21:08:07 +10:00
Damien Elmes
9f14240b51 update JS deps 2021-02-03 20:38:41 +10:00
Henrik Giesel
b6cfccda67 Move copy_page to ts/copy.bzl and rename to copy_files_into_group 2021-02-02 18:20:11 +01:00
Henrik Giesel
72259ed629 Export getEditorField and forEditorField 2021-01-31 20:56:28 +01:00
Henrik Giesel
8699c25bc5 Turn off eslint check for now 2021-01-31 20:55:36 +01:00
Henrik Giesel
9f3403d704 Move editor css to editor directory 2021-01-31 19:03:40 +01:00
Henrik Giesel
978258067b Move editor to /ts/editor 2021-01-31 14:15:03 +01:00
Damien Elmes
dce6682086 Merge pull request #963 from hgiesel/ease130
Coerce ease graph min to 130 if applicable
2021-01-31 09:22:01 +10:00
Henrik Giesel
9a8dbbc275 Coerce ease graph to 130 if applicable 2021-01-30 22:09:00 +01:00
Henrik Giesel
2ff9e29a15 Fix ease graph building wrong query omitting ease edge cases
E.g. search for "prop:ease>=2.5" AND "prop:ease<2.55" instead of
                "prop:ease>=2.5" AND "prop:ease<2.54"
2021-01-30 13:19:27 +01:00
Henrik Giesel
587f6dc96f Fix histogram-graph building invalid query 2021-01-30 02:46:26 +01:00
Henrik Giesel
0168736ad8 Fix graphs tooltip position 2021-01-30 02:35:48 +01:00
Henrik Giesel
8151156b98 Install types for lodash.throttle 2021-01-30 02:12:44 +01:00
Henrik Giesel
993cca1902 Make histogram show bars again 2021-01-30 02:08:01 +01:00
Henrik Giesel
dc62e56aef Remove modular d3 imports for imports from d3 bundle 2021-01-30 01:13:47 +01:00
Henrik Giesel
0af6d559a8 Remove d3 libraries from BUILD.bazel 2021-01-30 00:04:44 +01:00
Henrik Giesel
0527beec98 Replace individual d3 libraries with encompassing d3 2021-01-30 00:00:22 +01:00
Damien Elmes
45ec14184a show actual error when graphData fails
The original reason for the catch-all message was users with bad
data such as decimal intervals, but those get automatically coerced
these days. The common case should now be invalid search strings, which
we can show verbatim.
2021-01-29 14:39:05 +10:00
Damien Elmes
4958fb30c9 Merge pull request #946 from hgiesel/dispatchtype
Correctly type createEventDispatch and dispatch
2021-01-27 20:27:08 +10:00
Damien Elmes
ad188b1ecf Merge pull request #947 from hgiesel/noclickonemptybins
No clicking on empty bins in the Histogram
2021-01-27 19:45:07 +10:00
Henrik Giesel
e30f62c2a5 Add FutureDueShowBacklog as preferences 2021-01-27 01:15:19 +01:00
Henrik Giesel
f88aad8d85 No clicking on empty bins in the Histogram 2021-01-26 13:48:36 +01:00
Henrik Giesel
e204ddc0d4 Type createEventDispatcher and dispatch 2021-01-26 12:47:17 +01:00
Henrik Giesel
45ff094392 Add bridgeCommand helper function 2021-01-26 01:25:54 +01:00
Henrik Giesel
cf7bc58163 Use browserLinksSupported preference 2021-01-25 19:12:32 +01:00
Henrik Giesel
6b0a26e46b Move dispatch logic from Histogram to individual graphs 2021-01-25 16:34:44 +01:00
Henrik Giesel
ad5f0e721f Make calendar only clickable, if counts > 0 2021-01-25 13:47:20 +01:00
Henrik Giesel
11901e0e57 Add search functionality to Calendar view 2021-01-25 13:47:18 +01:00
Henrik Giesel
a26ffd9876 Add search functionality for ease graph 2021-01-25 13:46:44 +01:00
Henrik Giesel
ee5ba4e8d2 Normalize the remaining queries 2021-01-25 13:46:44 +01:00
Henrik Giesel
3c5493d424 Fix up histogram code to correctly hide tooltip again 2021-01-25 13:46:44 +01:00
Henrik Giesel
a9ccfa62a4 Normalize intervals query 2021-01-25 13:46:44 +01:00
Henrik Giesel
b8dbed44c7 Add query functionality to FutureDue graph 2021-01-25 13:46:44 +01:00
Henrik Giesel
bdacc42af3 Remove onlyReview from intervals query 2021-01-25 13:46:44 +01:00
Henrik Giesel
f3eae60773 Add search functional on interval graph 2021-01-25 13:46:44 +01:00
Henrik Giesel
31203e6d35 Add search to added graph 2021-01-25 13:46:44 +01:00
Henrik Giesel
13325e050c Export bridgeCommandsSupported from graphs.rs for stats 2021-01-25 13:46:44 +01:00
Henrik Giesel
76691176f6 Add a working example of searching from the stats screen in the Card Counts 2021-01-25 13:46:42 +01:00
Henrik Giesel
cee2f396da Add search event listeners on graphs 2021-01-25 13:45:42 +01:00
Henrik Giesel
f8c590c914 Fix RangeBox RevlogRange defaulting to All instead of Year 2021-01-23 13:57:43 +01:00
Damien Elmes
a6a4c0032d Merge pull request #934 from hgiesel/graphprefs
Add GraphsPreferences API to graphs for setting persistent preferences
2021-01-23 21:24:41 +10:00
Damien Elmes
387be76c00 minor wording tweak: GraphsPreferences -> GraphPreferences 2021-01-23 20:47:45 +10:00
Damien Elmes
fe739f4460 fix graphs failing to load until preferences set
The protobuf object will be missing keys that have the default value,
so we need to fill the defaults in.
2021-01-23 20:40:43 +10:00
Henrik Giesel
4e9fff493f Use scaleSqrt for calendar review values 2021-01-22 22:39:29 +01:00
Henrik Giesel
a5f59515e2 Rename GraphsPreferencesOut to simply GraphsPreferences 2021-01-22 19:39:03 +01:00
Henrik Giesel
0098869925 Make code typecheck, fix issue with day labels in nightMode 2021-01-22 19:02:05 +01:00
Henrik Giesel
7149c468e5 Set calendar labels to emptyColour 2021-01-22 18:15:16 +01:00
Henrik Giesel
24dd14896a Make cardCountsSeparateInactive settable 2021-01-22 18:03:58 +01:00
Henrik Giesel
101e193add Make first day of week settable through UI 2021-01-22 17:51:15 +01:00
Henrik Giesel
d6ba9eb61a Uniformly rename firstWeekday to firstDayOfWeek 2021-01-22 16:53:33 +01:00
Henrik Giesel
1a75772673 Remve SeparateInactiveCheckbox and correctly use preferences values
* Expose issue with non-existing calendar value in GraphPreferences
2021-01-22 14:56:41 +01:00
Henrik Giesel
fe75480fea Successfully send post request to rust 2021-01-22 14:37:24 +01:00
Henrik Giesel
846dd396a6 Add non-functioning logic for settings graphs preferences 2021-01-22 13:14:35 +01:00
Henrik Giesel
15bd2e74f8 Hook up cardCountsSeparateInactive to PreferenceStore 2021-01-22 13:14:35 +01:00
Henrik Giesel
5ee3e0d0d7 Add PreferenceStore with gettable/settable preferences
* setting is not yet hooked up to rslib
2021-01-22 13:14:33 +01:00
Henrik Giesel
1516f5c37e Add GraphsPreferences endpoint to backend 2021-01-22 13:13:48 +01:00
Henrik Giesel
e8169c5b54 Add first GraphPreferences which are not hooked to backend yet 2021-01-22 13:13:48 +01:00
Damien Elmes
574836fb7b Merge pull request #933 from hgiesel/calendardays
Add labels to calendar days
2021-01-22 11:52:44 +10:00
Henrik Giesel
e509b768ff Get weekday labels via Date.prototype.toLocaleString 2021-01-21 19:38:56 +01:00