GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-18 08:19:01 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions
5077 commits 12 branches 166 tags 134 MiB
Commit graph

153 commits

Author SHA1 Message Date
Damien Elmes
4d33b2d8f7 use qconnect everywhere, and fix some typing issues 
a step towards check_untyped_defs in aqt, but there's still 100+
issues to resolve
 2020-05-04 13:23:08 +10:00
Damien Elmes
5706cdfc2e fix saving searches in browser 2020-05-04 12:26:50 +10:00
BlueGreenMagick
b63b4fece1 use variable names 2020-04-26 15:47:19 +09:00
Damien Elmes
25789e14ef avoid adjusting position if selected row is visible 
https://anki.tenderapp.com/discussions/beta-testing/1868-anki-2124-beta#comment_48227037
 2020-04-11 15:54:52 +10:00
Damien Elmes
c3f149ab94 make sure preview window is closed when browser closed 2020-04-10 20:32:48 +10:00
Damien Elmes
6fa53fa734 fix preview closing 
https://anki.tenderapp.com/discussions/beta-testing/1868-anki-2124-beta#comment_48228480
 2020-04-08 16:21:20 +10:00
Arthur Milchior
d095b017e4 _basename to basename, since it's not private in use 2020-04-06 23:51:50 +02:00
Arthur Milchior
859178c113 _basename used where possible 2020-04-06 23:51:42 +02:00
Arthur Milchior
e6024d4d3d replace _path by path (because it's not private here) 2020-04-06 23:50:43 +02:00
Arthur Milchior
8962194dcb uses _path where possible 2020-04-06 23:50:37 +02:00
Damien Elmes
b5022ad354 store config in separate DB table 
- mtime is tracked on each key individually, which will allow
merging of config changes when syncing in the future
- added col.(get|set|remove)_config()
- in order to support existing code that was mutating returned
values (eg col.conf["something"]["another"] = 5), the returned list/dict
will be automatically wrapped so that when the value is dropped, it
will save the mutated item back to the DB if it's changed. Code that
is fetching lists/dicts from the config like so:

col.conf["foo"]["bar"] = baz
col.setMod()

will continue to work in most case, but should be gradually updated to:

conf = col.get_config("foo")
conf["bar"] = baz
col.set_config("foo", conf)
 2020-04-06 15:39:47 +10:00
Damien Elmes
ac54f85840 update tag handling 
- tag list stored in a separate DB table
- non-wildcard searches now do full unicode case folding
(eg tag:masse matches 'Maße')
- wildcard matches do simple unicode case folding
- some functions haven't been updated yet, so ascii folding will
continue to be used in some operations
 2020-04-03 19:34:46 +10:00
Damien Elmes
3f965f5534 use old name for preview dialog to avoid breaking add-ons 2020-04-03 09:00:18 +10:00
Damien Elmes
3959f7dcb8 render() conflicts with Qt method 2020-04-03 08:29:35 +10:00
Arthur Milchior
ef0cbb3a79 snake case 2020-04-02 17:44:06 +02:00
Arthur Milchior
2eed489792 Methods used by browser are not public 
As suggested by Glutanimate on https://github.com/ankitects/anki/pull/532#discussion_r401254100
 2020-04-02 17:44:06 +02:00
Arthur Milchior
d85c8288f6 remove the word preview from previewer variable 
As suggested by glutanimate https://github.com/ankitects/anki/pull/532#discussion_r401255290
 2020-04-02 17:44:06 +02:00
Arthur Milchior
7ce77e071d Class PreviewerBrowser 
This let a previewer class which can be used to display a single card,
and a previewer for the browser
 2020-04-02 17:44:06 +02:00
Arthur Milchior
7ea1ff840f move previewer to a different class. 
This uses exactly the same code, with one exception. In the previewer
`self` became `self.parent` in order to have action on the
browser. And in the browser, some `self` become `self.previewer` to
access the previewer. (Some function having an action on the previewer
starting from the browser now are separated in two. One version in the
previewer doing the same thing. One version in the browser, calling
the version in the previewer if it exists.)

Preview dialog now takes a QWidget in general, not necesarrily a
Browser. The parameter is called parent
 2020-04-02 17:44:06 +02:00
Damien Elmes
91c2e89360 ignore row change events that arrive after browser closed 
https://anki.tenderapp.com/discussions/ankidesktop/40148-bug-when-suspending-cards
 2020-04-02 19:44:51 +10:00
Damien Elmes
8d952570a8 left-align tags 
https://anki.tenderapp.com/discussions/ankidesktop/40068-tags-column-in-browser-is-centered
 2020-04-01 13:29:42 +10:00
Damien Elmes
78aad6b64b always position selection in center after search 
https://anki.tenderapp.com/discussions/beta-testing/1888-retaining-position-when-searching
 2020-04-01 11:01:20 +10:00
Arthur Milchior
015d07ec56 hook browser_header_will_show_context_menu 2020-03-27 23:06:22 +01:00
Hk-tang
f6d2c95888 Change not not to bool 2020-03-23 11:16:39 -06:00
Damien Elmes
28b0281972 allow customizing search order 2020-03-21 17:38:09 +10:00
Damien Elmes
6d7bf16b5a fix reversing sort order 2020-03-21 16:57:33 +10:00
Damien Elmes
eab7686d2f remove old finder code; add search hooks to browser & remove old one 2020-03-21 16:38:46 +10:00
Damien Elmes
67d1842691 enable sorting on the extra browser columns 2020-03-21 07:55:53 +10:00
Damien Elmes
cdb85ef72e disable word wrap in browser rows 2020-03-20 21:15:23 +10:00
Damien Elmes
f3296382ea ensure endReset() is called even if an exception is raised 2020-03-20 21:15:23 +10:00
Damien Elmes
c13056773b flush config on sort order change 2020-03-20 21:15:23 +10:00
Damien Elmes
a02c4ed994 drop the DB progress handler code 
This code was an awful hack to provide some semblance of UI
responsiveness while executing DB statements on the main thread.
Instead, we can just run DB statements in a background thread now,
keeping the UI responsive.
 2020-03-20 21:15:23 +10:00
Arthur Milchior
1993c0af70 Browser introduce method time_format 
I expect to use this in my add-on 1243668133 (by monkey patching in
this case) where it would allow to show hours/minutes/seconds... in browser
 2020-03-19 22:59:59 +01:00
Arthur Milchior
552c0cd8a8 adding missing constants in browser file 2020-03-17 06:32:46 +01:00
Damien Elmes
863e5f5e51 make sure audio queue is cleared when transitioning between cards 
https://anki.tenderapp.com/discussions/beta-testing/1846-anki-2122-beta#comment_48150139
 2020-03-14 20:04:40 +10:00
Damien Elmes
1161ac1962 fix play icons not appearing in browser preview when autoplay off 2020-03-14 19:29:11 +10:00
Glutanimate
fce24c6eea Type-annotate editor.card 2020-03-04 17:41:26 +01:00
Arthur Milchior
57efc22d99 browser_did_init 2020-03-01 11:39:41 +01:00
Damien Elmes
93c2e04267 FString -> TR 2020-02-27 12:25:19 +10:00
Damien Elmes
94ba217c25 formatting fixes 2020-02-25 17:56:46 +10:00
Damien Elmes
5ca00fc92d interrupt current audio when autoplay off 2020-02-25 17:49:06 +10:00
Damien Elmes
59328d9ade tweak rounding 
- avoid rounding minutes
- round the seconds taken in the card info screen
- provide different precise and imprecise modes, since we need
to display seconds to multiple decimals in some areas
 2020-02-25 17:29:06 +10:00
Damien Elmes
fa41f24bf6 fix display of 1+ day intervals in review history 
https://anki.tenderapp.com/discussions/ankidesktop/39189-interval-field-of-card-info-display-wrong-unit
 2020-02-25 17:00:02 +10:00
Damien Elmes
43dae5c90e Merge pull request #456 from Arthur-Milchior/noDefaultDeckInBrowser 
No default deck in browser
 2020-02-24 19:35:49 +10:00
Damien Elmes
70ae99778f remove old fmtTimeSpan() and associated strings 2020-02-23 18:47:16 +10:00
Damien Elmes
0d1a30c6d8 rework Fluent handling 
- all .ftl files for a language are concatenated into a single file
at build time
- all languages are included in the binary
- external ftl files placed in the ftl folder can override the
built-in definitions
- constants are automatically generated for each string key
- dropped the separate StringsGroup enum
 2020-02-23 13:22:50 +10:00
Arthur Milchior
adfbd0d70f should(default)deckbedisplayed in snake case 2020-02-22 04:08:01 -08:00
Arthur Milchior
6a50730f0d Remove options for all/allNames 
Instead, we always see default deck if it has a child
As indicated in https://github.com/ankitects/anki/pull/452
 2020-02-22 04:03:42 -08:00
Damien Elmes
8afaaf9c70 simplify interval display in review log 2020-02-21 15:29:38 +10:00
Damien Elmes
74bff450e2 add non-abbreviated timespan translation; update existing short=True calls 
- drop the '5m3s' special casing done in the card stats screen, and
just use decimals
- change alignment of the review log so that the non-abbreviated
spans are easier to read
 2020-02-21 15:29:38 +10:00
Damien Elmes
e98e85a0b8 Revert "Merge pull request #452 from Arthur-Milchior/noDefaultDeckInBrowser" 
This reverts commit 56d908cc28, reversing
changes made to c123b5bf95.

More discussion required on https://github.com/ankitects/anki/pull/452
 2020-02-21 12:27:39 +10:00
Arthur Milchior
59587f1bb2 no default in left-side browser 2020-02-19 02:42:04 -08:00
Arthur Milchior
541e586db1 Replace g[idx] by variable name 2020-02-19 02:41:57 -08:00
Arthur Milchior
aa1668ec96 remove default deck from filter list 2020-02-19 02:41:56 -08:00
Damien Elmes
5bb81a95c2 add 'new #' prefix to new cards in the due column 2020-02-18 11:16:15 +10:00
Damien Elmes
fdf297afa0 fix card info screen 2020-02-18 10:59:24 +10:00
Damien Elmes
08bb73b4d9 Merge pull request #450 from Arthur-Milchior/selectCardInBrowserFromReviewer 
Current card get selected in browser
 2020-02-18 08:27:34 +10:00
Arthur Milchior
3763d35149 Current card get selected in browser 
I'm pretty sure it was the way it worked before. I'm surprised that
it's not the case anymore.

If you open the browser from the reviewer, the current card get
selected if it exists. The current note is still entirely displayed.

Personally, I want to know easily which is the current card. Opening
the browser is the easiest way to do it; assuming I can see the
current card selected
 2020-02-17 04:10:47 -08:00
Damien Elmes
fd01cac4d7 split "Due" into three different contexts for translators 2020-02-17 14:41:01 +10:00
Damien Elmes
415cb15661 Merge pull request #447 from glutanimate/browser-sidebar-tree-hooks 
Add browser_will_build_tree filter
 2020-02-16 08:36:28 +10:00
Damien Elmes
f6bad7b9c3 Merge pull request #445 from glutanimate/new-html-view-hooks-2 
Allow add-on authors to easily inject their own content into Anki's web views – take 3
 2020-02-16 08:32:34 +10:00
Glutanimate
b7e0d4388a Add browser_will_build_tree filter 
Allows add-ons to populate the browser sidebar tree with their own
items, and/or take over specific construction stages in their
entirety
 2020-02-15 21:03:15 +01:00
Glutanimate
28a394a074 Assume that web assets without a specified subpath are under /_anki 
Maintains compatibility with existing add-ons
 2020-02-15 15:03:43 +01:00
Damien Elmes
3d1e89f014 Merge pull request #433 from Arthur-Milchior/ints 
Constants
 2020-02-14 08:37:31 +10:00
ijgnd
e39d18647f small fix: store return value for hook in preview 2020-02-13 18:51:11 +01:00
Glutanimate
ffdafaee6d Fix missing "Optional" import and lint 2020-02-12 22:15:44 +01:00
Glutanimate
7e213bdcd5 Pass CardInfoDialog context to stdHtml 2020-02-12 22:12:45 +01:00
Glutanimate
d7836e3af8 Add webview_will_set_content hook & update supporting code accordingly 2020-02-12 22:00:13 +01:00
Glutanimate
88b5d94513 Refactor web view title setting and add titles to all web views 
Simplifies debugging web views
 2020-02-12 21:03:11 +01:00
Damien Elmes
89f926f177 night mode fix for find dupes screen 2020-02-12 08:28:33 +10:00
Damien Elmes
e64b1e0ca2 provide easy access to browser from preview/dupes handlers 2020-02-12 08:28:21 +10:00
Damien Elmes
27dabaeaa6 tweak wording 2020-02-12 08:14:16 +10:00
Arthur Milchior
097e6d4b46 Adding export option in Browser 2020-02-11 10:50:59 -08:00
Arthur Milchior
c16a3954fa browser._exporting 2020-02-11 10:50:59 -08:00
Damien Elmes
fc40182335 pass instance to webview_did_receive_js_message instead of string 2020-02-09 08:59:29 +10:00
Arthur Milchior
769c806c2d correct missing french translation 2020-02-05 20:48:30 -08:00
Arthur Milchior
607bcc55c2 Reformatting through black 2020-02-04 08:47:36 -08:00
Arthur Milchior
611ce618a8 QUEUE and TYPE day learn, relearn 2020-02-04 08:47:36 -08:00
Arthur Milchior
41ffdbd504 QUEUE_TYPE_REV and CARD_TYPE_REV 2020-02-04 08:47:36 -08:00
Arthur Milchior
44368caf55 CARD_TYPE_LRN and QUEUE_TYPE_LRN 2020-02-04 08:47:35 -08:00
Arthur Milchior
e27b2ff554 QUEUE_TYPE_NEW and CARD_TYPE_NEW 2020-02-03 02:24:37 -08:00
Damien Elmes
85b3a1dc94 formatting 2020-02-02 13:09:02 +10:00
Damien Elmes
55c8a10a9d fix gridline color in macOS dark mode 
https://anki.tenderapp.com/discussions/beta-testing/1752-beta7-nightmode-issues-on-mac
 2020-02-02 12:01:27 +10:00
Damien Elmes
2d4d89d5a5 fix autoplaying of audio in preview screen, and drop extend_and_play() 2020-01-25 16:02:34 +10:00
Damien Elmes
cf815d01c5 respond to play button clicks in preview screen + card layout screen 2020-01-25 16:02:21 +10:00
Damien Elmes
46c6a7f7e4 extract and flag AV tags as part of the render process 
We can now show replay buttons for the audio contained in {{FrontSide}}
without having to play it again when the answer is shown.

The template code now always defers FrontSide rendering, as it wasn't
a big saving, and meant the logic had to be implemented twice.
 2020-01-24 11:06:11 +10:00
Damien Elmes
43cfcaca3d iconFromRef() compat 2020-01-23 17:27:07 +10:00
Damien Elmes
35435a130e basic night mode support 
Forces the Fusion theme when running night mode, so we don't need
to work around platform themes that don't respond to the defined
palette.

Feedback/suggestions on the chosen colours welcome - _vars.scss is the
file to change if you want to experiment with adjustments.
 2020-01-23 17:27:07 +10:00
Damien Elmes
4f9c9e1770 add a webview_did_receive_js_message hook 2020-01-22 11:06:12 +10:00
Damien Elmes
263a04c887 update qt/ to use the new API 2020-01-20 20:10:38 +10:00
Damien Elmes
5d29ad51da move types.py into the files responsible for each type 2020-01-17 10:17:33 +10:00
Damien Elmes
5e4f8673c4 fix preview button shortcut 
Qt 'helpfully' erases any existing shortcuts when .setText() is called,
and as PyQt's generated forms set the text after the shortcut is set,
it gets lost.

https://anki.tenderapp.com/discussions/ankidesktop/38038-does-ctrlshiftp-doesnt-trigger-preview-in-browse
 2020-01-16 12:31:02 +10:00
Damien Elmes
68791b7008 fix invalid func name in unfocus hook 
Don't know why mypy and pylint both failed to catch this :-(
 2020-01-16 08:53:28 +10:00
Damien Elmes
f02f845193 fix cases where we used the wrong type sig to connect to gui hook 2020-01-16 07:53:12 +10:00
Damien Elmes
20db4ab2f3 add qconnect helper and some type hints 
The type hints allow mypy to check the gui_hook calls, revealing a
bunch of places that are broken as they expect no arguments like the
legacy hooks.

To make mypy happy about PyQt's signal.connect(func), a qconnect()
helper has been added.
 2020-01-16 07:41:23 +10:00
Damien Elmes
b22dc71810 more tweaks for readability/consistency 2020-01-15 17:45:35 +10:00
Damien Elmes
dd780b2898 more hook tweaks, and merge the pre-render field and template hooks 2020-01-15 17:18:11 +10:00
Damien Elmes
8bad40152d remove _hook/_filter suffix 2020-01-15 16:53:24 +10:00
Damien Elmes
a38b5c1bb6 tweak the hook names in anki/ 
still a work in progress
 2020-01-15 16:43:22 +10:00
Damien Elmes
32edb4522d migrate addHook/remHook calls 2020-01-15 13:49:26 +10:00