Damien Elmes
f936735114
fix formatting
2020-08-21 11:45:14 +10:00
Damien Elmes
54f8a7ded5
Add comment
2020-08-21 11:10:30 +10:00
kelciour
580e561805
Reset av_player.current_player after mpv restart
2020-08-21 02:17:21 +03:00
Damien Elmes
4dff66cd10
formatting and debug statement tweak
2020-07-24 11:57:37 +10:00
Damien Elmes
f33451f12f
fix pylint failing in CI
2020-07-21 16:16:34 +10:00
Damien Elmes
47a9b523f7
protect against exception on initial recording wait
2020-07-21 16:07:58 +10:00
Damien Elmes
d084898b92
trigger recording permission on newer macOS SDKs
2020-07-21 15:54:04 +10:00
kelciour
7518597408
Replace mpv "idle" property with "end-file" event
2020-06-27 03:46:40 +03:00
kelciour
88103d29cf
Replace default mpv quit keybindings if mpv version is >= 0.30
...
4614d432a8
2020-06-27 03:46:40 +03:00
Damien Elmes
3396dc3d18
remove the script-message commands that older mpv version don't support
...
https://github.com/ankitects/anki/pull/671#issuecomment-647798343
2020-06-23 14:30:42 +10:00
Damien Elmes
4d16dc243d
remove mpv keybindings on init
...
On a machine here, they cause the following error:
raise MPVCommandError("%r: %s" % (message["command"], e))
aqt.mpv.MPVCommandError: ['keybind', 'q', 'stop']: invalid parameter
2020-06-22 13:22:57 +10:00
kelciour
1283e48603
Replace deprecated "idle" event with "idle-active" property
2020-06-20 02:04:35 +03:00
kelciour
ce3d3a3633
Disable OSC idle message
2020-06-20 02:04:34 +03:00
kelciour
ba9c4a5175
Replace default mpv "quit" keybindings with "stop"
...
https://github.com/mpv-player/mpv/blob/master/etc/input.conf
2020-06-20 02:04:34 +03:00
Damien Elmes
446577d694
allow input.conf in Anki data folder
...
https://anki.tenderapp.com/discussions/beta-testing/1964-anki-2128-alpha#comment_48382756
2020-06-09 10:26:25 +10:00
Damien Elmes
833faf1e63
try mpv on Windows again
...
https://github.com/ankitects/anki/pull/621
2020-05-27 09:21:41 +10:00
Damien Elmes
9ab0f7e2c8
avoid mention of pip
2020-05-05 16:30:22 +10:00
evandrocoan
682da15862
Used showWarning asking the user to install pyaudio
2020-05-05 00:00:48 -03:00
evandrocoan
73b2c5f45c
Fix missing pyaudio blocking Anki from running
...
https://github.com/ankitects/anki/pull 606
Remove pyaudio as mandatory dependency
2020-05-04 13:44:12 -03:00
Damien Elmes
c5fa0b130e
reduce the chances of a race condition in mplayer code
...
Not perfect, it may still happen.
https://anki.tenderapp.com/discussions/ankidesktop/39832-an-error-occurred-audio
2020-03-23 19:15:32 +10:00
Damien Elmes
9c8e8c2216
fix audio getting stuck (2/2)
2020-03-15 09:34:04 +10:00
Damien Elmes
8cd64bad6a
fix audio getting stuck (1/2)
...
The problem was caused by stop() doing a spin loop on the main
thread waiting for the completion signal. This prevented Qt's run
loop from executing, and so the completion signal was never delivered,
meaning longer files would time out.
Fixed by reworking the code so that stop() does not block at all -
instead it just sets the termination flag, and AVPlayer does not
unset current_player. Then when the completion callback fires, it
can advance to the next file.
TTS code still needs updating, and the lock should be safe to remove
as the start/stop logic is all on the main thread.
2020-03-15 09:26:31 +10:00
Damien Elmes
863e5f5e51
make sure audio queue is cleared when transitioning between cards
...
https://anki.tenderapp.com/discussions/beta-testing/1846-anki-2122-beta#comment_48150139
2020-03-14 20:04:40 +10:00
Damien Elmes
61e8a0ed3c
possible fix for invalid handle issue
...
https://anki.tenderapp.com/discussions/ankidesktop/39346-cant-add-audio-on-flash-drive
2020-03-14 18:53:43 +10:00
Alan Du
9c4e616191
Monkeytype qt/aqt/sound.py
2020-03-01 10:16:08 -05:00
Damien Elmes
e52ceaed9b
restore mpv/mplayer missing warning that got lost in the av changes
...
and ensure the UI doesn't get temporarily stuck after the command fails
2020-02-29 21:20:08 +10:00
Damien Elmes
5ca00fc92d
interrupt current audio when autoplay off
2020-02-25 17:49:06 +10:00
Damien Elmes
999aa74eb2
ensure Anki starts on Windows systems that don't have TTS installed
2020-02-25 16:25:17 +10:00
Damien Elmes
bda7e0e0a4
possible fix for race conditions in the sound code
...
https://anki.tenderapp.com/discussions/ankidesktop/39030-erro-ao-adicionar-arquivo-de-udio
the lock should at least ensure _process doesn't disappear in the
middle of our logic, and the longer wait should reduce the chances
of .stop() timing out and allowing multiple audio files to play
Not very happy with the current approach, as in the timeout case
you have multiple threads competing to access the same data
2020-02-21 15:14:09 +10:00
Damien Elmes
4f6d18ee19
drop the extraneous svg group
2020-01-31 07:23:35 +10:00
Damien Elmes
42f09fe933
add compat soundLink selector back
2020-01-31 07:01:22 +10:00
Damien Elmes
bbd134fcc6
use SVG for the play icon, and reduce the default size to 40px
2020-01-28 10:11:29 +10:00
Damien Elmes
2d4d89d5a5
fix autoplaying of audio in preview screen, and drop extend_and_play()
2020-01-25 16:02:34 +10:00
Damien Elmes
6bbab6e9f9
move strip_av_refs() into anki.sound
2020-01-24 15:48:40 +10:00
Damien Elmes
46c6a7f7e4
extract and flag AV tags as part of the render process
...
We can now show replay buttons for the audio contained in {{FrontSide}}
without having to play it again when the answer is shown.
The template code now always defers FrontSide rendering, as it wasn't
a big saving, and meant the logic had to be implemented twice.
2020-01-24 11:06:11 +10:00
Damien Elmes
f80bcf15ca
fix mpv failing to load
2020-01-24 07:06:59 +10:00
Damien Elmes
78a8229577
don't wait as long for player to stop
2020-01-23 17:27:07 +10:00
Damien Elmes
6e984b3cc3
fix audio displaying console window on Windows
2020-01-23 17:27:07 +10:00
Damien Elmes
214871c7a4
make pylint happy
2020-01-22 15:37:58 +10:00
Damien Elmes
712779886a
add a hook for when playback begins
2020-01-22 14:41:32 +10:00
Damien Elmes
42c04817c7
make .command() behave the same way for mplayer and mpv
2020-01-22 14:11:25 +10:00
Damien Elmes
bfc0ac1c0f
simplify taskman, and add .run_on_main()
2020-01-22 14:09:51 +10:00
Damien Elmes
837ac57ab2
add option in prefs to hide replay audio buttons
2020-01-21 21:00:17 +10:00
Damien Elmes
52a41d9a8e
formatting fixes
2020-01-21 20:39:25 +10:00
Damien Elmes
0df9837a66
fix mpv args
...
https://anki.tenderapp.com/discussions/ankidesktop/38186-mpvprocesserror-unable-to-start-process
2020-01-21 19:29:50 +10:00
Damien Elmes
e326236f7c
compare only on rank, as voices may be subclassed
2020-01-21 18:33:14 +10:00
Damien Elmes
8ddb49eb76
add Windows TTS support
2020-01-21 17:34:47 +10:00
Damien Elmes
171764e3e0
add replay buttons to reviewing screen
2020-01-21 14:47:03 +10:00
Damien Elmes
6d1d806b3a
make sure we don't mutate list passed to play_from_tags()
2020-01-21 14:43:33 +10:00
Damien Elmes
9dc9151963
add file-based TTS say implementation as well
2020-01-21 13:21:43 +10:00
