Commit graph

194 commits

Author SHA1 Message Date
Damien Elmes
ac8b6c0cac fix preview failing to appear when 'show both sides' enabled 2019-05-17 15:16:13 +10:00
Damien Elmes
a674b3386c preview code shouldn't assume self.card is valid 2019-04-15 12:20:12 +10:00
Damien Elmes
de6825288f ensure card info is closed properly 2019-04-09 16:21:43 +10:00
Damien Elmes
320cc90320 fix preview not updating when note edited 2019-04-08 15:18:40 +10:00
Damien Elmes
d15bfd6d1c fix note not displaying when preview toggled off & on 2019-04-08 15:18:27 +10:00
Damien Elmes
5522c240a5 revert undo shortcut change in browser
when ctrl+z pressed in focused field and no undo history left, qt
triggers the menu item instead, causing data loss

I tried capturing the shortcut in JS and manually executing the undo,
and that seems to work on macOS, but not on Windows.

fixes
https://anki.tenderapp.com/discussions/ankidesktop/33064-how-to-undo-reverted-to-state-deleting-my-cards
2019-03-11 13:43:25 +10:00
Damien Elmes
3e80f85d94 preview state depends on card id, not note id
fixes
https://anki.tenderapp.com/discussions/ankidesktop/32952-commit-b43b14eb6263676da4d41cd5f3ca514bb8b43873-causes-preview-to-not-work-with-multiples-cards-of-same-note-cloze-deletions
2019-03-05 07:50:54 +10:00
Damien Elmes
75a95ee1fb tidy up unused imports 2019-03-04 17:25:19 +10:00
Damien Elmes
71f2b0627d fix inconsistent indentation 2019-03-04 16:54:22 +10:00
Damien Elmes
7d0f7ae33c fix some warnings 2019-03-04 16:01:10 +10:00
Damien Elmes
e6d75207af explicitly import _ and ngettext 2019-03-04 11:58:34 +10:00
Damien Elmes
0595b3ab04 include note id in state
to make sure we refresh when multiple notes have same mod time
2019-02-26 11:21:25 +10:00
Damien Elmes
b43b14eb62 avoid refreshing preview when nothing has changed
fixes visible redraw when:
- opening preview screen while cursor in field (as editTimer
fires even if note has not changed)
- moving between cards (as loadNote and rowChanged hooks are both
fired)
2019-02-26 11:18:32 +10:00
Damien Elmes
4a1462d949 fix context menu in editor, and move workaround into shared function 2019-02-05 14:37:07 +10:00
Damien Elmes
a7eb6bb357 update copyright and clarify licenses 2019-02-05 14:01:33 +10:00
Damien Elmes
e7b6b9befa make sure change note type clears up hooks
if an error occurred after QDialog.accept() had been called,
the hook was left lying around and caused errors when reset later
fired

File "aqt\main.py", line 1028, in onCheckDB
  File "aqt\main.py", line 516, in reset
  File "anki\hooks.py", line 28, in runHook
  File "aqt\modelchooser.py", line 47, in onReset
  File "aqt\modelchooser.py", line 82, in updateModels
<class 'RuntimeError'>: wrapped C/C++ object of type QPushButton has been deleted
2018-12-15 12:45:17 +10:00
Damien Elmes
270e0b4271 apply stylesheet app wide, and add border to win10 menu
the night mode add-on may need updating with this change, but with
a global stylesheet it may be easier to style widgets in the future

menu bar issue:

https://anki.tenderapp.com/discussions/beta-testing/1313-anki-216-beta-1#comment_46664932
2018-12-14 20:35:12 +10:00
Damien Elmes
5c5042cf5a ensure card list updated when editing html
using an extra hook is ugly, but there's a risk re-purposing
the editTimer hook will break an add-on that assumes the note
has already been loaded

https://anki.tenderapp.com/discussions/ankidesktop/30972-bug-editing-html-in-browser-not-saved-unless-tabbingclicking-to-other-field
2018-11-27 18:00:57 +10:00
Damien Elmes
0605bd06fe case-insensitive field sort in find dupes 2018-11-27 16:44:23 +10:00
Damien Elmes
0560b6c4b2 limit find&replace fields to selected notes 2018-11-27 16:42:00 +10:00
Damien Elmes
45a42a1c76 normalize search text
https://anki.tenderapp.com/discussions/ankidesktop/30614-diacritics-changed-on-card-save-anki-21
2018-11-12 12:43:54 +10:00
Damien Elmes
555e94f558 skip scroll if the number of cards has not changed
The scrolling behaviour is useful when cards are deleted, but
annoying in other cases such as when changing flags.
2018-11-12 12:26:23 +10:00
Damien Elmes
984de2e57e prevent hiding of shortcuts in browser context menu 2018-11-12 12:13:58 +10:00
Damien Elmes
b97f63b5b8 checkmark on flags in browser 2018-11-12 12:10:50 +10:00
Damien Elmes
4965f6bfb7 toggle flags instead of using separate clear action in browser 2018-11-12 11:55:37 +10:00
Damien Elmes
96ae855afd use a semi transparent, neutral selection in browser
As the base colour of rows is now visible, actions like flagging
now provide immediate feedback about what they've changed.
2018-11-12 11:02:01 +10:00
Damien Elmes
fd37eceaeb change purple flag to orange 2018-11-01 14:58:41 +10:00
Damien Elmes
038eccab42 sidebar now visible by default 2018-10-28 12:24:54 +10:00
Damien Elmes
a2831ea843 we can use the old undo shortcut on 5.11
webviews no longer propagate the captured shortcut
2018-10-23 18:40:58 +10:00
Damien Elmes
62b02d2754 add rowChanged hook and ensure singleCard attr exists 2018-09-24 17:29:19 +10:00
Damien Elmes
0cf2eea1df prioritize marked/flagged card colour over suspended colour 2018-09-05 16:55:26 +10:00
Damien Elmes
2695391891 support rtl text in sort field in browser 2018-08-08 10:39:54 +10:00
Damien Elmes
b6a64991de Merge pull request #245 from glutanimate/fix-findreplace-showinfo-focus
Set showInfo parent explicitly in in browser find and replace
2018-07-26 16:31:13 +10:00
Damien Elmes
c7c559930e Merge pull request #244 from glutanimate/fix-togglefield-reset
Make sure to end model reset when prematurely returning from toggleField
2018-07-26 16:25:01 +10:00
Glutanimate
2518c13f16 Set showInfo parent explicitly in in browser find and replace
Fixes an issue where focus would be passed over to mw after longer
find and replace processing times.
2018-07-25 12:00:08 +02:00
Glutanimate
574edf9d2c Make sure to end model reset when prematurely returning from toggleField
Fixes an issue where Anki would stall after trying to remove the
last browser column.
2018-07-25 11:52:21 +02:00
Glutanimate
f0f1efd73d Add a hook to browser.onContextMenu for add-on authors
This will grant add-on authors more flexibility in implementing
custom context menu actions.
2018-07-25 11:40:49 +02:00
Damien Elmes
42c590e5b8 select current card when browser opened
https://anki.tenderapp.com/discussions/beta-testing/1208-no-way-to-know-which-card-im-seeing-anymore
2018-07-23 12:50:10 +10:00
Damien Elmes
8f38ddd2b9 leave space after deck:current
https://anki.tenderapp.com/discussions/ankidesktop/28662-add-space-after-deckcurrent
2018-07-23 11:01:21 +10:00
Damien Elmes
dbb1444a38 fix card info dialog size not being remembered 2018-06-25 11:56:27 +10:00
Damien Elmes
d453278d4b fix field getting overwritten when showing duplicates 2018-04-30 14:51:28 +10:00
Damien Elmes
317cb84201 ignore delete key if card list is not focused
https://anki.tenderapp.com/discussions/beta-testing/1004-ctrl-delete-erases-my-cards
2018-03-01 13:31:52 +10:00
Damien Elmes
e592886723 prevent find duplicates scrolling to top on link click 2018-02-03 17:11:32 +10:00
Damien Elmes
07dcacf09b remove format literals so we can support python 3.5 2018-01-16 16:07:30 +10:00
Damien Elmes
020eb86e3d add context menu to browser 2017-12-14 14:49:51 +10:00
Damien Elmes
d513c93b89 more raw string literals 2017-12-13 14:34:54 +10:00
Damien Elmes
ccb39c5f50 cgi.escape is deprecated 2017-12-11 16:20:00 +10:00
Damien Elmes
5f787d6d3c play question audio when preview set to 'show both sides' 2017-12-04 12:45:22 +10:00
Damien Elmes
7c520c55df night mode 2017-12-04 12:20:56 +10:00
Damien Elmes
fe209d9535 close preview window on collection close 2017-09-08 19:44:13 +10:00