1505 commits

Author	SHA1	Message	Date
Damien Elmes	5ae66af5d2	rework v2 scheduler upgrade; drop downgrade ... - Rework V2 upgrade so that it no longer resets cards in learning, or empties filtered decks. - V1 users will receive a message at the top of the deck list encouraging them to upgrade, and they can upgrade directly from that screen. - The setting in the preferences screen has been removed, so users will need to use an older Anki version if they wish to switch back to V1. - Prevent V2 exports with scheduling from being importable into a V1 collection - the code was previously allowing this when it shouldn't have been. - New collections still default to v1 at the moment. Also add helper to get map of decks and deck configs, as there were a few places in the codebase where that was required.	2021-02-21 15:50:41 +10:00
Damien Elmes	ab790c1d14	initial work on moving v2 card answering into backend ... Not plugged into the Python code yet. Still a work in progress. Other changes: - move a bunch of From implementations out of the giant backend/mod.rs file into separate submodules. - reorder backend methods to match proto order - fix some clippy lints	2021-02-20 14:48:07 +10:00
abdo	fae0437e49	Fix tag replacement matching substrings ... https://github.com/ankitects/anki/issues/1027	2021-02-17 03:57:07 +03:00
Damien Elmes	b3b40933c2	switch 'set due date' to leaving the interval alone for now ... The previous approach worked when the user pushes their due date back, or moves it forward a little bit, but breaks down if they reschedule shortly after the previous answer - a card that was only just answered will have had an effective delay of 0, causing the interval to be reset, which is not great. I thought about limiting interval reductions, but that means the behaviour is inconsistent when sending a card forward and moving it back again. We could apply a cap to the amount of interval we'll reduce, but that will either doing something like dividing by 2 (which breaks down when the action is performed repeatedly), or or looking up the review log to try and determine the previous interval we should not go below. One other option we might want to consider in the future is using the revlog to calculate the actual elapsed time at answer time instead of reschedule time, falling back to existing behaviour when the revlog doesn't match or is missing.	2021-02-12 11:19:58 +10:00
Damien Elmes	586ea07869	avoid wrapping outermost search in parens	2021-02-12 09:30:21 +10:00
Damien Elmes	35840221bb	tweak search wording and tidy up API ... - SearchTerm -> SearchNode - Operator -> Joiner; share between messages - build_search_string() supports specifying AND/OR as a convenience - group_searches() makes it easier to negate	2021-02-11 19:57:19 +10:00
Damien Elmes	59ccfe5918	more search bikeshedding ... While implementing the overdue search, I realised it would be nice to be able to construct a search string with OR and NOT searches without having to construct each part individually with build_search_string(). Changes: - Extends SearchTerm to support a text search, which will be parsed by the backend. This allows us to do things like wrap text in a group or NOT node. - Because SearchTerm->Node conversion can now fail with a parsing error, it's switched over to TryFrom - Switch concatenate_searches and replace_search_term to use SearchTerms, so that they too don't require separate string building steps. - Remove the unused normalize_search() - Remove negate_search, as this is now an operation on a Node, and users can wrap their search in SearchTerm(negated=...) - Remove the match_any and negate args from build_search_string Having done all this work, I've just realised that perhaps the original JSON idea was more feasible than I first thought - if we wrote it out to a string and re-parsed it, we would be able to leverage the existing checks that occur at parsing stage.	2021-02-11 17:11:17 +10:00
Damien Elmes	242b4ea505	switch search parser to using owned values ... I was a bit too enthusiastic with using borrowed values in structs earlier on in the Rust porting. In this case any performance gains are dwarfed by the cost of querying the DB, and using owned values here simplifies the code, and will make it easier to parse a fragment in the From<SearchTerm> impl.	2021-02-11 12:19:36 +10:00
Damien Elmes	8852359fa9	expose the ability to create search groups	2021-02-11 11:21:33 +10:00
Damien Elmes	b75851d823	add "due on day" search	2021-02-11 10:46:40 +10:00
Damien Elmes	843ec29228	make it easier to negate a search term	2021-02-11 10:45:47 +10:00
Damien Elmes	9ce4b21935	add markdown flag for deck description ... Needed so we can display consistently, and gradually transition over	2021-02-09 18:47:19 +10:00
Damien Elmes	180efbc578	recent -> today ... 'Current deck' has moved, and by removing 'due tomorrow', we can drop the 'today' suffix on the rest of the items. The keys of the existing translations have not been changed, so existing translations will not break, but will need to be manually updated to make them shorter.	2021-02-09 09:50:59 +10:00
Damien Elmes	05074f2cc1	make decks root search collection; move current deck ... Also use explicit 'deck:*' search, to make it more obvious what is happening	2021-02-08 22:48:45 +10:00
Damien Elmes	a8ddb65e1c	add ability to force interval reset ... - use trailing ! to force a reset - use - instead of .. - tweak i18n messages and error handling	2021-02-08 22:33:27 +10:00
Damien Elmes	b9635ce936	nest NoteWithEmptyCards	2021-02-08 19:11:16 +10:00
Damien Elmes	c23b01978d	nest progress messages and remove Python wrapper class ... The progress messages are only really intended to be consumed by Anki. If consumption by add-ons was expected, we'd be better off keeping the wrapper, as the API for oneofs in Python is quite awkward to use.	2021-02-08 16:40:27 +10:00
Damien Elmes	f434cff36f	remember last input for 'set due'; add string config; nest config types	2021-02-08 14:10:05 +10:00
Damien Elmes	704b5e581a	Rework reschedule tool ... The old rescheduling dialog's two options have been split into two separate menu items, "Forget", and "Set Due Date" For cards that are not review cards, "Set Due Date" behaves like the old reschedule option, changing the cards into a review card, and and setting both the interval and due date to the provided number of days. When "Set Due Date" is applied to a review card, it no longer resets the card's interval. Instead, it looks at how much the provided number of days will change the original interval, and adjusts the interval by that amount, so that cards that are answered earlier receive a smaller next interval, and cards that are answered after a longer delay receive a bonus. For example, imagine a card was answered on day 5, and given an interval of 10 days, so it has a due date of day 15. - if on day 10 the due date is changed to day 12 (today+2), the card is being scheduled 3 days earlier than it was supposed to be, so the interval will be adjusted to 7 days. - and if on day 10 the due date is changed to day 20, the interval will be changed from 10 days to 15 days. There is no separate option to reset the interval of a review card, but it can be accomplished by forgetting the card(s), and then setting the desired due date. Other notes: - Added the action to the review screen as well. - Set the shortcut to Ctrl+Shift+D, and changed the existing Delete Tags shortcut to Ctrl+Alt+Shift+A.	2021-02-07 21:57:51 +10:00
Damien Elmes	ded626f0b9	render deck description with markdown; strip images ... To support images on that screen, we'll first need to adjust the base url for each platform, or rewrite the local image URLs, as otherwise they are resolved to _anki/pages/...	2021-02-06 15:02:40 +10:00
Damien Elmes	6ba321f818	sanitize deck description in decks screen on backend ... Looks like ammonia only adds about 800k to the release binary	2021-02-06 13:42:38 +10:00
Damien Elmes	3839ed2e28	show deck description on congrats screen	2021-02-06 13:20:06 +10:00
Damien Elmes	b8d67cdad5	move remaining Filter button items into sidebar ... - Closes #976 - Added helper to apply arbitrary colour to an icon. - Fix #979 - low res icons in night mode. - The icons and colours are not perfect - please feel free to send through a PR if you can improve them. - Convert colors dictionary into module consts, so we can use code completion. - Added "Edited Today" and "Due Tomorrow" - Rename camelCase attribute to snake_case and tweak the wording of some enum constants. We've already broken compatibility with the major sidebar add-ons, so we may as well make these changes while we can. - Removed Filter button. Currently there is no exposed way to toggle the Sidebar off - wonder if we still need it?	2021-02-05 18:58:22 +10:00
Damien Elmes	a50601ed46	add tag drag & drop support	2021-02-02 20:14:04 +10:00
Damien Elmes	467064f873	collapsed->expanded in other tag uses for consistency	2021-02-02 18:52:57 +10:00
Damien Elmes	8e0f69b71c	return tags as a string list directly; we don't need usn or collapse state	2021-02-02 18:52:57 +10:00
Damien Elmes	52b256663f	collapsed->expanded in TagTreeNode	2021-02-02 18:52:57 +10:00
Damien Elmes	7d8448a321	decks start collapsed	2021-02-02 17:14:11 +10:00
Damien Elmes	4b7d30f515	tags start collapsed	2021-02-02 16:47:05 +10:00
Damien Elmes	4a4aef3972	Merge pull request #959 from Arthur-Milchior/AGPL ... NF: add AGPL licence missing in some file	2021-02-01 12:46:59 +10:00
Damien Elmes	d219337023	Update card_stats.html ... Don't want the header accidentally getting copied about when users copy+paste their stats.	2021-02-01 12:46:29 +10:00
Arthur Milchior	8b5ae7d7c5	NF: add AGPL licence missing in some file ... I noticed it when I looked at some files now used in AnkiDroid, wanting to be sure we clearly indicate that we have AGPLv3 code linked in the app	2021-01-31 21:50:21 +01:00
RumovZ	13c6921da1	Remove protobuf filters whole_col and current_deck	2021-01-31 11:12:49 +01:00
Damien Elmes	260a270eb0	embed BuiltinSortKind	2021-01-31 18:56:16 +10:00
Damien Elmes	5974163343	embed kind enum in StockNoteType and remove prefix	2021-01-31 18:56:16 +10:00
Damien Elmes	cb805cf355	Merge branch 'more-backend-search' into main	2021-01-31 14:21:51 +10:00
Damien Elmes	8410330f94	move drag/drop deck logic to backend	2021-01-31 13:46:31 +10:00
RumovZ	692aa16f6b	Rename EaseKind to RatingKind	2021-01-30 19:03:50 +01:00
RumovZ	b0890b0e47	Manually namespace enum variants in SearchTerm ... In protobuf "...enum values use C++ scoping rules, meaning that enum values are siblings of their type, not children of it. Therefore, [an enum variant] must be unique within [a message], not just within [the enum.]" So we must prefix enum variants with their enum's name, but can also call them directly from the message namespace. The protobuf crate is smart, though, and strips the prefixes. (Simultaneously change some SearchTerm variant names.)	2021-01-30 17:56:29 +01:00
Damien Elmes	705012164b	move Rating up a level ... More ergonomic, and will allow reuse if we expose prop:rated in the future.	2021-01-30 11:54:39 +10:00
Damien Elmes	cb6b88da0f	simplify nid/nids searches, and ditch helper function ... - IdList could be re-used for a cids: search in the future if required. - Embedding the message means it's easy to access from Python as an attribute of SearchTerm.	2021-01-30 11:37:00 +10:00
Damien Elmes	1adc9952f4	simplify Dupe message and ditch helper function ... Calling code doesn't need to know about the existence of such helpers; it can just rely on code completion to discover the required arguments.	2021-01-30 11:10:26 +10:00
Damien Elmes	73b897c754	rename FilterToSearchIn in backend to match frontend	2021-01-30 10:54:21 +10:00
Damien Elmes	52bac7a7a1	use a separate enum for the is:* searches	2021-01-30 10:49:00 +10:00
Damien Elmes	22b80c2dd5	combine forgot_in_days and studied_today into a more general 'rated'	2021-01-30 10:26:23 +10:00
RumovZ	c299e271e8	Refactor search_string() and FilterToSearchIn ... See #955.	2021-01-29 18:27:33 +01:00
Damien Elmes	6ba5ff5a01	place each sidebar section under its own collapsible parent node ... - Allows for group operations like "clear unused tags" - Allows users to hide groups they're not interested in	2021-01-29 22:11:05 +10:00
Damien Elmes	5ff7944a26	add getter/setter for boolean config values	2021-01-29 21:03:19 +10:00
RumovZ	1fb6024454	Rename filters added_in etc. to added_in_days	2021-01-29 09:38:13 +01:00
Damien Elmes	a9be60c8b4	sort config keys	2021-01-29 16:31:29 +10:00
Damien Elmes	7693879e3c	remove unused set_all_config; expose .all_config().	2021-01-29 16:30:42 +10:00
RumovZ	d33442f901	Add backend filter for field name	2021-01-28 19:48:01 +01:00
RumovZ	da6f3b7e76	Fix nid search test	2021-01-28 16:29:34 +01:00
RumovZ	bc52a54dfc	Add nid filter on backend	2021-01-28 16:19:55 +01:00
RumovZ	b15bb4289e	Add forgot, due and added filters on backend	2021-01-28 11:11:32 +01:00
Damien Elmes	e4d44efecc	unbury on sync start ... https://forums.ankiweb.net/t/unburying-works-differently-on-anki-desktop-ankiweb-and-ios-app/6909	2021-01-28 11:54:48 +10:00
Damien Elmes	163a9df886	avoid bumping mtime when correcting card eases on upgrade ... The USN is still set, which should cause the cards to sync in the non-conflict case, but if changes have been made on other devices the ease fix will not take priority, as we could be overwriting the reviews of someone who has not synced in a while.	2021-01-28 08:11:35 +10:00
Damien Elmes	2319312d94	Merge pull request #953 from hgiesel/backlogcb ... Add FutureDueShowBacklog as preferences	2021-01-27 19:44:01 +10:00
Damien Elmes	9299dc60f4	suggest DB check if HTTP status 400 is returned	2021-01-27 14:23:28 +10:00
Henrik Giesel	677f4d340c	Add FutureDueShowBacklog as preferences	2021-01-27 01:15:19 +01:00
Damien Elmes	644cc46dea	Merge pull request #897 from hgiesel/statssearch ... Triggering searches from the stats screen.	2021-01-26 11:31:36 +10:00
Henrik Giesel	759ed17963	Move dispatch logic from Histogram to individual graphs	2021-01-25 16:34:44 +01:00
Henrik Giesel	60ed9c1e22	Add back bridge_commands_support via backend.proto	2021-01-25 13:47:20 +01:00
Kerrick Staley	1eac36c5d7	Add comment explaining why sfld column has type integer ... The `notes.sfld` column in the `collection.anki2` database has type `integer`, even though it contains text. This is [something SQLite allows](https://dba.stackexchange.com/questions/106364/text-string-stored-in-sqlite-integer-column) and was done to allow integer values to sort numerically. Add a comment explaining this.	2021-01-25 18:39:59 +08:00
Damien Elmes	d70132cc8b	handle missing deck ID in templates ... https://github.com/ankidroid/Anki-Android/issues/7512	2021-01-25 16:47:23 +10:00
Damien Elmes	ef9f6b022b	coerce some more invalid decimal values to ints during sync	2021-01-25 09:43:50 +10:00
Damien Elmes	370fc00afd	handle older clients not setting 'done' key when false	2021-01-24 09:05:17 +10:00
Damien Elmes	2a875ffc55	Merge pull request #934 from hgiesel/graphprefs ... Add GraphsPreferences API to graphs for setting persistent preferences	2021-01-23 21:24:41 +10:00
Damien Elmes	37ca8afaf6	minor wording tweak: GraphsPreferences -> GraphPreferences	2021-01-23 20:47:45 +10:00
Damien Elmes	bdc5c619f7	handle decks/notetypes with a duplicate name being sent in a sync ... Typically caused by older clients, but could happen if the user added the same name on different devices without syncing. Also add an inactive test that was used to try track down this issue and might be useful in the future.	2021-01-23 12:59:24 +10:00
Henrik Giesel	de71123ab4	Rename GraphsPreferencesOut to simply GraphsPreferences	2021-01-22 19:39:03 +01:00
Henrik Giesel	834f2de99b	Make cardCountsSeparateInactive settable	2021-01-22 18:03:58 +01:00
Henrik Giesel	aebaa04652	Uniformly rename firstWeekday to firstDayOfWeek	2021-01-22 16:53:33 +01:00
Henrik Giesel	054c30a695	Add non-functioning logic for settings graphs preferences	2021-01-22 13:14:35 +01:00
Henrik Giesel	665a13e378	Add GraphsPreferences endpoint to backend	2021-01-22 13:13:48 +01:00
Damien Elmes	99d732799c	(de)serialize Weekday directly ... Re: discussion in https://github.com/ankitects/anki/pull/934	2021-01-22 12:12:57 +10:00
Damien Elmes	a77aa6b65a	handle non-chunked graves from AnkiDroid	2021-01-22 10:00:25 +10:00
Damien Elmes	ce50b1cddf	add missing file header	2021-01-21 10:31:34 +10:00
Damien Elmes	44cde24679	fix context in rated: search error message	2021-01-19 18:33:10 +10:00
Damien Elmes	d273ebb756	more parsing error tweaks ... The majority of the error checking can now be delegated to routines like parse_f32(), parse_negative_i32() and so on, instead of creating specific error messages for each type.	2021-01-19 15:50:26 +10:00
Damien Elmes	0b83efb63e	simplify write_props() and associated translations ... This is a work in progress; see associated PR discussion to follow.	2021-01-19 12:40:16 +10:00
Damien Elmes	a4ec467284	have register_tag mutate the tag if it changes it, instead of copying	2021-01-19 12:37:51 +10:00
Damien Elmes	9edb002679	fix deck and tag normalization ... The issue existed in the deck code as well; I've added a test for it.	2021-01-19 12:36:01 +10:00
Damien Elmes	09bea954a2	Merge pull request #929 from abdnh/tag-case ... Make tags match their parents case	2021-01-19 11:56:03 +10:00
Damien Elmes	71f1d3b982	tweaks to the parent matching behaviour ... - move logic out of the storage layer - its job is only to read and write data from the DB - avoid the Result within a Result - return the preferred case as an option, so we can avoid a copy in the unchanged case - return a Cow when normalizing, so we can avoid copying in the unchanged case - add tags directly in clear_unused_tags(), so we avoid doing lookups for every tag in the tag list	2021-01-19 11:52:24 +10:00
abdo	3159cf4ab6	Make tags match their parents case ... https://github.com/ankitects/anki/pull/900/#issuecomment-762018745	2021-01-19 02:29:09 +03:00
Henrik Giesel	a5947e5c65	Satisfy formatter	2021-01-19 00:17:30 +01:00
Henrik Giesel	04e606bf4b	Add firstWeekday to GraphsOut	2021-01-18 23:10:53 +01:00
Damien Elmes	318cc01c73	Merge pull request #900 from abdnh/tagtree ... Hierarchical tags	2021-01-18 16:36:22 +10:00
abdo	0ac97cf358	clear_tag() should be case-insensitive	2021-01-18 03:52:28 +03:00
Henrik Giesel	84c997fa4d	Adjust unit tests for new InvalidRatedEase	2021-01-18 00:05:20 +01:00
Henrik Giesel	bdc6494c79	Generalize InvalidRatedEase error for rated and prop:rated	2021-01-17 23:55:05 +01:00
Henrik Giesel	2b45ef22a5	Use explicit unreachable in rust pattern matching	2021-01-17 22:18:12 +01:00
Henrik Giesel	bc81165be4	Add resched to tags	2021-01-17 21:44:56 +01:00
Henrik Giesel	947260e4aa	Reintroduce false removed limits	2021-01-16 17:38:02 +01:00
Henrik Giesel	e7660113ce	Change argument order of write_rated to be more in line with the logic	2021-01-16 15:24:22 +01:00
Henrik Giesel	112e7f577e	Lift the 365 limit from rated/resched searches	2021-01-16 15:08:15 +01:00
Henrik Giesel	47542f97e5	Fix issues after rebasing	2021-01-16 13:07:35 +01:00
Henrik Giesel	908e0a375c	Being overly correct with the review ids	2021-01-16 12:45:02 +01:00
Henrik Giesel	8f3c63bf0b	Fix formatting	2021-01-16 12:45:02 +01:00
Henrik Giesel	88c75d73b6	Pass in the the negative offset day to write_rated	2021-01-16 12:44:59 +01:00
Henrik Giesel	3788cb8890	Port prop:rated to EaseKind	2021-01-16 12:44:03 +01:00
Henrik Giesel	b57d0da12a	Implement functioning prop:rated	2021-01-16 12:42:08 +01:00
Henrik Giesel	ce55dc4a75	Add nonfunctional "prop:rated" as possible search query	2021-01-16 12:42:06 +01:00
Damien Elmes	34245e6f72	use of 'self' in function name was confusing	2021-01-16 21:14:55 +10:00
Damien Elmes	9f964916ab	simplify unused tags and DB check ... - backend routines should contain minimal logic, and should call into a routine on the collection - instead of copying the giant-string approach the Python code was taking, we use a HashSet to keep track of seen tags as we loop through the notes, which should be more efficient	2021-01-16 20:38:16 +10:00
Damien Elmes	d80a5c56e3	no need for separate all_tags_sorted() ... tag is the primary key, so sqlite will give it back to us in sorted order already.	2021-01-16 19:46:58 +10:00
Damien Elmes	d54acba81f	custom ord/partialeq is not required; fix clippy lint	2021-01-16 19:44:37 +10:00
Damien Elmes	a390a77815	handle missing parent names with varying case ... Also convert to \x1f before sorting, so that numbers (with have a lower ascii order than '::') don't mess up the sort.	2021-01-16 19:42:25 +10:00
Damien Elmes	6f7c68b661	add a (currently failing) test for duplicate parent names	2021-01-16 19:04:25 +10:00
Damien Elmes	9686cd99ec	search error tweaks ... - use markdown instead of HTML, to make editing and translating easier - use a shared prefix - a few very minor wording tweaks - we don't need to translate undocumented command errors - share a string for positive number of days - share a string for invalid property and state arguments, and avoid listing them out Related discussion: https://github.com/ankitects/anki/pull/922	2021-01-16 15:59:19 +10:00
RumovZ	5b03d1e2c8	Add resched error tests	2021-01-15 10:57:55 +01:00
RumovZ	cb4a103bb1	Merge branch 'master' into search-errors ... Add error support for new resched node, update rated error.	2021-01-15 10:50:02 +01:00
RumovZ	c8f0961c6c	Include context in search error test	2021-01-15 09:09:54 +01:00
abdo	e018ea94b6	Merge branch 'master' of https://github.com/ankitects/anki into tagtree	2021-01-15 01:12:01 +03:00
RumovZ	182abfe66d	Encode HTML entities in search errors	2021-01-14 23:02:39 +01:00
RumovZ	2a2ac38a1b	Add search context for certain error kinds	2021-01-14 22:40:07 +01:00
RumovZ	5f05ca2548	Rename ParseErrorKind to SearchErrorKind	2021-01-14 22:00:52 +01:00
RumovZ	6af1852611	Add errorkind test	2021-01-14 19:10:12 +01:00
RumovZ	8f754e1525	Add FailKinds for unopened/unclosed groups	2021-01-14 19:09:31 +01:00
RumovZ	0b73110f82	Make AnkiError::SearchError work with ParseError ... Use mock ftl strings for now.	2021-01-14 11:14:55 +01:00
RumovZ	4afb476f04	Fix text node parsers, add FailKind alias	2021-01-14 11:10:33 +01:00
abdo	831942c2e2	Fix unicode tag sorting	2021-01-14 07:04:55 +03:00
abdo	ee3c019804	Remove Default impl of Tag	2021-01-14 07:04:55 +03:00
abdo	9c1d7c522a	Refactor code for clearing unused tags and saving collapse state	2021-01-14 07:04:14 +03:00
RumovZ	6d9cfb85ab	Add pb message for dupe filter	2021-01-14 10:42:37 +10:00
RumovZ	d9bb20ac24	Expect backslashes to be escaped in dupe: text	2021-01-14 10:42:37 +10:00
RumovZ	f4cfccfc0a	Fix writing dupe nodes ... Rename comments and dupe functions on the backend accordingly to avoid further confusion.	2021-01-14 10:42:37 +10:00
Damien Elmes	7d81d39be7	Merge pull request #918 from hgiesel/ratedflags ... Introduce `resched:n` instead of `rated:n:0`	2021-01-14 10:19:10 +10:00
RumovZ	3aa15a7139	Optimise term parsers	2021-01-13 14:15:57 +01:00
RumovZ	447ff6931c	Move parse errors, add helper func for parse fail	2021-01-13 13:23:25 +01:00
Henrik Giesel	9f7170ac0f	Change "between 1 and 4" to "> 0"	2021-01-13 11:44:54 +01:00
Henrik Giesel	c0ec21b139	Rename EaseKind values	2021-01-13 11:41:48 +01:00
Damien Elmes	633034b24d	add local sync server frontend	2021-01-13 11:42:00 +10:00
abdo	72e8f9d640	Merge branch 'master' of https://github.com/ankitects/anki into tagtree	2021-01-12 23:31:58 +03:00
abdo	9a68d84483	Keep tags in human form and update the tags table structure ... See https://github.com/ankitects/anki/pull/900#issuecomment-758284016 - Leave tag names alone and add the collapsed and config columns to the tags table. - Update The DB check code to preserve the collapse state of used tags. - Add a simple test for clearing tags and their children	2021-01-12 23:12:35 +03:00
RumovZ	b89381ac95	Fix top-level search errorkinds	2021-01-12 17:32:26 +01:00
Damien Elmes	fbd91b22f5	tidy up UTC offset handling/timing calculations ... - use the TimestampSecs newtype instead of raw i64s - use FixedOffset instead of a minutes_west offset - check localOffset each time the timing is calculated, and set it if it's stale - even for v1. - check for and fix missing rollover when calculating timing - stop explicitly passing localOffset in the sync/start call	2021-01-12 21:32:56 +10:00
RumovZ	d00c54aacf	Switch parser to custom erros and results	2021-01-12 10:43:12 +01:00
Damien Elmes	31f941267c	move sync JSON into separate file; add enum wrapper	2021-01-12 18:47:08 +10:00
Damien Elmes	09dfa9ced6	allow normal sync tests to run offline	2021-01-12 18:47:08 +10:00
Damien Elmes	f6c1a91674	use '<=' when merging UnchunkableChanges ... Prevents current tests from failing when testing locally, due the current second not changing between syncs.	2021-01-12 18:47:08 +10:00
Henrik Giesel	81d851610e	Coerce resched:days as well	2021-01-11 17:25:42 +01:00
Henrik Giesel	5eb2c7b271	Satisfy rslib unit tests	2021-01-11 17:18:40 +01:00
Henrik Giesel	7a7152fe27	Remove EaseKind impl in favor of transforming to sql in function	2021-01-11 17:10:17 +01:00
Henrik Giesel	cbfe14ef4f	Introduce "resched:n" instead of 0 and a flag for "rated"	2021-01-11 16:40:30 +01:00
Henrik Giesel	7e58660aab	Modify default behavior of rated searches to exclude manual	2021-01-11 16:40:30 +01:00
Damien Elmes	401d5dd9cc	Merge pull request #917 from hgiesel/querynozero3 ... Coerce added/edited:0 to 1, Constrain rated:n to 1-365	2021-01-11 16:24:12 +10:00
Henrik Giesel	0b955c3699	Fix formatting	2021-01-10 16:38:20 +01:00
Henrik Giesel	adf969d37f	Add a few rslib unit tests	2021-01-10 16:29:10 +01:00
Henrik Giesel	8f01887fe7	Remove coercion in write_rated	2021-01-10 16:23:53 +01:00
Henrik Giesel	87bc1e69b0	Coerce added/edited:0 to 1, constrain rated:n to 1 <= 365	2021-01-10 16:16:17 +01:00
Damien Elmes	5f70d718b8	favour readability over brevity in filter conversion	2021-01-10 09:19:33 +10:00
Damien Elmes	4ba4e8ca78	Merge pull request #913 from RumovZ/fix-write-template ... Fix ordinal case in write_template	2021-01-10 08:58:00 +10:00
RumovZ	f83553c82a	Merge branch 'master' into backend-filters ... Adapt new formatting.	2021-01-09 19:03:43 +01:00
RumovZ	ca62f3ef80	Fix ordinal case in write_template ... Internal card ordinals start at 0, so add 1 again when writing a template search string from a parsed ordinal.	2021-01-09 17:30:12 +01:00
abdo	0b5bb711a1	Remove unused backend methods & formatting	2021-01-09 17:48:34 +03:00
abdo	5919d9273f	Fix tag collapse state not getting updated	2021-01-09 17:46:52 +03:00
abdo	97b4c2124c	sql formatting	2021-01-09 17:38:16 +03:00
abdo	f7f509c70d	Move tag collapse method to the backend	2021-01-09 17:10:16 +03:00
abdo	1be789f25f	Move sql code for upgrading to schema 17 to a separate file	2021-01-09 17:10:16 +03:00
abdo	c6e3d55400	fill_missing_tags's input should be sorted ... I assumed that fill_missing_tags will work correctly with un unsorted tag list previously so I replaced the all_tags_sorted call, but take the following the list for example: ["foo::bar", "foo"] This will cause "foo" to be counted like a missing tag, since it's encountered the first time when looking at "foo::bar"", and its config and other associated data will be lost.	2021-01-09 17:10:16 +03:00
abdo	b33267f754	Do not check for missing tag parents at registration time	2021-01-09 17:10:16 +03:00
abdo	b276ce3dd5	Hierarchical tags	2021-01-09 17:10:13 +03:00
RumovZ	9ef691c06f	Provide filter searches through backend	2021-01-09 10:50:08 +01:00
Damien Elmes	c3b1266f47	fix some comments in wrong position after format	2021-01-09 14:26:51 +10:00
Damien Elmes	56e4e2d518	reformat .sql files	2021-01-09 14:08:55 +10:00
Henrik Giesel	82a4e0abe8	Don't import now unused INITIAL_EASE_FACTOR_THOUSANDS	2021-01-08 19:32:36 +01:00
Henrik Giesel	caa536a753	Reset ease to 0 for after rescheduling cards as new	2021-01-08 18:15:24 +01:00
Damien Elmes	fe4da25e15	fix reposition not honoring provided order, and add unit test	2021-01-08 20:38:49 +10:00
Damien Elmes	97e3bfe1c0	Merge pull request #904 from hgiesel/propdue ... Streamlining `is:due`, `prop:due`, and the FutureDue graph	2021-01-08 16:34:53 +10:00
Damien Elmes	10630ab723	handle SortOrderProto conversion separately, and use enum getter ... In most cases we can just fall back on the default enum value instead of caring if it's missing/invalid.	2021-01-08 15:56:20 +10:00
Damien Elmes	cbeb714062	convert sort_kind_from_pb into from impl	2021-01-08 09:42:54 +10:00
Damien Elmes	1a5b5f09cc	convert from protobuf enum, rather than the underlying i32	2021-01-08 09:24:03 +10:00
Henrik Giesel	4c570785bb	Add comment about integer division	2021-01-07 20:10:25 +01:00
Henrik Giesel	04a56209c6	Restate rslib unit test	2021-01-07 19:56:36 +01:00
Henrik Giesel	155a59b80b	Search for Learn and PreviewRepeat cards when using prop:due	2021-01-07 19:01:10 +01:00
Henrik Giesel	795dcab370	Include PreviewRepeat cards in is:due	2021-01-07 17:24:10 +01:00
RumovZ	76c16180ae	Add native enum for concatenate_search's separator	2021-01-07 12:50:57 +01:00
RumovZ	ebe535e42f	Add Position in PropertyKind match of writer.rs	2021-01-06 23:29:09 +01:00
RumovZ	6ee9e4f58c	Merge branch 'master' of https://github.com/ankitects/anki into norm-search	2021-01-06 20:57:24 +01:00
RumovZ	d9f7d2e70d	Add tests for writer.rs ... Also minor adjustments to concatenate_searches.	2021-01-06 19:39:34 +01:00
RumovZ	07499dd890	Implement search replacing via Ctrl+Shift combo ... Also switch to using the new backend functions for concatenating and negating searches.	2021-01-06 18:32:29 +01:00
RumovZ	84061a6e6d	Implement replace_search_term	2021-01-06 14:03:43 +01:00
RumovZ	79d0b5496b	Implement concatenate_searches ... Fix minor stuff in writer.rs.	2021-01-06 14:00:47 +01:00
RumovZ	713db05f27	Implement negate_search	2021-01-06 13:57:35 +01:00
Damien Elmes	e28c67d4f6	Merge pull request #895 from hgiesel/newlearn ... Change meaning of "is:learn" to filter on type, not queue	2021-01-06 19:13:59 +10:00
Henrik Giesel	59cb901a3b	Change meaning of "is:learn" to filter on type, not queue	2021-01-05 17:36:55 +01:00
Damien Elmes	dad4c76089	no need to log card resets when exporting	2021-01-05 11:11:37 +10:00
abdo	dc51dc6795	Rename prop:order to prop:pos	2021-01-02 13:35:10 +03:00
abdo	0ad4619833	Support prop:order to search for new cards by order	2021-01-01 04:36:51 +03:00
Damien Elmes	6199548ba9	Merge pull request #879 from Arthur-Milchior/Tex_keep_alt ... Add Alt text to latex image	2020-12-31 12:02:40 +10:00
Damien Elmes	a0b4948760	fix clippy error in unit test	2020-12-31 09:48:05 +10:00
Arthur Milchior	d933d7774f	Add Alt text to latex image ... I'm trying to go over accessibilities issues in AnkiDroid. Since we'll use rust backend, I thought I might as well go over it in rust directly. The only side effect in anki is that, if you copy a text with the image, you'll get the LaTeX copied instead of nothing. Alas, it seems qt does not show alt text.	2020-12-30 18:00:06 +01:00
RumovZ	95b4e4cc84	Make function names more explicit and add docs	2020-12-29 11:18:49 +01:00
RumovZ	62753290d8	Make normalized search syntax more explicit ... Also fix a bug with NoCombining and WordBoundary searches.	2020-12-29 11:06:53 +01:00
Arthur Milchior	008a87a794	NF: test # / and ^ can remains at end of string	2020-12-28 07:58:15 +01:00
Damien Elmes	14c0066a53	simplify NoteField init in test; add other bad chars	2020-12-28 13:19:37 +10:00
Damien Elmes	1d15a207bb	fix comment and add basic unit test	2020-12-28 13:14:49 +10:00
Arthur Milchior	01caa3d996	Trim the start of field name if it is #, /, ^ or a whitespace ... I actually need to trim whitespace again to deal with a field name of the form "# foo"	2020-12-28 03:32:05 +01:00
RumovZ	ecd04f8a59	Don't escape isolated -	2020-12-22 11:52:17 +01:00
RumovZ	873e96b60a	Fix format and tests	2020-12-22 11:32:53 +01:00
RumovZ	5b24d9e4a6	Expose search writer	2020-12-22 11:06:55 +01:00
RumovZ	fcc87d16ea	Add search writer	2020-12-22 11:04:38 +01:00
Damien Elmes	b48451610f	fix sync indicator turning blue after startup sync ... https://forums.ankiweb.net/t/why-is-my-sync-button-blue/2078/26?u=dae	2020-12-22 10:46:50 +10:00
Damien Elmes	ebeae9a5a0	don't pass BUILDINFO into build script ... It was causing the build script to be recompiled each time a commit was made, even though buildinfo.txt was not changing.	2020-12-21 16:04:29 +10:00
Damien Elmes	dee0a2fc18	fix reposition not being applied in browser sort order ... https://forums.ankiweb.net/t/reposition-function-not-working/5817 Also changed id->cid in the non-sorting case, as otherwise when using all_searched_cards() on a sorted list, the results will be wrong.	2020-12-16 10:58:46 +10:00
Damien Elmes	75cbbea048	Merge pull request #848 from cecini/rslibdep ... Update Rust deps, and nom to v6	2020-12-15 20:04:02 +10:00
cecini	d37ea0f5f7	Update rslib dep nom	2020-12-15 08:19:52 +00:00
abdo	197d665de8	Fix duplicate check not decoding entities ... This is a regression introduced in 358d0f957e See https://forums.ankiweb.net/t/bug-duplicates-not-detecting-on-paste/5753	2020-12-14 15:13:00 +03:00
Damien Elmes	77c9db5bba	plural rules and decimal separator should use bundle's language ... Instead of providing the list of languages in preferred order, when creating a bundle we need to specify the bundle language as the first language, so that the correct plural rules are used. Fluent's docs are misleading here; I will submit a PR to fix them. The old behaviour caused: https://forums.ankiweb.net/t/bug-in-review-intervals-for-some-languages-in-number-of-cards/5744	2020-12-14 14:23:49 +10:00
Damien Elmes	a9ea8e11a2	fix filtered decks not honoring sort order ... https://forums.ankiweb.net/t/2-1-36-filtered-decks-bug/5649/	2020-12-09 22:50:49 +10:00
Damien Elmes	1cb3984049	deck renaming tweaks ... - normalize name prior to creating parents - always mark modified https://github.com/ankitects/anki/pull/831#issuecomment-730064858	2020-11-30 10:09:23 +10:00
Damien Elmes	009906d0c2	fix duplicate search not checking first field ... Thanks to abdo for the initial solution. Closes #838	2020-11-30 09:27:10 +10:00
RumovZ	540d52c471	Comment fix	2020-11-27 22:12:36 +01:00
RumovZ	0c9ad7e952	Revert implementation of r: prefix	2020-11-27 22:10:37 +01:00
Damien Elmes	780f32b8ae	fix new Clippy lints	2020-11-25 09:12:19 +10:00
Damien Elmes	3923f56cbf	fix clippy lints	2020-11-24 20:13:05 +10:00
Damien Elmes	d7cded4ae1	fix compilation of rslib outside Bazel ... fixes code completion	2020-11-24 18:51:19 +10:00
RumovZ	347c547e10	Add tests for conversion functions in text.rs	2020-11-20 09:45:53 +01:00
RumovZ	0fc84d19b2	Replace text.rs/text_to_re with text.rs/to_re	2020-11-20 09:23:25 +01:00
Damien Elmes	e23d40e850	Merge pull request #823 from RumovZ/rework-search-parser ... Rework search parser	2020-11-20 16:22:12 +10:00
Damien Elmes	7c57e5044b	mark created deck parents as modified ... Thanks to cecini for the original report. Closes #831: https://github.com/ankitects/anki/pull/831	2020-11-19 08:48:43 +10:00
RumovZ	785540bddc	Revert changes to normalisation handling ... Handle norm calls individually in write_search_node_to_sql again.	2020-11-18 23:46:27 +01:00
RumovZ	6e51bad7db	Implement the prefix r: to search for raw input	2020-11-18 22:26:51 +01:00
RumovZ	c185fb966b	Merge branch 'master' into rework-search-parser ... Conflicts: rslib/src/search/sqlwriter.rs	2020-11-18 09:04:04 +01:00
RumovZ	b09a398d2d	Make - escapable ... Treat unescaped - as before but make it escapable with \ to distinguish the literal from the negator.	2020-11-17 18:38:27 +01:00
RumovZ	91873d68eb	Fix RE in to_custom_re of text.rs ... Match every single (potentially escaped) character of the string, so they can be escaped properly.	2020-11-17 15:39:54 +01:00
RumovZ	8c02c6e205	Split unescaping between parser and writer ... * Unescape wildcards in writer instead of parser. * Move text conversion functions to text.rs. * Implicitly norm when converting text. * Revert to using collection when comparing tags but add escape support.	2020-11-17 12:49:37 +01:00
abdo	358d0f957e	Make dupe search operate on non-stripped text ... See https://github.com/ankitects/anki/pull/822/	2020-11-16 04:01:04 +03:00
RumovZ	7c5cf6d18b	Use enforced re to parse deck ... Fix write_deck not recognising escaped deck name separators: \:\: -> ::	2020-11-15 21:32:36 +01:00
RumovZ	a6628709c5	Annotate RegEx for invalid-escape check	2020-11-15 14:22:16 +01:00
RumovZ	a16d271eb0	Extend tests for new search parsing ... (Also fix indentation)	2020-11-15 12:00:20 +01:00
RumovZ	ae01a5b3a2	Fix escape check for escaped backslash	2020-11-15 11:57:11 +01:00
RumovZ	63cc877023	Move whitespace check for tags from to sqlwriter ... Instead of not parsing a tag containing whitespace, check for spaces when writing sql and if there are any, explicitly match nothing.	2020-11-15 11:54:21 +01:00
RumovZ	57787368a1	Always use regex for tag search ... Don't distinguish between the glob and no-glob cases when comparing tags but always use regexp. Thus, avoid problems with SQL wildcards in registered tags.	2020-11-15 09:52:00 +01:00
RumovZ	9e53481003	Fix tests for new search parsing (and reformat)	2020-11-14 19:13:09 +01:00
RumovZ	836977aac8	Fix whitespace in write_tag and parser/whitespac0	2020-11-14 19:10:56 +01:00
RumovZ	3949996728	For deck searches, unescape quotes only ... For now, revert to the old handling of deck names using text_to_re from text.rs and have parser.rs only unescape quotes.	2020-11-14 19:06:37 +01:00
RumovZ	b186e61e54	Fix 'escaped' parser for empty string ... Fix a bug where 'escaped' parsers (nom) accepted the empty string by wrapping them in 'verify' parsers.	2020-11-14 18:28:24 +01:00
RumovZ	0cff65e5a8	Fix bugs and inconsistencies in the search parser	2020-11-12 17:27:50 +01:00
Damien Elmes	e99c0dbe15	Merge pull request #793 from nwwt/object-audio-tags-support ... Audio & object tag support	2020-11-11 10:33:31 +10:00
Andreas Reis	e68a40f13e	cleanup / renames ... ・ soundRegexps → sound_regexps ・ htmlRegexps → html_media_regexps ・ HTML_TAGS → HTML_MEDIA_TAGS ・ escapeImages → escape_media_filenames + alias ・ strip_html_preserving_image_filenames → strip_html_preserving_media_filenames	2020-11-10 14:53:04 +01:00
Damien Elmes	96f77b4b5e	Merge pull request #805 from cecini/duecounts ... align rslib get_subnode impl with anki pythonapi find_deck_in_tree	2020-11-06 10:57:49 +10:00
Damien Elmes	c157ccb3f5	handle notes with invalid utf8	2020-11-06 10:21:51 +10:00
Damien Elmes	3f47ff9abd	fix missing buildinfo on Windows	2020-11-05 11:21:27 +10:00
Damien Elmes	3c12cb1600	update to latest fluent libs, and integrate maximum digit handling ... We now limit number of digits in our formatter, instead of relying on an upstream patch.	2020-11-03 14:10:45 +10:00
Damien Elmes	0cf964b16d	trailing newline .ftl check can happen at build time ... Removes the need to build ripgrep for CI	2020-11-01 14:59:45 +10:00
Damien Elmes	aea0a6fcc6	initial Bazel conversion ... Running and testing should be working on the three platforms, but there's still a fair bit that needs to be done: - Wheel building + testing in a venv still needs to be implemented. - Python requirements still need to be compiled with piptool and pinned; need to compile on all platforms then merge - Cargo deps in cargo/ and rslib/ need to be cleaned up, and ideally unified into one place - Currently using rustls to work around openssl compilation issues on Linux, but this will break corporate proxies with custom SSL authorities; need to conditionally use openssl or use https://github.com/seanmonstar/reqwest/pull/1058 - Makefiles and docs still need cleaning up - It may make sense to reparent ts/* to the top level, as we don't nest the other modules under a specific language. - rspy and pylib must always be updated in lock-step, so merging rspy into pylib as a private module would simplify things. - Merging desktop-ftl and mobile-ftl into the core ftl would make managing and updating translations easier. - Obsolete scripts need removing. - And probably more.	2020-11-01 14:26:58 +10:00
cecini	2606a8a489	align rslib get_subnode impl with anki pythonapi find_deck_in_tree, fix nestdeck due counts issue	2020-10-29 23:53:26 +08:00
Andreas Reis	6e9aaad11e	Add audio & object tags to media check ... Makes the media check recognize files in <audio> and <object> tags as used. They've been observed/supported by the WebView (checked: Anki, AnkiDroid) since just about forever already and are extremely useful if one knows a thing about web dev.	2020-10-25 13:09:57 +01:00
abdo	97ea14449f	Ensure non-empty names ... https://github.com/ankitects/anki/pull/801/	2020-10-22 16:11:06 +03:00
abdo	55f1d3773f	Strip double quotes from names ... Strip double quotes from all kinds of names https://github.com/ankitects/anki/pull/798	2020-10-21 21:48:49 +03:00
Damien Elmes	c96784c0eb	fix new clippy lints	2020-10-09 21:35:53 +10:00
Damien Elmes	90fa38495e	reindex when checking database ... Came across a user with a corrupt index: sqlite> pragma integrity_check; integrity_check = wrong # of entries in index ix_revlog_cid integrity_check = wrong # of entries in index ix_cards_sched This is not picked up by a quick check, and a vacuum does not fix it, but a reindex does. AnkiWeb currently performs a full check when a file is uploaded to it, so this was leading to "corrupt" to show up when syncing the collection, with a local DB check not reporting/fixing the issue.	2020-10-05 17:40:43 +10:00
Damien Elmes	955c1bafb9	fix * handling in unqualifed text as well ... https://forums.ankiweb.net/t/anki-2-1-desktop-searching-with-only-when-limited-to-a-field/3789/4	2020-09-29 21:18:19 +10:00
Damien Elmes	7e872de875	fix escaping of * in field search ... mentioned in https://github.com/ankitects/anki/pull/769	2020-09-27 16:04:08 +10:00
Damien Elmes	cc3fdb2f37	rename downgrade method for clarity	2020-09-22 15:53:26 +10:00
Damien Elmes	76acf04dc0	update schema to fix default initial ease in deck configs ... Closes #766 - changes the on-disk representation from % to a multiplier, eg 250 -> 2.5, as this is consistent with the other options - resets deck configs at or below 1.3 to 2.5 - for any cards that were using a reset deck config, reset their current factor if it's at or below 2.0x. The cutoff is arbitrary, and just intended to make sure we catch cards the user has rated Easy on multiple times. The existing due dates are left alone.	2020-09-22 08:16:39 +10:00
Damien Elmes	d74cc2e9b0	stop is:due gathering learning cards that are not due yet ... https://forums.ankiweb.net/t/how-to-avoid-rebuilding-filtered-decks-to-skip-learning-cards-steps/3551/	2020-09-21 11:41:54 +10:00
Damien Elmes	755a58b96c	fix incorrect SQL in previous change	2020-09-19 12:27:00 +10:00
Damien Elmes	91759694a1	congrats_info() failed if learning card had negative due ... https://forums.ankiweb.net/t/integralvalueoutofrange-for-filtered-deck/3353	2020-09-18 20:14:35 +10:00
Damien Elmes	8bde6749b1	sched_timing_today() needs a default rollover hour ... When unset it was reverting to the V1 code. https://forums.ankiweb.net/t/daily-counts-are-reset-on-sync/3441/16	2020-09-18 19:13:47 +10:00
Damien Elmes	caa703126c	check original due in card stats ... https://forums.ankiweb.net/t/how-come-some-of-my-cards-are-showing-retrospective-due-dates/3434/6	2020-09-17 14:36:18 +10:00
Aleksa Sarai	312393e825	rs: remove most &mut references in BackendService ... The previous implementation had some slightly questionable memory safety properties (older versions of PyO3 didn't uphold the Rust aliasing rules and would thus create multiple &mut references to #[pyclass] objects). This explains why Backend has internal Mutex<T>s even though all of its methods took &mut self. The solution is to simply make all methods take &self, which luckily doesn't pose too make issues -- most of the code inside Backend already has sufficient locking. The only two things which needed to be explicitly handled where: 1. "self.runtime" which was fairly easy to handle. All usages of the Runtime only require an immutable reference to create a new Handle, so we could switch to OnceCell which provides lazy-initialisation semantics without needing a more heavy-handed Mutex<tokio::runtime::Handle>. 2. "self.sync_abort" was simply wrapped in a Mutex<>, though some of the odd semantics of sync_abort (not being able to handle multiple processes synchronising at the same time) become pretty obvious with this change (for now we just log a warning in that case). In addition, switch to an RAII-style guard to make sure we don't forget to clear the abort_handle. As a result, we now no longer break Rust's aliasing rules and we can build with newer versions of PyO3 which have runtime checks for these things (and build on stable Rust). Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>	2020-09-05 19:37:59 +10:00
Damien Elmes	c82a084edf	handle quoted html chars in media check ... https://forums.ankiweb.net/t/unable-to-play-longer-audio-on-cards/1313/30	2020-09-04 09:36:38 +10:00
Damien Elmes	56ceb6ba76	set_deck()	2020-09-03 17:42:46 +10:00
Damien Elmes	9214c4a700	support did:[deck id] search	2020-09-03 16:43:22 +10:00
Damien Elmes	97778bec43	log 0 day interval as 1 day ... Allows distinguishing it from resetting to new, and is treated as a one day delay when answering anyway.	2020-09-03 16:00:06 +10:00
Damien Elmes	b65174a026	move card sorting and resetting to backend	2020-09-03 15:54:15 +10:00
Damien Elmes	e56f83be84	set local offset when saving preferences	2020-09-03 12:43:18 +10:00
Damien Elmes	ce49ca9401	log manual reschedule, but ignore the log entry in the stats	2020-09-02 17:56:23 +10:00
Damien Elmes	39212a38aa	move reschedCards() to backend	2020-09-02 17:56:23 +10:00
Damien Elmes	8f9037cf0f	move filtered deck empty/fill to backend ... emptying of individual card ids still to be done	2020-09-02 17:56:23 +10:00
Damien Elmes	a834df60ce	rename some card+note fields in backend	2020-09-01 10:24:38 +10:00
Damien Elmes	d3dede057a	move bury/suspend into backend	2020-09-01 10:24:38 +10:00
Damien Elmes	ccfa989c62	move unbury/unsuspend routines into backend	2020-09-01 10:24:38 +10:00
Damien Elmes	ac6397ae9e	add separate sched/user bury searches, and fix bury enums	2020-09-01 10:24:38 +10:00
Damien Elmes	b0a3861734	handle null return from sum() in other columns	2020-09-01 10:24:38 +10:00
Damien Elmes	e5685254c6	reimplement congrats screen in Rust+Typescript	2020-09-01 10:24:38 +10:00
Damien Elmes	9fcd6c66f4	fix nonbreaking spaces breaking media ... https://forums.ankiweb.net/t/unable-to-play-longer-audio-on-cards/1313	2020-08-30 11:23:12 +10:00
Soren Bjornstad	a3a1f49be1	fix unanchored regex in bulk tag add routine ... Previously, it was not possible to add a substring of an existing tag. For example, with the tag "foobar", you could not add the tag "foo", "bar" or "oob". Because the match was unanchored, the regex checking whether the tag already existed determined that the tag was present when it was not.	2020-08-28 16:21:23 -05:00
Damien Elmes	4662a9fe1a	check if we need to unbury at the start of the sync process ... https://forums.ankiweb.net/t/bug-buried-cards-in-filtered-decks-not-being-unburied-next-day/2541/24	2020-08-28 21:09:07 +10:00
Damien Elmes	a7e254e81d	catch leading/trailing boolean operators ... https://forums.ankiweb.net/t/is-it-only-me-anki-giving-corrupt-collection-error/2424/20	2020-08-27 09:59:29 +10:00
Damien Elmes	7bcec00ef4	fix some clippy lints	2020-08-26 19:02:56 +10:00
Damien Elmes	07151faae8	add escape hatch for very slow connections	2020-08-26 18:44:20 +10:00
Damien Elmes	06e00be985	specify I/O timeout ... We need to be a bit conservative here due to buffer bloat - in the upload case on a slow link, it can appear that no I/O is happening when a buffer is draining.	2020-08-26 18:30:51 +10:00
Damien Elmes	134765036c	don't crash when upgrading collection with ntid of 0	2020-08-23 14:14:44 +10:00
Damien Elmes	63b8b32602	normalize field before checking duplicates ... https://forums.ankiweb.net/t/unicode-normalisation/2531	2020-08-23 12:09:55 +10:00
Damien Elmes	4df89c7c26	ensure we don't crash on a zero field notetype	2020-08-23 12:09:36 +10:00
Damien Elmes	fa46ef9e37	fix empty cards not ignoring <br> ... https://forums.ankiweb.net/t/bug-report-empty-cards-are-not-recognized/2555	2020-08-23 11:44:49 +10:00
Damien Elmes	85d99f7348	catch timeout error	2020-08-21 19:03:23 +10:00
Damien Elmes	8a9a9591cb	ensure tag replacements fully match ... https://anki.tenderapp.com/discussions/private/5180-anki-desktop-bug-removing-a-tag-removes-all-substrings	2020-08-19 15:35:20 +10:00
Damien Elmes	529deff82a	strip nuls from tags as well ... https://forums.ankiweb.net/t/unable-to-sync-between-macbook-and-my-iphone/2405	2020-08-19 15:34:21 +10:00
Damien Elmes	dab0c9ef7c	catch attempt to update missing note ... https://forums.ankiweb.net/t/bug-report-editor-updating-non-existing-card/2117/4?u=dae	2020-08-17 19:44:27 +10:00
Damien Elmes	d24bd7609c	allow setting sort field before add	2020-08-17 19:44:09 +10:00
Damien Elmes	9e53c84a35	fix globs not working in bulk tag add/remove	2020-08-17 18:14:00 +10:00
Damien Elmes	63f8e510d8	journal mode was not being set on media db	2020-08-17 12:30:14 +10:00
Damien Elmes	85e2db8ab0	handle <%foo%> inside {{#conditional}} ... https://forums.ankiweb.net/t/the-latest-version-of-ios-cannot-display-the-template-normally/2142	2020-08-12 19:28:26 +10:00
Damien Elmes	9334272a27	generate extra templates when recovering notetype	2020-08-10 13:42:37 +10:00
Damien Elmes	e6e9cb348e	show ordinal if card template missing	2020-08-10 13:41:22 +10:00
Damien Elmes	06a69c25e6	fix assertion failure when recovering notetype ... Notes need to have their notetype ID updated to reflect the newly created notetype. https://forums.ankiweb.net/t/anki-crashes-on-sync-study-export/1978	2020-08-08 12:26:00 +10:00
Damien Elmes	8363719994	handle negative review times in sync	2020-08-07 15:02:03 +10:00
Damien Elmes	0180868b60	fix negative review times in DB check	2020-08-07 14:37:44 +10:00
Damien Elmes	41d37464e6	add some extra help to the json decode error	2020-08-07 13:13:11 +10:00
Damien Elmes	b363aaf401	handle some instances of floats when an integer is expected during sync	2020-08-03 17:47:15 +10:00
Damien Elmes	f1a30c243a	fix conditional negation being lost on field rename ... https://forums.ankiweb.net/t/anki-force-changes-all-to/1694	2020-08-02 10:09:24 +10:00
Damien Elmes	710127d490	fix moves into/out of a filtered deck not syncing ... the mtime comparison should have only been done if the object in the local collection was also pending	2020-07-31 15:39:30 +10:00
Damien Elmes	469272659f	fix hour graph not handling timezones west of UTC ... https://forums.ankiweb.net/t/statistics-bugs-after-update-2-1-5-to-2-1-29/1620	2020-07-31 13:33:41 +10:00
Damien Elmes	a1866e72fd	handle preview repeat in deck list	2020-07-30 09:11:13 +10:00
Damien Elmes	01d20044e7	reject double comma in id list ... https://forums.ankiweb.net/t/anki-2-1-29-and-below-2-small-bugs/1496	2020-07-29 13:05:34 +10:00
Damien Elmes	6f76b86f7c	handle multiple clozes in cloze-only filter ... https://forums.ankiweb.net/t/built-in-tts-not-reading-multiple-clozes/1516	2020-07-29 12:54:29 +10:00
Damien Elmes	7e7f2d0be4	clearer message when template error is preventing save	2020-07-29 12:53:03 +10:00
Damien Elmes	1737a15766	show card stats in reverse order like older Anki versions	2020-07-28 09:49:27 +10:00
Damien Elmes	2bed018768	fix note/card ids being flipped in card stats	2020-07-28 09:49:11 +10:00
Damien Elmes	6af5cb9f38	strip unwanted control characters when writing fields ... closes #661	2020-07-24 09:18:05 +10:00
Damien Elmes	10afe2883a	add cloze-only filter ... https://anki.tenderapp.com/discussions/ankidesktop/42383-two-feature-suggestions	2020-07-21 12:59:28 +10:00
Damien Elmes	61017a2e21	i18n some sync errors	2020-07-16 13:55:59 +10:00
Damien Elmes	fa239be124	add platform version back into sync metadata	2020-07-16 10:12:41 +10:00
Damien Elmes	75443b5171	update rslib/rspy deps	2020-07-12 11:38:25 +10:00
Damien Elmes	df319c7c58	is:review should include relearning cards ... https://forums.ankiweb.net/t/anki-2-1-28-beta/629/36 This issue appears to have existed since the V2 scheduler was introduced - the old Python search code was ignoring Relearn as well.	2020-07-09 11:07:50 +10:00
Damien Elmes	19541c4a9d	fix deck tree with a day delta, and support arbitrary timestamps	2020-07-06 19:16:03 +10:00
Damien Elmes	5574c0dfb3	set schema on collection creation	2020-07-03 11:55:27 +10:00
Damien Elmes	05fb67d409	show clearer error when media db locked ... should not happen frequently during a sync, but may happen during the initial change checking stage https://forums.ankiweb.net/t/error-when-adding-audio-file/495/2	2020-07-01 11:19:06 +10:00
Damien Elmes	f8ca1d122d	fix media db conflict aborting immediately instead of after 5s ... https://forums.ankiweb.net/t/error-when-adding-audio-file/495/2	2020-07-01 11:17:33 +10:00
Damien Elmes	7cd02eea8f	supported edited:n ... https://forums.ankiweb.net/t/feature-request-advanced-broswer-search-by-edited/268	2020-07-01 10:17:57 +10:00
Damien Elmes	d4cd4535e6	lint fixes	2020-06-29 15:53:56 +10:00
Damien Elmes	28a6755c75	i18n card counts	2020-06-29 15:48:01 +10:00
Damien Elmes	41d77b0255	get i18n working in typescript	2020-06-29 15:48:01 +10:00
Damien Elmes	0f1f80aebc	handle revlog entries with negative review times	2020-06-29 15:48:01 +10:00
Damien Elmes	31a422cf85	fix partially quoted text not handling escaped quotes ... https://forums.ankiweb.net/t/how-to-search-for-cards-containing-quotes/500/10	2020-06-29 15:48:01 +10:00
Damien Elmes	329186f140	qt's js code now shares ts/node_modules; more graph work	2020-06-29 15:48:01 +10:00
Damien Elmes	0cab26d40c	cards added graph	2020-06-29 15:48:01 +10:00
Damien Elmes	82568a1f3e	experiment with exposing raw card/revlog data to frontend	2020-06-29 15:48:00 +10:00
Damien Elmes	510f8b86cb	some initial work on updating the graphs	2020-06-29 15:48:00 +10:00
Damien Elmes	e231895cc2	fix v2 scheduler cutoff being used if previously activated	2020-06-23 12:46:40 +09:00
Damien Elmes	df009d142c	formatting fix	2020-06-22 11:58:31 +10:00
Damien Elmes	26fc6609a7	move revlog out of sync code, and add enums ... and remove type=4, which does not appear to be used	2020-06-16 16:31:36 +10:00
Damien Elmes	b51f03085e	migrate card stats to backend ... Currently this renders the HTML directly like the previous Python implementation - doing it in JS would probably make more sense in the future.	2020-06-15 17:22:16 +10:00
Damien Elmes	263bfb2e8e	on upgrade, mark decks modified that are renamed	2020-06-14 14:48:58 +10:00
Damien Elmes	8e895aa247	handle db errors the same way as other backend requests	2020-06-12 20:39:02 +10:00
Damien Elmes	cf6d4f1cb9	pass db json back as bytes	2020-06-12 20:20:29 +10:00
Damien Elmes	514c73f547	don't exclude the default deck from the normal name list ... https://forums.ankiweb.net/t/issue-backend-get-deck-names-doesnt-return-default-deck/52	2020-06-11 14:36:00 +10:00
Damien Elmes	10a1d06dce	use vendored hyper for panic fix	2020-06-11 13:30:35 +10:00
Damien Elmes	816cec4a58	fix review cards with high intervals not being reset properly ... would lead to a "fixed .. with invalid card property" message that didn't go away	2020-06-09 20:11:26 +10:00
Damien Elmes	1beed74464	switch default leech action to tag only	2020-06-09 12:03:47 +10:00
Damien Elmes	c77d017135	catch invalid regex in search ... https://github.com/ankitects/anki/pull/652	2020-06-09 11:46:07 +10:00
Damien Elmes	e5849aac4d	check full upload return text	2020-06-09 08:50:16 +10:00
Damien Elmes	7c444b4d35	add progress to db check	2020-06-08 21:07:36 +10:00
Damien Elmes	1fe18718f7	add daily count updating to backend	2020-06-05 19:49:53 +10:00
Damien Elmes	fee6cdff22	support generating a due tree for a different date	2020-06-05 09:38:31 +10:00
Damien Elmes	4a69b55a90	add note/card removal to backend	2020-06-04 18:21:04 +10:00
Damien Elmes	ebce044be5	"Template" special field should have been called "Card"	2020-06-02 16:47:30 +10:00
Damien Elmes	683d779c3f	automatically abort the media sync on full sync	2020-06-02 16:22:53 +10:00
Damien Elmes	519b8c3425	ensure sync indicator updates after download	2020-06-02 15:10:41 +10:00
Damien Elmes	35ee106503	fix full download on Windows	2020-06-02 15:06:23 +10:00
Damien Elmes	9acf318572	skip note update if unchanged	2020-06-02 13:32:36 +10:00
Damien Elmes	4d7e23111e	change sync label to indicate sync state ... - blue for normal sync, red for full sync required - refactor status fetching code so we don't hold a collection lock during the network request, which slows things down - fix sync spinner restarting when returning to deck list	2020-06-02 13:23:01 +10:00
Damien Elmes	ac219ae728	use a shared async runtime instead of recreating each time	2020-06-02 09:35:27 +10:00
Damien Elmes	2147f75bc5	add some syncing tests - please see alpha2 notes before syncing	2020-06-01 19:44:25 +10:00
Damien Elmes	cec5a260e5	fix \n in buildhash	2020-06-01 19:38:45 +10:00
Damien Elmes	4917cabeb9	handle missing counts in sanity check	2020-06-01 19:38:41 +10:00
Damien Elmes	403ac2715c	if both sides empty, allow either	2020-06-01 18:11:43 +10:00
Damien Elmes	3484897229	don't put dyn=False in schema11 dconf's "other"	2020-06-01 18:11:40 +10:00
Damien Elmes	d8b907e4e8	tell AnkiWeb to abort on interrupt	2020-06-01 13:57:10 +10:00
Damien Elmes	90e19daec2	handle aborting normal sync ... - Use a separate abort handle, as the media sync is running in the background and we need to be able to target them separately. The current progress handling is going to need a rethink if we introduce any other background tasks in the future. - Roll back the transaction when interrupting.	2020-06-01 13:57:10 +10:00
Damien Elmes	c6f0710ce7	report normal sync progress ... Also: - provide a way for the progress handler to skip the throttling so that we can ensure progress is updated at the end of a stage - show 'checking' at the end of full sync	2020-06-01 13:57:10 +10:00
Damien Elmes	529152aef6	rework usn handling in sync	2020-06-01 13:57:10 +10:00
Damien Elmes	5102255ff9	add due counts to sanity check	2020-06-01 13:57:10 +10:00
Damien Elmes	0e5b7da62a	login/full up/full down plugged in	2020-06-01 13:57:10 +10:00
Damien Elmes	ee6d7f82e7	rework progress handling ... - client now polls status instead of backend pushing it - supports multiple threads - update throttling happens in one place	2020-06-01 13:57:10 +10:00
Damien Elmes	b254b1f722	another snapshot of sync work ... progress handler is going to need to be reworked to function across threads	2020-06-01 13:57:10 +10:00
Damien Elmes	e4b43b8773	make sure we invalidate cache after direct update	2020-06-01 13:57:10 +10:00
Damien Elmes	f10d0ee0cb	more syncing work ... no checks yet	2020-06-01 13:57:10 +10:00
Damien Elmes	529e89f48e	full upload/download HTTP code	2020-06-01 13:57:10 +10:00
Damien Elmes	4fcb10bfa9	start on HTTP client for syncing	2020-06-01 13:57:10 +10:00
Damien Elmes	c8d13209cd	move dupe check to backend	2020-05-24 19:48:56 +10:00
Damien Elmes	38508c3ad7	use keyword args for calls with more than one argument	2020-05-24 09:12:47 +10:00
Damien Elmes	89dde3aeb0	migrate the remaining methods	2020-05-24 08:36:50 +10:00
Damien Elmes	4bf8175bcb	migrate more scheduling/media/etc ... almost there	2020-05-23 21:34:19 +10:00
Damien Elmes	a105037ec9	migrate notetypes, update GIL list	2020-05-23 20:43:55 +10:00
Damien Elmes	6710e3d528	add some more newtypes to the RPC defs	2020-05-23 16:58:01 +10:00
Damien Elmes	95735f106a	migrate cards and notes	2020-05-23 16:19:48 +10:00
Damien Elmes	7550e6241c	migrate decks and dconf methods	2020-05-23 15:09:16 +10:00
Damien Elmes	081a61a438	more methods	2020-05-23 14:01:36 +10:00
Damien Elmes	175afa9fee	migrate more methods to service	2020-05-22 22:09:33 +10:00
Damien Elmes	9c20d9a02b	start reworking protobuf handling ... Will allow us to cut down on boilerplate by automatically generating code from RPC service definitions	2020-05-22 20:56:15 +10:00
Damien Elmes	0c85397461	fix extending limits in custom study ... https://anki.tenderapp.com/discussions/beta-testing/1967-2126-189-g7384df8f-crash-at-note-types-fields-save	2020-05-20 14:13:40 +10:00
Damien Elmes	08f1843b67	automatically omit notes or cards table when possible	2020-05-19 11:27:02 +10:00
Damien Elmes	c238bbe173	fix unit test bug triggered by low resolution win32 timer ... We don't yet have a remove_note(), so just remove all cards for now.	2020-05-18 19:02:54 +10:00
Damien Elmes	f2594b071e	fix cutoff adjustment test in other timezones	2020-05-18 14:08:02 +10:00
Damien Elmes	cdbe7346ab	bytes->blob in sql	2020-05-18 13:36:45 +10:00
Damien Elmes	68465ae07b	protobuf tidyups	2020-05-18 09:26:14 +10:00
Damien Elmes	010f0f33b5	use empty buffer if the other map is empty in dconf	2020-05-18 08:12:27 +10:00
Damien Elmes	7ec3f1ecc0	fix syncing	2020-05-17 20:52:02 +10:00
Damien Elmes	803aeff16e	update current note type in backend	2020-05-17 20:01:16 +10:00
Damien Elmes	3cb870ec9c	ensure notetype name unique on add as well	2020-05-17 19:41:47 +10:00
Damien Elmes	7daa417dc8	fix renaming corner cases and decks.update() ... - .update() should update a single deck and preserve usn by default, as that's what existing code expects - decks are automatically renamed when they conflict with an existing name	2020-05-17 19:07:15 +10:00
Damien Elmes	df48fa8cf7	handle deletion of default deck in backend; use + instead of _	2020-05-17 15:22:19 +10:00
Damien Elmes	b9b837e7bd	update before_upload()	2020-05-17 14:13:21 +10:00
Damien Elmes	6114836484	move deck config to protobuf	2020-05-17 13:28:41 +10:00
Damien Elmes	54670580ad	add option to limit deck tree counts to a particular node	2020-05-17 08:38:49 +10:00
Damien Elmes	da43d22aa5	update rusqlite	2020-05-16 19:49:08 +10:00
Damien Elmes	78a6813b9b	when merging day# in deck, make sure to reset older values	2020-05-16 15:58:25 +10:00
Damien Elmes	efde279588	use the latest day when converting from legacy deck	2020-05-16 14:58:14 +10:00
Damien Elmes	f747063752	add a unit test for deck counts	2020-05-16 14:07:48 +10:00
Damien Elmes	f2086fc2e3	switch to new deck tree in deck browser ... Saves us having to look up collapsed/filtered as we render, and gives us type completion.	2020-05-16 10:52:14 +10:00
Damien Elmes	964a69e54e	handle default deck and filtered deck suppression in the backend	2020-05-15 21:21:10 +10:00
Damien Elmes	2ac33500eb	fetch stock notetypes from backend	2020-05-15 17:08:24 +10:00
Damien Elmes	00db72e365	show (Deck) when card hasn't been added	2020-05-15 15:01:28 +10:00
Damien Elmes	24ffb6ab76	check for empty cloze cards when rendering as well	2020-05-14 21:56:45 +10:00
Damien Elmes	782911471b	add "fill empty" checkbox	2020-05-14 20:58:45 +10:00
Damien Elmes	f23eb350e4	drop availOrds(), and use backend for getting cloze numbers	2020-05-14 12:14:00 +10:00
Damien Elmes	6680cdf1d3	update the card layout screen ... - changes are now committed in bulk when closing the dialog, and can be canceled - it's not necessary to save the note to the database to preview it - duplicate fields are now shown as duplicates in the top list - redraw preview more quickly - use + instead of _ when deduplicating names, as the latter is a glob character	2020-05-13 17:24:49 +10:00
Damien Elmes	12b8fe6147	don't hide static template text when card is empty	2020-05-13 11:17:44 +10:00
Damien Elmes	826cbb0108	fetch template and note fields in backend during normal card render ... Saves having to serialize the note fields and q/a templates, which is particularly a win when rendering question/answer in the browse screen. Also some work towards being able to preview notes without having to commit them to the database.	2020-05-13 10:38:49 +10:00
Damien Elmes	9874b19526	handle decks set to random new order ... It probably makes more sense to randomize on queue build in the future, but for now this imitates the previous Anki behaviour.	2020-05-12 21:13:34 +10:00
Damien Elmes	7597130145	return resolved deck to facilitate random order mode	2020-05-12 21:13:34 +10:00
Damien Elmes	9317cee9ba	handle scheduling preferences in the backend	2020-05-12 21:13:34 +10:00
Damien Elmes	ea4f150455	fetch timing_today() params in backend	2020-05-12 21:13:34 +10:00
Damien Elmes	eee0d7e92f	switch server back into a bool and rely on config	2020-05-12 21:13:34 +10:00
Damien Elmes	2c7900989c	fix default rollover	2020-05-12 21:13:34 +10:00
Damien Elmes	8af475ac6f	add tests for the other checks, and fix new card due limiting	2020-05-12 21:13:34 +10:00
Damien Elmes	9b1eee85d5	rename SortMode arg to match enum	2020-05-12 21:13:34 +10:00
Damien Elmes	2b47e544a8	add tests for card fixes; implement deck recovery	2020-05-12 21:13:34 +10:00
Damien Elmes	5ec7251f6e	stop using memory for sqlite temp store ... On large collections this can end up consuming hundreds of megabytes of RAM on operations like a vacuum.	2020-05-12 21:13:34 +10:00
Damien Elmes	70cc1699a6	rewrite DB check ... - notes with wrong field count are now recovered instead of being deleted - notes with missing note types are now recovered - notes with missing cards are now recovered - recover_missing_deck() still needs implementing - checks required	2020-05-12 21:13:34 +10:00
Damien Elmes	4c9b6be832	fetch notes in nid order ... May reduce the amount of seeking on conventional disks. Chunking and fetching batches of notes at once would improve things further, at the cost of more memory use.	2020-05-12 21:13:34 +10:00
Damien Elmes	2413f286b1	bulk tag add/remove/update; canonify on note save ... also remove the tag list updated hook - we'll need a better solution in the future than having the library code call back into the GUI code	2020-05-12 21:13:34 +10:00
Damien Elmes	389b8a0536	add the Extra field back to cloze deletions as "Back Extra" ... Originally removed because some users were adding cloze deletions to it, but removing it just replaced that problem with a new problem where users add the field but don't add it to their card templates.	2020-05-12 21:13:34 +10:00
Damien Elmes	7bab99d873	support disabling unicode normalization in notes	2020-05-12 21:13:34 +10:00
Damien Elmes	a7a485d550	use backend for genCards() and updateFieldCache()	2020-05-12 21:13:34 +10:00
Damien Elmes	8b557ec382	move find&replace to backend	2020-05-12 21:13:34 +10:00
Damien Elmes	51bdbdb414	properly handle negated conditionals outside of req generation	2020-05-12 21:13:34 +10:00
Damien Elmes	2308b136fd	add an index on notes(mid) so we can avoid the tablescan	2020-05-12 21:13:34 +10:00
Damien Elmes	996d408695	fix sort field check on save	2020-05-12 21:13:33 +10:00
Damien Elmes	5ff83fad08	catch attempts to overwrite notetype with older version	2020-05-12 21:13:33 +10:00
Damien Elmes	238441f2d9	use the backend for the deck due tree ... - approx 3x faster on a large test deck - counts are no longer capped to 1000 in the tree	2020-05-12 21:13:33 +10:00
Damien Elmes	5fb5338d97	add missing decks in backend ... - need to compare parents with unicode case folding - duplicate check enforced by the DB	2020-05-12 21:13:33 +10:00
Damien Elmes	67421e02ec	add browserCollapsed as part of tree build	2020-05-12 21:13:33 +10:00
Damien Elmes	a88bc1e836	speed up browser load by rendering deck tree in Rust and skipping counts	2020-05-12 21:13:33 +10:00
Damien Elmes	5cefece264	switch primary key to deck id	2020-05-12 21:13:33 +10:00
Damien Elmes	8d17edc1e6	rework aux table sorting ... Instead of inserting text into the aux table and sorting on the fly (which does a binary sort), we insert the ids in unicase-sorted order, and then sort based on the automatically assigned rowids - giving us faster sorts, and proper unicase folding.	2020-05-12 21:13:33 +10:00
Damien Elmes	8246ba148e	fix case sensitivity of notetype/template searches	2020-05-12 21:13:33 +10:00
Damien Elmes	3339c404b4	update searching code to use decks table	2020-05-12 21:13:33 +10:00
Damien Elmes	3ffb37270d	add partial index on odid, and search odid as well ... the odid != 0 check in cards_for_deck.sql is necessary for sqlite to be able to take advantage of the index	2020-05-12 21:13:33 +10:00
Damien Elmes	f592672fa9	add separate decks table, and start on moving deck handling to Rust ... The Python tests are passing, but there are still a number of issues to work through, and the table/protobuf schema is not yet finalized.	2020-05-12 21:13:33 +10:00
Damien Elmes	36531ea96d	add (currently disabled) check for missing/empty decks on card add	2020-05-12 21:13:33 +10:00
Damien Elmes	d3b27c302c	split decks into module	2020-05-12 21:13:33 +10:00
Damien Elmes	bb56e9bc20	remove notetype from cache when removing	2020-05-12 21:13:33 +10:00
Damien Elmes	6e1d2990a0	remove unused _updateRequired and associated code	2020-05-12 21:13:33 +10:00
Damien Elmes	8bde0d4ac1	remove :{} and leading/trailing whitespace from field names on save	2020-05-12 21:13:33 +10:00
Damien Elmes	8b0121b0ac	sort empty cards by notetype name	2020-05-12 21:13:33 +10:00
Damien Elmes	b476d071e7	don't include non-empty notes in the list	2020-05-12 21:13:33 +10:00
Damien Elmes	5ac3fb5514	handle negative due numbers when gathering existing cards	2020-05-12 21:13:33 +10:00
Damien Elmes	bee0eb1264	empty card handling	2020-05-12 21:13:33 +10:00
Damien Elmes	87cd119216	fix use counts not including unused note types	2020-05-12 21:13:33 +10:00
Damien Elmes	a181d9aa02	note type removal	2020-05-12 21:13:33 +10:00
Damien Elmes	d32935382d	update template on field removals as well	2020-05-12 21:13:33 +10:00
Damien Elmes	d6706e1f0e	handle changed sort field index	2020-05-12 21:13:33 +10:00
Damien Elmes	ea8e0ef6a2	update template when fields renamed	2020-05-12 21:13:33 +10:00
Damien Elmes	fb578a0c2d	switch to owned strings in ParsedTemplate ... will make it easier to cache the parsed results in the future, and handle field renames & other transformations	2020-05-12 21:13:33 +10:00
Damien Elmes	ca5843acea	only compare to previous note type if it exists	2020-05-12 21:13:33 +10:00
Damien Elmes	5471f5b1bf	adjust sort index on save	2020-05-12 21:13:33 +10:00
Damien Elmes	6cc2bdbf87	start on exposing notes and individual note type methods ... changes to note: - add_note() now takes a provided deck id instead of looking it up in the notetype - note type use counts fetched using a single table scan - make sure note type changes are persisted - expose optionalness of ords in templates and fields json	2020-05-12 21:13:33 +10:00
Damien Elmes	b89dd32f78	mod schema if field/templates changed ... Instead of throwing an error if schema not marked as changed, just mark it changed, as that way it can be included as part of the same transaction.	2020-05-12 21:13:33 +10:00
Damien Elmes	f86c2dc567	normal note types now generate a dummy card if required ... In the cloze deletion case, we already created a dummy card 0 when no cloze deletions were found. This change makes normal note types behave the same way - if no cards would be generated, a dummy card 0 is added to allow the note to be added. This also applies when modifying note types - it is now possible to delete card templates even if some notes only use that template, as a dummy card 0 will be generated for notes that end up with no cards left.	2020-05-12 21:13:33 +10:00
Damien Elmes	5c3e5c672f	use default deck for new note types	2020-05-12 21:13:33 +10:00
Damien Elmes	15ff279a96	cloze generation	2020-05-12 21:13:33 +10:00
Damien Elmes	83bcb084fe	template changes and card generation ... Cloze cards are not yet supported, missing decks are not handled, and more testing is still required.	2020-05-12 21:13:33 +10:00
Damien Elmes	c34e3e8096	fix infinite loop on unclosed {{/<%	2020-05-12 21:13:33 +10:00
Damien Elmes	a226f70733	cache notetypes	2020-05-12 21:13:33 +10:00
Damien Elmes	e8f4a75bd5	always fetch full notetype	2020-05-12 21:13:33 +10:00
Damien Elmes	527c8bf867	embed enum to avoid conflicts	2020-05-12 21:13:33 +10:00
Damien Elmes	f75fd5335d	more work towards note adding ... Still a prototype at this stage - we'll likely want a caching layer for note types, and I'm not sure of the merit of having fields in a separate table, since they're almost always required.	2020-05-12 21:13:33 +10:00
Damien Elmes	5d4f9dc3c0	handle legacy syntax in parser instead of modifying original template ... Simplifies things for the caller, and ensures legacy handling doesn't get accidentally forgotten	2020-05-12 21:13:33 +10:00
Damien Elmes	f24dc05c8d	the start of note adding, and note type changes	2020-05-12 21:13:33 +10:00
Damien Elmes	7c23deb562	add separate search_notes_only()	2020-05-12 21:13:33 +10:00
Damien Elmes	04f0ea8599	start work on field changes, and add search_cards to col	2020-05-12 21:13:33 +10:00
Damien Elmes	cc297f1dc6	move note db code to storage	2020-05-12 21:13:33 +10:00
Damien Elmes	da29d0fcae	move latex header and styling into separate files	2020-05-12 21:13:33 +10:00
Damien Elmes	a17ddfdccd	native struct for CardTemplate	2020-05-12 21:13:33 +10:00
Damien Elmes	9080f602b1	native struct for NoteField ... ord is made optional so we can keep track of changes in the future	2020-05-12 21:13:33 +10:00
Damien Elmes	8cfb1fad44	use native struct for NoteType	2020-05-12 21:13:33 +10:00
Damien Elmes	d6646a6db5	expose stock notetypes	2020-05-12 21:13:33 +10:00
Damien Elmes	540892639f	add stock note types in backend	2020-05-12 21:13:33 +10:00
Damien Elmes	32bc1e88eb	migrate the schema11 usages to new structs/sql queries	2020-05-12 21:13:33 +10:00
Damien Elmes	e2b978e7cb	move schema11 note type code into separate file	2020-05-12 21:13:33 +10:00
Damien Elmes	805a3a710e	split note types into separate tables ... - store the config in protobuf instead of json - still loading+saving in bulk for now - code using the schema11 structs needs to be migrated	2020-05-12 21:13:33 +10:00
Damien Elmes	66809dd8a3	ignore empty sound tags ... https://github.com/ankitects/anki/pull/612	2020-05-12 20:53:50 +10:00
Damien Elmes	1de8d4baaf	fix a unit test	2020-05-08 17:27:41 +10:00
Damien Elmes	3f534b8c86	fix dupe search with included formatting ... https://anki.tenderapp.com/discussions/ankidesktop/41286-2125-doesnt-show-duplicates	2020-05-08 15:26:45 +10:00
Damien Elmes	38a109a5bf	tolerate decks with missing mtime exported by third party software	2020-05-02 10:18:08 +10:00
Damien Elmes	898801ebda	reset due on load if outside i32 bounds ... Some third party clients that create apkg files appear to be saving a millisecond timestamp into this column. While this could also be solved by increasing this field to a 64 bit number, some older clients expect this column to be a 32 bit number.	2020-04-30 11:57:35 +10:00
Damien Elmes	c95983ac1f	preserve entities when stripping HTML for MathJax ... https://anki.tenderapp.com/discussions/ankidesktop/40987-how-to-render-angled-brackets	2020-04-30 11:17:38 +10:00
Damien Elmes	e27d015ff9	expose clock hack via env var ... closes #594	2020-04-30 09:33:02 +10:00
Damien Elmes	a4d33dbdb0	report filename when unable to read data	2020-04-30 08:02:08 +10:00
Damien Elmes	18a6218a77	don't throw an error when a file is greater than MAXPATH ... https://anki.tenderapp.com/discussions/ankidesktop/40931-check-media-error	2020-04-30 08:01:45 +10:00
Damien Elmes	4e33775ed4	drop type answer requirement special case ... While it makes no sense to have the typing box on the front without another non-empty field, "the front of this card is empty" when a typing box is on the template seems to be confusing some users, so it is clearer to show them the box.	2020-04-29 21:29:16 +10:00
Damien Elmes	d36bd33972	AnkiDroid expects timer to be an integer ... https://github.com/ankidroid/Anki-Android/issues/6089#issuecomment-621110598	2020-04-29 20:52:00 +10:00
Damien Elmes	8dfd362fed	support globbing chars inside word boundary search	2020-04-25 09:43:08 +10:00
Damien Elmes	fd844a0d5a	add w: shortcut for searching on word boundaries	2020-04-25 08:48:01 +10:00
Damien Elmes	37bc44a8f5	report the missing filename in media check ... https://anki.tenderapp.com/discussions/ankidesktop/40578-check-media-error	2020-04-17 17:17:42 +10:00
Damien Elmes	f18f4e387b	older clients require 'separate' on filtered decks ... the deckconf['new']['separate' property is unused, but older code assumes filtered['separate'] exists, even though it doesn't do anything with it https://anki.tenderapp.com/discussions/beta-testing/1868-anki-2124-beta#comment_48240796	2020-04-15 15:02:12 +10:00
Damien Elmes	b55742509a	embed sort kind enum to avoid future namespace conflicts	2020-04-14 20:31:10 +10:00
Damien Elmes	6e6776aab2	fix dyn being serialized as bool ... If you were running from git in the last ~30 hours, please load your collection using the latest git, review one card, then force a full upload to fix compatibility with other clients.	2020-04-10 18:07:59 +10:00
Damien Elmes	bbceeacf0b	merge the 12-14 upgrade code	2020-04-10 17:46:57 +10:00
Damien Elmes	4c7210b430	(de)serialize decks in backend	2020-04-09 12:41:59 +10:00
Damien Elmes	36ec7830a9	load/save note types in backend ... This allows us to normalize bad data, and is the first step towards splitting note types into separate tables.	2020-04-08 10:05:07 +10:00
Damien Elmes	c29184d874	skip terminal logging unless LOGTERM defined ... seems to be quite slow on Windows	2020-04-07 10:25:47 +10:00
Damien Elmes	c950a00610	Cow<str> workaround no longer required	2020-04-07 10:08:03 +10:00
Damien Elmes	caa513899d	update rusqlite for param count assert fix	2020-04-07 08:54:57 +10:00
Damien Elmes	62fa265213	avoid warning on int sortBackwards from older Anki versions	2020-04-06 17:11:03 +10:00
Damien Elmes	75faba1667	add separate json error	2020-04-06 16:29:31 +10:00
Damien Elmes	03db16460a	log to the terminal as well	2020-04-06 15:57:13 +10:00
Damien Elmes	dc62d5072c	use bytes for deck config proto	2020-04-06 15:39:47 +10:00
Damien Elmes	164bd29438	use bytes for config proto	2020-04-06 15:39:47 +10:00
Damien Elmes	5a0203c7b4	display warning when config load fails	2020-04-06 15:39:47 +10:00
Damien Elmes	34cca119e3	use blobs for config	2020-04-06 15:39:47 +10:00
Damien Elmes	676f4e74a8	store config in separate DB table ... - mtime is tracked on each key individually, which will allow merging of config changes when syncing in the future - added col.(get|set|remove)_config() - in order to support existing code that was mutating returned values (eg col.conf["something"]["another"] = 5), the returned list/dict will be automatically wrapped so that when the value is dropped, it will save the mutated item back to the DB if it's changed. Code that is fetching lists/dicts from the config like so: col.conf["foo"]["bar"] = baz col.setMod() will continue to work in most case, but should be gradually updated to: conf = col.get_config("foo") conf["bar"] = baz col.set_config("foo", conf)	2020-04-06 15:39:47 +10:00
Damien Elmes	0750ad5c62	fix duplicates search	2020-04-04 17:38:35 +10:00
Damien Elmes	7375a0389a	add flag to skip downgrade on collection close ... Disabled for now; when enabled it will allow faster collection open and close in the normal case, while continuing to downgrade when exporting or doing a full sync. Also, when downgrading is disabled, the journal mode is no longer changed back to delete.	2020-04-04 17:21:45 +10:00
Damien Elmes	45ea0ddefd	use separate schema version for tag changes ... Will prevent issues if user upgrades after an unclean shutdown	2020-04-04 10:14:51 +10:00
Damien Elmes	3b619c4ca5	use case folding when sorting in canonify	2020-04-03 19:34:46 +10:00
Damien Elmes	ac4284b2de	update tag handling ... - tag list stored in a separate DB table - non-wildcard searches now do full unicode case folding (eg tag:masse matches 'Maße') - wildcard matches do simple unicode case folding - some functions haven't been updated yet, so ascii folding will continue to be used in some operations	2020-04-03 19:34:46 +10:00
Damien Elmes	333d0735ff	preserve mtime/usn when syncing deck config, and add snake_case names	2020-04-03 19:34:46 +10:00
Damien Elmes	70a1992f70	fix is:due search	2020-04-02 09:33:05 +10:00
Damien Elmes	c68a2fc838	return interrupted err when media sync aborted	2020-04-01 21:40:14 +10:00
Damien Elmes	546f4b44fc	FString -> TR	2020-04-01 18:16:43 +10:00
Damien Elmes	dfa1ce6429	translate default deck config name	2020-04-01 17:49:25 +10:00
Damien Elmes	a5940e3557	add fixme	2020-04-01 17:36:33 +10:00
Damien Elmes	d396460332	ignore .DS_Store in trash ... https://anki.tenderapp.com/discussions/ankidesktop/40035-anki-2123-on-macos-ds_store-files-in-new-anki-trash	2020-04-01 13:37:57 +10:00
Damien Elmes	6495240914	add some timeouts ... I'm waiting to hear back from the reqwests author on the best way to handle this. For now, this change just adds short timeouts to the quick requests, and will wait for up to an hour when sending/ receiving files to allow for the slow connection+large file case.	2020-04-01 10:03:54 +10:00
Damien Elmes	c9da4bc1a6	allow aborting a media sync while http req in flight ... The progress handling code needs a rethink, as we now have two separate ways to flag that the media sync should abort. In the future, it may make sense to switch to polling the backend for progress, instead of passing a callback in.	2020-04-01 09:49:25 +10:00
Damien Elmes	35c03af520	split deck config into separate SQL table ... - on collection load, the schema is upgraded to 12 - on collection close, the changes are reversed so older clients can continue to open the collection - in the future, we could potentially skip the reversal except when exporting/doing a full sync - the same approach should work for decks, note types and tags in the future too - the deck list code needs updating to cache the deck confs for the life of the call	2020-03-30 20:01:16 +10:00
Damien Elmes	004cc2b5f8	move deck conf handling to backend	2020-03-30 14:39:46 +10:00
Damien Elmes	bf83715ee0	initial work on undo support	2020-03-29 17:52:16 +10:00
Damien Elmes	f90e5dbe2c	remove usn cache ... SqliteStorage no longer contains any mutable state	2020-03-29 12:50:38 +10:00
Damien Elmes	d1ecf33c72	cache timing_today in collection, update it when cutover reached	2020-03-29 12:26:24 +10:00
Damien Elmes	fdeca610b0	drop separate RequestContext/StorageContext	2020-03-29 12:12:35 +10:00
Damien Elmes	2810d3883b	roll back the vec cache changes ... prepare_cached() is sufficiently fast, and allowing the vec cache to persist across calls is complicated due to lifetime restrictions	2020-03-29 09:26:09 +10:00
Damien Elmes	1a1a00d50f	Revert "add benchmark for vec cache" ... This reverts commit 82ed288dc5.	2020-03-29 09:16:11 +10:00
Damien Elmes	84b84ae31c	use add_card()	2020-03-27 15:11:07 +10:00
Damien Elmes	6b9378fb41	add (unused) add_card, and move sql to separate files	2020-03-27 14:48:25 +10:00
Damien Elmes	82ed288dc5	add benchmark for vec cache ... test storage::sqlite::bench::bench_hash_cache ... bench: 399 ns/iter (+/- 27) test storage::sqlite::bench::bench_no_cache ... bench: 4,854 ns/iter (+/- 499) test storage::sqlite::bench::bench_vec_cache ... bench: 0 ns/iter (+/- 0)	2020-03-27 09:59:48 +10:00
Damien Elmes	2f4e35d566	store cached statements in a vec instead of separate optionals	2020-03-27 09:51:19 +10:00
Damien Elmes	369d2d89d9	update card in transaction	2020-03-27 07:58:25 +10:00
Damien Elmes	7f16f436c3	handle mtime/usn bump in backend, and tweak integer sizes	2020-03-26 20:55:04 +10:00
Damien Elmes	7a56d18539	report invalid type/queue	2020-03-26 19:32:35 +10:00
Damien Elmes	47504245dc	update_card()	2020-03-26 18:54:20 +10:00
Damien Elmes	7ddaf93f7a	use backend to get card	2020-03-26 17:47:43 +10:00
Damien Elmes	8abba00496	DeckID, CardID	2020-03-26 15:10:40 +10:00
Damien Elmes	f52e775354	NoteTypeID	2020-03-26 15:00:24 +10:00
Damien Elmes	4ec30e412a	newtype NoteID	2020-03-26 14:42:43 +10:00
Damien Elmes	5eed3d7f71	use a macro for newtype defs	2020-03-26 13:50:20 +10:00
Damien Elmes	39f916a23e	usn newtype	2020-03-26 13:06:02 +10:00
Damien Elmes	eb89a2db3f	use newtypes for distinguishing between second and millisecond stamps	2020-03-26 12:59:51 +10:00
Damien Elmes	289bdde20c	handle fields with embedded nuls	2020-03-24 14:53:33 +10:00
Damien Elmes	11a4d582b4	convert asc to desc instead of appending desc to the end of the order ... as the latter doesn't work when sorting on more than one column https://anki.tenderapp.com/discussions/beta-testing/1868-anki-2124-beta#comment_48174812	2020-03-23 19:53:57 +10:00
Damien Elmes	14a970e923	rename long filenames in fields if files renamed in a previous sync	2020-03-23 18:38:45 +10:00
Damien Elmes	4e2e0d1b84	fix setting of wal	2020-03-23 13:52:57 +10:00
Damien Elmes	430f1ad616	handle trailing whitespace inside group	2020-03-22 18:52:44 +10:00
Damien Elmes	25ff4642ec	accept now_mins_west for v2 legacy timing as well	2020-03-22 17:33:14 +10:00
Damien Elmes	69d8cdd9ed	use backend for v1 and v2 cutoff calculations ... this should also fix the CI failures, which were happening because the datetime module wasn't matching the shifted time.time()	2020-03-22 14:28:26 +10:00
Damien Elmes	47fcdd0723	possible fix for CI failure	2020-03-22 13:17:00 +10:00
Damien Elmes	f28e57a367	add enum for controlling sort order ... eg col.find_cards("", order=BuiltinSortKind.CARD_DUE)	2020-03-22 12:59:24 +10:00
Damien Elmes	199713a39a	handle collections with sortBackwards set to 0 instead of a bool	2020-03-22 10:26:09 +10:00
Damien Elmes	cc44523449	remove debugging line	2020-03-21 18:29:04 +10:00
Damien Elmes	9696e959be	increase the rated search cap to 365, and allow searches for ease 0 ... An add-on appears to use ease 0 when rescheduling cards, and it may make sense for Anki to do the same in the future as well.	2020-03-21 16:05:17 +10:00
Damien Elmes	51a379de23	add search that ignores combining chars ... On a test of a ~40k card collection, the 'ignore accents' add-on takes about 1150ms, and this code takes about 70ms.	2020-03-21 15:15:59 +10:00
Damien Elmes	f0ed34d79b	support regexp search in single field	2020-03-21 13:06:46 +10:00
Damien Elmes	97577dbc16	support wildcard in field*:val search	2020-03-21 12:45:25 +10:00
Damien Elmes	08e64d246d	don't require wildcard for unicode case folding in search	2020-03-21 12:44:56 +10:00
Damien Elmes	4ff17d31b3	add unicase collation ... sqlite's like is hard-coded to use ASCII comparisons, so we can't take advantage of this yet	2020-03-21 12:40:20 +10:00
Damien Elmes	d1ebdbdcce	support regex searches	2020-03-21 12:00:48 +10:00
Damien Elmes	2dc1b5c982	add regexp() to sqlite	2020-03-21 10:23:11 +10:00
Damien Elmes	2aab44d9ce	support deck:"foo bar" style searches	2020-03-21 09:34:24 +10:00
Damien Elmes	a5787781d7	add note searching	2020-03-21 09:00:05 +10:00
Damien Elmes	aee64016ac	fix formatting and unit test	2020-03-21 08:17:24 +10:00
Damien Elmes	3a4146560c	handle escaped tag searches and tag:* special case	2020-03-21 08:09:28 +10:00
Damien Elmes	ad09c89c3c	check for child decks case-insensitively	2020-03-21 07:57:07 +10:00
Damien Elmes	c3314d3689	don't crash when card:0 passed in	2020-03-21 07:56:55 +10:00
Damien Elmes	124357bd82	handle * in single-field search	2020-03-21 07:56:32 +10:00
Damien Elmes	949252d438	fix ease search	2020-03-21 07:56:09 +10:00
Damien Elmes	5debd3e0f8	add the ability to provide a custom sort order; use backend for find	2020-03-21 07:55:21 +10:00
Damien Elmes	09a76967e7	support sorting on tags ... I don't personally understand it, but some users seem to want it.	2020-03-20 21:15:23 +10:00
Damien Elmes	00d0447ecb	support sorting on note type, card template and decks	2020-03-20 21:15:23 +10:00
Damien Elmes	2c362d6991	search order	2020-03-20 21:15:23 +10:00
Damien Elmes	d94effcdc7	fix is:new/is:review	2020-03-20 21:15:23 +10:00
Damien Elmes	79697746a4	added needs to use milliseconds	2020-03-20 21:15:23 +10:00
Damien Elmes	c90670ec3a	tolerate some string IDs	2020-03-20 21:15:23 +10:00
Damien Elmes	224bad2566	handle empty searches and leading/trailing whitespace	2020-03-20 21:15:23 +10:00
Damien Elmes	67cb27bada	add remaining tests and fix some clippy lints	2020-03-20 21:15:23 +10:00
Damien Elmes	8c158a3897	fix rated and state searches	2020-03-20 21:15:23 +10:00
Damien Elmes	37ad664afc	fix tags, more tests	2020-03-20 21:15:23 +10:00
Damien Elmes	fa654a0e22	fix cards	2020-03-20 21:15:23 +10:00
Damien Elmes	425a9d04ca	fix decks	2020-03-20 21:15:23 +10:00
Damien Elmes	2693e142aa	fix added	2020-03-20 21:15:23 +10:00
Damien Elmes	5df04b161c	fix qualified search	2020-03-20 21:15:23 +10:00
Damien Elmes	c723adea17	fix escape handling, and handle sql wildcards	2020-03-20 21:15:23 +10:00
Damien Elmes	b70668d31c	avoid extra sql binding in unqualified search	2020-03-20 21:15:23 +10:00
Damien Elmes	1f9e8e388a	start on search tests	2020-03-20 21:15:23 +10:00
Damien Elmes	bca5f2ddff	prototype of integration ... no ordering yet, and no tests	2020-03-20 21:15:23 +10:00
Damien Elmes	9752de5aaa	finish the remaining searches ... Searches that require multiple deck or note type lookups won't perform very well at the moment - it either needs caching or to be split up at the DB level. Nothing tested yet.	2020-03-20 21:15:23 +10:00
Damien Elmes	85af35509d	ctx->req	2020-03-20 21:15:23 +10:00
Damien Elmes	dc12c23ce9	add timing to search	2020-03-20 21:15:23 +10:00
Damien Elmes	2beccd377b	add v1 and v2 legacy timing code	2020-03-20 21:15:23 +10:00
Damien Elmes	9f3cc0982d	deck searching ... A bit more complicated than it needs to be, as we don't have the full deck manager infrastructure yet.	2020-03-20 21:15:23 +10:00
Damien Elmes	f559ae3ef8	address some clippy lints	2020-03-20 21:15:23 +10:00
Damien Elmes	cc54e92756	move html stripping out of field_checksum into caller	2020-03-20 21:15:23 +10:00
Damien Elmes	7eab504126	add field_at_index() sql func	2020-03-20 21:15:23 +10:00
Damien Elmes	cffa52ff82	more searching work	2020-03-20 21:15:23 +10:00
Damien Elmes	761d1d1812	add card queue/type enums	2020-03-20 21:15:23 +10:00
Damien Elmes	91d7b02325	separate out template ordinal and name search	2020-03-20 21:15:23 +10:00
Damien Elmes	dcb2b46d1b	use .eq_ignore_ascii_case() to avoid allocating	2020-03-20 21:15:23 +10:00
Damien Elmes	68657c7166	field_checksum needs to strip HTML	2020-03-20 21:15:23 +10:00
Damien Elmes	4f93ae4b6d	start of searching sql	2020-03-20 21:15:23 +10:00
Damien Elmes	00300bb24d	ensure rated ease in range	2020-03-20 21:15:23 +10:00
Damien Elmes	e790367b1e	ensure id list not empty	2020-03-20 21:15:23 +10:00
Damien Elmes	08d205d377	decode search terms in parser	2020-03-20 21:15:23 +10:00
Damien Elmes	289318d92c	split up searches with a qualifier	2020-03-20 21:15:23 +10:00
Damien Elmes	f623f19b3d	basic search parsing	2020-03-20 21:15:23 +10:00
Damien Elmes	72bcef917e	release mutex before beginning media sync ... And check media sync is not running on close	2020-03-20 21:15:23 +10:00
Damien Elmes	5f19048c93	fix media sync being logged to console	2020-03-20 21:15:23 +10:00
Damien Elmes	ba17567617	drop the separate i18n backend	2020-03-20 21:15:23 +10:00
Damien Elmes	874bc085fe	support opening and closing the DB while keeping backend alive ... This is safer than just dropping the backend, as .close() will block if something else is holding the mutex. Also means we can drop the extra I18nBackend code. Media syncing still needs fixing.	2020-03-20 21:15:23 +10:00
Damien Elmes	94e4c40ebf	move media folder/db paths into collection ... this breaks background media syncing for now	2020-03-20 21:15:23 +10:00
Damien Elmes	649b40371b	drop unused col_path	2020-03-20 21:15:23 +10:00
Damien Elmes	1322d8c617	make the collection optional	2020-03-20 21:15:23 +10:00
Damien Elmes	db1508e27c	support first_row_only	2020-03-20 21:15:23 +10:00
Damien Elmes	e14c5e4745	proper implementation of executemany(); drop executescript()	2020-03-20 21:15:23 +10:00
Damien Elmes	14546c8a8b	wrap the collection in a mutex so DB access is thread safe	2020-03-20 21:15:23 +10:00
Damien Elmes	47c142a74c	move note code into notes.rs, add ability to rollback when unchanged	2020-03-20 21:15:23 +10:00
Damien Elmes	ae06b9e446	add Collection struct, and get media check working again ... - media check no longer needs collection to be closed - use savepoints for operations initiated by Rust, so they are atomic without forcing a commit	2020-03-20 21:15:23 +10:00
Damien Elmes	2cd7885ec0	add begin/commit/rollback, and support creating collections ... all but one unit test is now passing	2020-03-20 21:15:23 +10:00
Damien Elmes	b51e575a9d	drop the protobuf prototype	2020-03-20 21:15:23 +10:00
Damien Elmes	b876d97770	use (or)json for DB bridge ... Some initial testing with orjson indicates performance varies from slightly better than pysqlite to about 2x slower depending on the type of query. Performance could be improved by building the Python list in rspy instead of sending back json that needs to be decoded, but it may make more sense to rewrite the hotspots in Rust instead. More testing is required in any case.	2020-03-20 21:15:23 +10:00
Damien Elmes	04ca8ec038	initial work on DB handling in Rust ... committing the Protobuf implementation for posterity, but will replace it with json, as Protobuf measures about 6x slower for some workloads like 'select * from notes'	2020-03-20 21:15:23 +10:00
Damien Elmes	e3a57a4193	fix clippy lint on other platforms	2020-03-19 10:58:52 +10:00
Damien Elmes	617b18ff49	correctly handle NFD content in media DB from older Anki versions	2020-03-19 10:20:42 +10:00
Damien Elmes	5e676db4a0	fix fallback preferences being used instead of English ... Check needs to be done regardless of if we found a regional variant or not.	2020-03-12 18:02:15 +10:00
Damien Elmes	9736e4a970	ignore remote file links in media check	2020-03-10 13:46:52 +10:00
Damien Elmes	0f4c3ab611	add restore media action	2020-03-10 13:35:09 +10:00
Damien Elmes	6ad2a1f9a3	add empty trash action in aqt	2020-03-10 12:49:40 +10:00
Damien Elmes	255d6f8af7	don't clean up the trash folder automatically ... The media check now reports if any files are in the trash folder, and a method has been exposed to clear the trash.	2020-03-10 12:02:38 +10:00
Damien Elmes	67d6b4f713	add basic log rotation	2020-03-10 10:33:14 +10:00
Damien Elmes	6e30572e6d	log sync errors	2020-03-10 09:43:48 +10:00
Damien Elmes	b4af0ca825	tweak logging	2020-03-10 09:30:05 +10:00
Damien Elmes	18cd841246	don't try to read file data when file marked as a deletion ... If the user hadn't used the media check to clean up files with invalid names on disk, the long filename would break the 'automatically rename long filenames when syncing' functionality, causing the original long filename to be uploaded to AnkiWeb as an addition instead of a deletion	2020-03-10 09:29:36 +10:00
Damien Elmes	2f20be7a5a	fix incorrect mark_collection_modified() ... - usn shouldn't be changed - mtime is in milliseconds	2020-03-05 14:55:03 +10:00
Damien Elmes	ba4fe71eba	make logging explicit, and support logging to a file	2020-02-29 20:44:01 +10:00
Damien Elmes	3a1fc74ec3	remove some unused imports	2020-02-29 15:21:11 +10:00
Damien Elmes	801c5fcc40	don't require a media scan after media deleted inside Anki	2020-02-29 14:45:16 +10:00
Damien Elmes	4781ed4d70	fix display of years	2020-02-28 17:14:35 +10:00
Damien Elmes	b4c3bf99ab	extra newline in network details	2020-02-27 11:22:48 +10:00
Damien Elmes	67942b54f5	use debug description for untranslated errors; fix template error	2020-02-27 11:07:18 +10:00
Damien Elmes	b610ff781f	info is superfluous	2020-02-27 10:53:49 +10:00
Damien Elmes	644670d0d6	return a localized error for all error kinds ... some errors are not yet localized, but now the Python code doesn't need to think about which property to use	2020-02-27 10:46:24 +10:00
Damien Elmes	fbbbbd6a7d	tweak rounding ... - avoid rounding minutes - round the seconds taken in the card info screen - provide different precise and imprecise modes, since we need to display seconds to multiple decimals in some areas	2020-02-25 17:29:06 +10:00
Damien Elmes	b1a192b384	cap answer buttons to 1 decimal place ... we can switch to NUMBER() instead in the future, but will need to update all the translations at the same time	2020-02-25 13:24:29 +10:00
Damien Elmes	c58b4158a7	use Fluent's number formatting; don't show trailing zeros ... We can add NUMBER() in the future for more control, but this will do for the time being.	2020-02-25 13:22:41 +10:00
Damien Elmes	9f7c3a2fcf	expand clozes before rendering LaTeX ... https://anki.tenderapp.com/discussions/ankidesktop/39071-latex-media-windows-version-2121-683b7983-fail-rendering-latex	2020-02-24 18:34:08 +10:00
Damien Elmes	0e931808c9	translations no longer require an open collection	2020-02-23 14:57:02 +10:00
Damien Elmes	4430c67069	rework Fluent handling ... - all .ftl files for a language are concatenated into a single file at build time - all languages are included in the binary - external ftl files placed in the ftl folder can override the built-in definitions - constants are automatically generated for each string key - dropped the separate StringsGroup enum	2020-02-23 13:22:50 +10:00
Damien Elmes	05d7852910	fix message references	2020-02-22 21:48:14 +10:00
Damien Elmes	ecc0298f65	add file prefix to fluent keys so we can merge the files at build	2020-02-22 20:26:15 +10:00
Damien Elmes	f8c4fb5e29	make sure English takes priority if it's listed first	2020-02-21 22:01:35 +10:00
Damien Elmes	6fd3d1e8b4	add deck config category	2020-02-21 20:53:20 +10:00
Damien Elmes	f4b9aff58a	reviews	2020-02-21 20:36:22 +10:00
Damien Elmes	9744736273	fix comment	2020-02-21 20:10:58 +10:00
Damien Elmes	972aee5f7a	add next learning due time + remaining count to congrats screen ... https://anki.tenderapp.com/discussions/ankidesktop/38000-v2-scheduler-learning-cards	2020-02-21 19:54:50 +10:00
Damien Elmes	49fe080636	add studied_today(), move to statistics.ftl	2020-02-21 18:01:15 +10:00
Damien Elmes	0fbe59cd57	add average-answer-time to Fluent ... drop the 0.1 special case; we're using two decimals now	2020-02-21 17:42:55 +10:00
Damien Elmes	71e7568904	remove unused import	2020-02-21 15:29:38 +10:00
Damien Elmes	d69a98a0d4	add 'studied-today' to Fluent ... The string has been constructed in parts so the old translations could be preserved	2020-02-21 15:29:38 +10:00
Damien Elmes	2fc15d0d3a	add non-abbreviated timespan translation; update existing short=True calls ... - drop the '5m3s' special casing done in the card stats screen, and just use decimals - change alignment of the review log so that the non-abbreviated spans are easier to read	2020-02-21 15:29:38 +10:00
Damien Elmes	99c07cfdcb	move answer_button_time to the backend, split sched into separate module	2020-02-21 15:29:38 +10:00
Damien Elmes	232a8625bf	move answer button labels into fluent	2020-02-21 15:29:38 +10:00
Damien Elmes	370bb38b8b	update to latest fluent-rs and add basic locale-aware decimals ... - git version pinned at the moment until the concurrency fix lands in 0.10.2 - currently float values are hard-coded at 2 decimal places; we should switch to using NUMBER() in the future	2020-02-21 15:29:38 +10:00
Damien Elmes	e0951e4cfe	add 'new #' prefix to new cards in the due column	2020-02-18 11:16:15 +10:00
Damien Elmes	44053f0715	fix deletion notices being sent unnecessarily	2020-02-17 17:21:58 +10:00
Damien Elmes	1524e7dcac	split "Due" into three different contexts for translators	2020-02-17 14:41:01 +10:00
Damien Elmes	771452c227	media check required message is no longer required	2020-02-17 13:51:33 +10:00
Damien Elmes	cb9ebf748c	match older string	2020-02-17 13:41:02 +10:00
Damien Elmes	63f08535e9	add some more comments	2020-02-17 11:43:18 +10:00
Damien Elmes	d612aa0945	localize some error messages	2020-02-17 11:38:22 +10:00
Damien Elmes	67a741958c	use new i18n infrastructure for more media check / media sync strings	2020-02-17 10:18:20 +10:00
Damien Elmes	0217cff099	add some comments to card-template-rendering.ftl	2020-02-17 09:06:54 +10:00
Damien Elmes	c395003def	expose translations to Python	2020-02-17 08:40:17 +10:00
Damien Elmes	4fe47b7be4	cache i18n categories	2020-02-17 08:40:17 +10:00
Damien Elmes	9247e5de7d	don't hard-code available ftl languages ... Instead of trying to define which languages we support, just check if an appropriate folder is available on disk. This allows users to drop their own translations into the locale folder and have things just work.	2020-02-17 08:40:17 +10:00
Damien Elmes	8cd76bee92	wrap i18n struct in a shared mutex so we can start caching	2020-02-17 08:40:17 +10:00
Damien Elmes	f6a881f950	pass progress back as translated string(s)	2020-02-17 08:40:17 +10:00
Damien Elmes	d1e587fca9	add ftl to the build process, and a sync-git script ... also - ensure po files are checked when updated - add start of sync.ftl	2020-02-17 08:40:17 +10:00
Damien Elmes	cc99f221be	expose StringsGroup enum in protobuf	2020-02-17 08:40:17 +10:00
Damien Elmes	319390f0c6	more frequent progress updates	2020-02-17 08:40:17 +10:00
Damien Elmes	b8e516b47c	rename card-templates.ftl	2020-02-17 08:40:17 +10:00
Damien Elmes	0cc1938657	move empty card check into template code	2020-02-17 08:40:17 +10:00
Damien Elmes	33367c8edf	make template errors translatable	2020-02-17 08:40:17 +10:00
Damien Elmes	5c8e3df612	include report in MediaCheckOutput	2020-02-17 08:40:17 +10:00
Damien Elmes	dc9362d4ed	add i18n support to Rust code using Fluent	2020-02-17 08:40:17 +10:00
Damien Elmes	ee27711b65	remove redundant test_ prefix	2020-02-17 08:40:17 +10:00
Damien Elmes	23483b0a57	mark deletions in media DB when files are deleted	2020-02-17 08:40:17 +10:00
Damien Elmes	1b0e8485fd	ignore errors when file to delete is already gone ... May be marked as pending upload or in media check screen, then removed by user.	2020-02-17 08:40:17 +10:00
Damien Elmes	df201c164f	make sure we don't leave a trailing dot or space when truncating	2020-02-17 08:40:17 +10:00
Damien Elmes	1ff6cbc54d	make sure renames generated during sync don't get immediately removed	2020-02-17 08:40:17 +10:00
Damien Elmes	d394aed5fd	don't filter out invalid filenames when we're sending them as a deletion	2020-02-17 08:40:17 +10:00
Damien Elmes	44a1a5f987	fix the wrong named being returned when renaming in sync	2020-02-17 08:40:17 +10:00
Damien Elmes	c3f22364c9	pt->pb for consistency with rsbackend.py	2020-02-17 08:40:17 +10:00
Damien Elmes	d73fec3280	shorten add_file_to_media_folder	2020-02-17 08:40:17 +10:00
Damien Elmes	4c0f216df2	use media.trash for unused media deletion as well	2020-02-17 08:40:17 +10:00
Damien Elmes	7f365faf3f	add extract_latex to backend; use it for latex build	2020-02-17 08:40:17 +10:00
Damien Elmes	c890ef871e	include LaTeX png/svg files when checking for unused media	2020-02-17 08:40:17 +10:00
Damien Elmes	4cca3ecef5	files with leading underscore are ignored	2020-02-17 08:40:17 +10:00
Damien Elmes	9913dcd5dc	include normalized filenames in the rename list ... Since they'll need to be uploaded on the next sync, better not to hide them from the list	2020-02-17 08:40:17 +10:00
Damien Elmes	6f158c8555	plug new media check in	2020-02-17 08:40:17 +10:00
Damien Elmes	c1939aebd1	when adding hash suffix, need length in hex, not bytes	2020-02-17 08:40:17 +10:00
Damien Elmes	fabfcb0338	gather field references in Rust; media check now mostly complete	2020-02-17 08:40:17 +10:00
Damien Elmes	aa832e9117	backend stores media folder/db locations; don't need to pass them in	2020-02-17 08:40:17 +10:00
Damien Elmes	58da7988c3	catch trailing space/period as well	2020-02-17 08:40:17 +10:00
Damien Elmes	5ccdeb46b8	check [ instead of con in unit test, so test works on Windows as well	2020-02-17 08:40:17 +10:00
Damien Elmes	dad8108feb	run the TZ test only on Macs	2020-02-17 08:40:17 +10:00
Damien Elmes	87c73741d0	test shouldn't depend on dentry order	2020-02-17 08:40:17 +10:00
Damien Elmes	314e643140	expire media trash after a week	2020-02-17 08:40:17 +10:00
Damien Elmes	e9f51a694c	use our own trash folder instead of using the system trash ... the trash crate was invoking external commands on Macs and Linux which is slow and likely to fall over if a large number of files need to be deleted at once.	2020-02-17 08:40:17 +10:00
Damien Elmes	660a9bf7ad	tidying	2020-02-17 08:40:17 +10:00
Damien Elmes	3350b4fa69	hold the DB open for the duration of the check	2020-02-17 08:40:17 +10:00
Damien Elmes	cee8d4b789	DB check ... Working, but should be refactored so media DB not re-opened each time a file is renamed.	2020-02-17 08:40:17 +10:00
Damien Elmes	8aa2984d04	factor entry code out for later	2020-02-17 08:40:17 +10:00
Damien Elmes	ce241f9756	mgr didn't need to be mutable	2020-02-17 08:40:17 +10:00
Damien Elmes	f7c26724f3	nfc helper	2020-02-17 08:40:17 +10:00
Damien Elmes	933b7a9a34	ignore 0 byte files when picking up changes	2020-02-17 08:40:17 +10:00
Damien Elmes	4fa4a5077c	don't add non-normalized files to media DB	2020-02-17 08:40:17 +10:00
Damien Elmes	22793c8cd6	media table doesn't need rowid	2020-02-17 08:40:17 +10:00
Damien Elmes	1ca11e4268	dirty index doesn't need to cover false case	2020-02-17 08:40:17 +10:00
Damien Elmes	bf50f88540	handle read errors during zip build	2020-02-17 08:40:17 +10:00
Damien Elmes	eddf9fdc44	clean up invalid media DB entries on the fly, instead of requiring DB check	2020-02-17 08:40:17 +10:00
Damien Elmes	7ae6244f6a	log media DB change registration progress, and allow aborting it	2020-02-17 08:40:17 +10:00
Damien Elmes	e5f9ed5a5b	move change tracking into separate file	2020-02-17 08:40:17 +10:00
Damien Elmes	5fe1bfc5b4	simplify code by accumulating stats at the source	2020-02-17 08:40:17 +10:00
Damien Elmes	4289f7a02a	move sync_media() into MediaManager	2020-02-17 08:40:17 +10:00
Damien Elmes	4c8ceeb809	remove duplicate method	2020-02-17 08:40:17 +10:00
Damien Elmes	32a3b5a020	tidy up sync.rs	2020-02-17 08:40:17 +10:00
Damien Elmes	9067bf98bd	handle concurrent modifications and ankiweb terminating early	2020-02-17 08:40:17 +10:00
Damien Elmes	e0511c560b	update dirmod as files added during sync	2020-02-17 08:40:17 +10:00
Damien Elmes	631bdc2a1e	add debug line	2020-02-17 08:40:17 +10:00
Damien Elmes	1f35ff0bd5	fix force_resync()	2020-02-17 08:40:17 +10:00
Damien Elmes	23f5c7cb9b	rename non-normalized filenames when downloading	2020-02-17 08:40:17 +10:00
Damien Elmes	98279add15	defer errors on upload to media check	2020-02-17 08:40:17 +10:00
Damien Elmes	0f7fc1e960	add proper version	2020-02-17 08:40:16 +10:00