GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-16 07:19:01 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions
9172 commits 11 branches 166 tags 122 MiB
Commit graph

208 commits

Author SHA1 Message Date
RumovZ
17ece47beb Cache selectionModel().selectedRows() 2021-09-28 11:45:22 +02:00
RumovZ
014220959a Calculate len_selection depending on modifiers 
If no modifiers are pressed, a single row has probably been clicked and
`selectedRows()` is fast, while a lot of rows might have been deselcted.
 2021-09-28 10:22:20 +02:00
RumovZ
4245a6bbc3 Prefer selectionModel().reset() over .clear() 
The latter triggers `selectionChanged()` unreliably, probably due to the
aggregation of chronologically close events, causing problems in
tracking `_len_selection`. `reset()` never emits signals.
 2021-09-28 10:19:33 +02:00
Damien Elmes
04a620ff1a Merge pull request #1382 from RumovZ/tags-from-sidebar 
Tags from sidebar
 2021-09-27 18:41:32 +10:00
RumovZ
94eafcf831 Calculate number of selected rows manually 
`len(self._view.selectionModel().selectedRows())` is slow for large
selections, because Qt queries flags() for every selected cell, so we
calculate the number of selected rows ourselves.
 2021-09-27 10:15:53 +02:00
RumovZ
8daecb94e5 Switch to new row before deleting notes 
The table now properly deselects deleted rows, but that takes effort and
it's more convenient to have a selected row after deleting.
 2021-09-25 17:28:38 +02:00
RumovZ
c0616fe820 Handle deleted or restored rows 
- Cache the result of 'table.len_selection()'
- Update this cache manually when a row was deleted or restored
- Emit 'dataChanged()' after such a change to fix flags not updating
correctly to the shortcut in 'model.flags()'
- Remove/retsore focus if the current element was deleted/restored
 2021-09-25 17:16:53 +02:00
RumovZ
053bbe8f01 Only check flags of cached rows 
Speeds up the selection process (esp. Ctrl+A) by avoiding to fetch rows.

Co-authored-by: BlueGreenMagick <BlueGreenMagick@users.noreply.github.com>
 2021-09-25 15:32:22 +02:00
RumovZ
0a95d69735 Add callbacks to row fetching routine 
Called when a row is detected that has been deleted or restored.
 2021-09-25 15:27:19 +02:00
RumovZ
a77c65006f Check 'index.isValid()' in 'table.model' 2021-09-25 15:21:06 +02:00
hikaru-y
6e196e43fd Fix memory leak in previewer 
Related thread:
https://forums.ankiweb.net/t/high-memory-usage-over-time-on-2-1-44/13544/
 2021-09-22 17:21:08 +09:00
RumovZ
dcb7d44ce4 Enable adding/removing tags from the sidebar ... 
... to selected notes.
 2021-09-21 11:48:43 +02:00
Damien Elmes
54ec174453 Merge pull request #1375 from RumovZ/disable-actions 
Disable unusable browser actions on row change
 2021-09-21 18:38:30 +10:00
Damien Elmes
2695cb64ff add hidden option to disable tooltips in browse screen 
https://forums.ankiweb.net/t/browser-text-pop-up-when-hovering-over-card-poll/13254
 2021-09-21 15:03:37 +10:00
Damien Elmes
916ff49efe temporary fix for error on deleting (#1374) 2021-09-20 22:02:44 +10:00
RumovZ
64fd90d633 Simplify sidebar context menu separators 
Qt can collapse consecutive menu separators, so no need to check if a
subroutine has actually added any actions to the menu.
 2021-09-19 18:33:36 +02:00
RumovZ
8fd0e89a5a Disable unusable browser actions on row change 2021-09-17 16:16:34 +02:00
Damien Elmes
2c235ccc70 don't check state of current card when repositioning 
closes #1365
 2021-09-13 14:56:53 +10:00
RumovZ
f1fcd8830d Disable 'Rename with Parents' for top-level items 2021-08-30 11:10:14 +02:00
Damien Elmes
48028aa397 Merge pull request #1319 from abdnh/sidebar-scroll-center 
Use PositionAtCenter for sidebar scrolling
 2021-08-02 18:35:38 +10:00
Damien Elmes
28535b4f84 Merge pull request #1311 from hikaru-y/flag-mark-icons-in-previewer 
Show flag and mark icons in previewer
 2021-08-02 18:33:36 +10:00
abdo
26b6688cb2 Use PositionAtCenter for sidebar scrolling 2021-08-02 10:57:54 +03:00
Damien Elmes
8e48722cf0 prevent hiding of sidebar 
https://forums.ankiweb.net/t/browser-format-issues/11504/10
 2021-07-28 11:14:09 +10:00
hikaru-y
7c90637922 Show flag and mark icons in previewer 2021-07-26 20:13:42 +09:00
RumovZ
16e3f2c7f3 Fix browser search completer 
Adding an empty entry at the top fixes
https://forums.ankiweb.net/t/anki-2-1-45-beta/10664/45
and allows for scrolling back to an empty line.
 2021-07-17 12:23:19 +02:00
Damien Elmes
4ed0260248 Merge pull request #1297 from hgiesel/browsershortcuts 
Allow Using Ctrl+Shift+P from Browser when focusing Qt components
 2021-07-17 15:18:36 +10:00
Henrik Giesel
f016df00cd Remove unnecessary lambda 2021-07-17 04:17:28 +02:00
Henrik Giesel
59f801abc7 Allow Using Ctrl+Shift+P from Browser when focusing Qt components 2021-07-17 03:39:27 +02:00
Damien Elmes
c93476512c Merge pull request #1292 from hgiesel/reviewerplus 
Move reviewer to ts/reviewer v2
 2021-07-17 09:10:14 +10:00
hikaru-y
dc11d7c297 Revert "Follow-up to #1271 (Preload answer images)" 2021-07-16 23:57:49 +09:00
Henrik Giesel
170bc5c25e Revert to MathJax through script tag 2021-07-16 16:56:57 +02:00
Henrik Giesel
28e2f62793 Remove protobuf important from reiewer (no longer necessary (?)) 2021-07-16 16:56:56 +02:00
Henrik Giesel
70040d508e Include MathJax over ts/reviewer 2021-07-16 16:56:56 +02:00
Henrik Giesel
c62d2dc033 Export jquery via ts/reviewer 2021-07-16 16:56:56 +02:00
Henrik Giesel
8ee6eb71eb Include css-browser-selector via ts/reviewer 2021-07-16 16:56:56 +02:00
Henrik Giesel
11f06161c9 Include protobuf in clayout and browser (p)reviewer 2021-07-16 16:56:56 +02:00
Damien Elmes
eb4e18a45f Merge pull request #1293 from RumovZ/find-and-replace 
Find & Replace
 2021-07-16 10:47:16 +10:00
RumovZ
9ba35b9efb Remove redundant QueryOp in rename_deck() 2021-07-15 08:56:47 +02:00
RumovZ
0804d054b7 Remove unused name prefix of sidebar templates 2021-07-13 16:41:50 +02:00
RumovZ
4f17400021 Add sidebar actions 
- Find & Replace for notetype fields
- Rename with Parents for decks and tags
 2021-07-13 16:34:02 +02:00
RumovZ
4b1218184d Rework Find & Replace dialog: 
- Add option to affect whole collection
- Allow to open without selection
- Add parameter for presetting field
 2021-07-13 16:33:45 +02:00
Damien Elmes
492137d264 Merge pull request #1291 from RumovZ/addon-cols 
Show key of unknown browser columns
 2021-07-13 13:35:54 +10:00
RumovZ
211f39836d Show key of unknown browser columns 2021-07-12 19:03:51 +02:00
RumovZ
300ff08ad0 Add mock browser model to support legacy resetting 2021-07-12 12:36:26 +02:00
Damien Elmes
2238cdaa43 rename Config in protobuf to avoid conflict with module name 
+ use the enum directly, instead of wrapping it in an object

Python code retains the old "Config" name.
 2021-07-11 19:27:08 +10:00
Damien Elmes
af6a80c4ec Merge pull request #1277 from RumovZ/config-keys 
Add constants for literal config keys
 2021-07-07 09:14:40 +10:00
RumovZ
e763745e05 Add pylib/browser.py for literal config keys 
Also, remove config bools for sort order.
 2021-07-05 12:44:48 +02:00
hikaru-y
00eaf63d41 Follow-up to #1271 
- remove no-longer-required 'escape_media_filenames()' b21af06d
- clean up previewer.py
 2021-07-05 01:13:17 +09:00
Damien Elmes
29808094c8 Merge pull request #1271 from hikaru-y/preload-images 
Preload answer images
 2021-07-04 15:50:55 +10:00
hikaru-y
bf93324448 Preload images to be displayed on answer side 2021-07-03 21:33:00 +09:00
RumovZ
94cc0cf901 Add flag manager and hook 
'FlagManager' allows cached access to the flag objects, takes care of
renaming flags and notifies GUI components with the hook
'flag_label_did_change'.
 2021-07-02 11:16:10 +02:00
Henrik Giesel
01cc9df232 Add flag icons from mdi after all 
- This way, we can also use their modifier versions with little pluses/minuses
 2021-07-01 01:16:50 +02:00
Henrik Giesel
d5f8a6e50c Remove multiple icons, new notetype/cardtype icons 2021-07-01 01:12:11 +02:00
Henrik Giesel
eec7eae885 Remove name_prefix from field sidebar item 2021-06-30 21:02:23 +02:00
Henrik Giesel
32f3c5dbe7 Replace card state and clock icon 2021-06-30 21:02:23 +02:00
Henrik Giesel
1850f24c4b Replace saved search icon 2021-06-30 21:02:23 +02:00
Henrik Giesel
5031bafb61 Add NOTETYPE_FIELD sidebar items 2021-06-30 21:02:23 +02:00
Henrik Giesel
fecceb1997 Add notetype icons 2021-06-30 21:02:23 +02:00
Henrik Giesel
5fe2519619 Add new icons for decks 2021-06-30 21:02:23 +02:00
Henrik Giesel
d9a368631f Add tag_multiple icon 2021-06-30 21:02:23 +02:00
Damien Elmes
309f5ee528 minor follow-up to #1257 
No need for a separate argument, as we only want to scroll when
searching.
 2021-06-29 11:53:10 +10:00
Damien Elmes
8743ccf682 Merge pull request #1257 from abdnh/sidebar-scroll-to-first-match 
Scroll to first sidebar search match
 2021-06-29 11:44:28 +10:00
Damien Elmes
2bada06570 use inner function instead of return value in _expand_where_necessary() 2021-06-29 11:40:59 +10:00
abdo
27313ba53d Scroll to first sidebar search match 2021-06-28 14:44:09 +03:00
RumovZ
1be1ca5911 Fix id check for today and card state items 2021-06-28 12:55:59 +02:00
Damien Elmes
c0dccee9fa Merge pull request #1252 from RumovZ/fix-tag-expand 
Fix expanding/collapsing tags triggering refresh
 2021-06-27 18:45:29 +10:00
Damien Elmes
f9560586cb PEP8 collection.py 2021-06-27 15:12:22 +10:00
Damien Elmes
d6e3964151 PEP8 cards.py 2021-06-27 12:12:23 +10:00
RumovZ
5cc2932fcb Add hook "browser_sidebar_will_show_context_menu" 2021-06-25 17:01:17 +02:00
RumovZ
7a82ea01b8 Fix expanding/collapsing tags triggering refresh 2021-06-24 17:27:53 +02:00
Damien Elmes
4ffca62afe allow customization of default search text 
https://forums.ankiweb.net/t/whats-the-default-search-when-browsing-now-also-how-do-i-choose-to-browse-current-deck/8922
 2021-06-24 11:24:30 +10:00
Henrik Giesel
43171c02af Allow inclusion of external icons into aqt/forms/icons 
+ Replace old tag icon with mdi tag and tag-off icon
 2021-06-16 17:19:21 +10:00
Henrik Giesel
8fd024c020 Make Browser root nodes use "_*" uniformly 2021-06-16 17:19:21 +10:00
Damien Elmes
153e1e8d41 new change notetype implementation for the frontend 
- changes can now be undone
- the same field can now be mapped to multiple target fields, allowing
fields to be cloned
- the old Qt dialog has been removed
- the old col.models.change() API calls the new code, to avoid
breaking existing consumers. It requires the field map to always
be passed in, but that appears to have been the common case.
- closes #1175
 2021-06-10 22:19:24 +10:00
Damien Elmes
e589edf6fd when focusing current card, position at top 
trying out the changes mentioned on
https://github.com/ankitects/anki/pull/1222#discussion_r648051997
 2021-06-09 21:01:29 +10:00
Damien Elmes
379317cfe0 ensure current card centered even if it was already visible 
Otherwise if a user reviews a card while keeping Browse open, the
card may not be centered if it was already in view.
 2021-06-08 16:22:56 +10:00
Damien Elmes
94ef3102d1 don't wait before scrolling to current card 
https://github.com/ankitects/anki/pull/1222#discussion_r647017566
 2021-06-08 12:54:05 +10:00
Damien Elmes
aaba9a777a fix note changes triggering a queue rebuild 2021-06-08 12:09:35 +10:00
Damien Elmes
c63e3ed72d Merge pull request #1222 from RumovZ/browser-card 
Change handling of browser's card parameter
 2021-06-08 09:32:43 +10:00
RumovZ
b09d71c2ec Change handling of browser's card parameter 
If a search is provided execute it, else search for current deck.
Then try to select and scroll to the provided card.
 2021-06-07 16:42:17 +02:00
Damien Elmes
998a3c0f7f add Rescheduled to Today section of sidebar 
https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/105
 2021-06-05 12:55:07 +10:00
cherryblossom
462da55fd5 fix documentation links 2021-06-03 16:51:03 +10:00
Damien Elmes
d38f57cf3c Merge pull request #1213 from RumovZ/new-flags 
Add pink, turquoise and purple flags
 2021-06-02 11:22:26 +10:00
Damien Elmes
c80e852ada prevent error storm when browser table encounters panic 2021-06-02 11:15:39 +10:00
RumovZ
d6d712c4a7 Rename violet to pink 2021-06-01 18:14:43 +02:00
Damien Elmes
b52ac3883e Merge pull request #1209 from RumovZ/drop-saved-search 
Drag & drop for saved search
 2021-06-01 17:50:55 +10:00
Damien Elmes
ea60b73275 fix timebox causing crash 
When a modal was created with another window as its parent, the other
window was being returned, when it was the current window that we
actually wanted. This caused nextCard() to be called again when it
presented the timebox modal, leading to a stack overflow.

https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/71
 2021-06-01 15:35:18 +10:00
RumovZ
9e56a4421b Add violet, turquoise and purple flags 2021-05-31 12:03:30 +02:00
Damien Elmes
0b6beaa1da remove deck protobuf from frontend 
Like the previous change, avoid exposing the protobuf as a public API
for now. It requires more thought, and is probably better done with
either extra helper accessors like decks.name(), or via a native class.
 2021-05-31 16:31:06 +10:00
RumovZ
fb9cbf9816 Make a new item the current item after refresh 2021-05-30 10:46:59 +02:00
RumovZ
bf0dbeb5f0 Skip saving search if it already exists 2021-05-30 10:11:40 +02:00
RumovZ
a989b4e8e9 Enable drop to create saved search 2021-05-30 09:30:22 +02:00
RumovZ
0297a698e8 Fix renaming of unused tag 
Unused tags can't be renamed, but since the CollectionOp returns success
in any case, the provisionally renamed sidebar item needs to be reset.
 2021-05-28 19:18:21 +02:00
RumovZ
f443058209 Prevent sidebar toolbar from folding 
If there is little space, Qt replaces some tools of the toolbar with an
expandable menu indicated by an arrow. But this arrow is invisible in
night mode.
 2021-05-28 18:09:44 +02:00
RumovZ
99bc3c698f Fix restoring current sidebar element for cards 2021-05-28 17:46:46 +02:00
Damien Elmes
4a0758b34f always start in first sidebar mode 
I didn't notice anyone objecting; let's see how this is received.

https://forums.ankiweb.net/t/anki-2-1-45-alpha/10061/35
 2021-05-24 14:51:21 +10:00
Damien Elmes
1f7118a8e3 config updates by the frontend now skip undo by default 2021-05-24 14:50:46 +10:00
Damien Elmes
380317d701 Merge pull request #1186 from RumovZ/ctx-actions 
Update context action states after card op
 2021-05-24 10:49:23 +10:00
RumovZ
fb8194d82a Remove browser.oneModelNotes() 2021-05-22 19:12:03 +02:00
RumovZ
fa81437ad6 Check notetype count in browser.onChangeModel() 2021-05-22 19:11:06 +02:00