GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-14 06:23:57 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions
11407 commits 10 branches 166 tags 121 MiB
Commit graph

3444 commits

Author SHA1 Message Date
Ben Nguyen
e044d34fa8 Fix reuse internal clipboard for primary selection pasting (#3613) 
* Pass down clipboard mode

* Add type annotation
 2024-12-09 15:38:52 +11:00
hideo aoyama
ccabe850b1 Snap: keep LD_LIBRARY_PATH when in snap environment (#3618) 2024-12-07 00:42:03 +11:00
user1823
3b62448aac Change font of debug console to Consolas (#3606) 2024-12-07 00:37:43 +11:00
sorata
91abff5c46 update error message (#3612) 
Co-authored-by: Abdo <abdo@abdnh.net>
 2024-12-06 03:05:49 +03:00
Damien Elmes
7b60af7754 "Fields for ..." 
https://forums.ankiweb.net/t/add-note-type-name-to-the-fields-editor/52263
 2024-11-23 22:45:19 +11:00
Damien Elmes
731f8a9c02 Bump mimalloc for CVE 2024-11-19 15:27:39 +10:00
Ben Nguyen
1f5798a35c Enable strict_optional for aqt/tagedit, utils, sync (#3578) 
* Enable strict_optional for tagedit

* Fix mypy errors

* Enable strict_optional for utils

* Fix mypy errors

* Enable strict_optional for sync

* Fix mypy errors

---------

Co-authored-by: Abdo <abdo@abdnh.net>
 2024-11-15 16:29:19 +03:00
Ben Nguyen
53e59d4c19 Enable strict_optional for aqt/mediasync, package, progress (#3577) 
* Enable strict_optional for mediasync

* Fix mypy errors

* Enable strict_optional for package

* Fix mypy errors

* Enable strict_optional for progress

* Fix mypy errors
 2024-11-15 16:24:50 +03:00
Ben Nguyen
fcb1da1446 Enable strict_optional for aqt/deckchooser, about, webview (#3573) 
* Enable strict_optional for deckchooser

* Fix mypy errors

* Enable strict_optional for about

* Fix mypy errors

* Enable strict_optional for webview

* Fix mypy errors

* Fix merge error

* Revert utils

* Add early returns

---------

Co-authored-by: Abdo <abdo@abdnh.net>
 2024-11-13 12:06:55 +03:00
Ben Nguyen
6fd430e94e Enable strict_optional for aqt/mediacheck, theme, toolbar (#3569) 
* Enable strict_optional for mediacheck

* Fix mypy errors

* Enable strict_optional for theme

* Fix mypy errors

* Enable strict_optional for toolbar

* Fix mypy errors
 2024-11-12 19:47:04 +03:00
Abdo
765eebc9e2 Remove outdated TODO (#3567) 2024-11-09 18:42:49 +03:00
Ben Nguyen
af93d346b2 Enable strict_optional for aqt/debug_console, emptycards, flags (#3565) 
* Enable strict_optional for debug_console

* Fix mypy errors

* Enable strict_optional for emptycards

* Fix mypy errors

* Enable strict_optional for flags

* Fix mypy errors
 2024-11-09 13:43:51 +03:00
Ben Nguyen
84f68fa62f Enable strict_optional for aqt/notetypechooser, stats, switch (#3558) 
* Enable strict_optional for notetypechooser

* Fix mypy errors

* Enable strict_optional for stats

* Fix mypy errors

* Enable strict_optional for switch

* Fix mypy errors

---------

Co-authored-by: Abdo <abdo@abdnh.net>
 2024-11-08 13:42:42 +03:00
Ben Nguyen
9bbaadb003 Enable strict_optional for aqt/deckoptions, editcurrent, filtered_deck (#3556) 
* Enable strict_optional for filtered_deck

* Fix mypy errors

* Enable strict_optional for editcurrent

* Fix mypy errors

* Enable strict_optional for deckoptions

* Fix mypy errors
 2024-11-07 08:33:41 +10:00
Abdo
20d5139890 Fix target deck reset to notetype-specific setting (#3555) 2024-11-07 08:32:42 +10:00
Abdo
593caaf5c6 Fix UI hanging with empty context menu (#3553) 2024-11-05 17:49:48 +03:00
Abdo
5f03d0766d Remove legacy import option (#3536) 
* Remove legacy import option

* Always return False in legacy_import_export()
 2024-11-05 18:25:06 +10:00
Ben Nguyen
1a22cce3e8 Enable strict_optional for aqt/clayout, changenotetype, fields (#3544) 
* Enable strict_optional for clayout

* Fix mypy errors

* Enable strict_optional for changenotetype

* Fix mypy errors

* Enable strict_optional for fields

* Fix mypy errors
 2024-10-30 13:40:40 +03:00
Ben Nguyen
4a894e7342 Enable strict_optional for aqt/studydeck, tts, mediasrv (#3542) 
* Enable strict_optional for studydeck

* Fix mypy errors

* Enable strict_optional for tts

* Fix mypy errors in tts

* Enable strict_optional for mediasrv

* Fix mypy errors in mediasrv
 2024-10-29 12:05:54 +03:00
Ben Nguyen
1f2e014f2c Enable strict_optional for aqt/modelchooser.py (#3539) 
* Enable strict_optional

* Fix mypy errors
 2024-10-28 14:19:31 +10:00
Ben Nguyen
b6e04f2625 Enable strict_optional for aqt/deckdescription.py (#3538) 
* Enable strict_optional

* Fix mypy errors
 2024-10-28 14:18:16 +10:00
Ben Nguyen
612fc8c0c0 Enable strict_optional for aqt/deckbrowser.py (#3537) 
* Enable strict_optional

* Fix mypy errors
 2024-10-28 14:16:42 +10:00
Abdo
0c82fcad20 Merge branch 'main' into aqt-strict-optional-taglimit 2024-10-27 17:10:21 +03:00
Abdo
9133d86eca Merge branch 'main' into aqt-strict-optional-overview 2024-10-27 17:06:58 +03:00
bpnguyen107
1340bd6718 Fix mypy errors 2024-10-26 19:33:04 -07:00
bpnguyen107
88b2213b55 Fix mypy errors 2024-10-26 19:19:20 -07:00
bpnguyen107
a7619d8d9a Fix mypy errors 2024-10-26 19:07:43 -07:00
Ben Nguyen
4572f63cba Enable strict_optional for aqt/importing.py (#3527) 
* Enable strict_optional

* Fix mypy errors
 2024-10-26 19:56:34 +10:00
Ben Nguyen
33704468f3 Enable strict_optional for aqt/preferences.py (#3519) 
* Enable strict_optional for aqt/preferences.py

* Fix mypy errors
 2024-10-26 19:33:53 +10:00
Damien Elmes
d3da6db1d5 Revert "Fix ease button alignment (#3474)" (#3522) 
This reverts commit 332fae40ca.
 2024-10-26 18:50:02 +10:00
Damien Elmes
b74032929f Fix error when exporting from empty cards screen 
https://forums.ankiweb.net/t/bug-copy-debug-info-button-crashes-anki-24-04-and-24-06-3/50852
 2024-10-22 23:24:27 +10:00
Damien Elmes
0a9990ed77 Rename remaining 'weights' references to 'params' 2024-10-21 18:13:23 +10:00
Damien Elmes
c74086fb95 Revert "NF: Improve typing of AnkiWebView action (#3475)" (#3504) 
This reverts commit 5610436c88.
 2024-10-16 03:02:22 +10:00
Taylor Obyen
332fae40ca Fix ease button alignment (#3474) 
* Fix ease button alignment

* Make CSS not 'hacky'
 2024-10-16 01:46:55 +10:00
Ben Nguyen
cb9bac7280 Enable strict_optional for aqt/editor.py (#3500) 
* Enable strict_optional for aqt/editor.py

* Fix mypy errors in EditorWebView class

* Fix mypy errors in Editor class

* DRY

* Match same short circuiting behavior

* Convention
 2024-10-16 01:08:24 +10:00
Hikaru Y.
da367a9499 Fix 'Discard changes' dialog appearing even when no changes are made (#3495) 
* Fix 'Discard changes' dialog appearing even when no changes are made

https://forums.ankiweb.net/t/anki-24-10-beta/49989/166

* Fix geometry of deck options window not being saved

evt.accept() does not seem to trigger reject().
 2024-10-16 00:47:33 +10:00
Damien Elmes
d494d1ff1c Fix UI hanging when update check stalls 
https://forums.ankiweb.net/t/anki-24-10-beta/49989/222
 2024-10-15 21:32:46 +10:00
Jarrett Ye
76eb24276c add get_revlogs API && fix the style of tooltipText of ReviewsGraph (#3490) 
* add get_revlogs API

* fix tooltipText of ReviewsGraph

the style of true-retention shouldn't affect the style of tooltipText of ReviewsGraph

* More verbose wording (dae)
 2024-10-12 14:49:14 +10:00
Ben Nguyen
71b61e530e Enable strict_optional for aqt/data, aqt/forms, aqt/import_export (#3489) 
* Added spacing

* Enable strict_optional for aqt/data

* Update CONTRIBUTORS

* Enable strict_optional for aqt/forms

* Enable strict_optional for aqt/import_export

* Fix mypy errors in import_dialog.py

* Fix mypy errors in exporting.py

* Better variable name

* Stick to assert convention
 2024-10-12 14:36:15 +10:00
Damien Elmes
688e5bd789 Ignore mw typing error 2024-10-11 23:47:22 +10:00
Ben Nguyen
1b0e483870 Enable strict_optional in aqt/. and aqt/browser (#3486) 
* Boolean naming convention

* Rename no_strict_optional -> strict_optional

* Update CONTRIBUTORS

* Enable strict optional for aqt module

* Fix errors

* Enable strict optional for aqt browser

* Fix layout.py errors

* Fix find_duplicates.py errors

* Fix browser.py errors

* Revert a0 a1 names

* Fix tree.py errors

* Fix previewer.py errors

* Fix model.py errors

* Fix find_and_replace.py errors

* Fix item.py errors

* Fix toolbar.py errors

* Fix table/__init__.py errors

* Fix model.py errors

* Fix state.py errors

* Fix table.py errors

* Fix errors in card_info.py

* Fix searchbar.py errors

* Fix name

* Fix assert in browser.py

* Formatting

* Fix assert vh

* assert is not None instead of truthy

* Split _move_current() up to correct type signature (dae)

We want either index or direction, but not both.
 2024-10-11 23:12:48 +10:00
a.r
5910395fcb typeanswer: NFC fix & cleanup (#3482) 
* typeanswer: cleanup

* DiffNonCombining's new() used String where plain Vec is appropriate
* get rid of normalize_typed for DiffTrait again by pulling code into DiffNonCombining's new()
* two DiffNonCombining testcases

* typeanswer: return to NFC & typos
 2024-10-11 20:33:08 +10:00
Arthur Milchior
5610436c88 NF: Improve typing of AnkiWebView action (#3475) 
There are only two types of actions. The code does not seems to
consider this to be extandable, and the changed variable is private,
so I would expect it relatively acceptable to change the way it
work. This would improve the typing.

If this is rejected, at least, the callback should be noted as
optional, so that the IDE does not complain that `if cb` can not be
false.
 2024-10-11 20:16:20 +10:00
Damien Elmes
09788cfac9 Pretend mw is set from the start 
https://github.com/ankitects/anki/pull/3476#issuecomment-2395281774

Closes #3476
 2024-10-10 22:17:58 +10:00
Hikaru Y.
76c69f8838 Fix issues with 'Discard changes' confirmation dialog (#3478) 
* Prevent memory leak

* Fix deck option changes not detected until focus is lost

* Accurately determine if there are any pending changes

This makes it so that the confirmation dialog appears when it should,
and not when it shouldn't.
 2024-10-06 14:21:00 +10:00
Damien Elmes
3a172a3f23 Revert "Fix ease button alignment (#3404)" 
This reverts commit 1663407d7e.

Due to regression:
https://forums.ankiweb.net/t/anki-24-10-beta/49989/119
 2024-10-04 22:38:50 +10:00
user1823
cfd0e4d6a3 Add "open image" option to editor (#3431) 
* Add "open image" option to editor

* Update qt/aqt/editor.py

Co-authored-by: Ben Nguyen <105088397+bpnguyen107@users.noreply.github.com>

* Update editor.py

* Remove unused import

* Fix "show in folder"

* Fix 'show in folder' on macOS

* Revert "Fix "show in folder""

This reverts commit cf2b33ee9422bcaf8d9e20bd4cce74e5061c13cf.

* Reimplement show_in_folder for Windows (dae)

- Avoid reusing call(), as the startupinfo we were passing in was
breaking the explorer invocation
- Attempt to bring explorer to the front after the window has been show,
as it otherwise appears under Anki (at least when running from source)

---------

Co-authored-by: Ben Nguyen <105088397+bpnguyen107@users.noreply.github.com>
Co-authored-by: Damien Elmes <gpg@ankiweb.net>
 2024-10-04 20:51:55 +10:00
박현우
e64cb6d3f0 Allow addon page URL on AddonsDialog (#3467) 
* Allow users to just copy&paste addon page URL to addon 'code' field.

https://forums.ankiweb.net/t/get-addons-allow-url-on-code-section/36370
 2024-10-04 15:02:29 +10:00
Shirish Pokhrel
307438dbb0 Fix editor loses focus when toggling list and copy selects wrong target deck for filtered decks (#3465) 
* fix copy selects wrong target deck for filtered decks
 2024-10-02 18:42:41 +10:00
Taylor Obyen
7a131f0fe9 Fix occlusion drift again (#3443) 
* Fix occlusion drift

* Fix image editor occasionally not loading fully

* Fix occlusion disassociation when browsing

* Address oversights

* Fix translucent modifier applies to newly created shapes incorrectly

* Fix i-text turns yellow upon immediate note change

* Fix image occlusion hot keys not disabled when typing

* Improve text label creation experience

* Remove redundant functions

* Fix error when adding occlusion (dae)
 2024-10-02 17:19:52 +10:00