GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-17 15:59:03 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions
6541 commits 12 branches 166 tags 134 MiB
Commit graph

1814 commits

Author SHA1 Message Date
Damien Elmes
767933e2f5 fix the preview shortcut references 2020-11-17 17:51:57 +10:00
Damien Elmes
066b1498ae merge bulk of qt/ - designer files still to do 2020-11-17 17:42:43 +10:00
Damien Elmes
d2e97d8332 add script to rewrite py files 2020-11-17 17:39:48 +10:00
Damien Elmes
39fe93be1f output strings into ftl files 2020-11-17 15:12:05 +10:00
Damien Elmes
83cbe0d412 map gettext strings to keys/modules for ftl conversion 2020-11-17 14:11:09 +10:00
Damien Elmes
f4d424788e Merge pull request #825 from hgiesel/mathjax3plus2 
Switch from jQuery pre 3.0.0 pseudo promises to ES6 promises for ts hooks
 2020-11-16 11:44:21 +10:00
Damien Elmes
e92848e0c2 Merge pull request #826 from abdnh/write-dupes-fix 
Make dupe search operate on non-stripped text
 2020-11-16 11:43:33 +10:00
abdo
35bfd20240 Make dupe search operate on non-stripped text 
See https://github.com/ankitects/anki/pull/822/
 2020-11-16 04:01:04 +03:00
Henrik Giesel
0d94016193 Switch from jQuery pre 3.0.0 pseudo promises to ES6 promises 2020-11-16 01:09:59 +01:00
Henrik Giesel
35b82bcd72 Satisfy formatter 2020-11-15 21:40:59 +01:00
Henrik Giesel
f498ae88dc Improve ts hooks to allow for asynchronous actions 
* reviewer ts hooks may now return a promise, which are then waited upon with Promise.all
* this does not break old ts hooks, as Promise.all allows for non-Promises in its array
 2020-11-15 21:16:06 +01:00
Henrik Giesel
d18653cf16 Include default MathJax packages 
* by default load all the default tex-chtml packages, which additionally include:
  * require: using \require{package-name} to load a package
  * autoload: using a command from a different package automatically loads it
  * configmacros: allows for definition of predefined macros
 2020-11-15 20:56:50 +01:00
Henrik Giesel
cc2ba7d07f Load require package in Mathjax 2020-11-15 13:58:51 +01:00
Damien Elmes
7f040cad0d Merge branch 'mathjax3' 2020-11-15 20:24:50 +10:00
Damien Elmes
896a1e44b1 add rule to copy mathjax from node_modules 2020-11-15 20:22:28 +10:00
Damien Elmes
da58bbaaa3 ignore incorrect clock in dev mode 2020-11-15 18:29:16 +10:00
RumovZ
8fc5d4c897 Update frontend search escapes to new parsing 2020-11-14 20:37:40 +01:00
Henrik Giesel
06bd0376b1 Remove @types/mathjax as it is for MathJax 2 2020-11-14 14:14:25 +01:00
Henrik Giesel
3ec4b0da3a Add moving MathJax3 into mathjax directory to build process 2020-11-14 14:14:25 +01:00
Henrik Giesel
6a29e0cd4d Rip out MathJax 2 and setup MathJax 3 environment 2020-11-14 14:14:25 +01:00
Henrik Giesel
839e6652dd Update MathJax2 config to MathJax3 config 
Used: https://mathjax.github.io/MathJax-demos-web/convert-configuration/convert-configuration.html
 2020-11-14 14:14:25 +01:00
Damien Elmes
a4af59fc4d format_fix -> format; rename svelte-check for consistency 2020-11-12 20:19:32 +10:00
Damien Elmes
ba5dc96a6b fix some unwanted leading space in i18n keys 2020-11-12 08:55:26 +10:00
Damien Elmes
0cb2b3f0c1 update qt/ to 3.8 as well 2020-11-11 21:37:36 +10:00
Damien Elmes
48d07b7541 sort merged po files 2020-11-11 21:18:41 +10:00
Damien Elmes
c62e6e61c2 update i18n scripts 
- export updated .po files for consumption
- add a script to pull and push translations
 2020-11-11 21:08:06 +10:00
Damien Elmes
5ab4cbfd63 prep for i18n updates 
Update scripts will be split into separate repo
 2020-11-11 16:18:28 +10:00
Damien Elmes
5f8df09271 add Makefile and README from packaged Linux version 2020-11-11 13:57:38 +10:00
Damien Elmes
fb21e89653 add pyqtwebengine to wheel deps and bump minimum required pyqt 2020-11-11 10:33:49 +10:00
Damien Elmes
ec74cf6730 handle packaged pylib buildinfo.txt; drop aqt buildinfo 2020-11-11 10:33:49 +10:00
Damien Elmes
8147c9996a Merge pull request #793 from nwwt/object-audio-tags-support 
Audio & object tag support
 2020-11-11 10:33:31 +10:00
Andreas Reis
776c46e23b Allow <audio> to play without user interaction in accordance to autoplay setting 
Since 2018, Chromium by default requires at least one user interaction with a page in order for sound to play. That's not what an Anki user expects.

So this commit undoes this by setting the policy accordingly if the deck's settings have autoplay set, so that files in <audio> tags (if they further have the autoplay attribute set / are jscripted accordingly) are treated the same as ones in [sound:…] elements. OFC, it's obviously not a good idea to mix both on one card.

(AnkiDroid's WebView has already been unconditionally ignoring the requirement since forever.)
 2020-11-10 14:53:45 +01:00
Andreas Reis
81d6d21ae3 cleanup / renames 
・ soundRegexps →  sound_regexps

・ htmlRegexps →  html_media_regexps

・ HTML_TAGS →  HTML_MEDIA_TAGS

・ escapeImages →  escape_media_filenames + alias

・ strip_html_preserving_image_filenames →  strip_html_preserving_media_filenames
 2020-11-10 14:53:04 +01:00
ianki
28ad68d490 Add hooks for filtering media. 2020-11-09 02:12:23 -08:00
Damien Elmes
27e14dc59e Merge pull request #814 from k12ish/master 
Improve compatibility with graphics pad/touchscreen
 2020-11-09 19:42:41 +10:00
Damien Elmes
b3db379655 Merge pull request #813 from RumovZ/fix-search-combos 
Fix clicking filters with keyboard modifiers
 2020-11-09 19:42:13 +10:00
k12ish
1ca0eb04bb Improve compatibility with graphics pad/touchscreen 
When using anki with a graphics pad, text is often selected on accident. This snippet of CSS will fix that issue
 2020-11-08 18:14:37 +00:00
RumovZ
7f9aa879b5 Fix clicking filters with keyboard modifiers 2020-11-08 11:05:11 +01:00
Damien Elmes
8cc6f338f5 fix missing QAudioDeviceInfo on macOS 2020-11-06 12:01:37 +10:00
Damien Elmes
5e3a4d2c88 Merge pull request #808 from sobjornstad/reposition-highlight 
Start with default value in reposition spinbox selected
 2020-11-06 11:09:15 +10:00
Damien Elmes
f128f0f79a fix aqt version requirement; use py3 instead of cp38 tag 2020-11-05 20:25:08 +10:00
Damien Elmes
338836ebb9 cleanups 2020-11-05 11:21:13 +10:00
Damien Elmes
d6e13ee28e fix tests on Linux 2020-11-04 21:39:41 +10:00
Damien Elmes
e4ba941cf1 move aqt_data into source folder; implement wheel building 2020-11-04 12:14:03 +10:00
Soren Bjornstad
e8b40ec7d5 start with default value in reposition text box highlighted 
This saves a keystroke if you want to replace the default value. It's
hard to imagine a situation in which you would want to *prepend*
characters to the default value, as is the current behavior. If you want
to accept the default value, you can still hit enter or tab immediately.
 2020-11-02 19:07:53 -06:00
Damien Elmes
9999ec8124 fix pywintypes issue when running tests on Windows 2020-11-02 21:36:01 +10:00
Damien Elmes
7c27c4b9a0 move backend.proto into rslib/ 2020-11-02 16:28:31 +10:00
Damien Elmes
a7f403f0b0 rspy -> pylib/rsbridge 2020-11-02 15:21:12 +10:00
Damien Elmes
99b20cbaa6 update CI 2020-11-01 16:33:40 +10:00
Damien Elmes
f9171eb3d3 remove old makefiles 2020-11-01 14:41:01 +10:00
Damien Elmes
e40be43843 always return str in aqt_data_folder() 2020-11-01 14:38:13 +10:00
Damien Elmes
ce3b08ac58 initial Bazel conversion 
Running and testing should be working on the three platforms, but
there's still a fair bit that needs to be done:

- Wheel building + testing in a venv still needs to be implemented.
- Python requirements still need to be compiled with piptool and pinned;
need to compile on all platforms then merge
- Cargo deps in cargo/ and rslib/ need to be cleaned up, and ideally
unified into one place
- Currently using rustls to work around openssl compilation issues
on Linux, but this will break corporate proxies with custom SSL
authorities; need to conditionally use openssl or use
https://github.com/seanmonstar/reqwest/pull/1058
- Makefiles and docs still need cleaning up
- It may make sense to reparent ts/* to the top level, as we don't
nest the other modules under a specific language.
- rspy and pylib must always be updated in lock-step, so merging
rspy into pylib as a private module would simplify things.
- Merging desktop-ftl and mobile-ftl into the core ftl would make
managing and updating translations easier.
- Obsolete scripts need removing.
- And probably more.
 2020-11-01 14:26:58 +10:00
Damien Elmes
4d861e4c95 Merge pull request #803 from RumovZ/fix-completer-focus 
Work around Qt's focus bug (fix help-wanted#22)
 2020-10-29 21:44:13 +10:00
Damien Elmes
fc46426951 Merge pull request #804 from hgiesel/mime 
Set MIME type for javascript files
 2020-10-29 20:54:03 +10:00
Henrik Giesel
3a4036d59d Set MIME type for javascript files 2020-10-26 23:32:38 +01:00
RumovZ
00a5a6ff33 Work around Qt's focus bug (fix help-wanted#22) 
Manually hide the editor's completer popup before accepting a short cut which changes the focus widget. Thus, work around the bug in PyQt 5.15 where a QLineEdit with open QCompleter popup won't get notified about focus changes handled by the Main Window, leading to inconsistent focus.
 2020-10-24 10:47:25 +02:00
abdo
96eadecdec Use replace instead of strip 
https://github.com/ankitects/anki/pull/801
 2020-10-22 15:21:30 +03:00
abdo
69da22a2b9 Strip double quotes from names 
Strip double quotes from all kinds of names

https://github.com/ankitects/anki/pull/798
 2020-10-21 21:48:49 +03:00
Damien Elmes
00a71b6499 Merge pull request #799 from hgiesel/cal 
Introduce Browser.search_for and Browser.update_search
 2020-10-21 21:31:21 +10:00
Damien Elmes
dff4849241 Merge pull request #798 from abdnh/escape-quotes-in-search 
Escape double quotes in search
 2020-10-21 21:28:51 +10:00
Damien Elmes
d32fd008c0 Merge pull request #797 from abdnh/importing-fix 
Fix notes being imported to the wrong deck in some cases
 2020-10-21 21:22:33 +10:00
Damien Elmes
75716d13ff Merge pull request #795 from abdnh/reviewer-cleanup 
Set card to None in reviewer cleanup
 2020-10-21 21:19:43 +10:00
Damien Elmes
1d330138cb Merge pull request #794 from abdnh/tagedit-enter-fix 
Don't apply suggestion when no suggestion list is shown in tagedit
 2020-10-21 21:19:05 +10:00
Damien Elmes
17de596fc1 Merge pull request #791 from abdnh/sidebar-context-menu 
help-wanted#6: continue work on new browser sidebar (based on #590)
 2020-10-21 21:13:32 +10:00
Henrik Giesel
ee34a3458c Turn update_search into its own method 2020-10-19 21:07:29 +02:00
Henrik Giesel
bd9fca786d Add search prompt for setupSearch 2020-10-19 20:57:19 +02:00
Henrik Giesel
634a6f04d1 Add uses of search_for 2020-10-19 20:51:36 +02:00
Henrik Giesel
ae26e2fc70 Add search_for method 2020-10-19 20:37:17 +02:00
abdo
0c7726f87e Escape double quotes in search 2020-10-19 01:06:41 +03:00
abdo
8f76fd5a39 Remove unused code 2020-10-15 16:14:14 +03:00
abdo
6e4d5453ac Save importing model in any case 
https://forums.ankiweb.net/t/bug-notes-are-imported-to-the-wrong-deck-in-certain-cases/4318
 2020-10-15 15:14:55 +03:00
abdo
d0aa8625b4 Set card to None in reviewer cleanup 2020-10-14 12:56:47 +03:00
abdo
51e5eba3fe Don't apply suggestion when no suggestion list is shown 2020-10-14 05:00:24 +03:00
Damien Elmes
74981145cf formatting fix 
formatting fix
 2020-10-14 10:35:57 +10:00
Damien Elmes
2c36fde269 Update __init__.py 2020-10-14 09:45:34 +10:00
Andreas Reis
4e35b1780d Add command-line argument to skip addons 
Shift doesn't work for me occasionally, for whatever reason. So just add an -s to skip it that way.

(Also, update my github nick)
 2020-10-14 01:31:07 +02:00
abdo
5463b13128 Fix typing warning 2020-10-12 11:01:15 +03:00
abdo
e0bbf38850 Do sidebar switch check in browser init 
https://github.com/ankitects/help-wanted/issues/6#issuecomment-706880794
 2020-10-12 10:28:21 +03:00
abdo
3d3e68ed7a Merge branch 'sidebar-context-menu' of https://github.com/abdnh/anki into sidebar-context-menu 2020-10-12 10:15:23 +03:00
Damien Elmes
874366fce7 formatting fix 2020-10-12 12:37:51 +10:00
Damien Elmes
362ebef832 Merge pull request #790 from hgiesel/fields 
Add fields_did_rename_field and fields_did_remove_field hooks
 2020-10-12 12:36:39 +10:00
Damien Elmes
b182c07a99 Merge pull request #789 from abdnh/editor-decode-urls 
Decode pasted URLs for nicer display
 2020-10-12 12:33:52 +10:00
Damien Elmes
089e48adac Merge branch 'master' into opus-audio 2020-10-12 12:32:43 +10:00
Damien Elmes
accffbd29a formatting fixes 2020-10-12 12:17:02 +10:00
Damien Elmes
597b81ebeb Merge pull request #782 from johan456789/patch-1 
fix outdated help site
 2020-10-12 12:15:46 +10:00
Henrik Giesel
0f09258e68 Add fields_did_rename_field and fields_did_remove_field hooks 2020-10-11 19:16:30 +02:00
abdo
9140c3597f Decode pasted URLs 2020-10-11 16:46:46 +03:00
Piotr Kubowicz
1add0e6c6b Add .opus as an audio extension 
Wikimedia Commons has pronunciation recordings with .opus extension.
Anki is able to play such files, but until now adding them required
changing the extension to .ogg or some other supported one.

Also sort the audio extensions list.
 2020-10-10 16:28:40 +02:00
Damien Elmes
909367efc1 fixes for latest mypy 2020-10-10 19:02:59 +10:00
abdo
401485834b Move new sidebar code to a separate file 
- Move the new sidebar code and SidebarTreeView implementation to a
  new file. Old sidebar can be accessed with the shift key. The "new" sidebar
  doesn't add much for now.
- Make rename_deck work with subdecks
- Fix an issue when trying to open context menu over areas not populated
  with sidebar items
 2020-10-10 04:42:49 +03:00
abdo
69f9543fda Merge commit 'refs/pull/590/head' of https://github.com/ankitects/anki into sidebar2 2020-10-10 04:11:54 +03:00
johan456789
0ebe5d14eb fix help url paths 2020-10-10 00:38:07 +08:00
johan456789
a5b452780e remove never used link 2020-10-10 00:07:34 +08:00
abdo
1b3b1e3329 Escape ampersands in note type names too 2020-10-07 15:26:32 +03:00
abdo
2e48b437eb Fix 'Filter' menu item in deck filters not working 2020-10-07 14:32:21 +03:00
abdo
2ebf8d5f0e Escape ampersands in filter menu 
Fixes ankitects/help-wanted#20
 2020-10-07 13:44:33 +03:00
Damien Elmes
53ceab9bd3 Merge pull request #778 from hgiesel/refocus 
Always focus main web instead of bottom web in reviewer
 2020-10-07 16:22:49 +10:00
Damien Elmes
515de117f4 add Gustavo Costa 
A reminder that anyone who's contributed is welcome to send
a PR adding themselves!
 2020-10-06 14:36:11 +10:00
Damien Elmes
8b0be88df5 fix invisible scrollbar in nightmode 
vars.scss no longer contains the Qt theme definitions, so the
easiest solution was to duplicate the colour in this case
 2020-10-06 14:35:21 +10:00
Henrik Giesel
5517e69f7e Have a "default" highlight, but naturally follow focus if focus is in container 2020-10-05 22:54:23 +02:00
Henrik Giesel
e7fe9b470f Give the focus on .focus element a red tint 2020-10-05 22:39:16 +02:00
Henrik Giesel
65f77ef44e Add focus class which mimics built-in focus 2020-10-05 22:18:46 +02:00
Damien Elmes
d3df6dd92a fix IndexError when switching notetypes 
Closes #780
https://github.com/ankitects/anki/pull/780
 2020-10-05 13:33:54 +10:00
Damien Elmes
0ed130b133 Merge pull request #781 from hgiesel/leftbtns 
Refactor Buttons in editor and add editor_did_init_left_buttons gui_hook
 2020-10-05 13:14:52 +10:00
Damien Elmes
28e00f487b Merge pull request #779 from david-allison-1/fix-sign-up-link 
Fix "Sign Up" link location
 2020-10-05 12:34:11 +10:00
Damien Elmes
bfd960af1a Merge pull request #777 from kelciour/mpv-anki-freeze-on-windows 
Separate player for videos on Windows
 2020-10-05 12:27:31 +10:00
Henrik Giesel
90572d1b7c Turn _class into rightside boolean flag 2020-10-04 23:03:37 +02:00
Henrik Giesel
b5b2a07a88 Refactor out theclass assignment 2020-10-04 22:51:34 +02:00
Henrik Giesel
716f8a103c Add editor_did_init_left_buttons gui_hook 2020-10-04 22:50:02 +02:00
Henrik Giesel
70b28b95a2 Make icon Optional explicitly in function signature 2020-10-04 22:42:28 +02:00
Henrik Giesel
b2d8db67f7 Rewrite so all editor toolbar buttons use _addButton 2020-10-04 22:41:18 +02:00
David Allison
94382867d0 Fix "Sign Up" link location 
String states "Sign Up", but currently points to the "Sign In" screen: https://ankiweb.net/account/login

c8a6d81fde/rslib/ftl/sync.ftl (L38-L42)
 2020-10-04 18:14:49 +01:00
Henrik Giesel
f7256569c5 Also focus main web instead of bottom web 2020-10-03 22:33:01 +02:00
kelciour
ec4bd071fe Separate player for videos on Windows 
https://forums.ankiweb.net/t/anki-crashes-because-of-mpv/3359/13
 2020-10-03 22:53:17 +03:00
abdo
375a395ef5 Paste links as plain text in basic mode 2020-10-03 19:46:05 +03:00
Damien Elmes
05f8ae116a Merge branch 'master' into fix-ui-scale 2020-10-03 09:44:04 +10:00
Akshara Balachandra
c5da91206b fix: sizing issue with scale UI 
Fixes ankitects/help-wanted#18. Height of webview should be the height
of the contents inside it. Previously, scale factors increased fixed
height of the container webview, thus creating empty space (e.g.
at 200% scaling, height of webview was double the height of the inner
HTML page). Now height of webview is always the height of the contained
element.
 2020-10-02 18:07:28 -04:00
abdo
a09a70fec2 Recognize ico files 
Local icons were being pasted as normal links previously instead of
being enclosed in img tags.
 2020-10-03 00:17:38 +03:00
Damien Elmes
2ed1507162 bump version 2020-10-02 10:22:21 +10:00
Damien Elmes
14885acc44 don't reschedule repeating timers that occur during progress 
For things like updating the deck list, it makes no sense to do it
multiple times at the end of a long operation, and the once/second signal
timer was causing hundreds or thousands of 100ms timers to be created.

https://forums.ankiweb.net/t/anki-memory-usage/3842
 2020-09-30 10:01:06 +10:00
Damien Elmes
722454bab1 Merge pull request #769 from abdnh/escape-sidebar-terms 
Escape browser sidebar search terms
 2020-09-27 16:06:10 +10:00
Damien Elmes
fa6ee12f47 fix links not opening externally after finishing 
https://forums.ankiweb.net/t/anki-2-1-34-35-beta/3569/19
 2020-09-27 14:36:55 +10:00
Damien Elmes
aefcdfa17f backups no longer happen on each sync 
https://forums.ankiweb.net/t/accidentally-deleted-backs-one-deck/3740/6
 2020-09-27 12:59:51 +10:00
Damien Elmes
86e8df58ee fix old content appearing when flagging 
https://forums.ankiweb.net/t/very-specific-but-quite-consistent-bug-in-browser/3685
 2020-09-27 12:31:25 +10:00
Damien Elmes
2cc4fad19a fix import shortcut 
https://forums.ankiweb.net/t/anki-2-1-34-35-beta/3569/21
 2020-09-27 11:57:12 +10:00
abdo
9ff8aa4830 Escape sidebar search terms 2020-09-25 21:05:34 +03:00
abdo
7aaf22b0a2 Fix previewer not refreshing when selecting multiple cards in browser 2020-09-24 07:05:16 +03:00
Damien Elmes
88114b0662 Merge pull request #767 from abdnh/context-menu-copy-image 
Allow copying of images using context menu
 2020-09-24 10:57:13 +10:00
Damien Elmes
1a619073d7 bump version 2020-09-24 10:52:24 +10:00
abdo
b20e022097 Allow copying of images using context menu 2020-09-22 06:32:37 +03:00
Damien Elmes
b57d1ed08a allow dragging of images in review screen again 
when we were using webkit+file URLs, this deleted files from the
media folder! But we're behind a HTTP server now, so this should
be safe.

https://forums.ankiweb.net/t/no-longer-able-to-copy-latex-output/3128/5

originally disabled in
dd4bae6e8d
 2020-09-22 10:29:53 +10:00
abdo
25c2eda7d2 'Show Both Sides' -> 'Back Side Only' 2020-09-20 19:31:00 +03:00
kelciour
401b1b43b2 Revert back to listening for idle callback 
https://forums.ankiweb.net/t/anki-2-1-33-linux-audio-stops-working/3023
 2020-09-16 09:25:18 +03:00
Damien Elmes
1b8d1303ca Merge pull request #758 from hgiesel/synchook 
Add sync_will_start and sync_did_finish hook
 2020-09-15 21:20:46 +10:00
Henrik Giesel
5981cebb8e Move sync_did_finish before reset 2020-09-15 13:06:11 +02:00
abdo
a410a1117a Support extended drag & drop 2020-09-14 17:07:31 +03:00
Henrik Giesel
306424455c Add some documentation to sync_did_finish hook 2020-09-14 13:18:16 +02:00
Henrik Giesel
52502fb1d3 Put sync_did_finish hook before after_sync because it might unload collection 2020-09-14 13:06:20 +02:00
Henrik Giesel
a685272e16 Add sync_will_start and sync_did_finish hook 2020-09-14 12:22:01 +02:00
Damien Elmes
32f5bc96a8 another showDupes fix from ANH 
https://forums.ankiweb.net/t/show-duplicates-not-working/2883/10
 2020-09-04 10:13:30 +10:00
Damien Elmes
a5955f0206 sound tags need filename html escaped 
https://forums.ankiweb.net/t/unable-to-play-longer-audio-on-cards/1313/30
 2020-09-04 09:36:38 +10:00
Damien Elmes
d81251676d Revert "Merge pull request #749 from ANH25/editor-media-autoplay" 
This reverts commit 373402ed0a, reversing
changes made to 35c59cb899.

https://github.com/ankitects/anki/pull/749#issuecomment-686385112
 2020-09-04 08:34:26 +10:00
Damien Elmes
bc60d233e5 rebuild_filtered_deck() and new_filtered() 2020-09-03 18:02:47 +10:00
Damien Elmes
6f7f5686e8 empty_filtered_deck() 2020-09-03 17:43:07 +10:00
Damien Elmes
f32d773e25 set_deck() 2020-09-03 17:42:46 +10:00
Damien Elmes
366c5c4774 log manual reschedule, but ignore the log entry in the stats 2020-09-02 17:56:23 +10:00
Damien Elmes
52425a9851 ensure background override works in night mode 2020-09-01 12:20:45 +10:00
Damien Elmes
9f51347e1e move bury/suspend into backend 2020-09-01 10:24:38 +10:00
Damien Elmes
a8f84c1264 formatting fixes for latest black 2020-09-01 10:24:38 +10:00
Damien Elmes
130f99fe44 fix some lints 2020-09-01 10:24:38 +10:00
Damien Elmes
fcf63205b6 add a hook to support extending external .html files 2020-09-01 10:24:38 +10:00
Damien Elmes
5536969f29 add load_ts_page() & avoid duplicate call 2020-09-01 10:24:38 +10:00
Damien Elmes
999b659c3a reimplement congrats screen in Rust+Typescript 2020-09-01 10:24:38 +10:00
Damien Elmes
a629e1acf2 apply standard zoom and background to graphs; prevent FOUC 2020-09-01 10:24:38 +10:00
Damien Elmes
7d84954f53 use css vars for graph styling as well; base webview.scss off core.scss 2020-09-01 10:24:38 +10:00
Damien Elmes
3b1a4d029c most of the .nightMode redefinitions are no longer required 2020-09-01 10:24:38 +10:00
Damien Elmes
2411e944e4 drop the old sass vars and define the properties directly 2020-09-01 10:24:38 +10:00
Damien Elmes
514409d86f migrate the majority of the sass vars to css variables 
Allows add-ons to easily override the theme, and allows us to apply
styling to elements outside of the normal document flow (like applying
the normal background colour to a position: fixed element).
 2020-09-01 10:24:38 +10:00
Damien Elmes
a6aaaf8691 move _vars to outer ts folder 
First step in sharing styling with graphs + future .html files
 2020-09-01 10:24:38 +10:00
Henrik Giesel
87bcc39a77 Some minor reformatting to satisfy black 2020-08-31 13:50:59 +02:00
Henrik Giesel
f32dc05daf Address broken translations and increase readibility of button insertion 2020-08-31 13:40:42 +02:00
Henrik Giesel
c87d60ea4c Remove unnecessary import 2020-08-31 13:35:18 +02:00
Henrik Giesel
31b2d46247 Fix type signature: models is passed because it's a method 2020-08-31 13:35:18 +02:00
Henrik Giesel
b9e26ae052 Remove duplicated buttons 2020-08-31 13:35:18 +02:00
Henrik Giesel
2a4f0edfe7 Don't import models in gui_hooks to avoid circular import 2020-08-31 13:35:18 +02:00
Henrik Giesel
14a33cb2ce Fix uninitialized buttons object 2020-08-31 13:35:18 +02:00
Henrik Giesel
6ee503742f Add compiled hook model_did_init_buttons 2020-08-31 13:35:18 +02:00
Henrik Giesel
14f4380c2e Add usage in models.py 2020-08-31 13:35:18 +02:00
Henrik Giesel
6d2f2282d2 Add gui_hook models_did_init_buttons 2020-08-31 13:35:01 +02:00
Henrik Giesel
a36a9ee3e0 Add unused add_button method 2020-08-31 13:33:59 +02:00
Damien Elmes
8729edffbb update to latest black 2020-08-31 13:29:28 +10:00
Damien Elmes
aeca369c9b update to latest isort, pylint and pytest 2020-08-31 12:05:36 +10:00
Damien Elmes
204db71586 fix new pylint raise-missing-from lint 2020-08-31 12:04:14 +10:00
Damien Elmes
0f24885581 Merge pull request #751 from ANH25/addon-config-editor-title 
Remove unicode isolation markers from add-on config editor title
 2020-08-31 11:10:44 +10:00
Damien Elmes
f3c6d565b0 bump version 2020-08-31 11:07:54 +10:00
ANH
ff4cb87433 remove unicode isolation markers from add-on config editor title 2020-08-31 00:35:17 +03:00
Damien Elmes
486ef03a0d fix card.template() in card layout screen 
https://forums.ankiweb.net/t/card-template-does-not-work-when-called-in-card-will-show-hook-in-template-editor/2798
 2020-08-30 11:23:44 +10:00
Damien Elmes
1ae6eb1255 add some names to about screen 
a reminder that anyone who's contributed is welcome - please just
send a PR adding yourself
 2020-08-27 11:24:13 +10:00
Damien Elmes
373402ed0a Merge pull request #749 from ANH25/editor-media-autoplay 
Only autoplay added media when recording in editor
 2020-08-27 10:37:42 +10:00
Damien Elmes
35c59cb899 Merge pull request #745 from ANH25/reviewer-context-menu-shortcut 
add shortcut for reviewer context menu
 2020-08-27 10:33:22 +10:00
ANH
063644a8f6 editor: only autoplay added media when recording 2020-08-26 14:49:19 +03:00
Damien Elmes
37fa80bbd6 Merge pull request #748 from ANH25/drag-and-drop 
fix drag & drop issue when dropping things over existing content
 2020-08-26 08:38:48 +10:00
Damien Elmes
a657310726 formatting 2020-08-26 08:36:08 +10:00
Damien Elmes
31f011b3a5 fix description in export screen (thanks to ANH) 
https://forums.ankiweb.net/t/anki-2-1-31-exporting-display-bug/2669/3
 2020-08-26 08:33:35 +10:00
Damien Elmes
ff10af10ac bigger default window size 
https://forums.ankiweb.net/t/increase-the-standard-window-size-so-all-buttons-are-visible/2613
 2020-08-26 08:06:46 +10:00
Damien Elmes
2f6d816cdc bump version 2020-08-26 08:05:45 +10:00
ANH
564f95c941 fix drag & drop issue when dropping things over existing content 2020-08-25 17:28:13 +03:00
Damien Elmes
52a7fa36cd fix signup link 2020-08-25 13:29:02 +10:00
Damien Elmes
58c8609332 bump version 2020-08-24 11:28:22 +10:00
ANH
6d69a0ba4e add shortcut for reviewer context menu 2020-08-23 17:46:47 +03:00
Damien Elmes
385a1c50fd 'cards' instead of 'notes' in export 
thanks to hgiesel; closes #744
 2020-08-23 13:48:20 +10:00
Damien Elmes
f9fe0504f0 fix formatting & lint 2020-08-21 12:36:18 +10:00
Damien Elmes
5adc3eff6f Merge pull request #735 from brownbat/master 
Add hook for initializing answer buttons
 2020-08-21 12:34:14 +10:00
Damien Elmes
f936735114 fix formatting 2020-08-21 11:45:14 +10:00
Damien Elmes
1db1f71261 Merge pull request #742 from evandroforks/fix_ts_sass 
Fix error reading scss;..\aqt_data\web: no such file or directory
 2020-08-21 11:44:55 +10:00
evandrocoan
36a8eff311 Fix error reading scss;..\aqt_data\web: no such file or directory 
Recently on my Windows, out of nowhere, it started throwing:
```
../../ts/node_modules/.bin/tsc --build
../../ts/node_modules/.bin/sass --no-source-map scss:..\\aqt_data\\web
Error reading scss;..\aqt_data\web: no such file or directory.
make: *** [Makefile:26: build] Error 66
```
 2020-08-20 22:22:33 -03:00
Damien Elmes
d91b686df2 Merge pull request #740 from kelciour/mpv-restart-fix 
Fix no sound after restarting mpv
 2020-08-21 11:10:46 +10:00
Damien Elmes
54f8a7ded5 Add comment 2020-08-21 11:10:30 +10:00
kelciour
580e561805 Reset av_player.current_player after mpv restart 2020-08-21 02:17:21 +03:00
Damien Elmes
e5c4ad9c78 Merge pull request #739 from ANH25/add-custom-study-ftl 
Add custom-study-must-rename-deck to Fluent
 2020-08-21 08:56:17 +10:00
Thomas B
c94336bbf5 Remove conflict- Sequence type no longer needed 2020-08-20 10:34:08 -04:00
Thomas B
e7e67e0c87 Fix other docstring to match. 2020-08-20 10:33:46 -04:00
Thomas B
718fd2c44d Clarify docstring 2020-08-20 10:30:31 -04:00
Damien Elmes
9393a33337 need to invalidate notetype cache on sync completion 
basicCheck() was populating it on startup sync, leading to
https://forums.ankiweb.net/t/error-when-adding-a-new-note/1664
 2020-08-20 15:35:23 +10:00
Damien Elmes
51ba6f6b31 fix find&replace getting too large 
https://forums.ankiweb.net/t/bug-find-and-replace-dialog-displays-length-of-longest-string-in-dropdown-list/2469
 2020-08-20 15:26:23 +10:00
Thomas B
3bcb7759d2 Add both Union and Sequence to typing import 
Resolve conflict.
 2020-08-19 16:19:15 -04:00
Thomas B
0450fde53a Update gui_hooks.py 2020-08-19 16:15:56 -04:00
Thomas B
a54135c5ac Fixing type hints 
Matched all type hints, changed the original Sequence[] type hint for _answerButtonList() in reviewer.py on mypy's recommendation.
 2020-08-19 16:15:49 -04:00
ANH
233e6abc55 add custom-study-must-rename-deck to Fluent 2020-08-19 18:27:14 +03:00
ANH
bfd08fa2be work around editor freeze issue after external drag & drop 2020-08-19 18:14:07 +10:00
Thomas B
9cbf5e2251 Update as part of previous commit 2020-08-18 10:38:59 -04:00
Thomas B
8b95ab5441 Bugfix proposed filter post-testing 
Mirrored filter more closely on _ReviewerWillAnswerCardFilter, including taking and returning the value to be modified.
 2020-08-18 10:37:45 -04:00
Henrik Giesel
2de59074a3 Remove ResetReason.BrowserDeleteNote 2020-08-17 12:50:40 +02:00
Henrik Giesel
8a3f6d72c7 Merge branch 'master' into resethook 2020-08-17 12:39:09 +02:00
Damien Elmes
67148b1c8a clear undo queue on sync 
https://forums.ankiweb.net/t/ios-ipad-sync-failure-with-filtered-decks/1617/34
 2020-08-17 20:09:07 +10:00
Damien Elmes
e573ed3eb6 close edit current window when card deleted 
https://forums.ankiweb.net/t/bug-report-editor-updating-non-existing-card/2117
 2020-08-17 20:07:48 +10:00
Damien Elmes
e856aa9952 fix duplicates not escaping html 
https://forums.ankiweb.net/t/bug-report-showdupes-not-html-escaping-field-content/2167
 2020-08-17 17:50:27 +10:00
Henrik Giesel
e613083018 Reorder gui_hooks imports 2020-08-16 23:34:24 +02:00
Henrik Giesel
a47cca75b2 Add Union import 2020-08-16 19:11:11 +02:00
Henrik Giesel
747c8532c2 Create ResetReason enum 2020-08-16 18:56:32 +02:00
Henrik Giesel
1f4e604e2b Rename to should_require_reset 2020-08-16 18:56:32 +02:00
Henrik Giesel
7bb4df13d9 Reorder + make all parameters optional 2020-08-16 18:56:32 +02:00
Henrik Giesel
0b9d7b2cb8 Satisfy formatter 2020-08-16 18:56:32 +02:00
Henrik Giesel
4f37e6196b Update signature of main_window_will_require_reset hook 2020-08-16 18:56:32 +02:00
Henrik Giesel
ea6eb2ba3b Add new use of requireReset 2020-08-16 18:56:32 +02:00
Henrik Giesel
9044a4b96b Insert gui_hook main_window_will_require_reset 
* into AnkiQt.requireReset method
 2020-08-16 18:56:32 +02:00
Henrik Giesel
28528fc3ec Add main_window_will_require_reset hook 2020-08-16 18:56:32 +02:00
Thomas B
830ab9cedb Add hook for initializing answer buttons 2020-08-14 13:52:20 -04:00
Arthur Milchior
e3e929fed2 Search_model has context 
I have an add-on which allow to open multiple windows. So would like to know which browser has done the search. This
would allow me to have browser with various setting. In particular, I've an add-on which allow to show a single line by
note, and I would like for some browser to have this feature on and for some other to have this feature off.
 2020-08-13 19:46:14 +02:00
Damien Elmes
2c500a1538 Merge pull request #732 from Arthur-Milchior/typing 
Typing
 2020-08-13 20:19:30 +10:00
Damien Elmes
90ad63cfa3 Merge pull request #730 from ANH25/rtl-editing 
fix Ctrl+right/left handling in RTL fields
 2020-08-13 20:09:51 +10:00
Damien Elmes
1dfe5b8165 remove RTL special case in cloze deletion 
https://forums.ankiweb.net/t/erroneous-characters-added-to-rtl-cloze-deletions/2164
 2020-08-13 19:11:48 +10:00
Arthur Milchior
110f4c664f Any removed 2020-08-12 01:37:21 +02:00
Arthur Milchior
a74601a0f0 NF: childMapNode 2020-08-12 00:42:42 +02:00
ANH
8ee74a02b2 add modify to the Selection interface 2020-08-11 03:32:58 +03:00
ANH
a2227960c0 fix Ctrl+right/left handling in RTL fields 2020-08-11 03:09:03 +03:00
Damien Elmes
bf1ac7e4a9 Merge pull request #728 from hgiesel/mungehtml 
Move "remove null bytes" and "reverse url formatting" functionality to editor_will_munge_html hook
 2020-08-10 16:33:56 +10:00
Henrik Giesel
31916102ed Add newlines 2020-08-09 11:16:19 +02:00
Henrik Giesel
6122b9ac53 Avoid extra assignment 2020-08-09 10:38:31 +02:00
Henrik Giesel
097538b061 Move reverse url quoting functionality to editor_will_munge_html hook 2020-08-09 10:37:38 +02:00
Henrik Giesel
612e38def3 Move remove null bytes functionality to editor_will_munge_html hook 2020-08-09 10:35:52 +02:00
Damien Elmes
d273f1b5b8 accept alternate strings file 2020-08-09 14:44:23 +10:00
Damien Elmes
ea2c5c6920 deauth -> log out 2020-08-09 14:44:03 +10:00
Damien Elmes
4629dd38fb bump version 2020-08-09 13:44:59 +10:00
Damien Elmes
c79bb313f8 Merge pull request #727 from hgiesel/mungehtml 
Add editor_will_munge_html hook
 2020-08-09 13:38:39 +10:00
Damien Elmes
41c95c07b4 make sure to reset after deleting empty cards 
https://anki.tenderapp.com/discussions/private/5067-anki-was-unable-to-open-your-file
 2020-08-09 12:42:58 +10:00
Damien Elmes
c366f07e65 find/replace completer should be case sensitive 
https://forums.ankiweb.net/t/bug-report-search-and-replace/2037
 2020-08-09 12:10:34 +10:00
Henrik Giesel
b3b77ea3b3 Replace functionality of mungeHTML with call to new gui_hook 2020-08-08 23:59:01 +02:00
Henrik Giesel
7d1d20cbf4 Add editor_will_munge_html hook 2020-08-08 23:27:58 +02:00
ANH
eecff63aa1 add card layout save shortcut 2020-08-06 13:23:17 +03:00
Damien Elmes
c2c929d63f avoid internal URLs in alert titlebar 
https://forums.ankiweb.net/t/anki-stats-no-longer-displaying-invalid-data-found-please-use-check-database-to-fix-the-problem/1902
 2020-08-06 09:50:12 +10:00
Damien Elmes
a2cbaa1ede fix Windows packages failing to start 2020-08-06 09:05:26 +10:00
Damien Elmes
4a13ffbfcf unnecessary f-string 2020-08-04 17:52:49 +10:00
Damien Elmes
d336ccd81a catch duplicate keys 2020-08-04 11:52:19 +10:00
Damien Elmes
c1bff288b8 convert po string extraction to GUI app 2020-08-04 11:21:39 +10:00
Damien Elmes
1ec9f606ea disable media get / posts when collection closed 
https://forums.ankiweb.net/t/countdown-to-events-exams-addon-official-thread/1093/4?u=dae
 2020-08-04 10:03:17 +10:00
Damien Elmes
c6b727f71a fix preview options responding to enter key by default 2020-08-03 13:32:38 +10:00
Damien Elmes
065e829a45 fix mobile class emulation 
should be set on html element
 2020-08-03 13:32:10 +10:00
Damien Elmes
02c7a0e339 enable strict equality checks in mypy 
Without it, the following code reports no problems:

def foo() -> int:
    return 5
print(foo == 5)
 2020-08-03 10:26:40 +10:00
Damien Elmes
6be12d6f90 fix automatic logout on auth failure not working 2020-08-03 10:24:49 +10:00
Damien Elmes
c14dc3ec38 check_untyped_defs can now be enabled globally for aqt 
A big thanks to Matt and phwoo who put in most of the work to get
to this point.
 2020-08-02 10:29:25 +10:00
Damien Elmes
c21cb89a93 fix untyped def issues in aqt/utils.py 2020-08-02 10:25:48 +10:00
Damien Elmes
5700d0c7a1 fix untyped def issues in aqt/mediasrv.py 2020-08-02 10:22:21 +10:00
Damien Elmes
1e05595e3a fix untyped def issues in aqt/__init__.py 2020-08-02 10:22:08 +10:00
Damien Elmes
efd6d81ba9 Merge pull request #723 from phwoo/typehints-for-qt-addons 
Typehints for qt addons
 2020-08-02 10:08:48 +10:00
Fabian Wood
d8bce7731f Fixed runtime error from changes in qt addons.py 
Changes to meet returning of Iterable (rather than List), meant
returning a different variable, but that may not have been created.
Reverted, changing to return List.
 2020-08-01 17:50:37 +10:00
Fabian Wood
00236ce253 Updated qt addons with more extensive typehints 2020-08-01 15:50:27 +10:00
Matt Krump
85ca0eff78 Turn on check_untyped_defs for aqt.progress 2020-07-31 21:00:08 -06:00
Matt Krump
411accc165 Turn on check_untyped_defs for aqt.main 2020-07-31 20:34:14 -06:00
Damien Elmes
f7eb3512a9 force stdout/stderr encoding to utf8 
As a GUI app, Anki only uses these for debugging info, and we've been
bitten numerous times in the past by bugs caused by printing Unicode
when the console only supported ASCII. An ens var might have been
a better approach, but Pyinstaller does not support defining them before
Python is initialized from what I can tell.

Latest issue:
https://forums.ankiweb.net/t/crashing-anki-version-2-1-29-3f62c1f7/1650
 2020-08-01 11:31:22 +10:00
Damien Elmes
684cf9732c pass night mode into body_class() instead of changing globally 2020-07-31 14:47:17 +10:00
Damien Elmes
58d3127d3c remove 'invert', as night mode is on when checkbox is on 2020-07-31 14:35:18 +10:00
Damien Elmes
9c2cb8bc2a fix button display on Macs 2020-07-31 14:23:56 +10:00
Damien Elmes
b5c72ac201 Merge branch 'master' into master 2020-07-31 14:14:10 +10:00
Damien Elmes
d4d73a4a59 Merge branch 'master' into help-wanted-4-add-type-hints-6 2020-07-31 14:07:59 +10:00
Damien Elmes
ee428d7949 Merge pull request #719 from ANH25/reviewer-hooks 
Add reviewer_will_play_question_sounds and reviewer_will_play_answer_sounds hooks
 2020-07-31 14:06:28 +10:00
Damien Elmes
ae796a5edd Merge pull request #718 from phwoo/typehints-for-qt-profiles 
Added typehints for qt profiles
 2020-07-31 14:04:29 +10:00
Damien Elmes
1bb256483c i18n some card template strings 
https://forums.ankiweb.net/t/untranslated-strings/1623
 2020-07-31 13:33:41 +10:00
Damien Elmes
961789562e refresh tag list after clearing unused 2020-07-31 13:33:41 +10:00
ANH
5d2cf10ee9 just forgot to regenerate gui_hooks.py to fix typo 2020-07-31 04:47:31 +03:00
ANH
9a768fc198 fix typo 2020-07-31 04:41:49 +03:00
Matt Krump
eef069f2b7 Turn on check_untyped_defs for aqt.emptycards 2020-07-30 18:43:57 -06:00
Matt Krump
1fe46438c0 Turn on check_untyped_defs for aqt.addons 2020-07-30 18:43:57 -06:00
Matt Krump
8feb2acbbf Turn on check_untyped_defs for aqt.webview 2020-07-30 18:43:57 -06:00
ANH
0eb48d3603 document hooks 2020-07-31 03:06:13 +03:00
ANH
23d0008a6f add reviewer_will_play_question_sounds and reviewer_will_play_answer_sounds hooks 2020-07-30 22:20:19 +03:00
ANH
2a5131a5d3 use 'Preview Settings' as a label for the new options button 2020-07-30 18:04:50 +03:00
Fabian Wood
4a7558f9be Added typehints for qt profiles 
* `Any` used for pickle methods, this could probably be improved
with some kind of Callable
* str used for self.base, though this may be a problem for
different OSes. Some type of os.PathLike might be good.
* Line 75, type ignored: mypy was complaining about no. of args,
and kwargs there didn't seem to be needed. Separate issue to test,
though.
 2020-07-31 00:56:48 +10:00
ANH
393403ffbf add night mode and mobile class toggles in card layout screen 2020-07-30 15:39:02 +03:00
Damien Elmes
3d947febab Merge pull request #715 from phwoo/typehints-for-qt-modelchooser 
Added typehints to qt/aqt/modelchooser.py, updated qt/mypy.ini
 2020-07-30 17:00:58 +10:00
Damien Elmes
fb029d844b Merge branch 'master' into add-type-hints-for-qt-models 2020-07-30 16:05:55 +10:00
Fabian Wood
b23129c3eb added typehints to modelchooser, updated mypy.ini 2020-07-30 15:25:25 +10:00
Fabian Wood
f0dabf4570 added type hints to qt models 2020-07-30 13:28:52 +10:00
Adam Plaice
df9e22aef5 Re-add previously supported file extensions for media 
(They had been removed in 6939d8ba5b).
 2020-07-29 15:08:33 +02:00
Damien Elmes
bb8127517f Merge pull request #703 from ANH25/master 
fix help-wanted#13
 2020-07-29 14:14:57 +10:00
Damien Elmes
aca9f5232c Merge branch 'master' into help-wanted-4-add-type-hints-5 2020-07-29 13:56:57 +10:00
Damien Elmes
55891fc8f7 clearer message when template error is preventing save 2020-07-29 12:53:03 +10:00
Matt Krump
d4511e3287 Turn on check_untyped_defs for aqt.exporting 2020-07-28 18:42:22 -06:00
Matt Krump
98d8e1c926 Turn on check_untyped_defs for aqt.editor 
* Turn on check_untyped_defs for aqt.browser
* Add type hints
 2020-07-28 18:42:22 -06:00
Damien Elmes
e1bfe68b9e Merge pull request #706 from mkrump/help-wanted-4-add-type-hints-4 
Turn on check_untyped_defs for aqt.taglimit, aqt.update and aqt.browser
 2020-07-28 13:16:49 +10:00
Damien Elmes
d3653ab6d5 bump version 2020-07-28 12:59:56 +10:00
Damien Elmes
ee10fd9008 don't throw error on empty path 
https://forums.ankiweb.net/t/anki-2-1-28-error-message-when-reviewing-cards/1439
 2020-07-27 11:28:32 +10:00
Matt Krump
1317b9f2b5 Fix browser.py import sorting 2020-07-26 13:16:06 -06:00
Matt Krump
0d8979f05e Cast set to list to fix mypy failure in browser.py 2020-07-26 13:00:06 -06:00
Damien Elmes
1d1f5e1afc apply AltGr workaround on qt 5.14 as well 2020-07-26 10:13:53 +10:00
Matt Krump
f27d465d69 Turn on check_untyped_defs for aqt.browser 
* Turn on check_untyped_defs for aqt.browser
* Add type hints to browser
 2020-07-25 17:31:49 -06:00
Matt Krump
a389e3ca94 Turn on check_untyped_defs for aqt.update 
* Turn on check_untyped_defs for aqt.update
 2020-07-25 17:31:44 -06:00
Matt Krump
8d988d2b6f Turn on check_untyped_defs for aqt.taglimit 
* Add type hints taglimit
* Turn on check_untyped_defs for aqt.taglimit
 2020-07-25 15:45:31 -06:00
ANH
9279d5e33d Merge branch 'master' into master 2020-07-25 05:24:45 +03:00
Damien Elmes
6ad544cf62 Merge branch 'master' into help-wanted-4-add-type-hints-3 2020-07-25 11:43:46 +10:00
Matt Krump
e93ae88cdf Add type hints to importing 
* Add type hints to importing
* Turn on type checking for aqt.importing
 2020-07-24 12:38:34 -06:00
Matt Krump
38651d6a4e Add type hints to errors 
* Add type hints to errors
* Turn on type checking for aqt.errors
 2020-07-24 11:20:54 -06:00
Matt Krump
a88f935a8c Add type hints to aqt.models 
* Add type hints to aqt.models
* Turn on type checking for aqt.models
 2020-07-24 10:59:45 -06:00
ANH
a777784a38 add missing string r flag 2020-07-24 09:18:05 +03:00
ANH
3ad5c866b3 formatting 2020-07-24 09:00:34 +03:00
ANH
3276cc2e5e avoid string concatenation 2020-07-24 08:12:46 +03:00
Matt Krump
90457e5f20 Add type hints for apt.deckconf 
* Add type hints for apt.deckconf
* Turn on check_untyped_defs for apt.deckconf
 2020-07-23 21:53:12 -06:00
ANH
939f3c8dc7 fix ankitects/help-wanted#13 2020-07-24 06:00:55 +03:00
Damien Elmes
7e4b2ac4d9 fix lint issue in previewer, and drop unused code 
No add-ons appear to be using the removed code, and Anki wasn't
using it either.
 2020-07-24 12:18:37 +10:00
Damien Elmes
4dff66cd10 formatting and debug statement tweak 2020-07-24 11:57:37 +10:00
Damien Elmes
d8ff54c884 fix preview not updating on edit 
https://forums.ankiweb.net/t/modification-and-preview/1331
 2020-07-24 11:57:22 +10:00
Damien Elmes
5104c0fd1b enable AltGr workaround by default 
5.15.1 may still be another month away
 2020-07-24 10:32:50 +10:00
Damien Elmes
d460549b8f ask user to check db when graphs fail to load 2020-07-24 09:56:28 +10:00
Damien Elmes
538f399787 Merge pull request #702 from mkrump/help-wanted-4-add-type-hints 
Add type hints for apt.dyndeckconf
 2020-07-24 09:01:07 +10:00
Matt Krump
51e50c176b Add type hints for apt.dyndeckconf 
* Add type hints for apt.dyndeckconf
* Turn on check_untyped_defs for apt.dyndeckconf
 2020-07-23 16:04:46 -06:00
kelciour
6f8585b98a Add --no-autoload-files option to mpv 2020-07-23 14:28:47 +03:00
Damien Elmes
fd45d7e2ae fix misaligned deck heading in RTL languages 
https://forums.ankiweb.net/t/anki-2-1-29-beta/1220/2?u=dae
 2020-07-22 11:00:39 +10:00
Damien Elmes
f33451f12f fix pylint failing in CI 2020-07-21 16:16:34 +10:00
Damien Elmes
47a9b523f7 protect against exception on initial recording wait 2020-07-21 16:07:58 +10:00
Damien Elmes
7e78d12b99 bump version 2020-07-21 15:54:14 +10:00
Damien Elmes
d084898b92 trigger recording permission on newer macOS SDKs 2020-07-21 15:54:04 +10:00
Damien Elmes
1b0228c4fc formatting 2020-07-21 14:17:56 +10:00
Damien Elmes
876f474b7d apply rtl dir to webviews 
https://forums.ankiweb.net/t/gui-problems-with-right-to-left-languages/1205
 2020-07-21 11:52:25 +10:00
Damien Elmes
976d42cc90 full sync terminates media sync; start it again afterwards 
https://forums.ankiweb.net/t/media-files-not-downloaded-in-first-full-sync-v2-1-28/1198/3
 2020-07-21 11:26:41 +10:00
Damien Elmes
3ca4a882a1 Merge pull request #692 from Arthur-Milchior/remove_useles_variables 
Remove useless variables
 2020-07-20 11:35:40 +10:00
Damien Elmes
8fb3da2e27 split add-ons window title from menu bar action 
https://anki.tenderapp.com/discussions/private/4781-print-mistake
 2020-07-19 09:49:36 +10:00
Damien Elmes
2ed481c37a catch SIGTERM, and respond more quickly 2020-07-18 11:26:04 +10:00
Arthur Milchior
71afb2b4d3 Remove useless variables 2020-07-17 08:38:48 +02:00
Damien Elmes
5f93eaaf8f i18n downgrade&quit button 2020-07-17 15:06:14 +10:00
Damien Elmes
9a457266f4 Merge pull request #690 from glutanimate/stats-will-show-hooks 
Add a couple of hooks to trigger add-on actions before showing stats
 2020-07-17 14:38:41 +10:00
Glutanimate
7056765179 Fix type annotation for old stats dialog class 2020-07-17 03:08:09 +02:00
Glutanimate
b7c8374095 Add a couple of hooks to trigger add-on actions before showing stats 2020-07-16 21:48:46 +02:00
Glutanimate
a9334014d3 Make sure to set domDone to False before loading URLs 
Fixes an issue where JS would be evaluated prematurely in views
directly loaded from URLs.
 2020-07-16 19:56:57 +02:00
Damien Elmes
baed2d8fa5 formatting 2020-07-16 13:55:53 +10:00
Damien Elmes
e471497bd2 add platform version back into sync metadata 2020-07-16 10:12:41 +10:00
Damien Elmes
d598a76f4a can't rely on stdout to handle unicode 2020-07-15 09:36:29 +10:00
Damien Elmes
c6f8854ec8 Revert "Added parameter/return types, fixed possible logic error and typo" 2020-07-13 21:25:44 +10:00
Damien Elmes
9a3a96e599 Merge pull request #686 from zerrs/master 
Added parameter/return types, fixed possible logic error and typo
 2020-07-13 21:25:16 +10:00
Damien Elmes
178a8fb29e Update customstudy.py 2020-07-13 21:24:18 +10:00
Damien Elmes
35494414cc Merge pull request #684 from flagist0/select-note-type-with-ctrl-plus-digit-key 
Allow to choose note type from list by pressing ctrl + row number
 2020-07-13 21:23:35 +10:00
Alexander Presnyakov
98238e1707 Don't call setCurrentRow if row didn't change 2020-07-13 12:33:36 +03:00
zzzz
f6c0560660 Added some return and parameter types in customstudy.py, also fixed a possible logic error in plus function and a small typo 2020-07-13 01:32:08 -04:00
kelciour
6ca239a247 Scroll media sync log to the last line 2020-07-13 03:06:44 +03:00
Alexander Presnyakov
3ccc6ce61a Allow to choose note type from list by pressing ctrl + row number 2020-07-12 22:15:58 +03:00
Damien Elmes
4e1bc76596 mediasrv symlink fix 
https://forums.ankiweb.net/t/anki-2-1-28-beta/629/39
 2020-07-11 10:53:41 +10:00
Glutanimate
ee8696cbf3 Add top_toolbar_did_redraw hook 
Notifies add-ons of the top toolbar being redrawn
 2020-07-10 17:38:40 +02:00
Damien Elmes
6e07ab64af formatting 2020-07-07 13:28:30 +10:00
Damien Elmes
a2b4160d60 tidy up logging 2020-07-07 10:50:12 +10:00
Damien Elmes
c5f36ccf08 if webexports does not match, return 403 2020-07-07 10:50:03 +10:00
evandrocoan
af731fa739 Fix _addons/ URL prefix not being removed on Windows systems 
Anki 2.1.28 Beta
https://forums.ankiweb.net/t/anki-2-1-28-beta/629/26

> Did the requirements on how to expose resources on the internal server change? Because scripts, css files and the like, registered with setWebExports, do not work anymore with beta2.
> A look at the console shows the following for all resources:
> Failed to load resource: the server responded with a status of 500 (INTERNAL SERVER ERROR)

**\Anki2\addons21\someaddon\__init__.py**
```py
from aqt import mw
import aqt

# assuming add-on folder is named "test"
# and assuming a 'test.js' is in the same folder
addon_id = "someaddon"
port = mw.mediaServer.getPort()
mw.addonManager.setWebExports(addon_id, ".*\\.js$")

print("Hello")

aqt.editor._html += f"""
<script>
    var script = document.createElement('script');
    script.type = 'text/javascript';
    script.src = 'http://127.0.0.1:{port}/_addons/{addon_id}/test.js';
    document.body.appendChild(script);
</script>"""
```
 2020-07-06 13:51:37 -03:00
Andreas Reis
3628011599 Always use standard QT color dialog on Linux 
On Linux only Gnome uses its own color dialog, and it's inferior to QT's own: See the same issue @ https://github.com/OpenShot/openshot-qt/pull/2425

(This is/was visible only on some distributions' packaged versions of Anki, not via ./run.)

isLin check since QT on Windows already uses the default, whereas Mac's own picker seems superior (from what I can judge by screenshots).
 2020-07-05 13:21:38 +02:00
Damien Elmes
85dd611b72 don't stuff mw into function objects 
Using the global is preferable to fighting against mypy to insert mw
into a function object.
 2020-07-03 10:55:29 +10:00
Damien Elmes
17f80e4a7a port previous css workaround to flask 2020-07-03 10:40:23 +10:00
Damien Elmes
d1253bbfa0 Merge pull request #554 from evandroforks/fix_html5_media_support 
Fixed HTML5 media tags
 2020-07-03 10:25:43 +10:00
evandrocoan
f96e090b72 Replaced flask.Response by flask.make_response to simplify the 
implementation and because make_response is preferred over Response
as it respects the server defined Response type.
 2020-07-02 20:39:03 -03:00
evandrocoan
6c5311417f Removed duplicated mediasrv.py security check and fixed invalid 
command/path error message.
 2020-07-02 20:39:03 -03:00
evandrocoan
2de914267b Fix jest unit tests after merge 
# Conflicts:
#	qt/aqt/mediasrv.py
#	qt/ts/src/ankimedia.ts
#	qt/ts/src/reviewer-exceptions.test.ts
#	qt/ts/src/reviewer.test.ts
#	ts/package.json
 2020-07-02 14:30:43 -03:00
evandrocoan
3ae83a0ec3 Replaced send_from_directory by send_file to simplify the code 2020-07-02 13:52:07 -03:00
evandrocoan
9bd8e494b3 Ensure protection against directory transversal 
https://security.openstack.org/guidelines/dg_using-file-paths.html
 2020-07-02 13:52:03 -03:00
evandrocoan
11183ac1f3 Fixed aqt/mediasrv.py:14: error: unused 'type: ignore' comment 
from waitress.server import create_server  # type: ignore
https://github.com/evandroforks/anki/runs/743801391#step:25:1129
 2020-07-02 13:51:59 -03:00
evandrocoan
7033329012 Replaced the mediasrv.py SimpleHttp server by flask and waitress, 
fixing HTML5 media support.
https://stackoverflow.com/questions/37044064/html-audio-cant-set-currenttime
https://stackoverflow.com/questions/21956683/enable-access-control-on-simple-http-server
https://stackoverflow.com/questions/5052635/what-is-relation-between-content-length-and-byte-ranges-in-http-1-1
https://stackoverflow.com/questions/16725907/google-app-engine-serving-mp3-for-audio-element-needs-content-range-header

I was trying to use HTML5 audio tag to display audios like:
```html
<audio id="elem_audio" src="myfile.mp3" controls></audio>
```
![image](https://user-images.githubusercontent.com/5332158/79063321-565b5500-7c77-11ea-9f8d-6e1df6f07892.png)

But the progress bar seek was not working. After researching, I found the problem was the HTML server not properly responding to the HTML5 header requests. The HTML server should respond to quite complicated things as 206 partial, properly handle keep-alive, provide media ranges and other HTTP headers: https://stackoverflow.com/questions/37044064/html-audio-cant-set-currenttime

To implement all these on the Simple HTTP server would be quite complicated. Then, instead, I imported the `flask` web server, which is quite simple and straight forward to use. Now, the back-end is using a secure complaint HTTP back-end:
1. https://palletsprojects.com/p/flask/
    > Flask is a lightweight WSGI web application framework. It is designed to make getting started quick and easy, with the ability to scale up to complex applications. It began as a simple wrapper around Werkzeug and Jinja and has become one of the most popular Python web application frameworks.
    >
    > Flask offers suggestions, but doesn't enforce any dependencies or project layout. It is up to the developer to choose the tools and libraries they want to use. There are many extensions provided by the community that make adding new functionality easy.

1. https://docs.pylonsproject.org/projects/waitress/en/latest/
    > Waitress is meant to be a production-quality pure-Python WSGI server with very acceptable performance. It has no dependencies except ones which live in the Python standard library. It runs on CPython on Unix and Windows under Python 2.7+ and Python 3.5+. It is also known to run on PyPy 1.6.0 on UNIX. It supports HTTP/1.0 and HTTP/1.1.

Right now, anki does not support fields passing file names directly to HTML audio tags, but this can be easily done with (https://github.com/ankitects/anki/pull 540 - Added arguments to the sound tag) plus the commit 826a97df61, the HTML5 audio tag can be used like this:
```html
// Audio = [sound:myfile.mp3|onlyfilename]
<audio id="elem_audio" src="{{Audio}}" controls controlsList="nodownload"></audio>
```
![image](https://user-images.githubusercontent.com/5332158/79063736-c539ad80-7c79-11ea-8420-40b72185f4e7.png)

# Conflicts:
#	qt/aqt/mediasrv.py
 2020-07-02 13:51:49 -03:00
Damien Elmes
f093acc0e8 dump error on profile load fail 
may help diagnose
https://forums.ankiweb.net/t/i-couldnt-open-anki-resetting-corrupt-global/190
 2020-07-02 10:35:01 +10:00
Damien Elmes
313b40f836 defer top toolbar drawing until after add-ons loaded 
https://forums.ankiweb.net/t/anki-2-1-28-beta/629/13
 2020-07-02 10:23:14 +10:00
Damien Elmes
67cde145b1 add new strings to .po files as part of template update 
Pontoon appears to only update existing gettext translations; it
won't add new ones on its own. Fixes
https://forums.ankiweb.net/t/anki-2-1-28-beta/629/6
 2020-07-02 10:03:39 +10:00
Damien Elmes
a5e78485f4 fix scrollbars on fields on Windows/Linux 2020-07-02 09:51:50 +10:00
Damien Elmes
4e7ae0969f formatting 2020-07-01 14:01:24 +10:00
Damien Elmes
c5ef40e5ec don't allow table inside field to extend outside of field 
https://anki.tenderapp.com/discussions/private/4498-adjust-textbox-geometry-in-add-note-window
 2020-07-01 12:13:04 +10:00
Damien Elmes
ed4c74ca4d add option to disable media syncing 
https://forums.ankiweb.net/t/error-when-adding-audio-file/495/2
 2020-07-01 11:35:24 +10:00
Damien Elmes
9bb45673a8 show clearer error when media db locked 
should not happen frequently during a sync, but may happen during
the initial change checking stage

https://forums.ankiweb.net/t/error-when-adding-audio-file/495/2
 2020-07-01 11:19:06 +10:00
Damien Elmes
c61f52d871 shift+click on the graphs button to access old graphs for now 2020-06-30 20:07:46 +10:00
Damien Elmes
6ad4111723 graphs now work in night mode 2020-06-30 16:23:46 +10:00
Damien Elmes
33317d41b3 update edited/changed column labels 
https://github.com/ankitects/anki/pull/674/files
 2020-06-29 18:34:03 +10:00
Damien Elmes
78fbaf7724 plug new graphs code into GUI 
Still some work to do. Feedback welcome!
 2020-06-29 15:53:56 +10:00
Damien Elmes
06d9f64dea lint fixes 2020-06-29 15:53:56 +10:00
Damien Elmes
d3feb931ba add option to webview to skip external browser open 2020-06-29 15:48:01 +10:00
Damien Elmes
94f75f0728 include generated js in aqt_data 2020-06-29 15:48:01 +10:00
Damien Elmes
349eca843b get i18n working in typescript 2020-06-29 15:48:01 +10:00
Damien Elmes
0293f2220c qt's js code now shares ts/node_modules; more graph work 2020-06-29 15:48:01 +10:00
Damien Elmes
27ac65418c update qt ts to prettier 2.0 2020-06-29 15:48:01 +10:00
Damien Elmes
93e1b907ba add top level component and pass search/day limit back from frontend 2020-06-29 15:48:00 +10:00
Damien Elmes
1e9901e9bd experiment with exposing raw card/revlog data to frontend 2020-06-29 15:48:00 +10:00
Damien Elmes
cfb76f8305 Merge pull request #675 from kelciour/mpv-changes-2 
A few mpv changes 2
 2020-06-29 15:47:09 +10:00
kelciour
66d69c3460 Fix "make check" by defining dummy _register_callbacks method in MPVBase 2020-06-27 13:07:46 +03:00
kelciour
39eec24c3d Fix no sound after mpv restart 2020-06-27 03:46:40 +03:00
kelciour
7518597408 Replace mpv "idle" property with "end-file" event 2020-06-27 03:46:40 +03:00
kelciour
88103d29cf Replace default mpv quit keybindings if mpv version is >= 0.30 
4614d432a8
 2020-06-27 03:46:40 +03:00
neitrinoweb
460ac4165d add type hints 2020-06-25 17:27:52 +03:00
neitrinoweb
4d9fe86b3c fix missing typing import 2020-06-25 16:53:24 +03:00
Damien Elmes
f38c9b4272 work around yet another qt bug 
https://anki.tenderapp.com/discussions/beta-testing/2017-httpsforumsankiwebnettrestore-defaults-config-not-visually-updated420
 2020-06-24 11:12:45 +10:00
Damien Elmes
3396dc3d18 remove the script-message commands that older mpv version don't support 
https://github.com/ankitects/anki/pull/671#issuecomment-647798343
 2020-06-23 14:30:42 +10:00
Damien Elmes
4d16dc243d remove mpv keybindings on init 
On a machine here, they cause the following error:

    raise MPVCommandError("%r: %s" % (message["command"], e))
aqt.mpv.MPVCommandError: ['keybind', 'q', 'stop']: invalid parameter
 2020-06-22 13:22:57 +10:00
Damien Elmes
8e73b77476 Merge pull request #671 from kelciour/mpv-changes 
A few mpv changes
 2020-06-22 12:12:58 +10:00
Damien Elmes
b43096c535 Merge pull request #670 from evandroforks/print_version 
Create the command line argument -v/--version to print version
 2020-06-22 12:06:18 +10:00
kelciour
fa635cfe17 Reset pause mode when switching to the next file 2020-06-20 02:04:35 +03:00
kelciour
1283e48603 Replace deprecated "idle" event with "idle-active" property 2020-06-20 02:04:35 +03:00
kelciour
ce3d3a3633 Disable OSC idle message 2020-06-20 02:04:34 +03:00
kelciour
ba9c4a5175 Replace default mpv "quit" keybindings with "stop" 
https://github.com/mpv-player/mpv/blob/master/etc/input.conf
 2020-06-20 02:04:34 +03:00
evandrocoan
5d166f990d Create the command line argument -v/--version to print version 
https://forums.ankiweb.net/t/i-couldnt-open-anki-resetting-corrupt-global/190
 2020-06-19 13:13:10 -03:00
Arthur Milchior
7319ab8231 Strip name of added deck 
There is currently what I believe to be a bug: create a deck "   ".
The creation is accepted and the name is renamed to "blank". Instead,
I believe you'd want to strip the deck name before testing its
emptiness.
 2020-06-17 11:58:33 +02:00
Damien Elmes
f5694a7e4a migrate card stats to backend 
Currently this renders the HTML directly like the previous Python
implementation - doing it in JS would probably make more sense in the
future.
 2020-06-15 17:22:16 +10:00
Damien Elmes
fc99306d22 Merge pull request #667 from BlueGreenMagick/refresh-deck-list 
refresh deck list when adding deck via deckchooser
 2020-06-12 09:12:51 +10:00
Damien Elmes
e0e9b91b92 Merge pull request #666 from BlueGreenMagick/studydeck-name 
get deck name after adding deck
 2020-06-12 09:12:21 +10:00
Damien Elmes
91fb5c1658 Merge pull request #665 from BlueGreenMagick/remove-a-var 
Add type hints to deckchooser
 2020-06-12 09:11:54 +10:00
Damien Elmes
154ee7a962 remove ellipsis 2020-06-12 09:04:19 +10:00
BlueGreenMagick
c824d45b2e add typehint to deckchooser.py 
every occurunce of self.widget is type ignored
because QHBoxLayout has a method named widget
renaming this property will allow type hints
 2020-06-11 14:19:36 +09:00
BlueGreenMagick
512a9afed6 refresh deck list when adding deck via deckchooser 2020-06-11 13:00:10 +09:00
BlueGreenMagick
5aa0addca2 get deck name after adding deck 2020-06-11 12:50:17 +09:00
BlueGreenMagick
d1b3897f86 remove self.deck set to mw.col as it isn't used 2020-06-11 11:59:27 +09:00
Quentin Nerden
a3e4449ec7 Update message to match gui 
The Change Note Type... command is under the Notes menu, not the Edit menu
 2020-06-09 11:49:47 +02:00
Damien Elmes
ef5f37efef Merge pull request #650 from evandroforks/remember_last_inputs 
Remember last inputs for Find and Replace and Duplicates Find
 2020-06-09 14:43:58 +10:00
Damien Elmes
43fae1cede Merge pull request #662 from gaul/screen/none 
Handle None from QApplication.desktop().screen()
 2020-06-09 14:42:59 +10:00
Damien Elmes
4e6dbd471c Merge pull request #655 from Arthur-Milchior/history_line 
History line
 2020-06-09 14:42:45 +10:00
Damien Elmes
87fcaf9bfe remove unused import 2020-06-09 14:14:12 +10:00
Damien Elmes
7a035a7bfa formatting 2020-06-09 14:07:39 +10:00
Damien Elmes
6d7be475e6 catch invalid regex in search 
https://github.com/ankitects/anki/pull/652
 2020-06-09 11:46:07 +10:00
Damien Elmes
8d3b2aa88f (un)escape image references in HTML editor to fix ampersand handling 
https://anki.tenderapp.com/discussions/ankidesktop/41479-image-names-with-are-breaking
 2020-06-09 11:22:07 +10:00
Andrew Gaul
00ca676df5 Handle None from QApplication.desktop().screen() 
This prevents a crash when Anki is open for multiple days.  Reference:
https://anki.tenderapp.com/discussions/ankidesktop/41879-qt-cannot-create-window-no-screens-available
 2020-06-09 09:57:35 +09:00
Damien Elmes
446577d694 allow input.conf in Anki data folder 
https://anki.tenderapp.com/discussions/beta-testing/1964-anki-2128-alpha#comment_48382756
 2020-06-09 10:26:25 +10:00
Damien Elmes
d62ba1e713 fix mistaken qconnect replacement 2020-06-09 10:20:16 +10:00
Damien Elmes
62307a6651 fix 'NoneType' object has no attribute 'latest_progress' 
https://anki.tenderapp.com/discussions/beta-testing/1964-anki-2128-alpha#comment_48382636
 2020-06-09 09:07:41 +10:00
evandrocoan
66c9afa031 Moved the utils.py new save/restore functions together 2020-06-08 16:23:32 -03:00
evandrocoan
650d7ddb8b Renamed save_combo_index to save_combo_index_for_session 2020-06-08 16:23:28 -03:00
Arthur Milchior
f9b0f6e7b3 hook: history_line 
I expect to use this hook to create an add-on which will simply remove
the ",,". By ignoring empty fields I expect to make this easier to
use.
 2020-06-08 20:47:01 +02:00
Damien Elmes
75471224fa add progress to db check 2020-06-08 21:07:36 +10:00
evandrocoan
5949f2b7cc Renamed new function on qt/aqt/utils.py to snake case 2020-06-08 01:35:31 -03:00
evandrocoan
a4aa0672e0 Created the profiles.py session attribute for things to forgot 
each time Anki restarted and set to only fill the find and replace
dialogs when they were filled on the actual session.
 2020-06-08 01:35:31 -03:00
evandrocoan
d2323e4448 Moved restoreComboHistory below saveComboHistory as others 2020-06-08 01:35:31 -03:00
evandrocoan
b351a41f6c Set to browser.py finddupes.ui remember the last selected field 
https://anki.tenderapp.com/discussions/ankidesktop/39468-find-and-replace-does-not-remember-the-input-from-last-time
 2020-06-08 01:35:31 -03:00
evandrocoan
9dbbb65570 Added some type checking to utils.py QComboBox restore functions 
# Conflicts:
#	qt/aqt/utils.py
 2020-06-08 01:35:31 -03:00
evandrocoan
efa8214d8f Moved restoreComboHistory closer to restoreComboIndex on utils.py 2020-06-08 01:35:31 -03:00
evandrocoan
3c8d6eb802 Renamed setupComboBoxHistory to restoreComboHisotory, 
saveComboActiveIndex to saveComboIndex, saveComboBoxHistory to
saveComboHistory and restoreComboActiveIndex to restoreComboIndex.
 2020-06-08 01:35:31 -03:00
evandrocoan
bada70a7d6 Set to browser.py finddupes.ui remember the last search text 
https://anki.tenderapp.com/discussions/ankidesktop/39468-find-and-replace-does-not-remember-the-input-from-last-time
 2020-06-08 01:35:31 -03:00
evandrocoan
074be2bfb5 Set to browser.py findreplace.ui remember the last selected field 
by creating saveComboActiveIndex and restoreComboActiveIndex.

https://anki.tenderapp.com/discussions/ankidesktop/39468-find-and-replace-does-not-remember-the-input-from-last-time
 2020-06-08 01:35:31 -03:00
evandrocoan
7095eb41a2 Set to browser.py findreplace.ui remember the last regex/case 
by creating the saveIsChecked and restoreIsChecked.

https://anki.tenderapp.com/discussions/ankidesktop/39468-find-and-replace-does-not-remember-the-input-from-last-time
 2020-06-08 01:35:31 -03:00
evandrocoan
8c2cd37501 Created the setupComboBoxHistory and saveComboBoxHistory to remove 
duplicated/common code.
https://anki.tenderapp.com/discussions/ankidesktop/39468-find-and-replace-does-not-remember-the-input-from-last-time
 2020-06-08 01:35:31 -03:00
evandrocoan
fc4a3b85cf Set to remember the last replace input for findreplace.ui 
https://anki.tenderapp.com/discussions/ankidesktop/39468-find-and-replace-does-not-remember-the-input-from-last-time
 2020-06-08 01:35:31 -03:00
evandrocoan
c27c5a523d Set to remember the last find input for findreplace.ui 
https://anki.tenderapp.com/discussions/ankidesktop/39468-find-and-replace-does-not-remember-the-input-from-last-time
 2020-06-08 01:35:31 -03:00
Damien Elmes
7f54af3d73 Merge pull request #660 from brownbat/tooltip-positioning 
Update tooltip() in utils.py
 2020-06-08 11:40:43 +10:00
Damien Elmes
919adf0d04 Merge pull request #659 from BlueGreenMagick/paste-typehint 
add type hint to paste-related functions
 2020-06-08 11:32:16 +10:00
Damien Elmes
3967dd9b78 Merge pull request #657 from BlueGreenMagick/prof-name 
don't allow addons21 as profile name
 2020-06-08 11:30:27 +10:00
Damien Elmes
2bb93e42c6 pin legacy modules 
https://anki.tenderapp.com/discussions/ankidesktop/42248-potentially-serious-image-issue#comment_48388863
 2020-06-08 11:12:51 +10:00
Thomas B
6bbddb9639 Update tooltip() in utils.py 
Allow x,y offsets to be specified for tooltip(), useful for accomodating longer tooltips.
 2020-06-07 16:06:23 -04:00
BlueGreenMagick
9029ea735c add type hint to paste-related functions 2020-06-07 12:06:11 +09:00
BlueGreenMagick
1be62f8cc5 don't allow addons21 as profile name 
because addons21 and profiles directory are stored in same directory
 2020-06-05 22:44:59 +09:00
Damien Elmes
c5e65d02e1 add note/card removal to backend 2020-06-04 18:21:04 +10:00
Damien Elmes
80987a34ab add .count() to hooks, and list->sequence in note deletion 2020-06-04 18:20:03 +10:00
evandrocoan
0ca8cd4e4d Add missing quotes to typecheck-setup.sh for paths with spaces on 
the name.
 2020-06-02 21:37:58 -03:00
Damien Elmes
86689c5e77 more fixes for bundled Qt types 2020-06-03 09:55:30 +10:00
Damien Elmes
56d07fdc49 update qt version pin 2020-06-03 09:55:04 +10:00
Damien Elmes
4d9d51a2af lint fixes 2020-06-02 17:58:14 +10:00
Damien Elmes
2b01c5c607 new stubs don't require as many ignores 2020-06-02 17:56:32 +10:00
Damien Elmes
7716e3b17e Switch to PyQt 5.15's (slightly broken) built-in stubs 2020-06-02 17:52:18 +10:00
Damien Elmes
d2fd4bf39e fix initial login 2020-06-02 15:10:58 +10:00
Damien Elmes
d0a498a564 save browser columns when changed, not on each browser close 2020-06-02 13:39:15 +10:00
Damien Elmes
d7a2e78c0b change sync label to indicate sync state 
- blue for normal sync, red for full sync required
- refactor status fetching code so we don't hold a collection lock
during the network request, which slows things down
- fix sync spinner restarting when returning to deck list
 2020-06-02 13:23:01 +10:00
Damien Elmes
e8f33e1526 fix media sync progress not updating, and issues closing profile 2020-06-01 13:57:10 +10:00
Damien Elmes
4fb5b22726 make sure browser sidebar refreshes on reset() 
if items are modified in a sync, the sidebar needs to reflect it
 2020-06-01 13:57:10 +10:00
Damien Elmes
ad3082d1c8 handle aborting normal sync 
- Use a separate abort handle, as the media sync is running
in the background and we need to be able to target them separately.
The current progress handling is going to need a rethink if we introduce
any other background tasks in the future.
- Roll back the transaction when interrupting.
 2020-06-01 13:57:10 +10:00
Damien Elmes
da1e0527ca report normal sync progress 
Also:
- provide a way for the progress handler to skip the throttling so that
we can ensure progress is updated at the end of a stage
- show 'checking' at the end of full sync
 2020-06-01 13:57:10 +10:00
Damien Elmes
d422b069de lint fixes 2020-06-01 13:57:10 +10:00
Damien Elmes
f171f74dc3 unify sync error handling; handle interrupted 2020-06-01 13:57:10 +10:00
Damien Elmes
b552dfb986 add "immediate" progress back 
on ops which we know are going to take time, it makes the interface
look more responsive to pop up the progress more quickly
 2020-06-01 13:57:10 +10:00
Damien Elmes
9698cb4f22 update auto-sync code 2020-06-01 13:57:10 +10:00
Damien Elmes
03465173dd show server message if present 2020-06-01 13:57:10 +10:00
Damien Elmes
bbc14b88e4 progress bar tweaks 2020-06-01 13:57:10 +10:00
Damien Elmes
0787381a99 login/full up/full down plugged in 2020-06-01 13:57:10 +10:00
Damien Elmes
aaed0464e5 rework progress handling 
- client now polls status instead of backend pushing it
- supports multiple threads
- update throttling happens in one place
 2020-06-01 13:57:10 +10:00
Damien Elmes
c4032c0176 another snapshot of sync work 
progress handler is going to need to be reworked to function across
threads
 2020-06-01 13:57:10 +10:00
Damien Elmes
f8e577367b handle images served from directory + svg content type 
https://anki.tenderapp.com/discussions/ankidesktop/41974-win-linux-when-pasting-some-html-i-get-error-in-_run_command-ankirsbackendioerror-ioerror
 2020-06-01 13:40:17 +10:00
Damien Elmes
82e7451136 handle unicode hostnames 
https://anki.tenderapp.com/discussions/ankidesktop/41915-something-wrong-and-i-cant-start-anki
 2020-06-01 13:40:17 +10:00
evandrocoan
c336b70ea5 Set to also print the correct QT log message category 2020-05-31 19:38:02 -03:00
evandrocoan
b72aecee36 Print qt context if it exists 
https://stackoverflow.com/questions/42561295/qt-error-is-printed-on-the-console-how-to-see-where-it-originates-from
https://stackoverflow.com/questions/35894171/redirect-qdebug-output-to-file-with-pyqt5
https://anki.tenderapp.com/discussions/ankidesktop/42070-anki-closes-without-warning-when-importing-conflicting-shared-deck
https://doc.qt.io/qt-5/qtglobal.html#qInstallMessageHandler
 2020-05-31 19:38:02 -03:00
Damien Elmes
c172dd3826 add some more names to about.py 
If you've contributed and are missing from the list, please send me
a PR!
 2020-06-01 06:27:14 +10:00
Damien Elmes
d9a39b565f Merge pull request #645 from evandroforks/resize_clayout_editor_and_preview 
Allow to resize clayout.py horizontal space between the text editor and the card preview
 2020-06-01 05:53:40 +10:00
evandrocoan
750ccc4bd7 Save and restore the debug console window geometry and splitter 2020-05-30 20:58:55 -03:00
evandrocoan
b6b5c37ab9 Add saveSplitter and restoreSplitter to clayout.py 
# Conflicts:
#	qt/aqt/clayout.py
 2020-05-30 20:33:57 -03:00
evandrocoan
1d82fadaa0 Allow to resize clayout.py horizontal space between the text editor 
and the card preview.

# Conflicts:
#	qt/aqt/clayout.py
 2020-05-30 20:33:10 -03:00
Damien Elmes
be6726b19f Merge pull request #641 from glutanimate/add-main-window-did-init-hook 
Add main_window_did_init hook
 2020-05-29 08:56:47 +10:00
Damien Elmes
6b66dad3b6 Merge pull request #640 from evandroforks/fix_render_card_being_called_twice 
Fixed previewer.py::render_card() being called twice in row
 2020-05-29 08:48:35 +10:00
Damien Elmes
2b13ec5857 add maximize button to HTML editor 
closes ankitects/help-wanted#1
 2020-05-29 08:43:33 +10:00
Damien Elmes
32de1ee5f9 fix progress window not disappearing when importing csv 2020-05-29 08:40:25 +10:00
Glutanimate
96b3b29a6f Add main_window_did_init hook and clarify difference to profile_did_open 2020-05-28 13:30:22 +02:00
evandrocoan
a34ecefc96 Fixed previewer.py::render_card() being called twice in row 
Related to: https://github.com/ankitects/anki/pull 529
Ensuring "setNote" is called only once during changing of note type

After debugging the code, every time the cards changes, there are
two stacktraces generated and triggered when note cards change:

calling 1590591251.4621403
   File "qt/runanki", line 4, in <module>
  File "F:\anki\qt\aqt\__init__.py", line 365, in run
    _run()
  File "F:\anki\qt\aqt\__init__.py", line 515, in _run
    app.exec()
  File "F:\anki\qt\aqt\webview.py", line 467, in handler
    cb(val)
  File "F:\anki\qt\aqt\editor.py", line 477, in <lambda>
    self.web.evalWithCallback("saveNow(%d)" % keepFocus, lambda res: callback())
  File "F:\anki\qt\aqt\browser.py", line 858, in <lambda>
    self.editor.saveNow(lambda: self._onRowChanged(current, previous))
  File "F:\anki\qt\aqt\browser.py", line 880, in _onRowChanged
    self._renderPreview(True)
  File "F:\anki\qt\aqt\browser.py", line 1576, in _renderPreview
    self._previewer.render_card(cardChanged)
  File "F:\anki\qt\aqt\previewer.py", line 136, in render_card
    print('calling', time.time(), "\n", "".join( traceback.format_stack() ) )

calling 1590591251.4766161
   File "qt/runanki", line 4, in <module>
  File "F:\anki\qt\aqt\__init__.py", line 365, in run
    _run()
  File "F:\anki\qt\aqt\__init__.py", line 515, in _run
    app.exec()
  File "F:\anki\qt\aqt\webview.py", line 467, in handler
    cb(val)
  File "F:\anki\qt\aqt\editor.py", line 453, in oncallback
    gui_hooks.editor_did_load_note(self)
  File "F:\anki\qt\aqt\gui_hooks.py", line 1168, in __call__
    hook(editor)
  File "F:\anki\qt\aqt\browser.py", line 887, in onLoadNote
    self.refreshCurrentCard(editor.note)
  File "F:\anki\qt\aqt\browser.py", line 884, in refreshCurrentCard
    self._renderPreview(False)
  File "F:\anki\qt\aqt\browser.py", line 1576, in _renderPreview
    self._previewer.render_card(cardChanged)
  File "F:\anki\qt\aqt\previewer.py", line 136, in render_card
    print('calling', time.time(), "\n", "".join( traceback.format_stack() ) )
 2020-05-27 14:41:07 -03:00
sandersantema
79cfe3914e remove unused variable 'w' from '_onHtmlEdit' 2020-05-27 12:04:49 +02:00
sandersantema
94e6078fcd add saveGeom and restoreGeom to htmlEditor 2020-05-27 12:04:00 +02:00
Damien Elmes
e40f507a87 Merge pull request #637 from BlueGreenMagick/field-drag-drop-fix 
fix drag drop field repositioning
 2020-05-27 10:24:07 +10:00
Damien Elmes
fa8a9499ce Merge pull request #636 from BlueGreenMagick/typing-contextmenuevent 
add evt type for contextMenuEvent method
 2020-05-27 10:23:44 +10:00
Damien Elmes
4e23460bda Merge pull request #635 from BlueGreenMagick/typing 
add typehint for eventFilter method
 2020-05-27 10:23:28 +10:00
Damien Elmes
833faf1e63 try mpv on Windows again 
https://github.com/ankitects/anki/pull/621
 2020-05-27 09:21:41 +10:00
Damien Elmes
eb49062617 apply mpv fix 
c0d9544812
 2020-05-27 09:19:20 +10:00
Damien Elmes
9e5dad86a8 fix typechecking breaking with latest mypy_protobuf 
the change that caused it:
https://github.com/dropbox/mypy-protobuf/issues/118

This is more awkward to handle now, as the types are only available
at type-checking time. Python's static typing is such a mess :-(
 2020-05-27 09:14:02 +10:00
BlueGreenMagick
26a8353664 do nothing if dropPos == idx 
since such move won't change the field position
and when trying to move the field below itself
may lead to it being moved below the next field
 2020-05-26 18:59:53 +09:00
BlueGreenMagick
3ee66375da fix drag drop field repositioning 2020-05-26 18:27:38 +09:00
BlueGreenMagick
60501852c2 add evt type for contextMenuEvent method 2020-05-26 17:12:39 +09:00
BlueGreenMagick
b8f73fee2f add typehint for eventFilter method 2020-05-26 17:08:55 +09:00
Damien Elmes
74d3b2ed41 allow hook to modify search text 2020-05-25 16:54:57 +10:00
Damien Elmes
5a790b4d35 Merge pull request #633 from hgiesel/dconf_hooks 
Add three deck config hooks
 2020-05-24 09:53:22 +10:00
Damien Elmes
e9fea26d1c use keyword args for calls with more than one argument 2020-05-24 09:12:47 +10:00
Damien Elmes
bbcc566e6d migrate the remaining methods 2020-05-24 08:36:50 +10:00
Henrik Giesel
91d7cd29b2 Satisfy black reformatter 2020-05-23 11:14:52 +02:00
Damien Elmes
927ed25b02 more methods 2020-05-23 14:01:36 +10:00
Henrik Giesel
ae57c6fbeb Add three deck config hooks 
- gui_hooks.deck_conf_did_add_config
- gui_hooks.deck_conf_will_remove_config
- gui_hooks.deck_conf_will_rename_config
 2020-05-22 21:24:05 +02:00
Damien Elmes
d57ded706f migrate more methods to service 2020-05-22 22:09:33 +10:00
Damien Elmes
a512cbfd5d EMPTY_CARDS should not be translatable 2020-05-22 11:45:14 +10:00
Damien Elmes
7eff75f5f3 hook expected an int, not a str 2020-05-22 11:27:40 +10:00
Damien Elmes
b90d20a3c1 fix custom study not saving 2020-05-22 11:25:11 +10:00
Damien Elmes
7676748e6c fix deletion of decks; allow deleting cards from default 
https://anki.tenderapp.com/discussions/beta-testing/1967-2126-189-g7384df8f-crash-at-note-types-fields-save#comment_48353232
 2020-05-22 11:24:56 +10:00
Damien Elmes
d31f2d8c23 move deck/notetype update hooks to gui 
We need to migrate away from firing hooks in libanki, since libanki
methods may be running on a background thread, and hook consumers
typically expect the code to run in the main thread. We could document
it, but it would frequently be forgotten about, and could lead to
crashes.

https://anki.tenderapp.com/discussions/ankidesktop/41748-qobject-cannot-create-children-for-a-parent-that-is-in-a-different-thread-when-hitting-the-save-button-on-clayoutpy-window
 2020-05-22 10:47:14 +10:00
Damien Elmes
59d3473149 show 'changes saved' in parent window 2020-05-22 10:43:41 +10:00
Damien Elmes
dcbfa23eed show message when search fails 2020-05-22 10:43:28 +10:00
Damien Elmes
40dc633d7f monospace font in clayout 2020-05-22 09:58:20 +10:00
Damien Elmes
e5f32e2f4e use context manager in retrieveURL 2020-05-21 10:58:42 +10:00
Damien Elmes
238ec0e4cb clearer variable names in retrieveURL 2020-05-21 09:22:34 +10:00
Damien Elmes
32016bc02b Merge pull request #630 from evandroforks/close_http_client_connections 
Fixed HttpClient session not being closed
 2020-05-21 09:17:07 +10:00
evandrocoan
fbfe611f03 Added missing Anki icon to debug window 2020-05-20 19:21:31 -03:00
evandrocoan
04dc65ef78 Fixed HttpClient session not being closed 2020-05-20 19:20:41 -03:00
Damien Elmes
0b04658920 fix shortcut keys in clayout 2020-05-21 07:51:35 +10:00
Damien Elmes
75570683db left-align radio buttons in clayout 2020-05-20 19:56:53 +10:00
Damien Elmes
b3e8c63d65 update missed storage._Collection references 2020-05-20 19:45:46 +10:00
Damien Elmes
068cc43095 storage->collection 2020-05-20 17:58:28 +10:00
Damien Elmes
4f5fc9a63d move storage logic into collection.py; fix export bug 
https://anki.tenderapp.com/discussions/ankidesktop/41495-using-file-export-closes-the-collection-on-mwcoldb-if-the-browser-window-is-open
 2020-05-20 17:43:34 +10:00
Damien Elmes
bac4232829 fix progress bar getting stuck on image paste 2020-05-20 16:12:41 +10:00
Damien Elmes
883d9a8851 deprecate removeTempNote() 2020-05-20 15:01:05 +10:00
Damien Elmes
1376c829db fix HTML editor in add screen 2020-05-20 14:59:22 +10:00
Damien Elmes
96a4b65cb0 drop mw.weakref usage in models.py for now 
https://anki.tenderapp.com/discussions/beta-testing/1967-2126-189-g7384df8f-crash-at-note-types-fields-save
 2020-05-20 13:53:34 +10:00
Damien Elmes
1e3080ebdc update empty cards hook 
Closes #515
 2020-05-20 13:41:09 +10:00
Damien Elmes
7f011bd26f tidy up Qt import 2020-05-20 13:38:55 +10:00
Damien Elmes
f27128418c Merge pull request #625 from evandroforks/fixed_check_box_called_twice 
Fixed clayout.py rendering the contents twice when clicked
 2020-05-20 12:48:48 +10:00
Damien Elmes
bb9da63433 Merge pull request #626 from evandroforks/fix_previewer_button 
Fixed previewer button not resetting the state when the preview
 2020-05-20 12:48:17 +10:00
evandrocoan
0292bea4d1 Fixed clayout.py rendering the contents twice when clicked 
https://stackoverflow.com/questions/36808257/pyqt-radiobutton-ischecked-is-executed-twice
 2020-05-19 20:17:20 -03:00
evandrocoan
1261266a4b Added missing Anki icon to qt/aqt/previewer.py 2020-05-19 19:43:18 -03:00
evandrocoan
b690a51a5c Fixed previewer button not resetting the state when the preview 
window is closed by its X button
 2020-05-19 19:24:54 -03:00
evandrocoan
1faf7450e4 Explicitly close the importer file descriptor 
https://github.com/ankitects/anki/pull 613
 2020-05-18 15:54:20 -03:00
evandrocoan
4fe92bfc6b Add missing close file descriptors using context managers 2020-05-18 15:54:20 -03:00
Damien Elmes
e8f0fd4d3b simplify the migration popup 
Avoid presenting the user with a wall of text they may not understand,
default to proceeding, and quit if the user cancels.
 2020-05-18 20:15:59 +10:00
Damien Elmes
bcb71bbf2d Merge pull request #610 from evandroforks/ask_confirmation_before_moving_anki_collection 
Ask user confirmation before moving the Anki directory
 2020-05-18 19:44:27 +10:00
Damien Elmes
b7489cdb75 Merge pull request #619 from evandroforks/fix_empty_sound_tags 
Also fix legacy.py::anki.sound._soundReg accepting empty tags
 2020-05-18 19:31:22 +10:00
Damien Elmes
349c5b378d Merge pull request #620 from evandroforks/remove_unused_var 
Remove unused t = time.time() variable on qt/aqt/browser.py
 2020-05-18 19:20:08 +10:00
Damien Elmes
8a83eaebdc fix python3.7 lint issue 2020-05-18 18:08:57 +10:00
Damien Elmes
3e156fdb49 bump version 2020-05-18 12:50:20 +10:00