GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-19 09:22:51 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions
4118 commits 12 branches 166 tags 146 MiB
Commit graph

704 commits

Author SHA1 Message Date
Damien Elmes
14d067f56a add selectable flag while preserving link clicking 
https://anki.tenderapp.com/discussions/beta-testing/1920-config-can-copy-paste-but-cant-click-links-now
 2020-04-21 09:11:56 +10:00
Damien Elmes
0c1b10162f Revert "Merge pull request #562 from ijgnd/master" 
This reverts commit 1163e418ee, reversing
changes made to 2bfff8dee4.

https://anki.tenderapp.com/discussions/beta-testing/1920-config-can-copy-paste-but-cant-click-links-now
 2020-04-21 09:10:45 +10:00
Damien Elmes
c9f18ba3d2 fix deleting deck configs 2020-04-20 13:23:05 +10:00
Damien Elmes
6f0159e141 fix renaming not updating dropdown 2020-04-20 13:17:55 +10:00
Damien Elmes
3dfbd1a9ae fix adding deck configs 2020-04-20 13:15:23 +10:00
Damien Elmes
a90d75f5fd Merge pull request #569 from evandroforks/limit_error_message_size 
Also limit the size of the error message
 2020-04-20 11:14:53 +10:00
Damien Elmes
f9302d9993 split scheduling prefs into separate tab 
https://anki.tenderapp.com/discussions/ankidesktop/40610-windows-anki-everything-was-enlarged-to-150
https://anki.tenderapp.com/discussions/beta-testing/1916-preferences-screen-partly-invisible
 2020-04-20 11:11:00 +10:00
evandrocoan
bed75b3980 Also limit the size of the error message in case it is 
build by a concatenation of stack traces, i.e.,
```js
throw new Error(err + err.stack)
```
 2020-04-17 16:28:31 -03:00
evandrocoan
4b3c452b6e Limit the reviewer.ts stack size 
https://anki.tenderapp.com/discussions/beta-testing/1918-reliably-reproduced-bug-in-2124beta6#comment_48247959
 2020-04-17 03:53:15 -03:00
evandrocoan
8d9ba4377a Cache webview.py console regex expression and disable multiline 2020-04-17 03:43:16 -03:00
Damien Elmes
09ac540168 fix delays caused by console.log regression in PR #560 
https://anki.tenderapp.com/discussions/beta-testing/1918-reliably-reproduced-bug-in-2124beta6
 2020-04-17 10:51:03 +10:00
Damien Elmes
78c1ced06a Merge pull request #560 from evandroforks/fix_javascript_console_output 
Fixed javaScriptConsoleMessage showing 'error on line'
 2020-04-16 10:15:56 +10:00
Damien Elmes
1163e418ee Merge pull request #562 from ijgnd/master 
make help text selectable
 2020-04-16 10:14:02 +10:00
Damien Elmes
d9b8aba358 catch and report issues when downgrading 2020-04-16 10:11:16 +10:00
Damien Elmes
a2c6a3e170 show a clearer error if the schema is too new 
will hold off on making it translatable for now
 2020-04-16 09:47:34 +10:00
Damien Elmes
a0587b09d1 downgrade manually 
- A regular collection open/close no longer goes through the
upgrade/downgrade steps each time. This avoids wasted cycles, and will
become more important in the future when decks and note types are
split into separate tables.
- Added a downgrade button to the profiles screen to downgrade all
profiles and close the app.
- Downgrading is still automatic when exporting/doing a full sync.
 2020-04-16 09:00:49 +10:00
Damien Elmes
18ae22c842 work around full sync on start closing the app 
This is just a temporary solution until the syncing code can be
reworked.

https://anki.tenderapp.com/discussions/ankidesktop/39761-anki-crashing-after-sync-and-download
 2020-04-16 08:10:17 +10:00
evandrocoan
2d84e8feee Set to use a regular expression to remove the server name because 
it is less prone to break in future updates.
 2020-04-15 16:27:41 -03:00
evandrocoan
d5df05ae6b Set to javaScriptConsoleMessage output to stdout because it 
may raise error messages on the anki GUI.
 2020-04-15 16:06:45 -03:00
ijgnd
9d076d00e0 make help text selectable 
This allows the user to copy e.g. values so that they don't have to retype them which might introduce typos.
 2020-04-15 18:59:04 +02:00
Damien Elmes
dd20337a85 don't write log files when exporting 2020-04-15 21:45:32 +10:00
Damien Elmes
41f469459e pare back dark mode support 
Anki now solely relies on the night mode setting in the preferences
to decide whether to show in light or dark mode. Some users wanted
to run Anki in light mode while keeping the rest of their system dark,
and there were various display problems when dark mode was changed
after Anki started that couldn't be easily worked around.

NSRequiresAquaAppearance is set again, which means we can rely on
the interface appearing properly and not changing as the macOS theme
is changed.

Users who only use dark mode, and preferred the native look of widgets
in dark mode, can achieve the previous appearance by running the
following command in the terminal:

defaults write net.ankiweb.dtop NSRequiresAquaSystemAppearance -bool no

And the following in the debug console:

mw.pm.meta["dark_mode_widgets"] = True

This is hidden behind a debug console command because it requires the
user ensure their system is always set to the same light/dark mode
as Anki.
 2020-04-15 21:44:56 +10:00
Damien Elmes
b60aa9efb9 Merge pull request #559 from evandroforks/show_full_javascript_stacktrace 
Set to show the JavaScript exception message and stacktrace
 2020-04-15 18:51:16 +10:00
Damien Elmes
58ff377187 Merge pull request #557 from simgunz/fix-button-not-highlighted 
Fix editor buttons not highlighted
 2020-04-15 18:50:36 +10:00
Damien Elmes
a33a02f3de update if a compatible branch is found, even if mtime is wrong 
https://anki.tenderapp.com/discussions/ankiweb/4668-addon-auto-update-problems
 2020-04-15 18:47:04 +10:00
evandrocoan
7226c40cce Set to show the JavaScript exception message and stacktrace, when 
a exception is throw, showing the function and lines from where
the exception/error is coming from.
https://stackoverflow.com/questions/591857/how-can-i-get-a-javascript-stack-trace-when-i-throw-an-exception

Exception example:
Invalid HTML on card: Error: The media element is missing its 'src' attribute.
at http://127.0.0.1:50233/_anki/reviewer.js:246:23
at http://127.0.0.1:50233/_anki/reviewer.js:112:9
at Array.forEach ()
at setAnkiMedia (http://127.0.0.1:50233/_anki/reviewer.js:111:11)
at AnkiMediaQueue.setup (http://127.0.0.1:50233/_anki/reviewer.js:244:9)
at eval (eval at (http://127.0.0.1:50233/_anki/jquery.js:2:2651), :2:11)
at eval ()
at http://127.0.0.1:50233/_anki/jquery.js:2:2651
at Function.globalEval (http://127.0.0.1:50233/_anki/jquery.js:2:2662)
at Ha (http://127.0.0.1:50233/_anki/jquery.js:3:21262)
 2020-04-15 04:15:47 -03:00
evandrocoan
c0f5110843 Fixed javaScriptConsoleMessage showing 'error on line' for 
all lines. The new output format is:
JS info /_anki/reviewer.js:166 autoadd
JS error /_anki/reviewer.js:240 Uncaught (in promise) NotAllowedError: play() can only be initiated by a user gesture.
 2020-04-15 04:12:47 -03:00
Simone Gaiarin
1d4620ff74 Fix editor buttons not highlighted 
The selector 'button.linkb' takes precedence on '.highlighted' because
it is more specific, so that '.highlighted' is never applied.
 2020-04-14 19:04:03 +02:00
Damien Elmes
8dafa8bce5 move autoplay() into card 2020-04-13 09:04:30 +10:00
Damien Elmes
6bef493aa5 fix replay audio again, and decouple the code from the reviewer 2020-04-13 08:59:36 +10:00
Damien Elmes
79a50ffb91 use isolation characters instead of direction markers in cloze handling 
https://anki.tenderapp.com/discussions/ankidesktop/40443-improper-location-of-c1foo-on-ltr-text-in-an-rtl-cloze-field
 2020-04-13 08:34:17 +10:00
Damien Elmes
25789e14ef avoid adjusting position if selected row is visible 
https://anki.tenderapp.com/discussions/beta-testing/1868-anki-2124-beta#comment_48227037
 2020-04-11 15:54:52 +10:00
Damien Elmes
4509a8c494 Merge pull request #550 from BlueGreenMagick/debugDiag-contextMenu 
add clear actions to context menu in debug console
 2020-04-11 14:19:46 +10:00
Damien Elmes
e1a0646d56 Update main.py 2020-04-11 14:19:27 +10:00
Damien Elmes
23c02f0a85 fix error when replaying audio in preview screen 2020-04-10 20:33:48 +10:00
Damien Elmes
c3f149ab94 make sure preview window is closed when browser closed 2020-04-10 20:32:48 +10:00
Damien Elmes
4da189a48c grey out spinner if max=0 
https://anki.tenderapp.com/discussions/ankidesktop/32710-custom-study
 2020-04-10 20:32:48 +10:00
Damien Elmes
79bcba0e52 Merge pull request #549 from BlueGreenMagick/debug-resizable 
Allow changing height of debug console text edit boxes
 2020-04-10 19:46:13 +10:00
BlueGreenMagick
4b63d598af add clear actions to context menu in debug console 2020-04-10 15:45:25 +09:00
BlueGreenMagick
2e44724e23 put debug textedits in a splitter 2020-04-10 13:50:09 +09:00
Damien Elmes
2723a03294 make sure progress stops when collection corrupt message shown 2020-04-09 14:19:20 +10:00
Damien Elmes
a1b1b7e428 fix deck_browser_did_render hook 2020-04-09 13:40:19 +10:00
Damien Elmes
896b798f12 Merge pull request #542 from BlueGreenMagick/addcards-cloze-warning 
detect cloze cards with other filters
 2020-04-08 16:30:00 +10:00
Damien Elmes
6f7b4191a3 Merge pull request #545 from BlueGreenMagick/draggable-field-pos 
allow dragging fields to change its position
 2020-04-08 16:22:27 +10:00
Damien Elmes
6fa53fa734 fix preview closing 
https://anki.tenderapp.com/discussions/beta-testing/1868-anki-2124-beta#comment_48228480
 2020-04-08 16:21:20 +10:00
Damien Elmes
83e988ce94 print exception on close 2020-04-08 10:05:33 +10:00
BlueGreenMagick
e7dba3709b allow dragging fields to change its position 2020-04-07 16:42:33 +09:00
BlueGreenMagick
50ae0bed3f use model type to detect cloze notes 2020-04-07 14:02:53 +09:00
Damien Elmes
f8f00f9d21 Merge pull request #543 from Arthur-Milchior/sort_according_to_path 
Sort according to path
 2020-04-07 14:44:53 +10:00
Damien Elmes
668bd25568 Merge pull request #541 from BlueGreenMagick/tmpNote-cloze 
detect renamed cloze fields in note type preview
 2020-04-07 14:17:44 +10:00
Damien Elmes
12e9293f60 avoid unnecessary work in 'make build' 2020-04-07 10:59:14 +10:00
BlueGreenMagick
e9929f84af detect renamed cloze fields in note type preview 
and cloze fields that is also other special field type
such as '{{cloze:hint:Text}}'
 2020-04-07 08:56:54 +09:00
Arthur Milchior
d095b017e4 _basename to basename, since it's not private in use 2020-04-06 23:51:50 +02:00
Arthur Milchior
859178c113 _basename used where possible 2020-04-06 23:51:42 +02:00
Arthur Milchior
e6024d4d3d replace _path by path (because it's not private here) 2020-04-06 23:50:43 +02:00
Arthur Milchior
8962194dcb uses _path where possible 2020-04-06 23:50:37 +02:00
Arthur Milchior
7bef7ef8ec Sort decks according to their paths 
Currently it's sorted alphabetically. Because of this, "A::B" appears
between "A9" and "AA" in list of decks.
 2020-04-06 22:49:25 +02:00
Damien Elmes
b5022ad354 store config in separate DB table 
- mtime is tracked on each key individually, which will allow
merging of config changes when syncing in the future
- added col.(get|set|remove)_config()
- in order to support existing code that was mutating returned
values (eg col.conf["something"]["another"] = 5), the returned list/dict
will be automatically wrapped so that when the value is dropped, it
will save the mutated item back to the DB if it's changed. Code that
is fetching lists/dicts from the config like so:

col.conf["foo"]["bar"] = baz
col.setMod()

will continue to work in most case, but should be gradually updated to:

conf = col.get_config("foo")
conf["bar"] = baz
col.set_config("foo", conf)
 2020-04-06 15:39:47 +10:00
Damien Elmes
d5200974f8 omit period in steps when possible 2020-04-06 15:39:47 +10:00
Damien Elmes
3c7eabc51e add flag to skip downgrade on collection close 
Disabled for now; when enabled it will allow faster collection
open and close in the normal case, while continuing to downgrade
when exporting or doing a full sync.

Also, when downgrading is disabled, the journal mode is no longer
changed back to delete.
 2020-04-04 17:21:45 +10:00
Damien Elmes
ac54f85840 update tag handling 
- tag list stored in a separate DB table
- non-wildcard searches now do full unicode case folding
(eg tag:masse matches 'Maße')
- wildcard matches do simple unicode case folding
- some functions haven't been updated yet, so ascii folding will
continue to be used in some operations
 2020-04-03 19:34:46 +10:00
Damien Elmes
07c414692e preserve mtime/usn when syncing deck config, and add snake_case names 2020-04-03 19:34:46 +10:00
Damien Elmes
6a7a18126f Merge pull request #537 from Arthur-Milchior/add_card_did_init 
hook add_card_did_init
 2020-04-03 19:34:33 +10:00
Arthur Milchior
952d943440 hook add_card_did_init 2020-04-03 11:03:08 +02:00
evandrocoan
b879c4a951 Fixed double python version check for python_requires=">=3.7" 2020-04-02 22:56:53 -03:00
evandrocoan
2cc12313dd Deprecated sdist wheels and pyqtwebengine as dependency 2020-04-02 22:56:48 -03:00
evandrocoan
e613e0dcbd Set the minimum python version required by anki on qt/setup.py 2020-04-02 22:56:44 -03:00
evandrocoan
7d1c5140a8 Set to build a source distribution instead of build distribution 
for aqt on qt/Makefile, because .whl files are just zip simple
zip files and do not support dynamic versioning. Also, there is no
restriction for aqt to be shipped as source tarball because it does
not ship any binaries.
 2020-04-02 22:56:37 -03:00
evandrocoan
745371f510 Fixed setup.py installing pyqtwebengine on older versions of pyqt 2020-04-02 22:56:33 -03:00
evandrocoan
4f591235c7 Set to checks.yml install and import anki wheels 
# Conflicts:
#	.github/workflows/checks.yml
 2020-04-02 22:56:13 -03:00
Damien Elmes
1f64059897 add type checking to previewer 2020-04-03 09:13:33 +10:00
Damien Elmes
da55f82619 add missing license header 2020-04-03 09:05:32 +10:00
Damien Elmes
3f965f5534 use old name for preview dialog to avoid breaking add-ons 2020-04-03 09:00:18 +10:00
Damien Elmes
8eca40dab8 fix some errors in the previewing code 2020-04-03 09:00:08 +10:00
Damien Elmes
d7edbedac0 Merge pull request #535 from evandroforks/upload_wheels_to_pypi 
Created the GitHub Actions step Upload to PyPi
 2020-04-03 08:40:17 +10:00
Damien Elmes
3959f7dcb8 render() conflicts with Qt method 2020-04-03 08:29:35 +10:00
Damien Elmes
c74cf44e90 be explicit that the method is a no-op 2020-04-03 08:27:56 +10:00
Damien Elmes
62586f75d0 tweak wording 2020-04-03 08:27:26 +10:00
Arthur Milchior
ef0cbb3a79 snake case 2020-04-02 17:44:06 +02:00
Arthur Milchior
c9bd4b53a3 Previewer is a QDialog 
As suggested by Glutanimate in https://github.com/ankitects/anki/pull/532#discussion_r401256921
 2020-04-02 17:44:06 +02:00
Arthur Milchior
391fd69061 Previewer: parent become private 
It seems parent is a method of QDialog, so it creates a typing problem
 2020-04-02 17:44:06 +02:00
Arthur Milchior
2eed489792 Methods used by browser are not public 
As suggested by Glutanimate on https://github.com/ankitects/anki/pull/532#discussion_r401254100
 2020-04-02 17:44:06 +02:00
Arthur Milchior
d85c8288f6 remove the word preview from previewer variable 
As suggested by glutanimate https://github.com/ankitects/anki/pull/532#discussion_r401255290
 2020-04-02 17:44:06 +02:00
Arthur Milchior
be66a0f1cd removing PreviewDialog dataclass 
It can be replaced by the previewer itself. As suggested by
Glutanimate https://github.com/ankitects/anki/pull/532#discussion_r401252970
 2020-04-02 17:44:06 +02:00
Arthur Milchior
1ee6bcbdcb PreviewerListCards can take cids and class 
This allow to avoid recomputing a card if it is known, while allowing
to compute it until it's actually displayed
 2020-04-02 17:44:06 +02:00
Arthur Milchior
7bf2631ea8 ListCardsPreviewer 2020-04-02 17:44:06 +02:00
Arthur Milchior
09a4a5307f Split PreviewerBrowser into a hierarchy 
A part in common to see multiple cards. And a part specific for the browser
 2020-04-02 17:44:06 +02:00
Arthur Milchior
b5b6786f95 split onPreview Prev/Next 2020-04-02 17:44:06 +02:00
Arthur Milchior
8bb2b037ef split _updatePreviewButtons 
This will allow to create a hierarchy in this class
 2020-04-02 17:44:06 +02:00
Arthur Milchior
cad44bb899 add a class to preview a single card 2020-04-02 17:44:06 +02:00
Arthur Milchior
7ce77e071d Class PreviewerBrowser 
This let a previewer class which can be used to display a single card,
and a previewer for the browser
 2020-04-02 17:44:06 +02:00
Arthur Milchior
0b80b157e7 split = None 2020-04-02 17:44:06 +02:00
Arthur Milchior
1322cd8e11 vbox and bbox are attribute 2020-04-02 17:44:06 +02:00
Arthur Milchior
6e30edd79f use card method 2020-04-02 17:44:06 +02:00
Arthur Milchior
6767431633 previewer: create gui in a distinct function 2020-04-02 17:44:06 +02:00
Arthur Milchior
7ea1ff840f move previewer to a different class. 
This uses exactly the same code, with one exception. In the previewer
`self` became `self.parent` in order to have action on the
browser. And in the browser, some `self` become `self.previewer` to
access the previewer. (Some function having an action on the previewer
starting from the browser now are separated in two. One version in the
previewer doing the same thing. One version in the browser, calling
the version in the previewer if it exists.)

Preview dialog now takes a QWidget in general, not necesarrily a
Browser. The parameter is called parent
 2020-04-02 17:44:06 +02:00
Damien Elmes
91c2e89360 ignore row change events that arrive after browser closed 
https://anki.tenderapp.com/discussions/ankidesktop/40148-bug-when-suspending-cards
 2020-04-02 19:44:51 +10:00
evandrocoan
30107ab09d Created the GitHub Actions step Upload to PyPi to run only on 
tagged releases of anki:
https://anki.tenderapp.com/discussions/ankidesktop/40025-anki-in-python-package-index
 2020-04-02 02:57:34 -03:00
Damien Elmes
f195296106 fix push-i18n-ftl 2020-04-01 18:20:31 +10:00
Damien Elmes
526569693c fix extract-po-string.py 2020-04-01 17:49:31 +10:00