Anki/rslib/src/serde.rs
RumovZ 651ba88393
Automate schema 11 other duplicates clearing (#2542)
* Skip linting target folder

Contains build files not passing the copyright header check.

* Implicitly clear duplicate keys when serializing

Fixes `originalStockKind` not being cleared from `other`, as it had
mistakenly been added to the field list for `NoteFieldSchema11`.
2023-06-12 11:14:14 +10:00

118 lines
3.3 KiB
Rust

// Copyright: Ankitects Pty Ltd and contributors
// License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
use serde::Deserialize as DeTrait;
use serde::Deserializer;
pub(crate) use serde_aux::field_attributes::deserialize_bool_from_anything;
pub(crate) use serde_aux::field_attributes::deserialize_number_from_string;
use serde_json::Value;
use crate::prelude::*;
/// Serializes the value to JSON, removing any duplicate keys in the process.
///
/// This function solves a very specific problem when (de)serializing structs on
/// up-/downgrade:
/// Older clients may have received keys from a newer client when
/// syncing, which get bundled into `other`. If they then upgrade, then
/// downgrade their collection to schema11, serde will serialize the
/// new default keys, but then add them again from `other`, leading
/// to the keys being duplicated in the resulting json - which older
/// clients then can't read. So we need to strip out any new keys we
/// add.
pub(crate) fn schema11_to_string(value: impl serde::Serialize) -> Result<String> {
serde_json::to_value(value)
.and_then(|val| serde_json::to_string(&val))
.map_err(Into::into)
}
/// Note: if you wish to cover the case where a field is missing, make sure you
/// also use the `serde(default)` flag.
pub(crate) fn default_on_invalid<'de, T, D>(deserializer: D) -> Result<T, D::Error>
where
T: Default + DeTrait<'de>,
D: Deserializer<'de>,
{
let v: Value = DeTrait::deserialize(deserializer)?;
Ok(T::deserialize(v).unwrap_or_default())
}
pub(crate) fn is_default<T: Default + PartialEq>(t: &T) -> bool {
*t == Default::default()
}
pub(crate) fn deserialize_int_from_number<'de, T, D>(deserializer: D) -> Result<T, D::Error>
where
D: Deserializer<'de>,
T: serde::Deserialize<'de> + FromI64,
{
#[derive(DeTrait)]
#[serde(untagged)]
enum IntOrFloat {
Int(i64),
Float(f64),
}
match IntOrFloat::deserialize(deserializer)? {
IntOrFloat::Float(f) => Ok(T::from_i64(f as i64)),
IntOrFloat::Int(i) => Ok(T::from_i64(i)),
}
}
// It may be possible to use the num_traits crate instead in the future.
pub(crate) trait FromI64 {
fn from_i64(val: i64) -> Self;
}
impl FromI64 for i32 {
fn from_i64(val: i64) -> Self {
val as Self
}
}
impl FromI64 for u32 {
fn from_i64(val: i64) -> Self {
val.max(0) as Self
}
}
impl FromI64 for i64 {
fn from_i64(val: i64) -> Self {
val
}
}
impl FromI64 for TimestampSecs {
fn from_i64(val: i64) -> Self {
TimestampSecs(val)
}
}
#[cfg(test)]
mod test {
use serde::Deserialize;
use super::*;
#[derive(Deserialize, Debug, PartialEq, Eq)]
struct MaybeInvalid {
#[serde(deserialize_with = "default_on_invalid", default)]
field: Option<usize>,
}
#[test]
fn invalid_or_missing() {
assert_eq!(
serde_json::from_str::<MaybeInvalid>(r#"{"field": 5}"#).unwrap(),
MaybeInvalid { field: Some(5) }
);
assert_eq!(
serde_json::from_str::<MaybeInvalid>(r#"{"field": "5"}"#).unwrap(),
MaybeInvalid { field: None }
);
assert_eq!(
serde_json::from_str::<MaybeInvalid>(r#"{"another": 5}"#).unwrap(),
MaybeInvalid { field: None }
);
}
}