mirror of
https://github.com/ankitects/anki.git
synced 2025-09-18 14:02:21 -04:00
5b0f371791
* add AnkiWebView subclasses for stats, empty cards and find dupes ui * update ui files to use subclassed webviews instead * remove superfluous calls to AnkiWebView.set_kind * Avoid set_kind() race condition in legacy stats webview Replacing the web view is a hacky workaround, but likely a reasonable compromise for a legacy view that we do not want to maintain a separate Qt form for. * Slightly refactor AnkiWebView subclass creation and tweak inline comment + Extend create_ankiwebview_subclass() with the ability to set any init time AnkiWebView argument + Introduce some nice-to-haves in terms of static type checking support and IDE autocompletion + Mark helper function as private to discourage add-on use * Drop `AnkiWebView.set_kind` completely There no longer is an Anki-internal use case for changing the web view kind after initializing a web view, and add-ons almost certainly do not have any use for it either. Given that setting the kind after web view construction can lead to known race conditions with `domDone` signals, we should remove this method to discourage uses like this in both Anki code and add-on consumers. There currenty only seems to be one add-on calling `set_kind()`, so this seem like a justifiable API change. --------- Co-authored-by: llama <100429699+iamllama@users.noreply.github.com>
128 lines
3 KiB
XML
128 lines
3 KiB
XML
<?xml version="1.0" encoding="UTF-8"?>
|
|
<ui version="4.0">
|
|
<class>Dialog</class>
|
|
<widget class="QDialog" name="Dialog">
|
|
<property name="geometry">
|
|
<rect>
|
|
<x>0</x>
|
|
<y>0</y>
|
|
<width>531</width>
|
|
<height>345</height>
|
|
</rect>
|
|
</property>
|
|
<property name="windowTitle">
|
|
<string notr="true">EMPTY_CARDS</string>
|
|
</property>
|
|
<layout class="QVBoxLayout" name="verticalLayout_2">
|
|
<property name="spacing">
|
|
<number>0</number>
|
|
</property>
|
|
<property name="leftMargin">
|
|
<number>0</number>
|
|
</property>
|
|
<property name="topMargin">
|
|
<number>0</number>
|
|
</property>
|
|
<property name="rightMargin">
|
|
<number>0</number>
|
|
</property>
|
|
<property name="bottomMargin">
|
|
<number>0</number>
|
|
</property>
|
|
<item>
|
|
<widget class="EmptyCardsWebView" name="webview" native="true">
|
|
<property name="url" stdset="0">
|
|
<url>
|
|
<string notr="true">about:blank</string>
|
|
</url>
|
|
</property>
|
|
</widget>
|
|
</item>
|
|
<item>
|
|
<layout class="QVBoxLayout" name="verticalLayout">
|
|
<property name="spacing">
|
|
<number>12</number>
|
|
</property>
|
|
<property name="leftMargin">
|
|
<number>12</number>
|
|
</property>
|
|
<property name="topMargin">
|
|
<number>12</number>
|
|
</property>
|
|
<property name="rightMargin">
|
|
<number>12</number>
|
|
</property>
|
|
<property name="bottomMargin">
|
|
<number>12</number>
|
|
</property>
|
|
<item alignment="Qt::AlignLeft">
|
|
<widget class="QCheckBox" name="keep_notes">
|
|
<property name="text">
|
|
<string notr="true">KEEP_NOTES</string>
|
|
</property>
|
|
<property name="checked">
|
|
<bool>true</bool>
|
|
</property>
|
|
</widget>
|
|
</item>
|
|
<item>
|
|
<widget class="QDialogButtonBox" name="buttonBox">
|
|
<property name="orientation">
|
|
<enum>Qt::Horizontal</enum>
|
|
</property>
|
|
<property name="standardButtons">
|
|
<set>QDialogButtonBox::Close</set>
|
|
</property>
|
|
</widget>
|
|
</item>
|
|
</layout>
|
|
</item>
|
|
</layout>
|
|
</widget>
|
|
<customwidgets>
|
|
<customwidget>
|
|
<class>EmptyCardsWebView</class>
|
|
<extends>QWidget</extends>
|
|
<header location="global">aqt/webview</header>
|
|
<container>1</container>
|
|
</customwidget>
|
|
</customwidgets>
|
|
<tabstops>
|
|
<tabstop>buttonBox</tabstop>
|
|
</tabstops>
|
|
<resources/>
|
|
<connections>
|
|
<connection>
|
|
<sender>buttonBox</sender>
|
|
<signal>accepted()</signal>
|
|
<receiver>Dialog</receiver>
|
|
<slot>accept()</slot>
|
|
<hints>
|
|
<hint type="sourcelabel">
|
|
<x>248</x>
|
|
<y>254</y>
|
|
</hint>
|
|
<hint type="destinationlabel">
|
|
<x>157</x>
|
|
<y>274</y>
|
|
</hint>
|
|
</hints>
|
|
</connection>
|
|
<connection>
|
|
<sender>buttonBox</sender>
|
|
<signal>rejected()</signal>
|
|
<receiver>Dialog</receiver>
|
|
<slot>reject()</slot>
|
|
<hints>
|
|
<hint type="sourcelabel">
|
|
<x>316</x>
|
|
<y>260</y>
|
|
</hint>
|
|
<hint type="destinationlabel">
|
|
<x>286</x>
|
|
<y>274</y>
|
|
</hint>
|
|
</hints>
|
|
</connection>
|
|
</connections>
|
|
</ui>
|