mirror of
https://github.com/ankitects/anki.git
synced 2025-11-19 19:17:12 -05:00
6941bccde4
Protobuf 3.15 introduced support for marking scalar fields like uint32 as optional, and all of our tooling appears to support it now. This allows us to use simple optional/null checks in our Rust/ TypeScript code, without having to resort to an inner message. I had to apply a minor patch to protobufjs to get this working with the json-module output; this has also been submitted upstream: https://github.com/protobufjs/protobuf.js/pull/1693 I've modified CardStatsResponse as an example of the new syntax. One thing to note: while the Rust and TypeScript bindings use optional/ null fields, as that is the norm in those languages, Google's Python bindings are not very Pythonic. Referencing an optional field that is missing will yield the default value, and a separate HasField() call is required, eg: ``` >>> from anki.stats_pb2 import CardStatsResponse as R ... msg = R.FromString(b"") ... print(msg.first_review) ... print(msg.HasField("first_review")) 0 False ``` |
||
|---|---|---|
| .. | ||
| backend.proto | ||
| card_rendering.proto | ||
| cards.proto | ||
| collection.proto | ||
| config.proto | ||
| deckconfig.proto | ||
| decks.proto | ||
| generic.proto | ||
| i18n.proto | ||
| links.proto | ||
| media.proto | ||
| notes.proto | ||
| notetypes.proto | ||
| scheduler.proto | ||
| search.proto | ||
| stats.proto | ||
| sync.proto | ||
| tags.proto | ||