mirror of
https://github.com/ankitects/anki.git
synced 2025-11-06 20:57:13 -05:00
b73cb15888
The approach in #2542 unfortunately introduced a regression, as whilst it ensured that duplicate keys are removed when downgrading, it no longer prevented the duplicates from being removed when converting to a legacy Schema11 object. This resulted in things like backend.get_notetype_legacy() returning duplicate keys, and could break syncing: https://forums.ankiweb.net/t/windows-desktop-sync-error/33128 As syncing and schema11 object usage is quite common compared to downgrading, the extra Value deserialization seemed a bit expensive, so I've switched back to explicitly removing the problem keys. To ensure we don't forget to add new keys in the future, I've added some new tests that should alert us whenever a newly-added key is missing from the reserved list. |
||
|---|---|---|
| .. | ||
| mod.rs | ||
| schema11.rs | ||
| service.rs | ||
| undo.rs | ||
| update.rs | ||