mirror of
https://github.com/ankitects/anki.git
synced 2025-11-13 08:07:11 -05:00
62223499c4
There were a few issues going on here: - If some operation had invalidated the queues, they were subsequently recreated with a call to .get_queues() in the undo handling code. This could happen after the changes to the card had already been reverted, leading to a queue state that didn't match our expectations. - More generally, it's not safe to assume our mutations will apply cleanly after the queue has been rebuilt. The next card will vary depending on the number of remaining cards when interspersing cards of different types, and a queue-invalidating operation will have changed the learning cutoff. So rather than rebuilding the queues on demand, we now check that they already exist, and were created at the time we expect. If not, we invalidate them and skip applying the mutations, and a subsequent refresh of the UI should rebuild the queues correctly. As part of this change, the cutoff snapshot has been moved into the normal answer update object. One possible downside here is that adding a note during review may cause a newly due learning card to appear when undoing a different review. If this proves to be a problem, we could potentially note down the learning cutoff and apply it when queues are rebuilt later. |
||
|---|---|---|
| .. | ||
| answering | ||
| filtered | ||
| queue | ||
| states | ||
| bury_and_suspend.rs | ||
| congrats.rs | ||
| learning.rs | ||
| mod.rs | ||
| new.rs | ||
| reviews.rs | ||
| timespan.rs | ||
| timing.rs | ||
| upgrade.rs | ||