Anki/cargo
RumovZ d55f080733
V3 parent limits (#1638)
* avoid repinning Rust deps by default

* add id_tree dependency

* Respect intermediate child limits in v3

* Test new behaviour of v3 counts

* Rework v3 queue building to respect parent limits

* Add missing did field to SQL query

* Fix `LimitTreeMap::is_exhausted()`

* Rework tree building logic

https://github.com/ankitects/anki/pull/1638#discussion_r798328734

* Add timer for build_queues()

* `is_exhausted()` -> `limit_reached()`

* Move context and limits into `QueueBuilder`

This allows for moving more logic into QueueBuilder, so less passing
around of arguments. Unfortunately, some tests will require additional
work to set up.

* Fix stop condition in new_cards_by_position

* Fix order gather order of new cards by deck

* Add scheduler/queue/builder/burying.rs

* Fix bad tree due to unsorted child decks

* Fix comment

* Fix `cap_new_to_review_rec()`

* Add test for new card gathering

* Always sort `child_decks()`

* Fix deck removal in `cap_new_to_review_rec()`

* Fix sibling ordering in new card gathering

* Remove limits for deck total count with children

* Add random gather order

* Remove bad sibling order handling

All routines ensure ascending order now.
Also do some other minor refactoring.

* Remove queue truncating

All routines stop now as soon as the root limit is reached.

* Move deck fetching into `QueueBuilder::new()`

* Rework new card gather and sort options

https://github.com/ankitects/anki/pull/1638#issuecomment-1032173013

* Disable new sort order choices ...

depending on set gather order.

* Use enum instead of numbers

* Ensure valid sort order setting

* Update new gather and sort order tooltips

* Warn about random insertion order with v3

* Revert "Add timer for build_queues()"

This reverts commit c9f5fc6ebe.

* Update rslib/src/storage/card/mod.rs (dae)

* minor wording tweaks to the tooltips (dae)

+ move legacy strings to bottom
+ consistent capitalization (our leech action still needs fixing,
but that will require introducing a new 'suspend card' string as the
existing one is used elsewhere as well)
2022-02-10 09:55:43 +10:00
..
remote V3 parent limits (#1638) 2022-02-10 09:55:43 +10:00
BUILD.bazel V3 parent limits (#1638) 2022-02-10 09:55:43 +10:00
BUILD.reqwest.native.bazel update Rust deps 2022-01-15 14:59:43 +10:00
BUILD.reqwest.rustls.bazel update Rust deps 2022-01-15 14:59:43 +10:00
BUILD.term-0.7.0.bazel update Rust deps 2022-01-15 14:59:43 +10:00
crates.bzl V3 parent limits (#1638) 2022-02-10 09:55:43 +10:00
licenses.json V3 parent limits (#1638) 2022-02-10 09:55:43 +10:00
README.md V3 parent limits (#1638) 2022-02-10 09:55:43 +10:00
update.py V3 parent limits (#1638) 2022-02-10 09:55:43 +10:00

This folder integrates Rust crates.io fetching into Bazel.

To add or update dependencies, ensure a local Rust environment is available (eg source scripts/cargo-env), then install cargo-raze:

cargo install cargo-raze --version 0.14.1
cargo install cargo-license

After adding/updating dependencies in ../rslib/Cargo.toml, change to this folder and run:

$ python update.py

or

$ REPIN=1 python update.py

The former will apply added crates and adjusted version numbers, while leaving most crate versions alone. The latter will also update pinned dependencies to their latest compatible versions.

Note: cargo-raze does not currently work when run from Windows, and nobody has investigated why yet. For now, you'll need a Mac or Linux machine, or will need to run update.py from within WSL.

A couple of crates need extra work to build with Bazel, and are listed in ../Cargo.toml. For example:

[package.metadata.raze.crates.pyo3.'*']
compile_data_attr = "glob([\"**\"])"

With minor version updates, you should not normally need to modify the entries in that file.

Because update.py modifies a lot of files in remote/, it makes it difficult to review in a PR, and the changes can sometimes break platforms like Windows. For this reason, please don't submit PRs that do minor version bumps - those will typically be done after stable releases. If you need a new crate for a feature you're working on, please raise it in an issue first.

Reqwest

Things are complicated with reqwest at the moment, because:

  • we're using a fork to implement better timeouts for syncing
  • we want to build it with different features on Linux (where we can't build a wheel that links to OpenSSL), and on other platforms.

For minor version bumps, update.py should take care of updating the versions of reqwest dependencies.

After making a big update to reqwest via an updated fork, the vendored BUILD.reqwest.* files may need updating. To do that, comment native-tls from the features in rslib/Cargo.toml and run update.py, and copy the file in remote/ over the old vendored file. Then comment the other two deps out, add native-tls back, and repeat the process.