GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-12 13:33:55 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Refactor desired retention handling in FsrsOptions.svelte

Browse source 
Updated the logic for effective desired retention to use the configuration default instead of the deck-specific value. This change improves consistency in the retention value used throughout the component, ensuring that the correct value is bound to the UI elements.
This commit is contained in:
Jarrett Ye 2025-07-11 14:20:06 +08:00
parent 9d7dc2350f
commit 341f9ae1f4
No known key found for this signature in database
GPG key ID: EBFC55E0C1A352BB
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
ts/routes/deck-options/FsrsOptions.svelte
View file

@ -106,15 +106,14 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
),
];
let desiredRetentionValue = $config.desiredRetention;
// Get the effective desired retention value (deck-specific if set, otherwise config default)
$: effectiveDesiredRetention = $limits.desiredRetention ?? $config.desiredRetention;
let effectiveDesiredRetention =
$limits.desiredRetention ?? $config.desiredRetention;
const startingDesiredRetention = effectiveDesiredRetention.toFixed(2);
$: simulateFsrsRequest = new SimulateFsrsReviewRequest({
params: fsrsParams($config),
desiredRetention: effectiveDesiredRetention,
desiredRetention: $config.desiredRetention,
newLimit: $config.newPerDay,
reviewLimit: $config.reviewsPerDay,
maxInterval: $config.maximumReviewInterval,
@ -331,7 +330,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
<DynamicallySlottable slotHost={Item} api={{}}>
<Item>
<SpinBoxFloatRow
bind:value={desiredRetentionValue}
bind:value={effectiveDesiredRetention}
defaultValue={defaults.desiredRetention}
min={0.7}
max={0.99}
@ -341,7 +340,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
<TabbedValue
slot="tabs"
tabs={desiredRetentionTabs}
bind:value={desiredRetentionValue}
bind:value={effectiveDesiredRetention}
/>
<SettingTitle on:click={() => openHelpModal("desiredRetention")}>
{tr.deckConfigDesiredRetention()}