GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-12 13:33:55 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

refactor the logic for obtaining deck-specific desired retention by using method chaining

Browse source
This commit is contained in:
Jarrett Ye 2025-07-13 11:01:54 +08:00
parent 341f9ae1f4
commit 50b3da74f0
No known key found for this signature in database
GPG key ID: EBFC55E0C1A352BB
2 changed files with 11 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
rslib/src/scheduler/answering/mod.rs
View file

@ -447,13 +447,11 @@ impl Collection {
// Get deck-specific desired retention if available, otherwise use config
// default
let desired_retention = if let Ok(normal_deck) = deck.normal() {
normal_deck
.desired_retention
.unwrap_or(config.inner.desired_retention)
} else {
config.inner.desired_retention
};
let desired_retention = deck
.normal()
.ok()
.and_then(|d| d.desired_retention)
.unwrap_or(config.inner.desired_retention);
let fsrs_enabled = self.get_config_bool(BoolKey::Fsrs);
let fsrs_next_states = if fsrs_enabled {
@ -685,10 +683,7 @@ pub(crate) mod test {
let deck_id = DeckId(1);
let deck = col.get_deck(deck_id)?.unwrap();
let mut deck_clone = (*deck).clone();
if let DeckKind::Normal(ref mut normal) = deck_clone.kind {
normal.desired_retention = Some(0.85); // Set deck-specific desired
// retention
}
deck_clone.normal_mut().unwrap().desired_retention = Some(0.85);
col.update_deck(&mut deck_clone)?;
// Create a card in this deck

12
rslib/src/scheduler/fsrs/memory_state.rs
View file

@ -208,13 +208,11 @@ impl Collection {
// Get deck-specific desired retention if available, otherwise use config
// default
let desired_retention = if let Ok(normal_deck) = deck.normal() {
normal_deck
.desired_retention
.unwrap_or(config.inner.desired_retention)
} else {
config.inner.desired_retention
};
let desired_retention = deck
.normal()
.ok()
.and_then(|d| d.desired_retention)
.unwrap_or(config.inner.desired_retention);
let historical_retention = config.inner.historical_retention;
let params = config.fsrs_params();