GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-24 16:56:36 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Improve error message for unknown fragment

Browse source
This commit is contained in:
RumovZ 2021-07-23 10:32:29 +02:00
parent f2f19e8b45
commit 6ef52726da
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
rslib/src/links.rs
View file

@ -7,10 +7,10 @@ static HELP_SITE: &'static str = "https://docs.ankiweb.net/";
impl HelpPage { impl HelpPage {
pub fn to_link(self) -> String { pub fn to_link(self) -> String {
format!("{}{}", HELP_SITE, self.to_fragment()) format!("{}{}", HELP_SITE, self.to_link_suffix())
} }
fn to_fragment(self) -> &'static str { fn to_link_suffix(self) -> &'static str {
match self { match self {
HelpPage::NoteType => "getting-started#note-types", HelpPage::NoteType => "getting-started#note-types",
HelpPage::Browsing => "browsing", HelpPage::Browsing => "browsing",
@ -74,9 +74,10 @@ mod test {
Ok(url) => match check_web(&url, ctx).await { Ok(url) => match check_web(&url, ctx).await {
Ok(()) => Outcome::Valid, Ok(()) => Outcome::Valid,
Err(Reason::Dom) => Outcome::Invalid(format!( Err(Reason::Dom) => Outcome::Invalid(format!(
"'{}' not found on '{}'", "'#{}' not found on '{}{}'",
page.to_fragment(), url.fragment().unwrap(),
HELP_SITE url.domain().unwrap(),
url.path(),
)), )),
Err(Reason::Web(err)) => Outcome::Invalid(err.to_string()), Err(Reason::Web(err)) => Outcome::Invalid(err.to_string()),
_ => unreachable!(), _ => unreachable!(),
@ -98,7 +99,7 @@ mod test {
impl Outcomes { impl Outcomes {
fn message(&self) -> String { fn message(&self) -> String {
iter::once(&format!("{} links could not be validated:", self.0.len())) iter::once(&format!("{} link(s) could not be validated:", self.0.len()))
.chain(self.0.iter()) .chain(self.0.iter())
.join("\n - ") .join("\n - ")
} }