GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2025-09-18 22:12:21 -04:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions

Merge pull request #1364 from evandroforks/fix_unclosed_python_file

Browse source 
Fix ResourceWarning: unclosed file <_io.BufferedWriter name=5>
This commit is contained in:
Damien Elmes 2021-09-13 12:01:34 +10:00 committed by Damien Elmes
parent 251c5ae080
commit c05475a49e
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
qt/aqt/sound.py
View file

@ -313,6 +313,8 @@ class SimpleProcessPlayer(Player): # pylint: disable=abstract-method
if self._terminate_flag: if self._terminate_flag:
self._process.terminate() self._process.terminate()
self._process.wait(1) self._process.wait(1)
if self._process.stdin:
self._process.stdin.close()
self._process = None self._process = None
return return
@ -321,6 +323,8 @@ class SimpleProcessPlayer(Player): # pylint: disable=abstract-method
self._process.wait(0.1) self._process.wait(0.1)
if self._process.returncode != 0: if self._process.returncode != 0:
print(f"player got return code: {self._process.returncode}") print(f"player got return code: {self._process.returncode}")
if self._process.stdin:
self._process.stdin.close()
self._process = None self._process = None
return return
except subprocess.TimeoutExpired: except subprocess.TimeoutExpired: