Damien Elmes
05a0c3c40e
Merge pull request #869 from Arthur-Milchior/trip_new_field_name
...
New field name checks are more specific
2020-12-28 16:53:32 +10:00
Damien Elmes
184d5ab368
Merge pull request #858 from hgiesel/editorwhitespace
...
Remove placeholder `<br>`s in empty fields in editor
2020-12-28 16:50:23 +10:00
Arthur Milchior
ebd4938507
Reject field name with : { or }
...
More than {{ is acceptable to start a tag, which means that `{{{Foo}}` won't be interpreted as "the content of `Foo`"
and should be rejected. For the sake of clarity and parsing, I suspect that those symbol should be rejected elsewhere
too.
Similary `{{Foo}}}` won't be interpreted as "Show the content of field `Foo}`" even if this field exists, so it's better
to reject `}`. It's clearly necessary to reject "}}" inside the field name, rejecting "}" seems easier to explain and
avoid future unexpected problem if the templates change.
The ":" are used to separate filters, and rejecting it in field name would ensure that there is no ambiguity.
2020-12-28 07:33:26 +01:00
Arthur Milchior
b2e0d0b968
Rejects field names starting with #, ^ and /
2020-12-28 06:23:49 +01:00
Arthur Milchior
ae489b1278
New field are stripped
...
Otherwise, you can rename "Back" to " Front" and then get unexpected result
2020-12-28 06:18:42 +01:00
Damien Elmes
e2be0c2cbd
simplify NoteField init in test; add other bad chars
2020-12-28 13:19:37 +10:00
Damien Elmes
e14198fad7
fix comment and add basic unit test
2020-12-28 13:14:49 +10:00
Damien Elmes
ed32a66a6b
Merge pull request #870 from Arthur-Milchior/trim_start_field_name
...
Trim the start of field name if it is #, /, ^ or a whitespace
2020-12-28 13:06:57 +10:00
Arthur Milchior
98d0136921
Trim the start of field name if it is #, /, ^ or a whitespace
...
I actually need to trim whitespace again to deal with a field name of the form "# foo"
2020-12-28 03:32:05 +01:00
Damien Elmes
f33a001859
Merge pull request #868 from Arthur-Milchior/contributing_sh
...
Contributing shell code in backtick
2020-12-28 10:46:34 +10:00
Damien Elmes
7bda223999
Merge pull request #865 from hgiesel/configaction
...
Open AddonsDialog via dialog manager
2020-12-28 10:36:02 +10:00
Damien Elmes
e80674b793
Merge pull request #863 from hgiesel/statsoverscroll
...
Prevent stats screen from overscrolling
2020-12-28 10:34:06 +10:00
Damien Elmes
680ded95f6
Merge pull request #862 from hgiesel/reviewerbottombuttons
...
Hide stats buttons in reviewer bottom bar, if window width is too small
2020-12-28 10:33:14 +10:00
Damien Elmes
fa5d0bcaef
update translations
2020-12-28 10:25:00 +10:00
Damien Elmes
2074bb03b6
update prost to new 0.7 release+auto stage changes
...
Allows us to drop slow git repo.
2020-12-28 10:12:35 +10:00
Damien Elmes
992a20c05c
remove reference to 'make pull-i18n', it's no longer required
2020-12-27 18:26:14 +10:00
Arthur Milchior
154a99a15b
Contributing shell code in backtick
...
Currently, on ffd28e00e0/docs/contributing.md the
whole code is on a single line. Copying does not work, as the test is commented
2020-12-27 08:57:40 +01:00
Henrik Giesel
b7556281d0
Open AddonsDialog via dialog manager
2020-12-26 18:07:37 +01:00
Henrik Giesel
3db9dec76b
Hide "Edit" and "More" buttons in reviewer bottom bar, if window width is too small
2020-12-26 15:50:32 +01:00
Henrik Giesel
0afed11159
Prevent stats screen from overscrolling
2020-12-26 15:29:45 +01:00
Damien Elmes
ffd28e00e0
bump version
2020-12-26 10:36:42 +10:00
Damien Elmes
4a039bd26a
use PYTHON_SYS_EXECUTABLE for setting path to Python
2020-12-23 21:53:13 +10:00
Damien Elmes
8f89b53568
update translations; use http_archive
2020-12-23 21:28:07 +10:00
Damien Elmes
250b59410e
convert some more git repositories to HTTP archives
...
Faster to download, and can be cached. Archives are from the
same commits as before.
2020-12-23 20:43:05 +10:00
Damien Elmes
e7f82d926a
winrt 1.0.20239.1 isn't available for python 3.9
2020-12-23 20:31:13 +10:00
Damien Elmes
7e39686cd9
use protobuf binaries to reduce initial compile times
2020-12-23 19:49:44 +10:00
Damien Elmes
f0abd82e85
revert docs change; rollup issues occurred again in CI
2020-12-23 16:27:45 +10:00
Damien Elmes
1bdb1b9633
update to rules_nodejs 3.0.0
...
Seems to fix the rollup issues on Windows.
2020-12-23 16:05:15 +10:00
Damien Elmes
d222686755
update to stable pyo3 0.13 release
2020-12-23 10:08:38 +10:00
Damien Elmes
c17471f905
update Rust deps
2020-12-23 10:06:35 +10:00
Damien Elmes
b937cd32b9
update translations
2020-12-22 13:30:39 +10:00
Damien Elmes
d183ce85bf
further decrease default q/a fade time
2020-12-22 13:02:07 +10:00
Damien Elmes
08b0c3aa5a
add video driver enum; allow setting angle+software on mac in prefs
2020-12-22 13:01:06 +10:00
Damien Elmes
8ebd2073a8
fix sync indicator turning blue after startup sync
...
https://forums.ankiweb.net/t/why-is-my-sync-button-blue/2078/26?u=dae
2020-12-22 10:46:50 +10:00
Damien Elmes
1185054ae8
mention deleting ts/node_modules in the docs
...
https://forums.ankiweb.net/t/strange-behaviour-in-the-html-editor/5796/6
2020-12-22 09:29:30 +10:00
Damien Elmes
d4cc34af95
update translations
2020-12-21 20:13:17 +10:00
Damien Elmes
425a4dff70
build wheels in Linux CI
2020-12-21 19:31:15 +10:00
Damien Elmes
25160daa90
tag the wheels as manual so test ... doesn't build them
2020-12-21 19:28:47 +10:00
Damien Elmes
250a45d32e
possible fix for sync button colour blue after sync
...
If the client's clock is behind AnkiWeb's, even by a few seconds,
we can end up with a situation where last_begin_at is updated after
the sync to a value less than the mtime we received from AnkiWeb,
causing the collection to be saved, which bumps the modtime.
Work around this by recording mtime at begin() time, and seeing if it
has changed in either direction.
Thanks to Rumo, who did the hard work looking into it:
https://forums.ankiweb.net/t/why-is-my-sync-button-blue/2078/21
2020-12-21 19:27:26 +10:00
Damien Elmes
584f23cfe0
Merge pull request #859 from hgiesel/tabindex2
...
Consider removing special handling of Shift+Tab in Editor on macOS
2020-12-21 18:38:35 +10:00
Damien Elmes
147be1258d
work around --text-fg ending up in fields
...
https://forums.ankiweb.net/t/strange-behaviour-in-the-html-editor/5796/4
2020-12-21 17:56:20 +10:00
Damien Elmes
e2ba0c3b1c
.prettierrc needs to be in web/, as it's needed for sass as well
2020-12-21 17:05:31 +10:00
Henrik Giesel
8f3bf6ad3c
Focus special handling of Shift+Tab on macOS
2020-12-21 08:00:47 +01:00
Damien Elmes
177764e065
add a small delay before terminating recording
...
https://forums.ankiweb.net/t/anki-crashes-periodically-after-clicking-record-audio-button/5824/12
2020-12-21 16:37:28 +10:00
Damien Elmes
9d71906d9f
remove voice recording fixme
2020-12-21 16:13:32 +10:00
Damien Elmes
7f89750fde
check formatting of .js files in aqt/data
...
mathjax.js did not match //ts:format output
2020-12-21 16:10:59 +10:00
Damien Elmes
5dcae09c5a
link .prettierrc into qt/aqt/data/web/js
...
So automatic formatting in VS Code matches CI format
2020-12-21 16:09:06 +10:00
Damien Elmes
3ecd321dc3
ask users to report if PyAudio works better for them
2020-12-21 16:04:41 +10:00
Damien Elmes
004078e59e
don't pass BUILDINFO into build script
...
It was causing the build script to be recompiled each time a commit was
made, even though buildinfo.txt was not changing.
2020-12-21 16:04:29 +10:00
Damien Elmes
5171633515
drop QtRecorder driver; rename existing
2020-12-21 15:02:22 +10:00