Commit graph

1927 commits

Author SHA1 Message Date
Damien Elmes
4965f6bfb7 toggle flags instead of using separate clear action in browser 2018-11-12 11:55:37 +10:00
Damien Elmes
96ae855afd use a semi transparent, neutral selection in browser
As the base colour of rows is now visible, actions like flagging
now provide immediate feedback about what they've changed.
2018-11-12 11:02:01 +10:00
Damien Elmes
f576d19426 improve handling of invalid deck trees
- move checking code out of the schedulers and into the deck manager
- ensure we can fix the problem in one loop - the previous recursive
approach could lead to stack overflows if the top level of a large
deck tree was missing. this was also the cause of the sqlite
'interrupted' error that some users were seeing
2018-11-09 15:04:35 +10:00
Damien Elmes
fd37eceaeb change purple flag to orange 2018-11-01 14:58:41 +10:00
Damien Elmes
c5a17a29fb Revert "workaround bottom toolbar issue on macOS/qt5.12"
This reverts commit 40b06d463a.

underlying issue should be fixed in qt5.12beta3
2018-10-29 21:08:16 +10:00
Damien Elmes
63a48ecdc4 display warning when profile corrupted 2018-10-29 21:06:33 +10:00
Damien Elmes
038151d2a9 correctly load prefs file modified in more recent qt 2018-10-29 21:06:11 +10:00
Damien Elmes
321559c8db Revert "increase db timeout"
This reverts commit 7a2dc6066c.

did not seem to help
2018-10-28 14:17:43 +10:00
Damien Elmes
053c1c320d work around existing instance not responding quickly
on a slow computer the first instance may have set up the local
server but not yet started the main loop, so when a user double clicks
on the icon twice, the second instance was timing out and opening
another window, then giving locked database errors

to work around this, increase the timeout, and tell the user the
existing instance is not responding instead of creating a new instance

https://anki.tenderapp.com/discussions/ankidesktop/30306-error
https://anki.tenderapp.com/discussions/ankidesktop/30550-im-sorry
2018-10-28 14:17:16 +10:00
Damien Elmes
038eccab42 sidebar now visible by default 2018-10-28 12:24:54 +10:00
Damien Elmes
9d20de871b run latex commands without bundled libs
https://anki.tenderapp.com/discussions/ankidesktop/30531-latex-wont-generate-svgs-automatically-but-will-generate-pngs
2018-10-28 11:41:43 +10:00
Damien Elmes
5a5df31b1a simplify about sizing 2018-10-25 15:47:17 +10:00
Damien Elmes
4836920576 Revert "fix about dialog collapsed on qt 5.11/12"
This reverts commit 510bbb2023.

causes a lot of flickering on startup - will just move to
static sizing instead, as there is a scrollbar anyway
2018-10-25 15:43:17 +10:00
Damien Elmes
40b06d463a workaround bottom toolbar issue on macOS/qt5.12 2018-10-25 15:34:27 +10:00
Damien Elmes
510bbb2023 fix about dialog collapsed on qt 5.11/12
the new approach doesn't seem to work properly on qt 5.9, so just
revert to a static size on that platform
2018-10-25 15:25:47 +10:00
Damien Elmes
b3d168664f bump version 2018-10-25 14:52:49 +10:00
Damien Elmes
eb36e95234 allow startup on qt5.12+
an intermittent issue with the webview on macOS, but otherwise
appears ok in initial tests
2018-10-25 14:48:08 +10:00
Damien Elmes
a2831ea843 we can use the old undo shortcut on 5.11
webviews no longer propagate the captured shortcut
2018-10-23 18:40:58 +10:00
Damien Elmes
385b2df492 fix black flash on stats load on osx/qt5.11 2018-10-23 17:09:16 +10:00
Damien Elmes
35ae933ad7 fix other clickable anchors 2018-10-23 17:05:47 +10:00
Damien Elmes
7d2d8d6ba7 deal with onclick handlers that don't return false
Because <base> is set to the media server URL, <a href='#' ...> causes
a page transition from the current setHtml() page data. Previous Qt
versions allowed us to just ignore the request, but now returning False
in acceptNavigationRequest() causes the subsequent page navigation to
be rejected as well, resulting in no visible change when clicking on a
deck in the deck list.

To deal with this, Anki will now warn when such navigation requests
come in, as the anchors need to be updated to return false. pycmd()
has been updated to return false to make returning in onclick easier.

Also use QUrl.matches() instead of converting the potentially long
URL to a string.
2018-10-23 16:47:01 +10:00
Damien Elmes
bf56616e40 allow the initial setHtml() request to proceed
Qt 5.11 appears to call acceptNavigationRequest() for the initial
page load now.
2018-10-23 16:11:08 +10:00
Damien Elmes
fd07481bed delay event filter installation
Qt 5.11 doesn't initialize the focusProxy until
a page has been loaded.
2018-10-23 16:06:56 +10:00
Damien Elmes
ad7135150b allow startup on qt 5.11 2018-10-23 16:03:27 +10:00
Damien Elmes
63961184dc support new sip module location
qt has moved sip into a submodule
2018-10-23 16:02:59 +10:00
Damien Elmes
416c64c493 prevent infinite loop with invalid template 2018-10-20 19:37:01 +10:00
Damien Elmes
65d8e01e50 don't require collection for top toolbar
This is a hack, and ideally the code would be refactored
so that the entire main window is not loaded until a collection
is available, but doing that will break a bunch of add-ons.

Fixes
https://anki.tenderapp.com/discussions/beta-testing/1276-anki-215-beta#comment_46241878
2018-10-12 12:08:19 +10:00
Damien Elmes
086fa04873 disable proxy support if 127.0.0.1 is not bypassed
There doesn't appear to be an easy way to tell WebEngine to ignore
the proxy for 127.0.0.1, so if the user has not bypassed the proxy
for local addresses, completely disable it. This may break remote
image and script references, but should at least allow the app to
load without intervention.
2018-10-11 15:49:04 +10:00
Damien Elmes
b556645809 use 127.0.0.1 instead of localhost in local urls 2018-10-11 15:45:55 +10:00
Damien Elmes
38189f53d0 fix bug in tag deletion
https://anki.tenderapp.com/discussions/ankidesktop/30146-removing-single-letter-tags-also-removes-any-other-tags-with-the-letter
2018-10-07 18:21:51 +10:00
Damien Elmes
f12e389109 Merge pull request #257 from jurf/patch-1
Use beautifulsoup4 instead of bs4
2018-10-05 11:02:10 +10:00
Juraj Fiala
3bc44584c4 Use beautifulsoup4 instead of bs4
bs4 is just a dummy package to prevent name squatting, it pulls in beautifulsoup4 as a dependency.

https://incolumitas.com/2016/06/08/typosquatting-package-managers/
2018-10-04 10:49:06 +02:00
Damien Elmes
346faf855a use nosetests3 if available 2018-10-04 17:56:50 +10:00
Damien Elmes
14c69c00d9 Merge pull request #255 from gmcmanus/master
Properly escape pasted URLs
2018-10-04 17:44:13 +10:00
Damien Elmes
0735a42cfa bump version 2018-10-01 15:43:47 +10:00
Gabriel McManus
dff57c6b20 Properly escape pasted URLs
If a URL is pasted and it isn't converted to a media link, then it
should be treated as normal text and properly escaped.
2018-09-29 00:47:45 +00:00
Damien Elmes
f861faaf83 bump version 2018-09-28 18:49:38 +10:00
Damien Elmes
f02b536212 increase overview width
fixes wrapped button on
https://anki.tenderapp.com/discussions/ankidesktop/29948-214-bugs
2018-09-28 17:54:43 +10:00
Damien Elmes
be94ce5d24 add small extra margin to answer button
fixes scrollbar in Japanese mode due to half width counts + full width
times on following screen

https://anki.tenderapp.com/discussions/ankidesktop/29948-214-bugs
2018-09-28 17:52:10 +10:00
Damien Elmes
b9d140e690 catch js results that are received after collection closed 2018-09-28 16:27:41 +10:00
Damien Elmes
0800050f95 Merge pull request #254 from giqtaqisi/patch-1
Add support for Lojban
2018-09-27 11:51:42 +10:00
Damien Elmes
dd38879cc9 catch .anki(2) imports 2018-09-27 11:35:21 +10:00
giqtaqisi
d10511627c add support for Lojban 2018-09-26 16:15:07 +00:00
Damien Elmes
76cca08b03 fix error when review button deselected
https://anki.tenderapp.com/discussions/ankidesktop/29882-selecting-a-button-and-enter-or-space-always-chooses-good
2018-09-26 16:31:31 +10:00
Damien Elmes
9be9d7c576 strictly enforce maxIvl
https://anki.tenderapp.com/discussions/ankidesktop/29904-bug-in-v2-scheduler-that-allows-exceeding-the-maximum-review-interval
2018-09-25 09:55:46 +10:00
Damien Elmes
0cfca6d70b beta version 2018-09-24 19:17:35 +10:00
Damien Elmes
04ef57551e fix translation path for packaged builds on Linux 2018-09-24 18:23:57 +10:00
Damien Elmes
c168fc22cf support newlines in type:cloze, and convert them to spaces
https://anki.tenderapp.com/discussions/ankidesktop/29747-empty-cards-when-trying-to-type-in-cloze-deletions
2018-09-24 17:44:34 +10:00
Damien Elmes
62b02d2754 add rowChanged hook and ensure singleCard attr exists 2018-09-24 17:29:19 +10:00
Damien Elmes
7a2dc6066c increase db timeout
possible workaround for 'database is locked' when switching
from WAL mode

https://anki.tenderapp.com/discussions/ankidesktop/29751-90dec2fdce28bb9f0bb7571f41edaff258e953d3
2018-09-24 17:25:23 +10:00