Damien Elmes
51476e05b2
Ensure media files are passed relative to the media folder
...
We were (partially) doing this for MpvManager, but not for
Windows' SimpleMpvPlayer. By passing a media file starting
with a special scheme, a malicious actor could have caused a file to
be written to the filesystem on Windows.
Thanks once again to Michael Lappas for the report.
2025-05-31 16:52:12 +07:00
Damien Elmes
757247d424
Use more secure API key
...
https://github.com/ankitects/anki/pull/3925#discussion_r2051494659
2025-05-31 16:01:03 +07:00
Damien Elmes
6cdebd7638
Fix inverted margin logic
...
https://github.com/ankitects/anki/pull/4040#issuecomment-2921626962
2025-05-30 22:48:31 +07:00
llama
f9f0894162
Add left margin to browser when sidebar is closed ( #4040 )
...
* add left margin to browser when sidebar is closed
* listen for event instead of explicit user action
* refresh sidebar on visibility change
* Add a margin on macOS even when not collapsed
---------
Co-authored-by: Damien Elmes <gpg@ankiweb.net>
2025-05-30 13:35:06 +07:00
Abdo
14b8a8ad0d
Fix new card sort order not reacting to changes in gather order ( #4039 )
2025-05-30 13:05:36 +07:00
Marvin Kopf
7a8b4a193f
offload mpv callback registration to background thread to avoid UI blocking ( #4038 )
...
Instantiating `MPV(MPVBase)` triggers multiple synchronous `command()` calls to the mpv process during callback registration. These calls block the main thread and degrade startup performance. This change defers registration via `taskman.run_in_background`.
2025-05-30 13:05:06 +07:00
Luc Mcgrady
f29bcb743b
Feat/Desired retention warning improvements ( #3995 )
...
* Feat/90% desired retention warning
* Update ftl/core/deck-config.ftl
* show on newly enabled
* Show warning on focus
* Never hide warning
* Display relative change
* Add: Separate warning for too long and short
* Revert unchanged text changes
* interval -> workload
* Remove dead code
* fsrs-rs/@L-M-Sherlock's workload calculation
* Added: delay
* CONSTANT_CASE
* Fix: optimized state
* Removed "Processing"
* Remove dead code
* 1 digit precision
* bump fsrs-rs
* typo
* Apply suggestions from code review
Co-authored-by: Damien Elmes <dae@users.noreply.github.com>
* Improve rounding
* improve comment
* rounding <1%
* decrease rounding precision
* bump ts-fsrs
* use actual cost values
* ./check
* typo
* include relearning
* change factor wording
* simplify sql
* ./check
* Apply suggestions from code review
Co-authored-by: user1823 <92206575+user1823@users.noreply.github.com>
* Fix: missing search_cids
* @dae's style patch
* Fix: Doesn't update on arrow keys change
* force two lines
* center two lines
---------
Co-authored-by: user1823 <92206575+user1823@users.noreply.github.com>
2025-05-27 13:07:21 +10:00
Jarrett Ye
1e6d12b830
Set Due Date: Set interval to actual elapsed days when FSRS is enabled ( #4035 )
2025-05-26 23:33:39 +10:00
Jarrett Ye
dfee38898d
calculate accurate retrievability in card info ( #4034 )
2025-05-26 23:25:27 +10:00
llama
16c5eaf00a
don't show "double click to expand" when it's not possible ( #4030 )
2025-05-22 23:21:08 +10:00
llama
420cd237df
fix io undo logic error ( #4027 )
2025-05-22 23:11:04 +10:00
GithubAnon0000
6a1d55ae75
ADD myself to about.py ( #4026 )
2025-05-22 22:55:37 +10:00
Luc Mcgrady
8694b3b410
Use non breaking spaces for names on about page ( #4025 )
...
* use non breaking spaces for names on about page
* Update qt/aqt/about.py
Co-authored-by: llama <gh@siid.sh>
---------
Co-authored-by: llama <gh@siid.sh>
2025-05-22 22:55:15 +10:00
GithubAnon0000
ec513dfde7
Fix DR not being in percent in the forgetting curve ( #4024 )
...
* FIX DR not displayed as % in forgetting curve
* Run ./check and fix errors found by it
* Round DR to full number
2025-05-22 22:54:35 +10:00
llama
d39284e101
Fix IO masks not saving when scaled ( #4021 )
...
* trigger save after modifying object
* remove redundant save
already called by undoStack.onObjectModified or setShapePosition
2025-05-22 21:43:38 +10:00
GithubAnon0000
e989564be2
FIX borken support link ( #4019 )
...
https://github.com/ankitects/anki/issues/4017
2025-05-22 21:40:13 +10:00
Damien Elmes
3b7f21e50e
Update translations
2025-05-22 21:25:33 +10:00
Lukas Sommer
28e9c5a630
Fix URL schemes translation ( #4004 )
2025-05-22 21:24:48 +10:00
llama
31d877f20d
place caret after mathjax element on overlay close event ( #4016 )
2025-05-19 13:43:01 +10:00
dependabot[bot]
150683ebe2
Bump vite from 5.4.18 to 5.4.19 ( #4018 )
...
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite ) from 5.4.18 to 5.4.19.
- [Release notes](https://github.com/vitejs/vite/releases )
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.19/packages/vite/CHANGELOG.md )
- [Commits](https://github.com/vitejs/vite/commits/v5.4.19/packages/vite )
---
updated-dependencies:
- dependency-name: vite
dependency-version: 5.4.19
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-19 13:38:53 +10:00
Damien Elmes
7b4a7dcf18
Bump flask-cors for latest CVEs
2025-05-19 13:34:59 +10:00
Emmanuel Ferdman
8a61a5470c
Resolve Python regex library warnings ( #4012 )
...
* Resolve Python regex library warnings
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
* Add CONTRIBUTORS
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
2025-05-19 13:29:54 +10:00
spiritualfather
63fd1ffbff
upgrade esbuild versions ( #4011 )
...
* upgrade esbuild versions
* Update license file
2025-05-19 13:25:05 +10:00
llama
d667abffd1
Fix searching for non-blank adjacent wildcard fields ( #4009 )
...
* modify collect_ranges to take param on whether to join ranges
* update tests
* update existing call
* fix searching for non-empty wildcard fields
2025-05-19 13:15:23 +10:00
Luc Mcgrady
ed13a351b9
Fix/Prevent manual resize of params input ( #4008 )
2025-05-19 13:10:47 +10:00
sorata
277061498d
update backup restore message ( #4005 )
...
* update backup restore message
* Update ftl/qt/qt-misc.ftl
Co-authored-by: GithubAnon0000 <160563432+GithubAnon0000@users.noreply.github.com>
---------
Co-authored-by: GithubAnon0000 <160563432+GithubAnon0000@users.noreply.github.com>
2025-05-19 13:09:43 +10:00
Lukas Sommer
a402670c4e
Update sync.ftl ( #4003 )
...
* Update sync.ftl
* Update ftl/core/sync.ftl
Improved string by @GithubAnon0000
Co-authored-by: GithubAnon0000 <160563432+GithubAnon0000@users.noreply.github.com>
---------
Co-authored-by: GithubAnon0000 <160563432+GithubAnon0000@users.noreply.github.com>
2025-05-19 10:44:54 +10:00
Damien Elmes
48a0640a07
Revert "feat(scheduler): add from_queue flag to CardAnswer ( #3976 )"
...
This reverts commit 1f95d030bbhttps://github.com/ankitects/anki/pull/3983
2025-05-19 10:26:10 +10:00
Damien Elmes
d3d6bd8ce0
Skip ytdl flag on macOS ARM
...
Fixes sounds failing to play in the packaged build on macOS.
2025-05-15 19:04:26 +10:00
Damien Elmes
1157465844
Update translations
2025-05-15 16:50:08 +10:00
llama
413b73d9f4
fix onNote potentially discarding editor field changes ( #4001 )
2025-05-15 16:48:56 +10:00
llama
97b12b420a
Resize fsrs params input to fit content ( #3999 )
...
* resize param input on value change
* resize on window resize
2025-05-15 16:41:30 +10:00
user1823
8f2c708751
Include reset entries in dataset exported for research ( #3998 )
...
https://github.com/open-spaced-repetition/fsrs4anki-helper/pull/566#issuecomment-2875432135
2025-05-15 16:31:18 +10:00
llama
a2a1f597be
Style the fsrs params input ( #3997 )
...
* style textarea and date inputs
* remove redundant date input styling
2025-05-15 16:30:17 +10:00
llama
4e1a901738
Clarify field separator being a guess when importing csv ( #3996 )
...
* clarify that the initially selected field separator is a guess
* explain why the field seperator setting might be locked
2025-05-15 16:26:51 +10:00
Adnane Taghi
f96c8c2ac8
Make URL schemes dialog more ergonomic ( #4002 )
...
(originally merged into a PR branch)
* Make URL schemes dialog more ergonomic
* add name to contributors list
* Title Case
* Tweak build instructions so Cursor picks them up
* Use a warning icon for the URL scheme pop-up
* Default to cancelling
2025-05-15 16:17:33 +10:00
Kolby Moroz Liebl
6427ff3db5
Fix dockerimage, by bumping rust version ( #3993 )
2025-05-15 16:09:27 +10:00
Damien Elmes
86c89907e7
Add URL scheme whitelist ( #3994 )
...
* Add experimental Cursor rules
* Add the ability to customize URL schemes
Closes #3965
2025-05-15 15:37:49 +10:00
Luc Mcgrady
f7cdf4eb9e
Fix/Leech suspended tooltip ( #3992 )
...
* Fix/Leech suspended popup
* extra check
* Fix: None check
* move comment
2025-05-15 15:14:10 +10:00
GithubAnon0000
f727934a42
CHANGE collection size too large error to add MB values and info about compressed vs. uncompressed. ( #3981 )
...
* CHANGE collection size too large error to add MB values and info about compressed vs. uncompressed
* Round f64 to 2 decimals
* Remove line breaks from ftl/core
* Remove string 'uncompressed' from code
* Add string 'uncompressed' to ftl/core
* Remove if statement change introduced to test changes locally
* Run ./check
2025-05-15 15:08:41 +10:00
GithubAnon0000
37dfbca094
UPDATE answer button graph tooltip to include I) answer button name and II) description of what "correct" means ( #3979 )
...
* ADD name of the button after button number (1 → again...)
* ADD info string to explain what 'correct' means
* Run ./check and make it happy
* Apply suggestion from @dae to make text shorter
2025-05-15 14:54:51 +10:00
llama
1c69333210
don't scale border width along with existing masks ( #3991 )
2025-05-12 01:49:29 +03:00
Damien Elmes
5080451829
Disable YouTube DL in mpv
...
mpv looks for ytdl on the path, which includes the CWD on Windows.
A malicious shared deck could place an executable called yt-dlp.exe in the
media folder, which mpv would then helpfully invoke the first time
a YouTube link was encountered.
A big thank you to Michael Lappas for the report.
2025-05-10 19:31:06 +10:00
llama
c33974f6ab
Fix polygons closing when clicking existing masks while editing IO ( #3990 )
...
* fix polygons closing when clicking existing masks while editing io
* disallow selecting new polygons
* update CONTRIBUTORS
* preserve ids when pushing canvas state to undo stack
* rehandle tool changes after undoing/redoing
the polygon tool makes all objects unselectable, which isn't
preserved when restoring the canvas state after an undo/redo
2025-05-10 16:32:44 +10:00
llama
573f59fab1
Allow rotating IO masks ( #3987 )
...
* Revert "Disable rotation globally"
This reverts commit 22736238c1
2025-05-10 16:21:33 +10:00
llama
5cc44b3f68
Make IO polygon markers centred and transparent ( #3989 )
...
* make polygon markers centred and transparent
* centre active line
* set perPixelTargetFind per object, and not on the canvas
otherwise it can't be overridden for a specific object
see 4c305baae6/src/canvas.class.js (L786)
2025-05-09 00:20:00 +10:00
llama
9025202204
properly construct file url when opening image/folder on linux ( #3986 )
2025-05-08 23:29:46 +10:00
Abdo
80618cad85
Clear notetypes cache on import ( #3969 )
...
* Clear notetypes cache on import
* Clear cache in AnkiQt.on_operation_did_execute() instead
2025-05-08 23:11:47 +10:00
Jarrett Ye
1124a63798
expose decay of Card object in Python ( #3985 )
2025-05-06 23:32:58 +03:00
Damien Elmes
cbb202a46f
Re-run minilints on .md change
...
While trivial updates to our docs don't really need a license
declaration, they were causing CI to fail after merge.
2025-05-05 19:10:13 +10:00
