Damien Elmes
53686b54c5
Merge remote-tracking branch 'origin/main' into svelte5
2024-08-22 19:08:09 +07:00
Abdo
e81f0846b2
Fix new formatting errors
2024-08-19 15:17:47 +03:00
Abdo
a9c7c71794
Formatting
2024-08-19 12:15:14 +03:00
Abdo
929053f01e
Fix MathJax editor not loading
2024-08-15 15:34:04 +03:00
Abdo
797f6a02c5
Fix editor loading
2024-08-14 17:26:17 +03:00
Abdo
887aa1c8b7
Fix graph tooltips
2024-08-14 15:34:24 +03:00
Abdo
add1248cd8
Merge branch 'main' into svelte5
2024-08-14 14:44:16 +03:00
Damien Elmes
5f80ddf27d
Remove outdated comments in contributing, and mention refactoring
2024-08-10 18:43:11 +07:00
David Culley
4fb6fa81ac
refactor: use not in and is not as recommended ( #3351 )
...
- https://docs.astral.sh/ruff/rules/not-is-test/
- https://docs.astral.sh/ruff/rules/not-in-test/
2024-08-10 17:55:26 +07:00
Voczi
1065941767
Add option for toggling update checks ( #3346 )
2024-08-10 17:46:49 +07:00
Damien Elmes
06d5256f4e
Update translations
2024-08-10 16:56:30 +07:00
Damien Elmes
b27b42e6e5
Revert "Updated tooltips ( #3326 )"
...
This reverts commit c7762d4ec4https://github.com/ankitects/anki/pull/3331#issuecomment-2276317668
2024-08-10 16:56:30 +07:00
Damien Elmes
3b0abe7571
Revert "update review limit's name ( #3331 )"
...
This reverts commit e0de13e240https://github.com/ankitects/anki/pull/3331#issuecomment-2276317668
2024-08-10 16:56:30 +07:00
sorata
af8fdd8b87
reviews —> review cards ( #3347 )
2024-08-10 16:53:25 +07:00
Damien Elmes
872ecf481a
Update translations
2024-08-08 18:37:33 +07:00
Damien Elmes
afb0790703
Revert "Rename review limit ( #3320 )"
...
This reverts commit f0933cf06chttps://forums.ankiweb.net/t/rename-review-limit/47097/50
2024-08-08 18:37:08 +07:00
David Culley
70a063a3b9
Fix error if regex can't find the filename ( #3285 )
...
* fix: treat error if regex doesn't match
* refactor: use assertion to avoid error message
2024-08-07 16:17:37 +07:00
Dillon Baldwin
a2b4b57390
Added name to contributors list as well as addressed issue #3343 . Ran ninja check and the build compiled successfully. ( #3345 )
2024-08-07 16:15:50 +07:00
sorata
e0de13e240
update review limit's name ( #3331 )
...
* update review limit's name
* updated tooltip for clarity
this reads more well now, given that new limit isn't max limit
* re-add maximum
* typo
2024-08-05 20:13:53 +07:00
Asuka Minato
e851d0d281
Update about.py ( #3330 )
...
* Update about.py
* Update CONTRIBUTORS
2024-08-05 15:56:04 +07:00
Jarrett Ye
1f7a84d68c
Update to FSRS-rs v1.1.4 ( #3329 )
...
* update to fsrs-rs v1.1.4
2024-08-05 15:54:10 +07:00
Damien Elmes
ca4393142e
Update to Rust 1.80
...
https://github.com/ankitects/anki/pull/3329#issuecomment-2254538270
2024-08-05 15:37:59 +07:00
cdonat2
b1bf1c3141
Add maximize hint for models.py ( #3151 ) ( #3328 )
...
Co-authored-by: Christian Donat <cdonat@tu-berlin.de>
2024-08-05 15:21:18 +07:00
David Culley
bab83ffce0
fix: add proper imports ( #3296 )
...
Co-authored-by: Damien Elmes <dae@users.noreply.github.com>
2024-08-05 11:34:46 +07:00
David Culley
44380dd62a
Specify Python version for auto-formatters ( #3325 )
...
* chore(isort): specify Python version to be assumed
https://pycqa.github.io/isort/docs/configuration/options#python-version
Default is to assume _any_ Python 3 version could be the target.
* chore(black): specify Python target versions
https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#t-target-version
* chore(ruff): specify Python version to be assumed
https://docs.astral.sh/ruff/settings/#target-version
* chore: exclude directories from auto-formatting
2024-08-04 20:54:14 +07:00
David Culley
37a3f4708a
Refactor _addButton method of editor ( #3294 )
...
* refactor: simplify f-string
* refactor: use more readable names
* style: separate if-else-clauses by empty lines
* fix: add missing import
Properly `import os`.
* refactor: simplify variable assignment
* refactor: rename variables
* refactor: use f-string
* refactor: reorder variables
* refactor: simplify if-clause with de morgan's laws
* refactor: simplify if-else-construct
* fixup! refactor: rename variables
* Revert "refactor: use f-string"
This reverts commit 1dcb58bdab813130ba6a
2024-08-04 20:51:45 +07:00
David Culley
c0349ea9da
Improve exception handling ( #3290 )
...
* fix: except only non-system-exiting exceptions
see https://youtu.be/zrVfY9SuO64
* chore: add myself to CONTRIBUTORS file
* refactor: explicitly specify possible exceptions
If an exception is not an Exception, there are only three options left.
see https://docs.python.org/3/library/exceptions.html#exception-hierarchy
* refactor: use BaseException for fallback
Co-authored-by: Damien Elmes <dae@users.noreply.github.com>
* chore: add myself to contributors
2024-08-04 20:51:13 +07:00
David Culley
a5a39c9302
Fix 'NoneType object is not subscriptable' error ( #3286 )
...
* fix: ensure none of the returned values is None
Fixes TypeError 'NoneType' object is not subscriptable
* refactor: reduce code duplication using a function
* refactor: prefer KeyError over None for dicts
If the key is not in the dictionary, we want to raise a KeyError rather
than returning None. That way, we can distinguish between whether the
value was None or the key was not found.
* chore: add myself to CONTRIBUTORS file
* refactor: simplify the code
2024-08-04 20:49:45 +07:00
Damien Elmes
426790bfcb
Formatting fix
...
For some reason this didn't get caught by my pre-push hook :-(
2024-08-01 12:24:38 +07:00
Damien Elmes
1910b9609e
Drop non-working tiff support
...
https://forums.ankiweb.net/t/anki-fails-to-attach-tif-images-to-cards/47609
2024-08-01 12:19:35 +07:00
Expertium
2c30081e3e
SM2 -> SM-2.ftl ( #3327 )
...
Relevant: https://github.com/ankitects/anki-manual/pull/218
2024-07-26 21:24:29 +07:00
sorata
c7762d4ec4
Updated tooltips ( #3326 )
...
* Update deck-config.ftl
* Update deck-config.ftl
* Update deck-config.ftl
* Update deck-config.ftl
* Update ftl/core/deck-config.ftl
2024-07-26 19:30:35 +07:00
Damien Elmes
656309f385
Update translations
2024-07-26 18:21:01 +07:00
Expertium
f0c211389f
Ignore reviews before -> Ignore cards reviewed before.ftl ( #3314 )
...
* Ignore review before -> Ignore cards reviewed before.ftl
* Revert the change.ftl
* Update CONTRIBUTORS
2024-07-26 18:19:51 +07:00
David Culley
0743e6e40e
Update type annotations to use | operator ( #3323 )
...
* refactor: update to `|` operator
* refactor: add missing type hint
* refactor: enable `|` operator for older versions
* refactor: remove obsolete import
2024-07-26 18:15:39 +07:00
sorata
f0933cf06c
Rename review limit ( #3320 )
...
* maximum reviews/day —> maximum cards/day
* New cards ignore maximum limit
2024-07-26 18:05:33 +07:00
David Culley
3f66f995f7
style: reformat with black ( #3324 )
2024-07-26 17:58:57 +07:00
David Culley
363a52526e
Update type annotations ( #3322 )
...
* refactor: update Callable type hint
* refactor: update type annotations for hooks
2024-07-26 17:57:25 +07:00
David Culley
6c0857395f
Refactor getting the index of a user's language ( #3311 )
...
* refactor: rename variables of tuple
* refactor: rename function argument
* refactor: use function to get index of language
* refactor: replace for-loop
* refactor: use variable
* refactor: assert values are not None
To satisfy the type checker.
* refactor: change generator expression to for-loop
2024-07-25 12:46:59 +07:00
Damien Elmes
5c33e5ea65
Revert "About section transparent logo ( #3284 )" ( #3315 )
...
This reverts commit 0b38ecdbc7
2024-07-22 02:09:40 +07:00
Damien Elmes
faa9efaff7
Latest openssl fix
2024-07-22 02:08:35 +07:00
Jarrett Ye
52ce6e6a6b
Feat/FSRS-5 ( #3298 )
...
* Feat/FSRS-5
* adapt the SimulatorConfig of FSRS-5
* update parameters from FSRS-4.5
* udpate to FSRS-rs v1.1.0
* ./ninja fix:minilints
* pass ci
* update cargo-deny to 0.14.24
* udpate to FSRS-rs v1.1.1
* update to fsrs-rs v1.1.2
2024-07-21 21:02:24 +07:00
sorata
5216fa959e
Update AutoAdvance.svelte ( #3313 )
2024-07-21 20:49:42 +07:00
user1823
dccb7c9b27
Update references to tooltip strings ( #3312 )
...
* Update string reference
* Update FsrsOptionsOuter.svelte
2024-07-21 17:24:41 +07:00
Damien Elmes
39b764aaad
Update sveltekit-svg to match svelte version
...
Fixes deck options failing to load, and a bunch of warnings with
./yarn dev
2024-07-21 17:13:14 +07:00
sorata
087f957a36
Update Tooltip ( #3288 )
...
* Update Tooltip
updated the tooltips as described here: https://forums.ankiweb.net/t/update-tooltips/46849
* Update CONTRIBUTORS
* Update deck-config.ftl
* fixed punctuation, stylistic incoherence, etc.
* Update deck-config.ftl
https://github.com/open-spaced-repetition/fsrs4anki/pull/667
* Changed string requires new key (dae)
* Minor tweaks to tense for clarity (dae)
https://github.com/ankitects/anki/pull/3288#issuecomment-2223384500
2024-07-21 16:44:37 +07:00
Abdo
b05c9d1598
Fix change_notetype_of_notes's docstring ( #3304 )
2024-07-21 15:26:10 +07:00
David Culley
aa6583cdd1
Refactor ephemeral_card of notes ( #3307 )
...
* refactor: fix type annotation
* fix: properly check if argument is None
Don't use Boolean expressions to implement a default value.
* fix: ensure that 'model' is not None
Don't use exceptions to control the flow.
* refactor: simplify if-else construct
2024-07-21 15:25:48 +07:00
David Culley
e213c0a6d1
refactor: use list comprehension ( #3308 )
2024-07-21 15:21:41 +07:00
Abdo
bb5ed4da9c
Fix unused parent tags getting cleared ( #3299 )
...
Co-authored-by: Damien Elmes <dae@users.noreply.github.com>
2024-07-21 15:00:39 +07:00
