Commit graph

2459 commits

Author SHA1 Message Date
Damien Elmes
829f504740 Merge pull request #363 from ig3/bug/new-perday
Use _deckNewLimitSingle in _groupChildrenMain
2019-12-21 07:41:18 +10:00
Damien Elmes
cb8f8dd4f6 mention example in contrib file 2019-12-21 07:38:01 +10:00
Damien Elmes
92bdc5ff8a add an example of how circular imports can be handled
The type name needs to be quoted so it is evaluated after the module
has been initialized.

In the future when we drop support for python 3.6, and mypy is updated,
we will be able to remove the quotes and use the following at
the top of the file instead:

from __future__ import annotations
2019-12-21 07:29:45 +10:00
Damien Elmes
2678f9b01b pytype can't handle circular imports 2019-12-21 07:16:26 +10:00
Ian Goodacre
2ac26f03fd Use _deckNewLimitSingle in _groupChildrenMain 2019-12-21 09:26:51 +13:00
Damien Elmes
ff450f60ef add type hints section to README.contributing 2019-12-20 20:52:16 +10:00
Damien Elmes
a186635a0e add comment about pretty to makefile 2019-12-20 20:37:29 +10:00
Damien Elmes
e8c5d0bf3b Revert "add arg hints to schedulers"
This reverts commit 19a4e0bcf3.

no longer needed
2019-12-20 19:44:08 +10:00
Damien Elmes
8095ad8e4b use isort to tidy up imports 2019-12-20 19:19:29 +10:00
Damien Elmes
92ea94a034 add some typing to addcards and main 2019-12-20 18:43:52 +10:00
Damien Elmes
3cdb5db11a a few more typing fixes 2019-12-20 17:55:19 +10:00
Damien Elmes
96bb318c8e add a bunch of extra hints for mypy 2019-12-20 16:40:20 +10:00
Damien Elmes
de89c72511 remove typings from some other files
not used frequently enough to deal with the mypy errors they're causing
at the moment
2019-12-20 16:33:49 +10:00
Damien Elmes
dc0fdaeea5 add a bunch of annotations for mypy 2019-12-20 15:07:40 +10:00
Damien Elmes
f08ef66550 fix media.check() sig 2019-12-20 11:58:50 +10:00
Damien Elmes
19311514f7 exporting, latex 2019-12-20 11:47:19 +10:00
Damien Elmes
85e1a1c772 importing 2019-12-20 11:41:24 +10:00
Damien Elmes
9f960bc38e lang/media/storage 2019-12-20 11:27:01 +10:00
Damien Elmes
a65d91267c decks 2019-12-20 11:07:08 +10:00
Damien Elmes
594a2c14b7 models 2019-12-20 11:07:08 +10:00
Damien Elmes
6818234679 db/hooks/utils 2019-12-20 11:07:08 +10:00
Damien Elmes
0c5d1db81d collection 2019-12-20 11:07:08 +10:00
Damien Elmes
5b776971f8 cards/notes 2019-12-20 11:07:08 +10:00
Damien Elmes
87d37c7889 type hints for scheduler 2019-12-20 11:07:08 +10:00
Damien Elmes
19a4e0bcf3 add arg hints to schedulers 2019-12-20 11:07:08 +10:00
Damien Elmes
9983774a12 add pytype inferred types to anki/
I've corrected some obvious issues, and we can fix others over time.
Mypy tests are currently broken, as adding the type hints has increased
mypy's testing surface.
2019-12-20 11:07:08 +10:00
Damien Elmes
c9c219bd38 pin pyqt version; the just-released 5.14 looks to be broken 2019-12-20 10:44:15 +10:00
Damien Elmes
fc8f5f76ac hide errors when sudo required for typecheck setup 2019-12-20 10:39:24 +10:00
Damien Elmes
79fb2f0929 fix travis again 2019-12-20 10:38:14 +10:00
Damien Elmes
e39c3fadd2 typing fixes 2019-12-20 10:21:20 +10:00
Damien Elmes
090f8d2953 disable unit test broken by revert 2019-12-20 10:16:17 +10:00
Damien Elmes
81282202b5 call onExpanded() 2019-12-20 09:30:35 +10:00
Damien Elmes
252d5b56e0 honor expand setting 2019-12-20 09:27:14 +10:00
Damien Elmes
fbc18a4a5c fix click to expand/contract 2019-12-20 08:52:03 +10:00
Damien Elmes
f70e439d95 Revert "DeckManager: _checkDeckTree ignore case"
This reverts commit a6dab26d45.

This commit broke collections that had children under each of the
the duplicate names - it renames one of the decks, but the children
of the renamed deck are left without a parent, causing an error like

line 235, in deckDueList  nlim = min(nlim, lims[p][0])\n\nKeyError('..)

Rather than a more complicated approach, I think it's safer just to
leave the case or normalization-differing decks around for now, and
we can normalize things properly in a future schema upgrade.
2019-12-20 08:18:01 +10:00
Damien Elmes
33051e0913 typing tweaks 2019-12-19 21:11:35 +10:00
Damien Elmes
a35824bf86 rebuild gui if any icons change 2019-12-19 21:11:27 +10:00
Damien Elmes
ec2b5e4aeb faster sidebar implementation
- qtreewidget is too slow on Qt5
- expanding/collapsing still todo
2019-12-19 21:11:12 +10:00
Damien Elmes
0998cf04f2 fix bug in editor ts conversion 2019-12-19 20:53:00 +10:00
Damien Elmes
8cee5e5d7e Revert "add signatures to calling code"
This reverts commit 9a1f616a3a.

Pytype does catch the mentioned error without the extra annotations.
2019-12-19 11:39:40 +10:00
Damien Elmes
9a1f616a3a add signatures to calling code
otherwise mypy ignores them. And even then, it's not smart enough
to notice self.mw.pm.setUiScale("foo") is invalid unless the
instance assignment in main has a type hint as well
2019-12-19 11:34:46 +10:00
Damien Elmes
d04b8aa8bb add UI scale preference 2019-12-19 09:58:16 +10:00
Damien Elmes
129892a059 setup profile earlier in startup, but defer warning message until qt init 2019-12-19 09:38:36 +10:00
Damien Elmes
af013308c3 split qt requirements out again
PyQt didn't used to split WebEngine out separately, and that can
cause conflicts with distro-provided packages.
2019-12-19 09:34:31 +10:00
Damien Elmes
40713067d0 update make instructions 2019-12-19 07:46:25 +10:00
Damien Elmes
bddd92bea3 ignore buildhash when checking if tests need to be re-run 2019-12-18 21:06:47 +10:00
Damien Elmes
dae7d313d2 use single .gitignore file 2019-12-18 21:06:24 +10:00
Damien Elmes
9f8070dbc8 fix broken js building
- deps need to be defined before used
- incremental builds were not working properly
2019-12-18 17:56:58 +10:00
Damien Elmes
a88894da4f individual build rules need to depend on prereqs 2019-12-18 17:28:23 +10:00
Damien Elmes
7070148e5a do typecheck setup as part of prereqs install 2019-12-18 17:18:24 +10:00