GitHub/Anki
1
0
Fork 0
mirror of https://github.com/ankitects/anki.git synced 2026-01-14 06:23:57 -05:00
Code Issues Projects Releases Packages 1 Wiki Activity Actions
6738 commits 10 branches 166 tags 121 MiB
Commit graph

6738 commits

This branch
This branch
All branches
Author SHA1 Message Date
Damien Elmes
8c1a386202 Revert "ensure fields normalized before checksumming" 
This reverts commit f4bd867b3b54b172125d2f2021c8c6a6e69c4c4d.
 2021-03-17 22:21:13 +10:00
Damien Elmes
545048f350 fix schema not being modified 
https://forums.ankiweb.net/t/python-checksum-rust-checksum/8195/8
 2021-03-17 22:18:31 +10:00
Damien Elmes
77e5d02cbc add note about bumping Rust deps 2021-03-15 13:29:36 +10:00
Damien Elmes
7de07e5a29 Merge pull request #1071 from RumovZ/sidebar-del 
Only delete by key when selected items have same type
 2021-03-15 13:27:31 +10:00
Damien Elmes
e165c6ea4d Merge pull request #1070 from Arthur-Milchior/update_is_executable 
update is executable
 2021-03-15 13:23:29 +10:00
Damien Elmes
dcff620b56 Merge pull request #1069 from Arthur-Milchior/Emptying_field_lead_to_proper_message 
Emptying field lead to proper message
 2021-03-15 13:17:05 +10:00
Arthur Milchior
d1bf02a709 If a template name contains only quote, show relevant error message 
This is for the sake of the consistency with the last commit
 2021-03-14 02:10:48 +01:00
Arthur Milchior
574a513fe6 Return meaningful message if a field is empty after normalizing 
This correct the probably rare bug as follow:

I got a note type with a field whose name is "\".

When I made any change to this note type, even unrelated, I get a message stating that there is an empty field. This is
strange because I can see it to be false. Investigating show that "\" is normalized to empty field. This ensure that
it's shown
 2021-03-14 02:10:32 +01:00
RumovZ
41428ca6f9 Improve grouping of sidebar methods 2021-03-13 09:45:06 +01:00
RumovZ
99122dfa16 Use same constraints for deleting by key press ... 
... as for deleting via context menu, i.e., delete key does nothing if
not all selected items are of the same type.
 2021-03-13 09:31:56 +01:00
Arthur Milchior
e0dee90905 update is executable 
Without this change, I can't just do `./update.py` and need to do `python3 update.py`
 2021-03-13 07:35:36 +01:00
Damien Elmes
455a93cc27 ensure fields normalized before checksumming 
https://forums.ankiweb.net/t/python-checksum-rust-checksum/8195
 2021-03-13 10:23:32 +10:00
Damien Elmes
b5a913c1cf Merge pull request #1067 from RumovZ/regex-err 
Fix regex error formatting and search error escaping
 2021-03-13 10:16:10 +10:00
RumovZ
9bbe584522 Fix markdown escaping in search errors 2021-03-12 20:32:38 +01:00
RumovZ
456a3b214a Fix formatting of invalid regex error 
Preserve whitespace, special characters and use monospace font.
 2021-03-12 20:31:23 +01:00
Damien Elmes
ae6cf81d69 add indexes to graves table to speed up undo 2021-03-12 18:59:24 +10:00
Damien Elmes
f25b95b312 avoid hanging UI when undoing in browse screen 2021-03-12 18:54:08 +10:00
Damien Elmes
da2467838c undo in background, and show progress window 2021-03-12 17:54:56 +10:00
Damien Elmes
c52df814a4 experiment with perform_op() wrapper 
Fixes #1065, and gives us similar functionality to #1066
 2021-03-12 17:54:13 +10:00
Damien Elmes
b9581b94fb 'change deck' now undoable 2021-03-12 16:27:57 +10:00
Damien Elmes
5b52f0e931 consume original card when updating 2021-03-12 16:20:58 +10:00
Damien Elmes
fef8c402e0 make 'forget card' undoable; remove checkpoint() in set_due_date 2021-03-12 16:13:50 +10:00
Damien Elmes
37ebeaa119 fix set due date not remembering default in browse screen 2021-03-12 15:47:11 +10:00
Damien Elmes
18a8d458bb Revert "Merge pull request #1066 from RumovZ/editor-save-dec" 
This reverts commit 994081be34, reversing
changes made to 091ea67690.

@RumoVZ this broke a bunch of operations like 'select notes' and
'set due date'. When the triggered signal is connected to a function,
PyQt looks at the function signature to decide what arguments to pass
it. The wrapper was using *args, so PyQt passes in an extra argument,
which the underlying function didn't expect.

I tried settting __signature__ on the wrapper, but PyQT seems to
ignore it, so we may either need to check all of the existing calls
and add the ignored extra arguments, or create a separate wrapper for
such cases.
 2021-03-12 15:44:19 +10:00
Damien Elmes
28cd625204 limit initial sort selection to new cards 
https://github.com/ankidroid/Anki-Android/issues/8172
 2021-03-12 14:58:19 +10:00
Damien Elmes
7f8d675e25 'set due date' now undoable 2021-03-12 14:50:31 +10:00
Damien Elmes
7e76c68c0c move old scheduler files into scheduler/ 
Includes a hack that should allow existing imports to continue to work;
if this breaks things for you, please let me know.
 2021-03-12 14:43:45 +10:00
Damien Elmes
ab564315d8 split out common scheduler code into base.py, use scheduler/ dir 
Also move the legacy aliases into a separate file
 2021-03-12 14:07:52 +10:00
Damien Elmes
994081be34 Merge pull request #1066 from RumovZ/editor-save-dec 
Add decorators for calling editor.saveNow()
 2021-03-12 09:23:18 +10:00
RumovZ
fc787f1e9b Add decorator to save editor in sidebar 2021-03-11 22:25:18 +01:00
RumovZ
0def65a684 Add decorator to save editor in browser 2021-03-11 22:24:24 +01:00
Damien Elmes
091ea67690 enable deck removal undo again 2021-03-11 22:24:12 +10:00
Damien Elmes
755a12358b Merge pull request #1044 from RumovZ/sidebar-tools 
Add sidebar modes for different click behaviour
 2021-03-11 21:57:53 +10:00
RumovZ
b093d62f5a Merge branch 'master' into sidebar-tools 2021-03-11 12:08:32 +01:00
RumovZ
7d4f830322 Annotate decks.rem as deprecated 2021-03-11 11:26:35 +01:00
Damien Elmes
abf4ef9eac deck drag&drop undo 2021-03-11 20:02:16 +10:00
RumovZ
35902ef9fc Remove prompt when deleting from deckbrowser 2021-03-11 10:28:23 +01:00
Damien Elmes
f09c1d027c add a separate 'rename deck' method 2021-03-11 19:24:54 +10:00
RumovZ
a4e6f9791f Run background tasks with progress 2021-03-11 10:04:58 +01:00
RumovZ
193e7cc2aa Remove deck remove prompt but show card count 2021-03-11 09:52:11 +01:00
RumovZ
45fab1c043 Remove prompt when deleting saved searches 2021-03-11 09:20:41 +01:00
RumovZ
80444db6b0 Show count of affected notes after tag renaming 2021-03-11 09:17:22 +01:00
RumovZ
a5464de688 Show tooltip instead of prompt for removing tags 2021-03-11 09:14:50 +01:00
Damien Elmes
c89fea1174 split out remaining rpc methods 
@david-allison-1 note this also changes the method index to start at
0 instead of 1
 2021-03-11 17:04:32 +10:00
Damien Elmes
35a2022901 split out stats, media and search 2021-03-11 16:16:40 +10:00
Damien Elmes
ebc5695038 split out tags, deck config and card rendering 2021-03-11 16:05:06 +10:00
Damien Elmes
c30d3ee137 split out sync, notetypes and config code 2021-03-11 15:47:31 +10:00
Damien Elmes
7c09b73b6b rework backend codegen to support multiple services; split out sched 
Rust requires all methods of impl Trait to be in a single file, which
means we had a giant backend/mod.rs covering all exposed methods. By
using separate service definitions for the separate areas, and updating
the code generation, we can split it into more manageable chunks -
this commit starts with the scheduling code.

In the long run, we'll probably want to split up the protobuf file into
multiple files as well.

Also dropped want_release_gil() from rsbridge, and the associated method
enum. While it allows us to skip the thread save/restore and mutex unlock/
lock, it looks to only be buying about 2.5% extra performance in the
best case (tested with timeit+format_timespan), and the majority of
the backend methods deal with I/O, and thus were already releasing the
GIL.
 2021-03-11 14:51:29 +10:00
Damien Elmes
aec2934ac6 Merge pull request #1064 from BlueGreenMagick/fix-sidebar-click 
Clicking the expander icon should not trigger click event
 2021-03-11 10:19:55 +10:00
bluegreenmagick
270dac70f0 Clicking the expander icon should not trigger click event 
Expander icon does not change currentIndex
 2021-03-11 09:04:24 +09:00