Commit graph

6561 commits

Author SHA1 Message Date
Henrik Giesel
a9ded7cc3c Fix highlight for topright buttons 2021-03-09 13:37:56 +01:00
Henrik Giesel
261b93ea36 Remove field margins
* Bootstrap solves it more elegantly with line-height
* body { margin: 0 } is also defined by bootstrap
2021-03-09 13:37:56 +01:00
Henrik Giesel
dbcf0ffee1 Include bootstrap in editor 2021-03-09 13:37:56 +01:00
Henrik Giesel
b7c24a9f98 Add bootstrap, bootstrap-icons, and popperjs 2021-03-09 13:37:56 +01:00
Damien Elmes
26a4e7b355 Merge pull request #1062 from abdnh/strip-html-comments
Strip HTML comments from external pastes
2021-03-09 11:55:59 +10:00
Damien Elmes
94795b9392 Merge pull request #1060 from hgiesel/focusplus
Fix focus handling by moving caretToEnd logic
2021-03-09 11:53:09 +10:00
Damien Elmes
bee7925225 fix sync download failing when temp dir on different mount
https://forums.ankiweb.net/t/problems-with-2-1-41-on-arch-linux/8103
2021-03-09 11:44:49 +10:00
abdo
45b4be4dd3 Strip HTML comments from external pastes
Fix a regression caused by 2efc2030f6
2021-03-09 03:15:08 +03:00
Henrik Giesel
b4a2f9930b Satisfy formatter 2021-03-08 20:55:04 +01:00
Henrik Giesel
4dd565065f Move caretToEnd logic out of focus handling 2021-03-08 20:40:23 +01:00
Henrik Giesel
eff90085ea Improve focus handling
* Ported from #1046:

* disabling buttons will clear button highlight
* enabling button will set button highlight
* move caret to end executed before enabling buttons (so button highlight will be for actual position of caret)
* move caret to end will also be executed if previousActiveElement is null, which will only be the case before the first onBlur was executed:
  * so that caret will be moved to end on opening editor
2021-03-08 14:20:06 +01:00
Damien Elmes
86c101b872 Ensure we purge caches when rolling back
Fixes #1056
2021-03-08 10:39:18 +10:00
Damien Elmes
d2de56b2ef Merge pull request #1052 from tqml/fix/import-delimiter-change
Import Dialog: Do not change delimiter if cancel button is pressed
2021-03-08 10:23:45 +10:00
Damien Elmes
cad37cdb08 Merge pull request #1057 from abdnh/fix-editor-rtl-check
Fix editor RTL check
2021-03-08 10:05:50 +10:00
abdo
5af6a63e20 Fix editor RTL check 2021-03-07 18:12:42 +03:00
Benjamin K
4c8e90d17d Update CONTRIBUTORS 2021-03-07 11:05:41 +01:00
Damien Elmes
60523848cd Merge pull request #1055 from hgiesel/editorfocustofix
Do not execute caretToEnd when Alt-tabbing back to application
2021-03-07 09:40:57 +10:00
Henrik Giesel
41c3c3ecf3 Do not execute caretToEnd when Alt-tabbing back to application 2021-03-06 17:57:04 +01:00
Benjamin K
61fd5688c0 Clean up imports 2021-03-04 19:55:35 +01:00
Benjamin K
48da1bda1d The old delimiter is now kept, when cancel button is clicked 2021-03-04 19:39:43 +01:00
Damien Elmes
e6cb092ac7 more undo strings 2021-03-04 11:52:20 +10:00
Damien Elmes
64dd899785 handle duplicate keys in schema 11 deckconf 2021-03-04 11:52:15 +10:00
Damien Elmes
923ab2e54c update translations 2021-03-04 11:52:10 +10:00
Damien Elmes
4d1cd03c0a fix infinite loop on card answer when parent is missing deck 2021-03-04 11:03:09 +10:00
Damien Elmes
3194b2cbb2 add undo.ftl 2021-03-04 11:03:09 +10:00
Damien Elmes
af8090a4e7 handle case when .ftl file doesn't exist yet 2021-03-04 11:03:09 +10:00
Damien Elmes
b759ba9c3f Merge pull request #1048 from hgiesel/focusfieldsfix
Fix focus handling when coming from top left buttons
2021-03-02 13:00:24 +10:00
Damien Elmes
40b412852c don't cap child counts to parents when reviewing in v2
https://forums.ankiweb.net/t/anki-2-1-41-beta/7305/59

When originally implemented in f6176748c5,
a given deck's limit was bound by its parents. This lead to a deck list
that seemed more logical in the parent limit < child limit case, as
child counts couldn't exceed a parent's, but it obscured the fact that
child decks could still be clicked on to show cards. And in the parent
limit > child limit case, the count shown for the child on the deck list
did not reflect how many cards were actually available and would be
delivered.

This change updates the reviewer to ignore parent limits when getting
review counts for the deck, which makes the behaviour consistent with
the deck list, which was recently changed to ignore parent limits.

Neither solution is ideal - this was a tradeoff v2 made in order to keep
fetching of review cards from multiple decks reasonably performant. The
experimental scheduling work moves back to respecting limits on
individual children, so this should hopefully improve in the future.

Also removed _revForDeck(), which was unused.
2021-03-02 10:23:06 +10:00
Damien Elmes
140c246ceb switch to 4 buttons when previewing in test scheduler
- Currently we just use 1.5x and 2x the normal preview delay; we could
change this in the future.
- Don't try to capture the current state; just use a flag to denote
exit status.
- Show (end) when exiting
2021-03-01 23:47:00 +10:00
Damien Elmes
a5e95ab476 interval sorting 2021-03-01 21:48:14 +10:00
Damien Elmes
d84ef0e7e6 fix reps updating in v2, but do it in answerCard instead of getCard 2021-03-01 21:48:02 +10:00
Henrik Giesel
e87d951a74 Fix focus handling when coming from top left buttons 2021-03-01 12:28:45 +01:00
Damien Elmes
47a18c5e71 Merge pull request #1047 from RumovZ/dyndeck-links
Make clickable dyndeck labels fixed in size
2021-03-01 20:45:59 +10:00
RumovZ
572bf12d9d Make clickable dyndeck labels fixed in size 2021-03-01 11:26:52 +01:00
Damien Elmes
ab610d836e show the empty card message on the back of the card as well
Otherwise when viewing the back side, user can end up with an empty
screen.
2021-03-01 15:32:31 +10:00
Damien Elmes
fead18ef43 update translations 2021-03-01 13:49:14 +10:00
Damien Elmes
b63f07ac36 turn the 'cards may be excluded' sentence into an action 2021-03-01 13:48:56 +10:00
Damien Elmes
56bd601322 fix inconsistent test handling on Windows
Bazel sets TZ to UTC when running tests, so the tests are reproducible.
But it seems like the Rust time crate was not honoring it, and using
the configured timezone instead. "Fix" by forcing UTC when testing, as
we already special-case a test run.
2021-03-01 13:36:36 +10:00
Damien Elmes
08fb9b5a0b use different approach to running tests twice
The symlink approach was breaking on Windows
2021-03-01 12:47:39 +10:00
Damien Elmes
62b23d1bb9 experimental queue building
Still a work in progress, and hidden behind a feature flag.
2021-03-01 12:18:21 +10:00
Damien Elmes
19ba8cef63 remove local tz test
This was breaking some of the unit tests when they happened to
complete in a particular order
2021-03-01 10:59:01 +10:00
Damien Elmes
45e1aacaf1 monospace font in html editor
https://forums.ankiweb.net/t/change-default-font-of-html-edit-mode-to-a-monospaced-font/7833
2021-03-01 10:16:12 +10:00
Damien Elmes
24ba4e3a29 catch attempts to nest under a filtered deck; don't show traceback 2021-03-01 09:58:12 +10:00
Damien Elmes
5045517f8a Merge pull request #1040 from RumovZ/deck-name-err
Catch deck rename errors and localise warnings
2021-03-01 09:40:55 +10:00
RumovZ
c4a2a212ec Catch DeckIsFilteredError directly on frontend 2021-02-26 11:32:40 +01:00
RumovZ
eb1e2391bd Add filtered deck error localisation on backend 2021-02-26 11:32:26 +01:00
Damien Elmes
1e142d4ac6 move cards out of the new queue on filtered deck upgrade 2021-02-26 19:16:18 +10:00
Damien Elmes
0377783a59 remove left-click on saved searches
Multiple users have thought it was a bug rather than an intentional
feature, and it breaks double-clicking:

https://forums.ankiweb.net/t/anki-2-1-41-beta/7305/51
2021-02-26 18:48:32 +10:00
Damien Elmes
5e946fad08 fix browser appearance defaults
https://forums.ankiweb.net/t/small-bug-in-the-browser-appearance-window/7806
2021-02-26 18:46:09 +10:00
Damien Elmes
2ffaf9499d Merge pull request #1039 from RumovZ/dyndeck-hint
Clickable hint in dyndeck dialogue for unmovable cards
2021-02-26 18:02:51 +10:00