Commit graph

6536 commits

Author SHA1 Message Date
Damien Elmes
af8090a4e7 handle case when .ftl file doesn't exist yet 2021-03-04 11:03:09 +10:00
Damien Elmes
b759ba9c3f Merge pull request #1048 from hgiesel/focusfieldsfix
Fix focus handling when coming from top left buttons
2021-03-02 13:00:24 +10:00
Damien Elmes
40b412852c don't cap child counts to parents when reviewing in v2
https://forums.ankiweb.net/t/anki-2-1-41-beta/7305/59

When originally implemented in f6176748c5,
a given deck's limit was bound by its parents. This lead to a deck list
that seemed more logical in the parent limit < child limit case, as
child counts couldn't exceed a parent's, but it obscured the fact that
child decks could still be clicked on to show cards. And in the parent
limit > child limit case, the count shown for the child on the deck list
did not reflect how many cards were actually available and would be
delivered.

This change updates the reviewer to ignore parent limits when getting
review counts for the deck, which makes the behaviour consistent with
the deck list, which was recently changed to ignore parent limits.

Neither solution is ideal - this was a tradeoff v2 made in order to keep
fetching of review cards from multiple decks reasonably performant. The
experimental scheduling work moves back to respecting limits on
individual children, so this should hopefully improve in the future.

Also removed _revForDeck(), which was unused.
2021-03-02 10:23:06 +10:00
Damien Elmes
140c246ceb switch to 4 buttons when previewing in test scheduler
- Currently we just use 1.5x and 2x the normal preview delay; we could
change this in the future.
- Don't try to capture the current state; just use a flag to denote
exit status.
- Show (end) when exiting
2021-03-01 23:47:00 +10:00
Damien Elmes
a5e95ab476 interval sorting 2021-03-01 21:48:14 +10:00
Damien Elmes
d84ef0e7e6 fix reps updating in v2, but do it in answerCard instead of getCard 2021-03-01 21:48:02 +10:00
Henrik Giesel
e87d951a74 Fix focus handling when coming from top left buttons 2021-03-01 12:28:45 +01:00
Damien Elmes
47a18c5e71 Merge pull request #1047 from RumovZ/dyndeck-links
Make clickable dyndeck labels fixed in size
2021-03-01 20:45:59 +10:00
RumovZ
572bf12d9d Make clickable dyndeck labels fixed in size 2021-03-01 11:26:52 +01:00
Damien Elmes
ab610d836e show the empty card message on the back of the card as well
Otherwise when viewing the back side, user can end up with an empty
screen.
2021-03-01 15:32:31 +10:00
Damien Elmes
fead18ef43 update translations 2021-03-01 13:49:14 +10:00
Damien Elmes
b63f07ac36 turn the 'cards may be excluded' sentence into an action 2021-03-01 13:48:56 +10:00
Damien Elmes
56bd601322 fix inconsistent test handling on Windows
Bazel sets TZ to UTC when running tests, so the tests are reproducible.
But it seems like the Rust time crate was not honoring it, and using
the configured timezone instead. "Fix" by forcing UTC when testing, as
we already special-case a test run.
2021-03-01 13:36:36 +10:00
Damien Elmes
08fb9b5a0b use different approach to running tests twice
The symlink approach was breaking on Windows
2021-03-01 12:47:39 +10:00
Damien Elmes
62b23d1bb9 experimental queue building
Still a work in progress, and hidden behind a feature flag.
2021-03-01 12:18:21 +10:00
Damien Elmes
19ba8cef63 remove local tz test
This was breaking some of the unit tests when they happened to
complete in a particular order
2021-03-01 10:59:01 +10:00
Damien Elmes
45e1aacaf1 monospace font in html editor
https://forums.ankiweb.net/t/change-default-font-of-html-edit-mode-to-a-monospaced-font/7833
2021-03-01 10:16:12 +10:00
Damien Elmes
24ba4e3a29 catch attempts to nest under a filtered deck; don't show traceback 2021-03-01 09:58:12 +10:00
Damien Elmes
5045517f8a Merge pull request #1040 from RumovZ/deck-name-err
Catch deck rename errors and localise warnings
2021-03-01 09:40:55 +10:00
RumovZ
c4a2a212ec Catch DeckIsFilteredError directly on frontend 2021-02-26 11:32:40 +01:00
RumovZ
eb1e2391bd Add filtered deck error localisation on backend 2021-02-26 11:32:26 +01:00
Damien Elmes
1e142d4ac6 move cards out of the new queue on filtered deck upgrade 2021-02-26 19:16:18 +10:00
Damien Elmes
0377783a59 remove left-click on saved searches
Multiple users have thought it was a bug rather than an intentional
feature, and it breaks double-clicking:

https://forums.ankiweb.net/t/anki-2-1-41-beta/7305/51
2021-02-26 18:48:32 +10:00
Damien Elmes
5e946fad08 fix browser appearance defaults
https://forums.ankiweb.net/t/small-bug-in-the-browser-appearance-window/7806
2021-02-26 18:46:09 +10:00
Damien Elmes
2ffaf9499d Merge pull request #1039 from RumovZ/dyndeck-hint
Clickable hint in dyndeck dialogue for unmovable cards
2021-02-26 18:02:51 +10:00
Damien Elmes
ddb8a4fae6 Merge pull request #1042 from BlueGreenMagick/studydeck-noadd
StudyDeck without add button
2021-02-26 14:42:41 +10:00
bluegreenmagick
5ef9401686 StudyDeck without add button 2021-02-25 07:34:01 +09:00
RumovZ
b8f828a465 Fix #1024 – catch deck rename errors 2021-02-24 13:59:38 +01:00
RumovZ
5e7b594c71 Localise RenameDeckError 2021-02-24 13:57:44 +01:00
RumovZ
1686a065f8 Fix type hints in dyndeckconf 2021-02-24 11:24:27 +01:00
RumovZ
6ae03c3aa9 Refactor dyndeckconf/on_hint_button 2021-02-24 11:14:33 +01:00
Damien Elmes
7c03d184de Merge pull request #1038 from hgiesel/imgmaxwidth
Fix scrollbar issue in anki-editable component in two ways
2021-02-24 10:16:12 +10:00
Damien Elmes
735253dd43 Merge pull request #1037 from hgiesel/browserbug2
Remove logic for pulling editor field into view
2021-02-24 09:53:11 +10:00
RumovZ
6eca669cb0 Give dyndeck hint unique styling 2021-02-23 23:34:05 +01:00
RumovZ
c0dfce3908 Add clickable hint to dyndeckconf 2021-02-23 23:14:11 +01:00
RumovZ
bb58060c91 Add direct col reference to dyndeckconf 2021-02-23 22:31:04 +01:00
Henrik Giesel
e2bda7273e Fix scrollbar issue in anki-editable component in two ways
- using :host-context(.nightMode) allows for applying the nightmode
  scroll bar inside the component
- apply max-width: 100% to all element within editable, not just images
2021-02-23 15:52:20 +01:00
Henrik Giesel
561dbbb718 Satisfy formatter 2021-02-23 13:34:41 +01:00
Henrik Giesel
eed8fb06c6 Remove logic for pulling editor field in view 2021-02-23 12:55:04 +01:00
Damien Elmes
f376f70075 add test to the previewing code 2021-02-23 17:35:20 +10:00
Damien Elmes
dbd4aad5d7 split rescheduling_filter, and more tidyups 2021-02-23 17:35:20 +10:00
Damien Elmes
6160613051 split review/learn/new/relearn 2021-02-23 17:35:20 +10:00
Damien Elmes
7cf6971496 split state fetching, revlog and preview code out 2021-02-23 17:35:20 +10:00
Damien Elmes
97d916543a sched->scheduler 2021-02-23 17:35:20 +10:00
Damien Elmes
1086321c8b answering.rs tidyups 2021-02-23 17:35:20 +10:00
Damien Elmes
3d155a7c80 implement leech handling
Also change the default for new users to "tag only"
2021-02-23 17:35:20 +10:00
Damien Elmes
b4a12fb07c Merge pull request #1036 from hgiesel/graphsaslib
Source graphs.js as library in the HTML head
2021-02-23 17:35:07 +10:00
Henrik Giesel
49e408e64d Satisfy formatter 2021-02-22 14:44:31 +01:00
Henrik Giesel
5c332e20ab Load graphs.js from head
* Also move script into body, to be a valid HTML document
2021-02-22 14:17:56 +01:00
Henrik Giesel
042d9095ea Move tooltip creation into function 2021-02-22 14:10:35 +01:00