Commit graph

2277 commits

Author SHA1 Message Date
Arthur Milchior
bf1048d904 Making newBasicModel private
Following @timrae's advice on the pull request #340.
2019-10-21 07:02:08 +02:00
Arthur Milchior
4df6af3174 Creating now basic type without doing full sync
There is currently what I believe to be a small bug in anki. You can
clone a note type without doing a full sync, but you can't create
forwardReverse and forwardOptionalReverse note type without doing a
full sync. On the other hand you can clone, and even create any other
basic type without doing a full sync.

This commit simply wants to correct this.

The main trouble is that the method to create a copy of forwardReverse
and forwardOptionalReverse use a copy of the basic model, and add this
copy in the model manager BEFORE adding yet another template. This
commit corrects it by ensuring that the model is added only after all
templates are added, so that anki does not detect any change of a
template in the schema.

In order to do this, I created a method newBasicModel which creates
the basic model without adding it.

By the way, addBasicTypingModel could also use newBasicModel, and then
only change afmt. I didn't do it here because I believe that you want
the change to be minimal, and this correction would not add any
feature, only factorize the code.
2019-10-21 02:30:06 +02:00
Damien Elmes
e464dfe37f Merge pull request #338 from Aqueminivan/master
Added file counts when deleting media
2019-10-20 09:46:14 +10:00
Aqueminivan
241053a158 Moved number inside ngettext() 2019-10-19 19:39:43 -04:00
Damien Elmes
f03bcdd106 Merge pull request #339 from Arthur-Milchior/correctDueOfNewSiblings
New cards of existing note take due value of NEW siblings
2019-10-20 08:22:15 +10:00
Aqueminivan
7f691a152a Fixed code style issue (column width) 2019-10-19 18:10:59 -04:00
Aqueminivan
3c3eddfd57 Fixed translation issues for media counts 2019-10-19 18:03:59 -04:00
Arthur Milchior
d33503177d New cards of existing note take due value of NEW siblings
Here is a bug, how to reproduce it, and why this is a fix.

This is a way to create a new note with a due card extremly high
without any add-on, just with basic anki.

Bug
===
Create a note type with three fields One, Two, and Three and three card
type One, Two and Three such that each card is generated when the
field of the same name is filled.

Create a note with fields One and Two filled only. Review card One and
click on good. Card one should goes in learning mode. Fill the field
Three. In the browser, you'll see that card Two and Three are new, but
card Two and Three's due value are distinct. More precisely, the due
value of card Three is equal to the due value of card One; except that
in card One it's interpreted as a timestamp, while in card Three it's
interpreted as a position in the list of new card.

You'll remark by the way that the due of card Three is extremly high,
potentially more than 1000000; which may explain why so many
collection has this bug.

Fix
===
Only consider due value of new cards.
2019-10-19 06:28:10 +02:00
Aqueminivan
40527f58c7 Added file counts when deleting media 2019-10-18 03:51:54 -04:00
Damien Elmes
5eef660bc3 bump version 2019-09-24 16:12:38 +10:00
Damien Elmes
eae4921a14 pin qtsvg
https://anki.tenderapp.com/discussions/ankidesktop/35990-32-bit-of-anki-missing-python-binding-pyqt5qtsvgpyd
2019-09-24 15:54:26 +10:00
Damien Elmes
c69c4aa486 escape backslash in find&replace
https://anki.tenderapp.com/discussions/ankidesktop/35903-bug-find-and-replace-breaks-when-replacing-with-latexmathjax-commands
2019-09-24 15:46:26 +10:00
Damien Elmes
f7bbbfdbb1 fix negative due dates in filtered decks
https://anki.tenderapp.com/discussions/ankidesktop/35978-rebuilding-filtered-deck-on-experimental-v2-empties-deck-and-reschedules-to-the-year-1745

this means affected cards will not have the selected ordering applied,
but that seems preferable to the alternatives
2019-09-24 15:38:33 +10:00
Damien Elmes
f9ff48d9c7 tweak translation license 2019-09-24 15:36:06 +10:00
Damien Elmes
9e3cd31e59 use locales instead of two digit lang codes
and move away from launchpad
2019-09-23 21:18:03 +10:00
Damien Elmes
7e1873fe17 Merge pull request #332 from Arthur-Milchior/sortEase
when sorting by easiness, put new card separately
2019-09-23 14:18:04 +10:00
Arthur Milchior
93afd44133 when sorting by easiness, put new card separately 2019-09-18 16:58:29 +02:00
Damien Elmes
574e119566 fix qtwebengineprocess leak in stats screen
https://anki.tenderapp.com/discussions/ankidesktop/35941-closing-stats-window-doesnt-end-its-extra-qt-process
2019-09-16 15:16:41 +10:00
Damien Elmes
7035f405a3 Merge pull request #330 from glutanimate/add-typing-module
Add "typing" to pinned modules
2019-09-07 13:01:26 +10:00
Glutanimate
a9c687d7d2 Add "typing" to pinned modules 2019-09-06 17:25:30 +02:00
Damien Elmes
f8b3bb7f05 Merge pull request #329 from aidanholm/fix-default-discard
Don't discard new card contents by default
2019-09-02 10:24:29 +10:00
Damien Elmes
dd9894cd12 support multiple urls at once in editor 2019-09-02 10:17:04 +10:00
Damien Elmes
4c846f0620 reduce editcurrent width constraint
https://anki.tenderapp.com/discussions/ankidesktop/35724-bug-edit-window-not-resizable
2019-09-02 09:52:04 +10:00
Aidan Holm
b68ed4180c Don't discard new card contents by default 2019-09-01 13:09:05 +08:00
Damien Elmes
4bfb8e8881 Merge pull request #328 from lovac42/clearUndoOnSchedConvert
clears undo before changing schedulers
2019-08-31 11:38:07 +10:00
Damien Elmes
ed0a1a255a Merge pull request #327 from Blauelf/patch-1
Prevent non-integer ivl when importing from Mnemosyne
2019-08-31 11:34:54 +10:00
lovac42
390dece050 clears undo before changing schedulers 2019-08-30 20:55:38 -04:00
Damien Elmes
59900ee458 statsbg credit/link 2019-08-31 10:47:01 +10:00
Blauelf
7e8604fde2 Prevent non-integer ivl when importing from Mnemosyne
A reddit user had a few issues when importing from Mnemosyne, one of which was non-integer values interpreted as "v2 scheduler bug". I assume that's the line where they originated.
https://www.reddit.com/r/Anki/comments/cxcv27/what_just_happened_cards_with_v2_scheduler_bug/
2019-08-30 14:56:44 +02:00
Damien Elmes
a839aa42af add decimal
https://anki.tenderapp.com/discussions/ankidesktop/35620-module-decimal-missing-in-binary-package-2115-linux-only
2019-08-26 10:04:42 +10:00
Damien Elmes
78ff03608d Merge pull request #326 from lovac42/fix_cased_fieldNames
Fix case sensitive field names
2019-08-21 17:50:38 +10:00
lovac42
68b8331347 rm unnecessary step 2019-08-20 23:31:04 -04:00
lovac42
6bddae5817 Fix case sensitive field names so that 'apple' and 'Apple' both show up in drop down list when performing a search and replace. 2019-08-20 22:28:45 -04:00
Damien Elmes
97c90d6212 Merge pull request #325 from MHordecki/format_exception
Use traceback.format_exception for debug error display.
2019-08-20 19:35:54 +10:00
Mike Hordecki
ecba3f429b Use traceback.format_exception for debug error display. 2019-08-19 23:08:55 +02:00
Damien Elmes
a8b302c7f2 Merge pull request #324 from MHordecki/software-opengl
Add support for OpenGL software rendering.
2019-08-18 20:18:03 +10:00
Damien Elmes
a2b7bcb3b1 Merge pull request #323 from SebastienGllmt/patch-1
Allow disabling timeTicks
2019-08-17 18:50:44 +10:00
Damien Elmes
9f27be3095 ensure random distribution of due cards for a given day in v2 sched 2019-08-17 18:45:00 +10:00
Damien Elmes
bac937ee49 add progress dialog for media delete 2019-08-17 18:32:39 +10:00
Mike Hordecki
fe9df49226 Add support for OpenGL software rendering.
In some systems, the default Qt hardware renderer is buggy. There's a Qt
option for forcing software rendering. This commit adds support for a
new environment variable, ANKI_SOFTWAREOPENGL, that, when set, will
prompt Anki to force software OpenGL in Qt.
2019-08-16 23:18:28 +02:00
Sebastien Guillemot
afc741de7c Allow disabling timeTicks 2019-08-16 01:58:10 +10:00
Damien Elmes
5d1dc680a9 pin logging
https://anki.tenderapp.com/discussions/ankidesktop/35444-python-standard-library-availability-in-anki
2019-08-13 19:08:49 +10:00
Damien Elmes
e74d395958 Merge pull request #320 from shanrauf/readme-dev-typo
Small README.development error
2019-08-03 09:11:58 +10:00
Shan Rauf
cddd9a9dd8 Fix readme.development typo 2019-07-29 02:10:34 -07:00
Damien Elmes
da533b3854 Merge pull request #318 from wgreven/single-config-file-for-colors
Allow configuring Anki's color scheme using a single config file on Linux
2019-07-22 10:51:51 +10:00
Damien Elmes
a7b33ad234 remove open backup folder link
https://anki.tenderapp.com/discussions/ankidesktop/35084-crash-while-trying-to-revert-to-a-backup
2019-07-22 10:49:22 +10:00
Wilco Greven
eec70c9d17 Set applicationName and desktopFileName before instantiating the application.
When these are set after instantiating the application Anki will load both
$XDG CONFIG HOME/.config/Ankirc and $XDG CONFIG HOME/.config/ankirc.
2019-07-20 13:10:59 +02:00
Damien Elmes
8f280d3bc9 Merge pull request #317 from wgreven/fix-window-icon-on-wayland
Show the correct window icon when running on Wayland
2019-07-19 08:37:50 +10:00
Wilco Greven
6585967799 Set the desktop file name.
Otherwise, on Wayland, Anki will look for python3.desktop This fixes the window icon.
2019-07-18 23:14:34 +02:00
Damien Elmes
edabdd0e74 Merge pull request #316 from vi3itor/master
Remove outdated pyqt mentions from README.development
2019-07-17 18:45:04 +10:00